crypto: qat - add CRYPTO_AES to Kconfig dependencies
PATCH 1/1 crypto: qat - add CRYPTO_AES to Kconfig dependencies
This patch includes a missing dependency (CRYPTO_AES) which may lead to an "undefined reference to `aes_expandkey'" linking error.
--- drivers/crypto/qat/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/crypto/qat/Kconfig +1 -0
@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 + select CRYPTO_AES select FW_LOADER config CRYPTO_DEV_QAT_DH895xCC
Signature · 1 line
2.26.2
Herbert Xu
maintainerQuoted 9 lines · Marco Chiappero
This patch includes a missing dependency (
CRYPTO_AES) which may lead to an "undefined reference to `aes_expandkey'" linking error.Fixes 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")Reported-by kernel test robot <[email protected]>Signed-off-by Marco Chiappero <[email protected]>--- drivers/crypto/qat/Kconfig | 1 + 1 file changed, 1 insertion(+)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 24 lines · Marco Chiappero
This patch includes a missing dependency (
CRYPTO_AES) which may lead to an "undefined reference to `aes_expandkey'" linking error.Fixes 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")Reported-by kernel test robot <[email protected]>Signed-off-by Marco Chiappero <[email protected]>--- drivers/crypto/qat/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/crypto/qat/Kconfig +1
-1@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 + select CRYPTO_AES select FW_LOADER config CRYPTO_DEV_QAT_DH895xCC --
Quoted 2 lines
2.26.2
This should be 'select CRYPTO_LIB_AES'
Herbert Xu
maintainerQuoted 2 lines · Ard Biesheuvel
This should be 'select
CRYPTO_LIB_AES'
Please send a follow-up. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
PATCH 1/1 crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT common code.
--- drivers/crypto/qat/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/qat/Kconfig +1 -1
@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 - select CRYPTO_AES + select CRYPTO_LIB_AES select FW_LOADER config CRYPTO_DEV_QAT_DH895xCC
Signature · 1 line
2.26.2
Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
Quoted 7 lines · Marco Chiappero
Use
CRYPTO_LIB_AESin place ofCRYPTO_AESin the dependences for the QAT common code.Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")Reported-by Ard Biesheuvel <[email protected]>Signed-off-by Marco Chiappero <[email protected]>
Quoted 20 lines
--- drivers/crypto/qat/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/qat/Kconfig +1
-2@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 - select CRYPTO_AES + select CRYPTO_LIB_AES select FW_LOADER config CRYPTO_DEV_QAT_DH895xCC --2.26.2
Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
In reply to Marco ChiapperoQuoted 6 lines · Marco Chiappero
Use
CRYPTO_LIB_AESin place ofCRYPTO_AESin the dependences for the QAT common code.Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")Reported-by Ard Biesheuvel <[email protected]>Signed-off-by Marco Chiappero <[email protected]>
Quoted 20 lines
--- drivers/crypto/qat/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/qat/Kconfig +1
-1@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 - select CRYPTO_AES + select CRYPTO_LIB_AES select FW_LOADER config CRYPTO_DEV_QAT_DH895xCCSignature · 1 line
2.26.2
Herbert Xu
maintainerRe: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
In reply to Marco ChiapperoQuoted 9 lines · Marco Chiappero
Use
CRYPTO_LIB_AESin place ofCRYPTO_AESin the dependences for the QAT common code.Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")Reported-by Ard Biesheuvel <[email protected]>Signed-off-by Marco Chiappero <[email protected]>--- drivers/crypto/qat/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 14 lines
Quoted 11 lines · Marco Chiappero
drivers/crypto/qat/Kconfig +1
-0@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 + select CRYPTO_AES select FW_LOADER
Quoted 6 lines
Quoted 4 lines
drivers/crypto/qat/Kconfig +0
-1config CRYPTO_DEV_QAT_DH895xCC --2.26.2
This should be 'select
CRYPTO_LIB_AES'
Thank you for bringing this up.
Regards,
Marco