Skip to contentSkip to conversation

crypto: qat - add CRYPTO_AES to Kconfig dependencies

PATCH In review Marco Chiappero 4 participants 9 messages Dec 22, 2020 – Jan 14, 2021 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: qat - add CRYPTO_AES to Kconfig dependencies

This patch includes a missing dependency (CRYPTO_AES) which may lead to an "undefined reference to `aes_expandkey'" linking error.

Fixes 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
---
 drivers/crypto/qat/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/qat/Kconfig +1 -0
index beb379b23dc3..846a3d90b41a 100644
@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
 	select CRYPTO_SHA1
 	select CRYPTO_SHA256
 	select CRYPTO_SHA512
+	select CRYPTO_AES
 	select FW_LOADER
 
 config CRYPTO_DEV_QAT_DH895xCC
Signature · 1 line
2.26.2
maintainer
#1 lore raw
Quoted 9 lines · Marco Chiappero

This patch includes a missing dependency (CRYPTO_AES) which may lead to an "undefined reference to `aes_expandkey'" linking error.

Fixes 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
---
 drivers/crypto/qat/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw
In reply to Marco Chiappero
Quoted 24 lines · Marco Chiappero

This patch includes a missing dependency (CRYPTO_AES) which may lead to an "undefined reference to `aes_expandkey'" linking error.

Fixes 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
---
 drivers/crypto/qat/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/qat/Kconfig +1 -1
index beb379b23dc3..846a3d90b41a 100644
@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
        select CRYPTO_SHA1
        select CRYPTO_SHA256
        select CRYPTO_SHA512
+       select CRYPTO_AES
        select FW_LOADER
 
 config CRYPTO_DEV_QAT_DH895xCC
--
Quoted 2 lines

2.26.2

This should be 'select CRYPTO_LIB_AES'

maintainer
#3 lore raw
Quoted 2 lines · Ard Biesheuvel

This should be 'select CRYPTO_LIB_AES'

Please send a follow-up. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#4 lore raw

PATCH 1/1 crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT common code.

Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
---
 drivers/crypto/qat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/qat/Kconfig +1 -1
index 846a3d90b41a..77783feb62b2 100644
@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
 	select CRYPTO_SHA1
 	select CRYPTO_SHA256
 	select CRYPTO_SHA512
-	select CRYPTO_AES
+	select CRYPTO_LIB_AES
 	select FW_LOADER
 
 config CRYPTO_DEV_QAT_DH895xCC
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#5 lore raw

Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

Quoted 7 lines · Marco Chiappero

Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT common code.

Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
Quoted 20 lines
---
 drivers/crypto/qat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/qat/Kconfig +1 -2
index 846a3d90b41a..77783feb62b2 100644
@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
        select CRYPTO_SHA1
        select CRYPTO_SHA256
        select CRYPTO_SHA512
-       select CRYPTO_AES
+       select CRYPTO_LIB_AES
        select FW_LOADER
 
 config CRYPTO_DEV_QAT_DH895xCC
--

2.26.2

Reviewed-by on v1 1/1
#6 lore raw

Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

In reply to Marco Chiappero
Quoted 6 lines · Marco Chiappero

Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT common code.

Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
Quoted 20 lines
---
 drivers/crypto/qat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/qat/Kconfig +1 -1
index 846a3d90b41a..77783feb62b2 100644
@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
 	select CRYPTO_SHA1
 	select CRYPTO_SHA256
 	select CRYPTO_SHA512
-	select CRYPTO_AES
+	select CRYPTO_LIB_AES
 	select FW_LOADER
 
 config CRYPTO_DEV_QAT_DH895xCC
Signature · 1 line
2.26.2
maintainer
#7 lore raw

Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

In reply to Marco Chiappero
Quoted 9 lines · Marco Chiappero

Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT common code.

Fixes c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
---
 drivers/crypto/qat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#8 lore raw
In reply to Ard Biesheuvel
Quoted 14 lines
Quoted 11 lines · Marco Chiappero
drivers/crypto/qat/Kconfig +1 -0
index beb379b23dc3..846a3d90b41a 100644
@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
        select CRYPTO_SHA1
        select CRYPTO_SHA256
        select CRYPTO_SHA512
+       select CRYPTO_AES
        select FW_LOADER
 
Quoted 6 lines
Quoted 4 lines
drivers/crypto/qat/Kconfig +0 -1
 config CRYPTO_DEV_QAT_DH895xCC
--

2.26.2

This should be 'select CRYPTO_LIB_AES'

Thank you for bringing this up.

Regards,
Marco