Skip to contentSkip to conversation

ARM: dts: stm32: Fix GPIO hog names on DHCOM

PATCH In review Marek Vasut 2 participants 2 messages Dec 24, 2020 – Jan 14, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Fix GPIO hog names on DHCOM

The GPIO hog node name should match regex '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', make it so and fix the following two make dtbs_check warnings:

arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dt.yaml: hog-usb-port-power: $nodename:0: 'hog-usb-port-power' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$' arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: hog-usb-hub: $nodename:0: 'hog-usb-hub' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
 arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi   | 4 ++--
 arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi +2 -2
index 62ab23824a3e..cb68afbbea68 100644
@@ -33,7 +33,7 @@ &gpiob {
 	 * during TX anyway and that it only controls drive enable DE
 	 * line. Hence, the RX is always enabled here.
 	 */
-	rs485-rx-en {
+	rs485-rx-en-hog {
 		gpio-hog;
 		gpios = <8 GPIO_ACTIVE_HIGH>;
 		output-low;
@@ -61,7 +61,7 @@ &gpioi {
 	 * order to reset the Hub when USB bus is powered down, but
 	 * so far there is no such functionality.
 	 */
-	usb-hub {
+	usb-hub-hog {
 		gpio-hog;
 		gpios = <2 GPIO_ACTIVE_HIGH>;
 		output-high;
arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi +1 -1
index 356150d28c42..b99f2b891629 100644
@@ -43,7 +43,7 @@ &gpioa {
 	 * in order to turn on port power when USB bus is powered up, but so
 	 * far there is no such functionality.
 	 */
-	usb-port-power {
+	usb-port-power-hog {
 		gpio-hog;
 		gpios = <13 GPIO_ACTIVE_LOW>;
 		output-low;
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw

Hi Marek

Quoted 46 lines · Marek Vasut

The GPIO hog node name should match regex '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', make it so and fix the following two make dtbs_check warnings:

arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dt.yaml: hog-usb-port-power: $nodename:0: 'hog-usb-port-power' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$' arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: hog-usb-hub: $nodename:0: 'hog-usb-hub' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
  arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi   | 4 ++--
  arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi +2 -2
index 62ab23824a3e..cb68afbbea68 100644
@@ -33,7 +33,7 @@ &gpiob {
  	 * during TX anyway and that it only controls drive enable DE
  	 * line. Hence, the RX is always enabled here.
  	 */
-	rs485-rx-en {
+	rs485-rx-en-hog {
  		gpio-hog;
  		gpios = <8 GPIO_ACTIVE_HIGH>;
  		output-low;
@@ -61,7 +61,7 @@ &gpioi {
  	 * order to reset the Hub when USB bus is powered down, but
  	 * so far there is no such functionality.
  	 */
-	usb-hub {
+	usb-hub-hog {
  		gpio-hog;
  		gpios = <2 GPIO_ACTIVE_HIGH>;
  		output-high;
arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi +0 -0
index 356150d28c42..b99f2b891629 100644

arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi &gpioa { · line 49

Quoted 8 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi +1 -1
@@ -43,7 +43,7 @@ &gpioa {
  	 * in order to turn on port power when USB bus is powered up, but so
  	 * far there is no such functionality.
  	 */
-	usb-port-power {
+	usb-port-power-hog {
  		gpio-hog;
  		gpios = <13 GPIO_ACTIVE_LOW>;
  		output-low;

Applied on stm32-fixes with a Fixes tag added.

Thanks.
Alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel