Skip to contentSkip to conversation

fix tegra-hda on tegra30 devices

PATCH Superseded Peter Geis 4 participants 11 messages Dec 25, 2020 – Jan 8, 2021

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Peter Geis

author
#0 lore raw

cover fix tegra-hda on tegra30 devices

The following patches fix tegra-hda on legacy tegra devices.
Two issues were discovered preventing tegra-hda from functioning:
The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function. The tegra-hda encounters an input/output error when opening a stream.

Since the only mainline device that used tegra-hda previously was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices.
We can apply it universally to the tegra-hda device to resolve the issues across the board.
Note that downstream devices used the spdif device instead of hda for hdmi audio.
The spdif device lacks a driver on mainline.

Peter Geis (2):
clk: tegra30: Add hda clock default rates to clock driver
ALSA: hda/tegra: fix tegra-hda on tegra30 soc

 drivers/clk/tegra/clk-tegra30.c | 2 ++
 sound/pci/hda/hda_tegra.c       | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/2 clk: tegra30: Add hda clock default rates to clock driver

Current implementation defaults the hda clocks to clk_m.
This causes hda to run too slow to operate correctly.
Fix this by defaulting to pll_p and setting the frequency to the correct rate.

This matches upstream t124 and downstream t30.

---
 drivers/clk/tegra/clk-tegra30.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/tegra/clk-tegra30.c +2 -0
index 37244a7e68c2..9cf249c344d9 100644
@@ -1256,6 +1256,8 @@ static struct tegra_clk_init_table init_table[] __initdata = {
 	{ TEGRA30_CLK_I2S3_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
 	{ TEGRA30_CLK_I2S4_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
 	{ TEGRA30_CLK_VIMCLK_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
+	{ TEGRA30_CLK_HDA, TEGRA30_CLK_PLL_P, 102000000, 0 },
+	{ TEGRA30_CLK_HDA2CODEC_2X, TEGRA30_CLK_PLL_P, 48000000, 0 },
 	/* must be the last entry */
 	{ TEGRA30_CLK_CLK_MAX, TEGRA30_CLK_CLK_MAX, 0, 0 },
 };
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] clk: tegra30: Add hda clock default rates to clock driver

Quoted 17 lines · Peter Geis

Current implementation defaults the hda clocks to clk_m.
This causes hda to run too slow to operate correctly.
Fix this by defaulting to pll_p and setting the frequency to the correct rate.

This matches upstream t124 and downstream t30.

---
 drivers/clk/tegra/clk-tegra30.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/tegra/clk-tegra30.c +0 -0
index 37244a7e68c2..9cf249c344d9 100644

drivers/clk/tegra/clk-tegra30.c static struct tegra_clk_init_table init_table[] __initdata = { · line 1263

Quoted 8 lines
drivers/clk/tegra/clk-tegra30.c +2 -0
@@ -1256,6 +1256,8 @@ static struct tegra_clk_init_table init_table[] __initdata = {
 	{ TEGRA30_CLK_I2S3_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
 	{ TEGRA30_CLK_I2S4_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
 	{ TEGRA30_CLK_VIMCLK_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
+	{ TEGRA30_CLK_HDA, TEGRA30_CLK_PLL_P, 102000000, 0 },
+	{ TEGRA30_CLK_HDA2CODEC_2X, TEGRA30_CLK_PLL_P, 48000000, 0 },
 	/* must be the last entry */
 	{ TEGRA30_CLK_CLK_MAX, TEGRA30_CLK_CLK_MAX, 0, 0 },
 };

This looks good to me. So ...

Cheers
Jon

Signature · 1 line
nvpublic
author
#3 lore raw

PATCH 2/2 ALSA: hda/tegra: fix tegra-hda on tegra30 soc

In reply to Peter Geis

Currently hda on tegra30 fails to open a stream with an input/output error. This is similar to the issue referenced in [1].

For example:
speaker-test -Dhw:0,3 -c 2

speaker-test 1.2.2

Playback device is hw:0,3
Stream parameters are 48000Hz, S16_LE, 2 channels
Using 16 octaves of pink noise
Rate set to 48000Hz (requested 48000Hz)
Buffer size range from 64 to 16384
Period size range from 32 to 8192
Using max buffer size 16384
Periods = 4
was set period_size = 4096
was set buffer_size = 16384
0 - Front Left
Write error: -5,Input/output error
xrun_recovery failed: -5,Input/output error
Transfer failed: Input/output error

[1] states "Due to a legacy HW design problem", implying the issue applies to all previous tegra-hda devices. The tegra-hda device was introduced in tegra30 but only utilized in tegra124 until now.
For this reason it is unknown when this issue first manifested.

Applying the fix in [1] universally resolves this issue on tegra30. Tested on the Ouya game console and the tf201 tablet.

[1] 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194")

---
 sound/pci/hda/hda_tegra.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +1 -2
index 70164d1428d4..f8d61e677a09 100644
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
 	 * in powers of 2, next available ratio is 16 which can be
 	 * used as a limiting factor here.
 	 */
-	if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-		chip->bus.core.sdo_limit = 16;
+	chip->bus.core.sdo_limit = 16;
 
 	/* codec detection */
 	if (!bus->codec_mask) {
Signature · 1 line
2.25.1
#4 lore raw

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Quoted 26 lines · Peter Geis

External email: Use caution opening links or attachments

Currently hda on tegra30 fails to open a stream with an input/output error. This is similar to the issue referenced in [1].

For example:
speaker-test -Dhw:0,3 -c 2

speaker-test 1.2.2

Playback device is hw:0,3
Stream parameters are 48000Hz, S16_LE, 2 channels
Using 16 octaves of pink noise
Rate set to 48000Hz (requested 48000Hz)
Buffer size range from 64 to 16384
Period size range from 32 to 8192
Using max buffer size 16384
Periods = 4
was set period_size = 4096
was set buffer_size = 16384
0 - Front Left
Write error: -5,Input/output error
xrun_recovery failed: -5,Input/output error
Transfer failed: Input/output error

Quoted 8 lines

[1] states "Due to a legacy HW design problem", implying the issue applies to all previous tegra-hda devices. The tegra-hda device was introduced in tegra30 but only utilized in tegra124 until now.
For this reason it is unknown when this issue first manifested.

Applying the fix in [1] universally resolves this issue on tegra30. Tested on the Ouya game console and the tf201 tablet.

[1] 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194")

This issue was never seen on Tegra210/Tegra186 and hence at that time it was thought to be specific to Tegra194. I never tested this on Tegra30 since I don't have this device. I will clarify this with HW folks if workaround is safer for all chips.

Quoted 12 lines
---
  sound/pci/hda/hda_tegra.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +0 -0
index 70164d1428d4..f8d61e677a09 100644

sound/pci/hda/hda_tegra.c static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev) · line 391

Quoted 6 lines
sound/pci/hda/hda_tegra.c +1 -2
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
          * in powers of 2, next available ratio is 16 which can be
          * used as a limiting factor here.
          */
-       if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-               chip->bus.core.sdo_limit = 16;
+       chip->bus.core.sdo_limit = 16;

Future Tegra chips address this problem and hence cannot be enforced by default. May be we can have like below:

if (of_device_is_compatible(np, "nvidia,tegra30-hda")) chip->bus.core.sdo_limit = 16;

Quoted 6 lines
sound/pci/hda/hda_tegra.c +0 -1
         /* codec detection */
         if (!bus->codec_mask) {
--

2.25.1

author
#5 lore raw

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Quoted 37 lines · Sameer Pujar
Quoted 33 lines · Peter Geis

External email: Use caution opening links or attachments

Currently hda on tegra30 fails to open a stream with an input/output error. This is similar to the issue referenced in [1].

For example:
speaker-test -Dhw:0,3 -c 2

speaker-test 1.2.2

Playback device is hw:0,3
Stream parameters are 48000Hz, S16_LE, 2 channels
Using 16 octaves of pink noise
Rate set to 48000Hz (requested 48000Hz)
Buffer size range from 64 to 16384
Period size range from 32 to 8192
Using max buffer size 16384
Periods = 4
was set period_size = 4096
was set buffer_size = 16384
0 - Front Left
Write error: -5,Input/output error
xrun_recovery failed: -5,Input/output error
Transfer failed: Input/output error

[1] states "Due to a legacy HW design problem", implying the issue applies to all previous tegra-hda devices. The tegra-hda device was introduced in tegra30 but only utilized in tegra124 until now.
For this reason it is unknown when this issue first manifested.

Applying the fix in [1] universally resolves this issue on tegra30. Tested on the Ouya game console and the tf201 tablet.

Quoted 6 lines
Quoted 1 line

[1] 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194")

This issue was never seen on Tegra210/Tegra186 and hence at that time it was thought to be specific to Tegra194. I never tested this on Tegra30 since I don't have this device. I will clarify this with HW folks if workaround is safer for all chips.

So this is confirmed to not affect Tegra210 and Tegra186, but it does affect Tegra194 and Tegra30.
Is it possible for the hardware team to pitch on on where the fix was implemented?

Quoted 23 lines
Quoted 13 lines
---
  sound/pci/hda/hda_tegra.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +0 -0
index 70164d1428d4..f8d61e677a09 100644

sound/pci/hda/hda_tegra.c static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev) · line 391

Quoted 6 lines
sound/pci/hda/hda_tegra.c +1 -2
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
          * in powers of 2, next available ratio is 16 which can be
          * used as a limiting factor here.
          */
-       if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-               chip->bus.core.sdo_limit = 16;
+       chip->bus.core.sdo_limit = 16;

Future Tegra chips address this problem and hence cannot be enforced by default. May be we can have like below:

Quoted 3 lines

if (of_device_is_compatible(np, "nvidia,tegra30-hda")) chip->bus.core.sdo_limit = 16;

It will need to be a bit more complicated than that, since the tegra186 and tegra210 device trees have "nvidia,tegra30-hda" as a fallback.
Looking at the generation map, tegra30-hda can be the fallback for the broken implementation and tegra210-hda can be the fallback for the working implementation.
Does that work for you?

Quoted 7 lines
Quoted 6 lines
sound/pci/hda/hda_tegra.c +0 -1
         /* codec detection */
         if (!bus->codec_mask) {
--

2.25.1

#6 lore raw

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Quoted 41 lines · Peter Geis

External email: Use caution opening links or attachments

Quoted 37 lines · Sameer Pujar
Quoted 34 lines · Peter Geis

External email: Use caution opening links or attachments

Currently hda on tegra30 fails to open a stream with an input/output error. This is similar to the issue referenced in [1].

For example:
speaker-test -Dhw:0,3 -c 2

speaker-test 1.2.2

Playback device is hw:0,3
Stream parameters are 48000Hz, S16_LE, 2 channels
Using 16 octaves of pink noise
Rate set to 48000Hz (requested 48000Hz)
Buffer size range from 64 to 16384
Period size range from 32 to 8192
Using max buffer size 16384
Periods = 4
was set period_size = 4096
was set buffer_size = 16384
0 - Front Left
Write error: -5,Input/output error
xrun_recovery failed: -5,Input/output error
Transfer failed: Input/output error

[1] states "Due to a legacy HW design problem", implying the issue applies to all previous tegra-hda devices. The tegra-hda device was introduced in tegra30 but only utilized in tegra124 until now.
For this reason it is unknown when this issue first manifested.

Applying the fix in [1] universally resolves this issue on tegra30. Tested on the Ouya game console and the tf201 tablet.

[1] 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194")

Quoted 8 lines
Quoted 4 lines

This issue was never seen on Tegra210/Tegra186 and hence at that time it was thought to be specific to Tegra194. I never tested this on Tegra30 since I don't have this device. I will clarify this with HW folks if workaround is safer for all chips.

So this is confirmed to not affect Tegra210 and Tegra186, but it does affect Tegra194 and Tegra30.
Is it possible for the hardware team to pitch on on where the fix was implemented?

I discussed this with HW team. The issue is applicable to all Tegra chips.

Below is the striping formula referenced from HD audio spec. { ((num_channels * bits_per_sample) / number of SDOs) >= 8 }

The current issue is seen because Tegra HW has a problem with boundary condition (= 8) for striping. The reason why it is not seen on Tegra210/Tegra186 is because it uses max 2SDO lines. Max SDO lines is read from GCAP register.

For the given stream (channels = 2, bps = 16); ratio = (channels * bps) / NSDO = 32 / NSDO;

On Tegra30,      ratio = 32/4 = 8  (FAIL)
On Tegra210/186, ratio = 32/2 = 16 (PASS)
On Tegra194,     ratio = 32/4 = 8  (FAIL) ==> Earlier workaround was applied for it

If Tegra210/186 is forced to use 4SDO, it fails there as well. So the behavior is consistent across all these chips.

Quoted 23 lines
Quoted 20 lines
Quoted 11 lines
---
   sound/pci/hda/hda_tegra.c | 3 +--
   1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +0 -0
index 70164d1428d4..f8d61e677a09 100644

sound/pci/hda/hda_tegra.c static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev) · line 391

Quoted 6 lines
sound/pci/hda/hda_tegra.c +1 -2
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
           * in powers of 2, next available ratio is 16 which can be
           * used as a limiting factor here.
           */
-       if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-               chip->bus.core.sdo_limit = 16;
+       chip->bus.core.sdo_limit = 16;

Future Tegra chips address this problem and hence cannot be enforced by default. May be we can have like below:

Quoted 3 lines

if (of_device_is_compatible(np, "nvidia,tegra30-hda")) chip->bus.core.sdo_limit = 16;

Quoted 7 lines

It will need to be a bit more complicated than that, since the tegra186 and tegra210 device trees have "nvidia,tegra30-hda" as a fallback.
Looking at the generation map, tegra30-hda can be the fallback for the broken implementation and tegra210-hda can be the fallback for the working implementation.
Does that work for you?

As per above explanation, it is fine to apply the workaround for Tegra210/186 as well. So it simplifies things for all existing chips.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
sound/pci/hda/hda_tegra.c +0 -1
          /* codec detection */
          if (!bus->codec_mask) {
--

2.25.1

maintainer Reviewed-by
#7 lore raw

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

On 08/01/2021 08:00, Sameer Pujar wrote:

...

Quoted 32 lines
Quoted 24 lines
Quoted 21 lines
Quoted 11 lines

---
   sound/pci/hda/hda_tegra.c | 3 +--

   1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +0 -0
index 70164d1428d4..f8d61e677a09 100644

sound/pci/hda/hda_tegra.c static int hda_tegra_first_init(struct azx · line 392

Quoted 7 lines
sound/pci/hda/hda_tegra.c +1 -2
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx
 *chip, struct platform_device *pdev)
            * in powers of 2, next available ratio is 16 which can be
            * used as a limiting factor here.
            */
-       if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-               chip->bus.core.sdo_limit = 16;
+       chip->bus.core.sdo_limit = 16;

Future Tegra chips address this problem and hence cannot be enforced by default. May be we can have like below:

Quoted 3 lines

if (of_device_is_compatible(np, "nvidia,tegra30-hda")) chip->bus.core.sdo_limit = 16;

Quoted 7 lines

It will need to be a bit more complicated than that, since the tegra186 and tegra210 device trees have "nvidia,tegra30-hda" as a fallback.
Looking at the generation map, tegra30-hda can be the fallback for the broken implementation and tegra210-hda can be the fallback for the working implementation.
Does that work for you?

Quoted 2 lines

As per above explanation, it is fine to apply the workaround for Tegra210/186 as well. So it simplifies things for all existing chips.

FYI ... we now have minimal support for Tegra234 in upstream that should not require this. Given that the Tegra234 device-tree does not include support for HDA yet, I think it is fine to apply this as-is. However, once we do add support for Tegra234 HDA, then we should ensure that this is not applied. So that said ...

Cheers
Jon

Signature · 1 line
nvpublic
maintainer
#8 lore raw

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Quoted 41 lines · Jon Hunter

On 08/01/2021 08:00, Sameer Pujar wrote:

...

Quoted 32 lines
Quoted 24 lines
Quoted 21 lines
Quoted 11 lines

---
   sound/pci/hda/hda_tegra.c | 3 +--

   1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +0 -0
index 70164d1428d4..f8d61e677a09 100644

sound/pci/hda/hda_tegra.c static int hda_tegra_first_init(struct azx · line 392

Quoted 7 lines
sound/pci/hda/hda_tegra.c +1 -2
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx
 *chip, struct platform_device *pdev)
            * in powers of 2, next available ratio is 16 which can be
            * used as a limiting factor here.
            */
-       if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-               chip->bus.core.sdo_limit = 16;
+       chip->bus.core.sdo_limit = 16;

Future Tegra chips address this problem and hence cannot be enforced by default. May be we can have like below:

Quoted 3 lines

if (of_device_is_compatible(np, "nvidia,tegra30-hda")) chip->bus.core.sdo_limit = 16;

Quoted 7 lines

It will need to be a bit more complicated than that, since the tegra186 and tegra210 device trees have "nvidia,tegra30-hda" as a fallback.
Looking at the generation map, tegra30-hda can be the fallback for the broken implementation and tegra210-hda can be the fallback for the working implementation.
Does that work for you?

Quoted 2 lines

As per above explanation, it is fine to apply the workaround for Tegra210/186 as well. So it simplifies things for all existing chips.

Quoted 7 lines

FYI ... we now have minimal support for Tegra234 in upstream that should not require this. Given that the Tegra234 device-tree does not include support for HDA yet, I think it is fine to apply this as-is. However, once we do add support for Tegra234 HDA, then we should ensure that this is not applied. So that said ...

Sorry I was chatting with Sameer offline and we think if we just switch the test to the following then this will take care of Tegra234 when we add it ...

    if (of_device_is_compatible(np, "nvidia,tegra30-hda"))

Peter, would you be able to send a V2 with this?

Thanks!
Jon

Signature · 1 line
nvpublic
author
#9 lore raw

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Quoted 59 lines · Jon Hunter
Quoted 41 lines · Jon Hunter

On 08/01/2021 08:00, Sameer Pujar wrote:

...

Quoted 32 lines
Quoted 24 lines
Quoted 21 lines
Quoted 11 lines
---
   sound/pci/hda/hda_tegra.c | 3 +--
   1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_tegra.c +0 -0
index 70164d1428d4..f8d61e677a09 100644

sound/pci/hda/hda_tegra.c static int hda_tegra_first_init(struct azx · line 392

Quoted 7 lines
sound/pci/hda/hda_tegra.c +1 -2
@@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx
 *chip, struct platform_device *pdev)
           * in powers of 2, next available ratio is 16 which can be
           * used as a limiting factor here.
           */
-       if (of_device_is_compatible(np, "nvidia,tegra194-hda"))
-               chip->bus.core.sdo_limit = 16;
+       chip->bus.core.sdo_limit = 16;

Future Tegra chips address this problem and hence cannot be enforced by default. May be we can have like below:

Quoted 3 lines

if (of_device_is_compatible(np, "nvidia,tegra30-hda")) chip->bus.core.sdo_limit = 16;

Quoted 7 lines

It will need to be a bit more complicated than that, since the tegra186 and tegra210 device trees have "nvidia,tegra30-hda" as a fallback.
Looking at the generation map, tegra30-hda can be the fallback for the broken implementation and tegra210-hda can be the fallback for the working implementation.
Does that work for you?

Quoted 2 lines

As per above explanation, it is fine to apply the workaround for Tegra210/186 as well. So it simplifies things for all existing chips.

Quoted 7 lines

FYI ... we now have minimal support for Tegra234 in upstream that should not require this. Given that the Tegra234 device-tree does not include support for HDA yet, I think it is fine to apply this as-is. However, once we do add support for Tegra234 HDA, then we should ensure that this is not applied. So that said ...

Sorry I was chatting with Sameer offline and we think if we just switch the test to the following then this will take care of Tegra234 when we add it ...

    if (of_device_is_compatible(np, "nvidia,tegra30-hda"))
Quoted 7 lines

Peter, would you be able to send a V2 with this?

Thanks!
Jon

--
nvpublic

Certainly, thank you all!

#10 lore raw
In reply to Peter Geis
Quoted 12 lines · Peter Geis

The following patches fix tegra-hda on legacy tegra devices.
Two issues were discovered preventing tegra-hda from functioning:
The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function. The tegra-hda encounters an input/output error when opening a stream.

Since the only mainline device that used tegra-hda previously was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices.
We can apply it universally to the tegra-hda device to resolve the issues across the board.
Note that downstream devices used the spdif device instead of hda for hdmi audio.
The spdif device lacks a driver on mainline.

Quoted 3 lines

Peter Geis (2):
clk: tegra30: Add hda clock default rates to clock driver
ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Can Nvidia people look at those?

thanks,

Takashi

Quoted 8 lines
 drivers/clk/tegra/clk-tegra30.c | 2 ++
 sound/pci/hda/hda_tegra.c       | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1