imx8mm_beacon: Enable HS400 on MMC controller
PATCH 1/1 imx8mm_beacon: Enable HS400 on MMC controller
The i.MX8MM is capable of HS400. Enable it in both U-Boot and SPL for faster throughput.
configs/imx8mm_beacon_defconfig +7 -0
@@ -70,6 +70,13 @@ CONFIG_DM_I2C=y CONFIG_SYS_I2C_MXC=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y +CONFIG_MMC_IO_VOLTAGE=y +CONFIG_SPL_MMC_IO_VOLTAGE=y +CONFIG_MMC_UHS_SUPPORT=y +CONFIG_SPL_MMC_UHS_SUPPORT=y +CONFIG_MMC_HS400_ES_SUPPORT=y +CONFIG_MMC_HS400_SUPPORT=y +CONFIG_SPL_MMC_HS400_SUPPORT=y CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_ATHEROS=y
Signature · 1 line
2.25.1
PATCH 1/1 imx8mm_beacon: Enable HS400 on MMC controller
Hello Adam,
Quoted 10 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Adam Ford
Sent: Saturday, December 5, 2020 2:00 AM
To: u-boot at lists.denx.de
Cc: aford at beaconembedded.com; Adam Ford <[email protected]>
Subject: [PATCH]imx8mm_beacon: Enable HS400 on MMC controllerThe i.MX8MM is capable of HS400. Enable it in both U-Boot and SPL for faster throughput.
I'm not quite sure if those high-speed modes would be required to be enabled for SPL...
Even though the support for those modes is provided in SPL build, there might be a little benefit of having it enabled as the only thing SPL would need to fetch from storage medias would be U-Boot itself, and the difference in access time between high speed modes enabled or disabled for this task is quite negligible. The downside there would rather be an increase in SPL size to accommodate enabled code paths.
I was contemplating myself to have those included, but decided to op-out from it as I could not justify the benefit of it.
Do you see any particular use-case where it would be beneficial to enable those modes in SPL? If so - can you please share them, as if it would turn out to be beneficial - I might also turn them on in EVK configs.
Quoted 22 lines
Signed-off-by Adam Ford <[email protected]>(quoted diff) +0
-0b/configs/imx8mm_beacon_defconfig index
c5d331f617..49d5453078100644configs/imx8mm_beacon_defconfig +7
-1@@ -70,6 +70,13 @@ CONFIG_DM_I2C=y CONFIG_SYS_I2C_MXC=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y +CONFIG_MMC_IO_VOLTAGE=y +CONFIG_SPL_MMC_IO_VOLTAGE=y +CONFIG_MMC_UHS_SUPPORT=y +CONFIG_SPL_MMC_UHS_SUPPORT=y +CONFIG_MMC_HS400_ES_SUPPORT=y +CONFIG_MMC_HS400_SUPPORT=y +CONFIG_SPL_MMC_HS400_SUPPORT=y CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_ATHEROS=y --
Quoted 1 line
2.25.1
-- andrey
PATCH 1/1 imx8mm_beacon: Enable HS400 on MMC controller
Quoted 11 lines · ZHIZHIKIN Andrey
Hello Adam,
Quoted 8 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Adam Ford
Sent: Saturday, December 5, 2020 2:00 AM
To: u-boot at lists.denx.de
Cc: aford at beaconembedded.com; Adam Ford <[email protected]>
Subject: [PATCH]imx8mm_beacon: Enable HS400 on MMC controller
Quoted 5 lines
Quoted 2 lines
The i.MX8MM is capable of HS400. Enable it in both U-Boot and SPL for faster throughput.
I'm not quite sure if those high-speed modes would be required to be enabled for SPL...
There are separate SPL flags, so we could leave them off.
Quoted 7 lines
Even though the support for those modes is provided in SPL build, there might be a little benefit of having it enabled as the only thing SPL would need to fetch from storage medias would be U-Boot itself, and the difference in access time between high speed modes enabled or disabled for this task is quite negligible. The downside there would rather be an increase in SPL size to accommodate enabled code paths.
Quoted 6 lines
I was contemplating myself to have those included, but decided to op-out from it as I could not justify the benefit of it.
Do you see any particular use-case where it would be beneficial to enable those modes in SPL? If so - can you please share them, as if it would turn out to be beneficial - I might also turn them on in EVK configs.
I turned them on because I could and it fit into SPL. In theory the impy could be deactivated for people who don't have the room. I didn't do any time measurements so I don't know of the higher speed made it load u-boot any faster since it takes a little more time to do the extra initialization, I can see the argument to leave them off.
Maybe it's best to default the configs to leave them off in SPL, and let people decide on what's best for their boards. For the Beacon board, I'll probably leave it on, but if SPL size constraints become an issue, I might turn them off later.
adam
Quoted 26 lines
Quoted 23 lines
Signed-off-by Adam Ford <[email protected]>(quoted diff) +0
-0b/configs/imx8mm_beacon_defconfig index
c5d331f617..49d5453078100644configs/imx8mm_beacon_defconfig +7
-1@@ -70,6 +70,13 @@ CONFIG_DM_I2C=y CONFIG_SYS_I2C_MXC=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y +CONFIG_MMC_IO_VOLTAGE=y +CONFIG_SPL_MMC_IO_VOLTAGE=y +CONFIG_MMC_UHS_SUPPORT=y +CONFIG_SPL_MMC_UHS_SUPPORT=y +CONFIG_MMC_HS400_ES_SUPPORT=y +CONFIG_MMC_HS400_SUPPORT=y +CONFIG_SPL_MMC_HS400_SUPPORT=y CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_ATHEROS=y --Quoted 1 line
2.25.1
-- andrey
PATCH 1/1 imx8mm_beacon: Enable HS400 on MMC controller
Quoted 42 lines
-----Original Message-----
From: Adam Ford <[email protected]>
Sent: Saturday, December 5, 2020 4:01 PM
To: ZHIZHIKIN Andrey <[email protected]>
Cc: u-boot at lists.denx.de; aford at beaconembedded.com
Subject: Re: [PATCH]imx8mm_beacon: Enable HS400 on MMC controllerQuoted 11 lines · ZHIZHIKIN Andrey
Hello Adam,
Quoted 8 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Adam Ford
Sent: Saturday, December 5, 2020 2:00 AM
To: u-boot at lists.denx.de
Cc: aford at beaconembedded.com; Adam Ford <[email protected]>
Subject: [PATCH]imx8mm_beacon: Enable HS400 on MMC controllerQuoted 5 lines
Quoted 2 lines
The i.MX8MM is capable of HS400. Enable it in both U-Boot and SPL for faster throughput.
I'm not quite sure if those high-speed modes would be required to be enabled for SPL...
There are separate SPL flags, so we could leave them off.
Quoted 6 lines
Even though the support for those modes is provided in SPL build, there might be a little benefit of having it enabled as the only thing SPL would need to fetch from storage medias would be U-Boot itself, and the difference in access time between high speed modes enabled or disabled for this task is quite negligible. The downside there would rather be an
increase in SPL size to accommodate enabled code paths.
Quoted 7 lines
I was contemplating myself to have those included, but decided to op-out from it as I could not justify the benefit of it.
Do you see any particular use-case where it would be beneficial to enable those modes in SPL? If so - can you please share them, as if it would turn out to be beneficial - I might also turn them on in EVK configs.
Quoted 5 lines
I turned them on because I could and it fit into SPL. In theory the impy could be deactivated for people who don't have the room. I didn't do any time measurements so I don't know of the higher speed made it load u-boot any faster since it takes a little more time to do the extra initialization, I can see the argument to leave them off.
OK, got it! Since you've introduced it for a specific derivative and you know that from the size perspective it fits - then I believe it is OK to have them enabled.
Quoted 4 lines
Maybe it's best to default the configs to leave them off in SPL, and let people decide on what's best for their boards. For the Beacon board, I'll probably leave it on, but if SPL size constraints become an issue, I might turn them off later.
For EVK configs I would leave SPL configs OFF.
Quoted 29 lines
adam
Quoted 27 lines
Quoted 24 lines
Signed-off-by Adam Ford <[email protected]>(quoted diff) +0
-0b/configs/imx8mm_beacon_defconfig index
c5d331f617..49d5453078100644configs/imx8mm_beacon_defconfig +7
-1@@ -70,6 +70,13 @@ CONFIG_DM_I2C=y CONFIG_SYS_I2C_MXC=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y +CONFIG_MMC_IO_VOLTAGE=y +CONFIG_SPL_MMC_IO_VOLTAGE=y +CONFIG_MMC_UHS_SUPPORT=y +CONFIG_SPL_MMC_UHS_SUPPORT=y +CONFIG_MMC_HS400_ES_SUPPORT=y +CONFIG_MMC_HS400_SUPPORT=y +CONFIG_SPL_MMC_HS400_SUPPORT=y CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_ATHEROS=y --Quoted 1 line
2.25.1
-- andrey
-- andrey
PATCH 1/1 imx8mm_beacon: Enable HS400 on MMC controller
In reply to Adam FordQuoted 11 lines
The i.MX8MM is capable of HS400. Enable it in both U-Boot and SPL for faster throughput.
Signed-off-by Adam Ford <[email protected]>configs/imx8mm_beacon_defconfig +0
-0@@ -70,6 +70,13 @@ CONFIG_DM_I2C=y CONFIG_SYS_I2C_MXC=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y
configs/imx8mm_beacon_defconfig CONFIG_DM_I2C=y · line 82
Quoted 10 lines
configs/imx8mm_beacon_defconfig +7
-0+CONFIG_MMC_IO_VOLTAGE=y +CONFIG_SPL_MMC_IO_VOLTAGE=y +CONFIG_MMC_UHS_SUPPORT=y +CONFIG_SPL_MMC_UHS_SUPPORT=y +CONFIG_MMC_HS400_ES_SUPPORT=y +CONFIG_MMC_HS400_SUPPORT=y +CONFIG_SPL_MMC_HS400_SUPPORT=y CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_ATHEROS=y
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================