Skip to contentSkip to conversation

bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE

PATCH New Pali Rohár 3 participants 4 messages Dec 26, 2020 – Dec 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE

CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.

Define this dependency in Kconfig and remove information about this requirement from documentation file.

---
 cmd/Kconfig            | 1 +
 doc/usage/bootmenu.rst | 5 -----
 2 files changed, 1 insertion(+), 5 deletions(-)
cmd/Kconfig +1 -0
index 1595de999b..02c28c68bd 100644
@@ -279,6 +279,7 @@ source lib/efi_selftest/Kconfig
 config CMD_BOOTMENU
 	bool "bootmenu"
 	select MENU
+	select CFB_CONSOLE_ANSI if CFB_CONSOLE
 	help
 	  Add an ANSI terminal boot menu command.
 
doc/usage/bootmenu.rst +0 -5
index 1f094ad6ed..1016ac8ceb 100644
@@ -88,8 +88,3 @@ To run the bootmenu at startup add these additional settings::
     CONFIG_AUTOBOOT_KEYED=y
     CONFIG_BOOTDELAY=30
     CONFIG_AUTOBOOT_MENU_SHOW=y
-
-When you intend to use the bootmenu on a color frame buffer console,
-make sure to additionally define::
-
-    CONFIG_CFB_CONSOLE_ANSI=y
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE

Hi Paul,

Quoted 4 lines · Pali Roh?r

CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.

Quoted 8 lines

Define this dependency in Kconfig and remove information about this requirement from documentation file.

---
 cmd/Kconfig            | 1 +
 doc/usage/bootmenu.rst | 5 -----
 2 files changed, 1 insertion(+), 5 deletions(-)

This driver is past the driver model migration deadline so we shouldn't accept patches, except perhaps to migrate or remove it.

Regards,
Simon

#2 lore raw

PATCH 1/1 bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE

Quoted 10 lines · Simon Glass

Hi Paul,

Quoted 7 lines · Pali Roh?r

CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.

Define this dependency in Kconfig and remove information about this requirement from documentation file.

Quoted 8 lines
Quoted 5 lines
---
  cmd/Kconfig            | 1 +
  doc/usage/bootmenu.rst | 5 -----
  2 files changed, 1 insertion(+), 5 deletions(-)

This driver is past the driver model migration deadline so we shouldn't accept patches, except perhaps to migrate or remove it.

All boards selecting CONFIG_CFB_CONSOLE also select CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in doc/usage/bootmenu.rst.

Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting used by all driver model video drivers? Shouldn't that setting be mentioned in doc/usage/bootmenu.rst?

Best regards

Heinrich

#3 lore raw

PATCH 1/1 bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE

Quoted 17 lines · On Tuesday 29 December 2020 11:42:56 Heinrich Schuchardt wrote:
Quoted 16 lines · Simon Glass

Hi Paul,

Quoted 12 lines · Pali Roh?r

CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.

Define this dependency in Kconfig and remove information about this requirement from documentation file.

---
  cmd/Kconfig            | 1 +
  doc/usage/bootmenu.rst | 5 -----
  2 files changed, 1 insertion(+), 5 deletions(-)
Quoted 7 lines
Quoted 2 lines

This driver is past the driver model migration deadline so we shouldn't accept patches, except perhaps to migrate or remove it.

All boards selecting CONFIG_CFB_CONSOLE also select CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in doc/usage/bootmenu.rst.

That is because I added this "hint" into Kconfig. So it does not have to be specified in documentation rst file.

Quoted 3 lines

Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting used by all driver model video drivers? Shouldn't that setting be mentioned in doc/usage/bootmenu.rst?

Because I did not know about this option. It was not mentioned in documentation rst file.