Skip to contentSkip to conversation

spi: spi-qcom-qspi: Use irq trigger flags from firmware

PATCH Superseded Stephen Boyd 3 participants 4 messages Dec 13, 2020 – Jan 13, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: spi-qcom-qspi: Use irq trigger flags from firmware

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Cc Douglas Anderson <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Mukesh Kumar Savaliya <[email protected]>
Cc Akash Asthana <[email protected]>
---
 drivers/spi/spi-qcom-qspi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/spi/spi-qcom-qspi.c +1 -2
index 5eed88af6899..8e70f5e63e0b 100644
@@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev)
 	ret = platform_get_irq(pdev, 0);
 	if (ret < 0)
 		goto exit_probe_master_put;
-	ret = devm_request_irq(dev, ret, qcom_qspi_irq,
-			IRQF_TRIGGER_HIGH, dev_name(dev), ctrl);
+	ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl);
 	if (ret) {
 		dev_err(dev, "Failed to request irq %d\n", ret);
 		goto exit_probe_master_put;

base-commit: b65054597872ce3aefbc6a666385eabdf9e288da

Signature · 1 line
https://chromeos.dev
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 18 lines · Stephen Boyd

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Cc Douglas Anderson <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Mukesh Kumar Savaliya <[email protected]>
Cc Akash Asthana <[email protected]>
---
 drivers/spi/spi-qcom-qspi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/spi/spi-qcom-qspi.c +0 -0
index 5eed88af6899..8e70f5e63e0b 100644

drivers/spi/spi-qcom-qspi.c static int qcom_qspi_probe(struct platform_device *pdev) · line 519

Quoted 6 lines
drivers/spi/spi-qcom-qspi.c +1 -2
@@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev)
        ret = platform_get_irq(pdev, 0);
        if (ret < 0)
                goto exit_probe_master_put;
-       ret = devm_request_irq(dev, ret, qcom_qspi_irq,
-                       IRQF_TRIGGER_HIGH, dev_name(dev), ctrl);
+       ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl);

I don't feel that the old code is really wrong, but I guess it is weird that it's double-specified (both in the code and in the dts). ...so this is OK w/ me.

maintainer
#2 lore raw
In reply to Stephen Boyd
Quoted 2 lines · Stephen Boyd

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

This doesn't apply against current code, please check and resend.

maintainer
#3 lore raw
In reply to Stephen Boyd
Quoted 2 lines · Stephen Boyd

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-qcom-qspi: Use irq trigger flags from firmware

      commit: eaecba8767835783bdd2f4e72406668cda7d8d54

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark