lpm: add sve support for lookup on Arm platform
Subsystems (2)
RFC PATCH 1/1 lpm: add sve support for lookup on Arm platform
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
--- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 +++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 lib/librte_lpm/rte_lpm_sve.h
lib/librte_eal/arm/include/rte_vect.h +3 -0
@@ -9,6 +9,9 @@#include "generic/rte_vect.h" #include "rte_debug.h" #include "arm_neon.h" +#ifdef __ARM_FEATURE_SVE +#include <arm_sve.h> +#endif #ifdef __cplusplusextern "C" {
lib/librte_lpm/meson.build +1 -1
@@ -5,6 +5,6 @@ sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers # without worrying about which architecture we actually need -headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') +headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h', 'rte_lpm_sve.h') deps += ['hash'] deps += ['rcu']
lib/librte_lpm/rte_lpm.h +4 -0
@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else
lib/librte_lpm/rte_lpm_sve.h new file +83 -0
83 lines not on this page · raw message
Signature · 1 line
2.25.1
Hi Ruifeng,
Thanks for the patch, see comments below
Quoted 98 lines · Ruifeng Wang
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
Signed-off-by Ruifeng Wang <[email protected]>--- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 +++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 1 deletion(-)create mode 100644
lib/librte_lpm/rte_lpm_sve.hlib/librte_eal/arm/include/rte_vect.h +3
-0@@ -9,6 +9,9 @@#include "generic/rte_vect.h" #include "rte_debug.h" #include "arm_neon.h" +#ifdef __ARM_FEATURE_SVE +#include <arm_sve.h> +#endif #ifdef __cplusplusextern "C" {lib/librte_lpm/meson.build +1
-1@@ -5,6 +5,6 @@ sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers # without worrying about which architecture we actually need -headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') +headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h', 'rte_lpm_sve.h') deps += ['hash'] deps += ['rcu']lib/librte_lpm/rte_lpm.h +4
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else lib/librte_lpm/rte_lpm_sve.h new file +38
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_ +#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static void +__rte_lpm_lookup_vec(const struct rte_lpm *lpm, const uint32_t *ips, + uint32_t *__rte_restrict next_hops, const uint32_t n) +{ + uint32_t i = 0; + svuint32_t v_ip, v_idx, v_tbl24, v_tbl8, v_hop; + svuint32_t v_mask_xv, v_mask_v, v_mask_hop; + svbool_t pg = svwhilelt_b32(i, n); + svbool_t pv; + + do { + v_ip = svld1(pg, &ips[i]); + /* Get indices for tbl24[] */ + v_idx = svlsr_x(pg, v_ip, 8); + /* Extract values from tbl24[] */ + v_tbl24 = svld1_gather_index(pg, (const uint32_t *)lpm->tbl24, + v_idx); + + /* Create mask with valid set */ + v_mask_v = svdup_u32_z(pg, RTE_LPM_LOOKUP_SUCCESS); + /* Create mask with valid and valid_group set */ + v_mask_xv = svdup_u32_z(pg, RTE_LPM_VALID_EXT_ENTRY_BITMASK); + /* Create predicate for tbl24 entries: (valid && !valid_group) */ + pv = svcmpeq(pg, svand_z(pg, v_tbl24, v_mask_xv), v_mask_v);
lib/librte_lpm/rte_lpm_sve.h line 48
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+/* Create mask for next_hop in table entry */ + v_mask_hop =svdup_u32_z (pg,0x00ffffff ); +/* Extract next_hop and write back */ + v_hop =svand_x (pv, v_tbl24, v_mask_hop); +svst1 (pv, &next_hops[i], v_hop); + +/* Update predicate for tbl24 entries: (valid && valid_group) */ + pv =svcmpeq (pg,svand_z (pg, v_tbl24, v_mask_xv), v_mask_xv); +/* Compute tbl8 index */ + v_idx =svand_x (pv, v_tbl24,svdup_u32_z (pv,0xff ));
Loos like here should bev_idx = svand_x(pv, v_tbl24, svdup_u32_z(pv, 0xffffff)); because we are using 24 bits to keep tbl8 group.
lib/librte_lpm/rte_lpm_sve.h line 59
Quoted 11 lines
lib/librte_lpm/rte_lpm_sve.h new file +11
-0+ v_idx =svmul_x (pv, v_idx,RTE_LPM_TBL8_GROUP_NUM_ENTRIES ); + v_idx =svadd_x (pv,svand_x (pv, v_ip,svdup_u32_z (pv,0xff )), + v_idx); +/* Extract values from tbl8[] */ + v_tbl8 =svld1_gather_index (pv, (const uint32_t *)lpm->tbl8, + v_idx); +/* Update predicate for tbl8 entries: (valid) */ + pv =svcmpeq (pv,svand_z (pv, v_tbl8, v_mask_v), v_mask_v); +/* Extract next_hop and write back */ + v_hop =svand_x (pv, v_tbl8, v_mask_hop); +svst1 (pv, &next_hops[i], v_hop);
I'm not an expert, but probably it would be better to merge two stores (svst1) into a single one?
lib/librte_lpm/rte_lpm_sve.h line 62
Quoted 3 lines
lib/librte_lpm/rte_lpm_sve.h new file +3
-0+ + i +=svlen (v_ip); + pg =svwhilelt_b32 (i, n);
Isn't it better to move the predicate calculation to the beginning of the loop and just do {} while (i < n)?
Quoted 22 lines
lib/librte_lpm/rte_lpm_sve.h new file +21
-0+ } while (svptest_any(svptrue_b32(), pg)); +} + +static inline void +rte_lpm_lookupx4 (const struct rte_lpm *lpm,xmm_t ip,uint32_t hop[4 ], +uint32_t defv) +{ +uint32_t i, ips[4 ]; + +vst1q_s32 ((int32_t *)ips, ip); +for (i =0 ; i <4 ; i++) + hop[i] = defv; + +__rte_lpm_lookup_vec (lpm, ips, hop,4 ); +} + +#ifdef __cplusplus +} +#endif + +#endif /* _RTE_LPM_SVE_H_ */
Signature · 2 lines
Regards, Vladimir
Quoted 10 lines
-----Original Message-----
From: Medvedkin, Vladimir <[email protected]>
Sent: Tuesday, January 5, 2021 11:44 PM
To: Ruifeng Wang <[email protected]>; Jan Viktorin <[email protected]>; [email protected]; Bruce Richardson <[email protected]>
Cc: [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>
Subject: Re: [RFC PATCH] lpm: add sve support for lookup on Arm platform
Quoted 3 lines
Hi Ruifeng,
Thanks for the patch, see comments below
Hi Vladimir,
Thank you for your review.
Quoted 115 lines · Ruifeng Wang
lib/librte_lpm/rte_lpm.h rte_lpm_lookupx4(const struct rte_lpm *lpm,
Quoted 46 lines
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
Signed-off-by Ruifeng Wang <[email protected]>--- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 +++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 1 deletion(-)create mode 100644
lib/librte_lpm/rte_lpm_sve.hlib/librte_eal/arm/include/rte_vect.h +3
-0@@ -9,6 +9,9 @@#include "generic/rte_vect.h" #include "rte_debug.h" #include "arm_neon.h" +#ifdef __ARM_FEATURE_SVE +#include <arm_sve.h> +#endif #ifdef __cplusplusextern "C" {lib/librte_lpm/meson.build +2
-1@@ -5,6 +5,6 @@ sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers # without worrying about which architecture we actually need -headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') +headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', +'rte_lpm_sse.h', 'rte_lpm_sve.h') deps += ['hash'] deps += ['rcu']lib/librte_lpm/rte_lpm.h index renamed from lib/librte_lpm/rte_lpm.h +0
-0
1afe55cdc..28b57683b100644lib/librte_lpm/rte_lpm.h +0
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm,
xmm_tip,uint32_thop[4],Quoted 47 lines
lib/librte_lpm/rte_lpm.h +4
-0uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else (quoted diff) +0
-0
b/lib/librte_lpm/rte_lpm_sve.hnew file mode 100644 index 000000000..86576ec52lib/librte_lpm/rte_lpm_sve.h new file +29
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2020 Arm Limited + */ + +#ifndef _RTE_LPM_SVE_H_ +#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static void +__rte_lpm_lookup_vec(const struct rte_lpm *lpm, const uint32_t *ips, + uint32_t *__rte_restrict next_hops, const uint32_t n) { + uint32_t i = 0; + svuint32_t v_ip, v_idx, v_tbl24, v_tbl8, v_hop; + svuint32_t v_mask_xv, v_mask_v, v_mask_hop; + svbool_t pg = svwhilelt_b32(i, n); + svbool_t pv; + + do { + v_ip = svld1(pg, &ips[i]); + /* Get indices for tbl24[] */ + v_idx = svlsr_x(pg, v_ip, 8); + /* Extract values from tbl24[] */ + v_tbl24 = svld1_gather_index(pg, (const uint32_t *)lpm-tbl24,
lib/librte_lpm/rte_lpm_sve.h
Quoted 6 lines
lib/librte_lpm/rte_lpm_sve.h new file +6
-0+ v_idx); + +/* Create mask with valid set */ + v_mask_v =svdup_u32_z (pg,RTE_LPM_LOOKUP_SUCCESS ); +/* Create mask with valid and valid_group set */ + v_mask_xv = svdup_u32_z(pg,
RTE_LPM_VALID_EXT_ENTRY_BITMASK);lib/librte_lpm/rte_lpm_sve.h
Quoted 1 line
lib/librte_lpm/rte_lpm_sve.h new file +1
-0+/* Create predicate for tbl24 entries: (valid && !valid_group) */
lib/librte_lpm/rte_lpm_sve.h
Quoted 1 line
lib/librte_lpm/rte_lpm_sve.h new file +1
-0+ pv = svcmpeq(pg, svand_z(pg, v_tbl24, v_mask_xv),
v_mask_v);lib/librte_lpm/rte_lpm_sve.h
Quoted 7 lines
lib/librte_lpm/rte_lpm_sve.h new file +7
-0+/* Create mask for next_hop in table entry */ + v_mask_hop =svdup_u32_z (pg,0x00ffffff ); +/* Extract next_hop and write back */ + v_hop =svand_x (pv, v_tbl24, v_mask_hop); +svst1 (pv, &next_hops[i], v_hop); + +/* Update predicate for tbl24 entries: (valid && valid_group) */
Quoted 8 lines
lib/librte_lpm/rte_lpm_sve.h
Quoted 1 line
lib/librte_lpm/rte_lpm_sve.h new file +1
-0+ pv = svcmpeq(pg, svand_z(pg, v_tbl24, v_mask_xv),
v_mask_xv);lib/librte_lpm/rte_lpm_sve.h line 48
Quoted 2 lines
lib/librte_lpm/rte_lpm_sve.h new file +2
-0+/* Compute tbl8 index */ + v_idx =svand_x (pv, v_tbl24,svdup_u32_z (pv,0xff ));Loos like here should be
v_idx=svand_x(pv, v_tbl24, svdup_u32_z(pv, 0xffffff)); because we are using 24 bits to keep tbl8 group.
Yes, the mask should be 0xffffff.
Also noticed there is common issue in all vector lookup implementations (NEON/SSE/ALTIVEC). I'll correct this and fix other vector implementations in next version.
Quoted 6 lines
lib/librte_lpm/rte_lpm_sve.h
Quoted 3 lines
lib/librte_lpm/rte_lpm_sve.h new file +1
-0+ v_idx = svmul_x(pv, v_idx,
RTE_LPM_TBL8_GROUP_NUM_ENTRIES);lib/librte_lpm/rte_lpm_sve.h
Quoted 1 line
lib/librte_lpm/rte_lpm_sve.h new file +1
-0+ v_idx = svadd_x(pv, svand_x(pv, v_ip, svdup_u32_z(pv,
0xff)),
Quoted 12 lines
lib/librte_lpm/rte_lpm_sve.h line 59
Quoted 9 lines
lib/librte_lpm/rte_lpm_sve.h new file +9
-0+ v_idx); +/* Extract values from tbl8[] */ + v_tbl8 =svld1_gather_index (pv, (const uint32_t *)lpm->tbl8, + v_idx); +/* Update predicate for tbl8 entries: (valid) */ + pv =svcmpeq (pv,svand_z (pv, v_tbl8, v_mask_v), v_mask_v); +/* Extract next_hop and write back */ + v_hop =svand_x (pv, v_tbl8, v_mask_hop); +svst1 (pv, &next_hops[i], v_hop);I'm not an expert, but probably it would be better to merge two stores (svst1) into a single one?
I think we can keep current implementation.
In most cases, tbl24 will be not expanded. Then SVE predicate for tbl8 processing will be zero. So operations on tbl8 will be null operations.
I think it is better not to mix the two stores (from tbl24 and from tbl8).
Quoted 7 lines
lib/librte_lpm/rte_lpm_sve.h line 62
Quoted 4 lines
lib/librte_lpm/rte_lpm_sve.h new file +3
-0+ + i +=svlen (v_ip); + pg =svwhilelt_b32 (i, n);Isn't it better to move the predicate calculation to the beginning of the loop and just do {} while (i < n)?
Yes, that also works.
I think checking on SVE predicates is the suggested way to do vector length agnostic loop. It is more generic and flexible.
Quoted 25 lines
Quoted 11 lines
lib/librte_lpm/rte_lpm_sve.h new file +9
-0+ }while (svptest_any (svptrue_b32 (), pg)); } + +static inline void +rte_lpm_lookupx4 (const struct rte_lpm *lpm,xmm_t ip,uint32_t hop[4 ], +uint32_t defv) +{ +uint32_t i, ips[4 ]; + +vst1q_s32 ((int32_t *)ips, ip);lib/librte_lpm/rte_lpm_sve.h line 83
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+for (i =0 ; i <4 ; i++) + hop[i] = defv; + + __rte_lpm_lookup_vec(lpm, ips, hop, 4); } + +#ifdef __cplusplus +} +#endif + +#endif /* _RTE_LPM_SVE_H_ */ --
Regards,
Vladimir
v2 cover lpm lookup with sve support
In reply to Ruifeng WangAdded lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface.
Refer to [1] for more information about SVE.
Configuration was added for Neoverse N2 CPU which has SVE support.
Some bugs were fixed so compiling with sve enabled can pass.
---
v2:
Fixed tbl8 group index calculation. (Vladimir)
Added N2 config.
Fixed compiling when sve was enabled.
Ruifeng Wang (5):
lpm: add sve support for lookup on Arm platform
net/hns3: fix build with sve enabled
net/octeontx: fix build with sve enabled
common/octeontx2: fix build with sve enabled
config: add Arm Neoverse N2
config/arm/arm64_n2_linux_gcc | 17 +++++ config/arm/meson.build | 11 +++- drivers/common/octeontx2/otx2_io_arm64.h | 37 ++--------- drivers/net/hns3/meson.build | 2 +- drivers/net/octeontx/base/octeontx_io.h | 16 ++--- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 ++++++++++++++++++++++++ 9 files changed, 127 insertions(+), 48 deletions(-) create mode 100644 config/arm/arm64_n2_linux_gcc create mode 100644 lib/librte_lpm/rte_lpm_sve.h
Signature · 1 line
2.25.1
PATCH v2 1/5 lpm: add sve support for lookup on Arm platform
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
--- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 +++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 lib/librte_lpm/rte_lpm_sve.h
lib/librte_eal/arm/include/rte_vect.h +3 -0
@@ -9,6 +9,9 @@#include "generic/rte_vect.h" #include "rte_debug.h" #include "arm_neon.h" +#ifdef __ARM_FEATURE_SVE +#include <arm_sve.h> +#endif #ifdef __cplusplusextern "C" {
lib/librte_lpm/meson.build +1 -1
@@ -5,6 +5,6 @@ sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers # without worrying about which architecture we actually need -headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') +headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h', 'rte_lpm_sve.h') deps += ['hash'] deps += ['rcu']
lib/librte_lpm/rte_lpm.h +4 -0
@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else
lib/librte_lpm/rte_lpm_sve.h new file +83 -0
83 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoted 134 lines · Ruifeng Wang
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
Signed-off-by Ruifeng Wang <[email protected]>--- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 +++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 1 deletion(-)create mode 100644
lib/librte_lpm/rte_lpm_sve.hlib/librte_eal/arm/include/rte_vect.h +3
-0@@ -9,6 +9,9 @@#include "generic/rte_vect.h" #include "rte_debug.h" #include "arm_neon.h" +#ifdef __ARM_FEATURE_SVE +#include <arm_sve.h> +#endif #ifdef __cplusplusextern "C" {lib/librte_lpm/meson.build +1
-1@@ -5,6 +5,6 @@ sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers # without worrying about which architecture we actually need -headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') +headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h', 'rte_lpm_sve.h') deps += ['hash'] deps += ['rcu']lib/librte_lpm/rte_lpm.h +4
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else lib/librte_lpm/rte_lpm_sve.h new file +73
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_ +#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static void +__rte_lpm_lookup_vec(const struct rte_lpm *lpm, const uint32_t *ips, + uint32_t *__rte_restrict next_hops, const uint32_t n) +{ + uint32_t i = 0; + svuint32_t v_ip, v_idx, v_tbl24, v_tbl8, v_hop; + svuint32_t v_mask_xv, v_mask_v, v_mask_hop; + svbool_t pg = svwhilelt_b32(i, n); + svbool_t pv; + + do { + v_ip = svld1(pg, &ips[i]); + /* Get indices for tbl24[] */ + v_idx = svlsr_x(pg, v_ip, 8); + /* Extract values from tbl24[] */ + v_tbl24 = svld1_gather_index(pg, (const uint32_t *)lpm->tbl24, + v_idx); + + /* Create mask with valid set */ + v_mask_v = svdup_u32_z(pg, RTE_LPM_LOOKUP_SUCCESS); + /* Create mask with valid and valid_group set */ + v_mask_xv = svdup_u32_z(pg, RTE_LPM_VALID_EXT_ENTRY_BITMASK); + /* Create predicate for tbl24 entries: (valid && !valid_group) */ + pv = svcmpeq(pg, svand_z(pg, v_tbl24, v_mask_xv), v_mask_v); + /* Create mask for next_hop in table entry */ + v_mask_hop = svdup_u32_z(pg, 0x00ffffff); + /* Extract next_hop and write back */ + v_hop = svand_x(pv, v_tbl24, v_mask_hop); + svst1(pv, &next_hops[i], v_hop); + + /* Update predicate for tbl24 entries: (valid && valid_group) */ + pv = svcmpeq(pg, svand_z(pg, v_tbl24, v_mask_xv), v_mask_xv); + /* Compute tbl8 index */ + v_idx = svand_x(pv, v_tbl24, svdup_u32_z(pv, 0xffffff)); + v_idx = svmul_x(pv, v_idx, RTE_LPM_TBL8_GROUP_NUM_ENTRIES); + v_idx = svadd_x(pv, svand_x(pv, v_ip, svdup_u32_z(pv, 0xff)), + v_idx); + /* Extract values from tbl8[] */ + v_tbl8 = svld1_gather_index(pv, (const uint32_t *)lpm->tbl8, + v_idx); + /* Update predicate for tbl8 entries: (valid) */ + pv = svcmpeq(pv, svand_z(pv, v_tbl8, v_mask_v), v_mask_v); + /* Extract next_hop and write back */ + v_hop = svand_x(pv, v_tbl8, v_mask_hop); + svst1(pv, &next_hops[i], v_hop); + + i += svlen(v_ip); + pg = svwhilelt_b32(i, n); + } while (svptest_any(svptrue_b32(), pg)); +} + +static inline void +rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], + uint32_t defv) +{ + uint32_t i, ips[4]; + + vst1q_s32((int32_t *)ips, ip); + for (i = 0; i < 4; i++)
lib/librte_lpm/rte_lpm_sve.h line 83
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+ hop[i] = defv; + +__rte_lpm_lookup_vec (lpm, ips, hop,4 ); +} + +#ifdef __cplusplus +} +#endif + +#endif /* _RTE_LPM_SVE_H_ */
Signature · 2 lines
Regards, Vladimir
PATCH v2 2/5 net/hns3: fix build with sve enabled
In reply to Ruifeng WangBuilding with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)
This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.
--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/hns3/meson.build +1 -1
@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] + cflags += ['-DCC_SVE_SUPPORT'] sources += files('hns3_rxtx_vec_sve.c') endif endif
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled
<snip>
Quoted 23 lines
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #definePG64_256BITsvwhilelt_b64(0, 4)This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.Signed-off-by Ruifeng Wang <[email protected]>--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/hns3/meson.build +0
-0
drivers/net/hns3/meson.build deps += ['hash'] · line 35
Quoted 5 lines
drivers/net/hns3/meson.build +1
-1@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] + cflags += ['-DCC_SVE_SUPPORT']
This comment is unrelated to this patch. We need to be consistent with the macro definitions. Is '__ARM_FEATURE_SVE' not enough? If we need to define an additional flag, I would name it something like 'RTE_ARM_FEATURE_SVE'.
Quoted 5 lines
drivers/net/hns3/meson.build +0
-1sources += files('hns3_rxtx_vec_sve.c') endif endif --2.25.1
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled
Quoted 20 lines · Honnappa Nagarahalli
<snip>
Quoted 18 lines
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.Signed-off-by Ruifeng Wang <[email protected]>--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
drivers/net/hns3/meson.build deps += ['hash'] · line 35
Quoted 10 lines
drivers/net/hns3/meson.build +1
-1@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] + cflags += ['-DCC_SVE_SUPPORT']This comment is unrelated to this patch. We need to be consistent with the macro definitions. Is '
__ARM_FEATURE_SVE' not enough? If we need to define an additional flag, I would name it something like 'RTE_ARM_FEATURE_SVE'.
I think the __ARM_FEATURE_SVE is ok. if use the gcc version included SVE flag, it will be identified as __ARM_FEATURE_SVE. it is defined in the ARM SVE document.
Quoted 6 lines
Quoted 5 lines
drivers/net/hns3/meson.build +0
-1sources += files('hns3_rxtx_vec_sve.c') endif endif --2.25.1
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled
Quoted 47 lines
-----Original Message-----
From: oulijun <[email protected]>
Sent: Saturday, January 9, 2021 10:12 AM
To: Honnappa Nagarahalli <[email protected]>; Ruifeng Wang <[email protected]>; Wei Hu (Xavier) <[email protected]>; Min Hu (Connor) <[email protected]>; Yisen Zhuang <[email protected]>; Huisong Li <[email protected]>; Chengchang Tang <[email protected]>; Chengwen Feng <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; nd <[email protected]>; [email protected]
Subject: Re: [PATCH v2 2/5] net/hns3: fix build with sve enabledQuoted 20 lines · Honnappa Nagarahalli
<snip>
Quoted 18 lines
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.Signed-off-by Ruifeng Wang <[email protected]>--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
drivers/net/hns3/meson.build deps += ['hash'] · line 35
Quoted 10 lines
(quoted diff) +0
-0b/drivers/net/hns3/meson.build index 45cee34d9..798086357 100644
drivers/net/hns3/meson.build +1
-1@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] + cflags += ['-DCC_SVE_SUPPORT']This comment is unrelated to this patch. We need to be consistent with the
Quoted 7 lines
macro definitions. Is '
__ARM_FEATURE_SVE' not enough? If we need to define an additional flag, I would name it something like 'RTE_ARM_FEATURE_SVE'.Quoted 1 line
I think the
__ARM_FEATURE_SVEis ok. if use the gcc version included SVE flag, it will be identified as__ARM_FEATURE_SVE. it is defined in the ARM SVE document.
Yes, we can rely on flags defined by compiler and no extra flag is needed.
I can update in next version to remove this section from meson file and replace CC_SVE_SUPPORT in code.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
drivers/net/hns3/meson.build +0
-1sources += files('hns3_rxtx_vec_sve.c') endif endif --2.25.1
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled
<snip>
Quoted 35 lines
Quoted 35 lines
Quoted 19 lines
Quoted 19 lines
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.Signed-off-by Ruifeng Wang <[email protected]>--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 12 lines
drivers/net/hns3/meson.build deps += ['hash'] · line 35
Quoted 10 lines
(quoted diff) +0
-0b/drivers/net/hns3/meson.build index 45cee34d9..798086357 100644
drivers/net/hns3/meson.build +1
-1@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' -cflags = ['-DCC_SVE_SUPPORT'] +cflags += ['-DCC_SVE_SUPPORT']This comment is unrelated to this patch. We need to be consistent with the
macro definitions. Is '
__ARM_FEATURE_SVE' not enough? If we need to define an additional flag, I would name it something like 'RTE_ARM_FEATURE_SVE'.Quoted 1 line
Quoted 7 lines
Quoted 3 lines
I think the
__ARM_FEATURE_SVEis ok. if use the gcc version included SVE flag, it will be identified as__ARM_FEATURE_SVE. it is defined in the ARM SVE document.Yes, we can rely on flags defined by compiler and no extra flag is needed. I can update in next version to remove this section from meson file and replace
CC_SVE_SUPPORTin code.
Sounds good to me.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
drivers/net/hns3/meson.build +0
-1sources += files('hns3_rxtx_vec_sve.c') endif endif --2.25.1
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled
In reply to Ruifeng WangQuoted 23 lines · Ruifeng Wang
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.Signed-off-by Ruifeng Wang <[email protected]>--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/hns3/meson.build +0
-0
drivers/net/hns3/meson.build deps += ['hash'] · line 35
Quoted 5 lines
drivers/net/hns3/meson.build +1
-1@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] + cflags += ['-DCC_SVE_SUPPORT']
Hi
I noticed this patch, but I checked that the hns3 driver did not use
this function.How did you compile it?
Thanks
Lijun Ou
Quoted 4 lines
drivers/net/hns3/meson.build +0
-0sources += files('hns3_rxtx_vec_sve.c') endif endif
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled
Quoted 36 lines
-----Original Message-----
From: oulijun <[email protected]>
Sent: Saturday, January 9, 2021 10:16 AM
To: Ruifeng Wang <[email protected]>; Wei Hu (Xavier) <[email protected]>; Min Hu (Connor) <[email protected]>; Yisen Zhuang <[email protected]>; Huisong Li <[email protected]>; Chengchang Tang <[email protected]>; Chengwen Feng <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>; [email protected]
Subject: Re: [PATCH v2 2/5] net/hns3: fix build with sve enabledQuoted 18 lines · Ruifeng Wang
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)This is caused by unintentional cflags reset.
Fixed the issue by appending required flag to cflags instead of overriding it.Signed-off-by Ruifeng Wang <[email protected]>--- drivers/net/hns3/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
drivers/net/hns3/meson.build deps += ['hash'] · line 35
Quoted 10 lines
(quoted diff) +0
-0b/drivers/net/hns3/meson.build index 45cee34d9..798086357 100644
drivers/net/hns3/meson.build +1
-1@@ -32,7 +32,7 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] + cflags += ['-DCC_SVE_SUPPORT']Hi
I noticed this patch, but I checked that the hns3 driver did not use this
function.How did you compile it?
Hi,
The hns3 driver has sve rx/tx implementation in hns3_rxtx_vec_sve.c. This path will be enabled when compiling with sve feature enabled.
I compiled it by using gcc-10.2 with flag '-march=armv8.3-a+sve'. You can try compile for n2 with the cross file added in this series (5/5).
Thanks,
Ruifeng
Quoted 7 lines
Thanks
Lijun OuQuoted 4 lines
drivers/net/hns3/meson.build +0
-0sources += files('hns3_rxtx_vec_sve.c') endif endif
PATCH v2 3/5 net/octeontx: fix build with sve enabled
In reply to Ruifeng WangBuilding with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:91: Error: selected processor does not support addvl x4,x8,#-1' {standard input}:95: Error: selected processor does not support ptrue p1.d,all' {standard input}:135: Error: selected processor does not support whilelo p2.d,xzr,x5' {standard input}:137: Error: selected processor does not support decb x1'
This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Fixed the issue by replacing inline assembly with equivalent atomic built-ins. Compiler will generate LSE instructions for cpu that has the extension.
--- drivers/net/octeontx/base/octeontx_io.h | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)
drivers/net/octeontx/base/octeontx_io.h +4 -12
@@ -58,14 +58,8 @@ do { \static inline uint64_t octeontx_reg_ldadd_u64 (void *addr,int64_t off) { -uint64_t old_val; - - __asm__volatile ( -" .cpu generic+lse\n" -" ldadd %1, %0, [%2]\n" - :"=r" (old_val) :"r" (off),"r" (addr) :"memory" ); - -return old_val; +return (uint64_t )__atomic_fetch_add ((int64_t *)addr, off, + __ATOMIC_RELAXED); }/**
@@ -97,10 +91,8 @@ octeontx_reg_lmtst(void *lmtline_va, void *ioreg_va, const uint64_t cmdbuf[], }/* LDEOR initiates atomic transfer to I/O device */ - __asm__volatile ( -" .cpu generic+lse\n" -" ldeor xzr, %0, [%1]\n" - :"=r" (result) :"r" (ioreg_va) :"memory" ); + result =__atomic_fetch_xor ((uint64_t *)ioreg_va,0 , + __ATOMIC_RELAXED); }while (!result); }
Signature · 1 line
2.25.1
PATCH v2 4/5 common/octeontx2: fix build with sve enabled
In reply to Ruifeng WangBuilding with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:4002: Error: selected processor does not support mov z3.b,#0' {standard input}:4003: Error: selected processor does not support whilelo p1.b,xzr,x7' {standard input}:4005: Error: selected processor does not support ld1b z0.b,p1/z,[x8]' {standard input}:4006: Error: selected processor does not support whilelo p4.s,wzr,w7'
This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Fixed the issue by replacing inline assembly with equivalent atomic built-ins. Compiler will generate LSE instructions for cpu that has the extension.
--- drivers/common/octeontx2/otx2_io_arm64.h | 37 +++--------------------- 1 file changed, 4 insertions(+), 33 deletions(-)
drivers/common/octeontx2/otx2_io_arm64.h +4 -33
@@ -24,55 +24,26 @@ static __rte_always_inline uint64_totx2_atomic64_add_nosync (int64_t incr,int64_t *ptr) { -uint64_t result; -/* Atomic add with no ordering */ - asmvolatile ( -".cpu generic+lse\n" -"ldadd %x[i], %x[r], [%[b]]" - : [r]"=r" (result),"+m" (*ptr) - : [i]"r" (incr), [b]"r" (ptr) - :"memory" ); -return result; +return (uint64_t )__atomic_fetch_add (ptr, incr, __ATOMIC_RELAXED); } static __rte_always_inline uint64_totx2_atomic64_add_sync (int64_t incr,int64_t *ptr) { -uint64_t result; - -/* Atomic add with ordering */ - asmvolatile ( -".cpu generic+lse\n" -"ldadda %x[i], %x[r], [%[b]]" - : [r]"=r" (result),"+m" (*ptr) - : [i]"r" (incr), [b]"r" (ptr) - :"memory" ); -return result; +return (uint64_t )__atomic_fetch_add (ptr, incr, __ATOMIC_ACQUIRE); } static __rte_always_inline uint64_totx2_lmt_submit (rte_iova_t io_address) { -uint64_t result; - - asmvolatile ( -".cpu generic+lse\n" -"ldeor xzr,%x[rf],[%[rs]]" : - [rf]"=r" (result): [rs]"r" (io_address)); -return result; +return __atomic_fetch_xor ((uint64_t *)io_address,0 , __ATOMIC_RELAXED); } static __rte_always_inline uint64_totx2_lmt_submit_release (rte_iova_t io_address) { -uint64_t result; - - asmvolatile ( -".cpu generic+lse\n" -"ldeorl xzr,%x[rf],[%[rs]]" : - [rf]"=r" (result) : [rs]"r" (io_address)); -return result; +return __atomic_fetch_xor ((uint64_t *)io_address,0 , __ATOMIC_RELEASE); }static __rte_always_inline void
Signature · 1 line
2.25.1
Re: [dpdk-dev] [EXT] [PATCH v2 4/5] common/octeontx2: fix build with sve enabled
Hi Ruifeng,
Quoted 50 lines
Building with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:4002: Error: selected processor does not support `mov z3.b,#0'
{standard input}:4003: Error: selected processor does not support `whilelo p1.b,xzr,x7'
{standard input}:4005: Error: selected processor does not support `ld1b z0.b,p1/z,[x8]'
{standard input}:4006: Error: selected processor does not support `whilelo p4.s,wzr,w7'This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Fixed the issue by replacing inline assembly with equivalent atomic built-ins. Compiler will generate LSE instructions for cpu that has the extension.
Fixes 8a4f835971f5 ("common/octeontx2: add IO handling APIs")Signed-off-by Ruifeng Wang <[email protected]>---
drivers/common/octeontx2/otx2_io_arm64.h| 37 +++-------------------- -1 file changed, 4 insertions(+), 33 deletions(-)drivers/common/octeontx2/otx2_io_arm64.h +0
-0@@ -24,55 +24,26 @@static
__rte_always_inlineuint64_totx2_atomic64_add_nosync(int64_t incr, int64_t *ptr){drivers/common/octeontx2/otx2_io_arm64.h +0
-2-uint64_t result; -/* Atomic add with no ordering */drivers/common/octeontx2/otx2_io_arm64.h +1
-7- asmvolatile ( -".cpu generic+lse\n" -"ldadd %x[i], %x[r], [%[b]]" - : [r]"=r" (result),"+m" (*ptr) - : [i]"r" (incr), [b]"r" (ptr) - :"memory" ); -return result; + return (uint64_t)__atomic_fetch_add(ptr, incr,
Quoted 3 lines
__ATOMIC_RELAXED);
}
Here LDADD acts as a way to interface to co-processors i.e. LDADD instruction opcode + specific io address are recognized by HW interceptor and dispatched to the specific coprocessor.
Leaving it to the compiler to use the correct instruction is a bad idea. This breaks the arm64_armv8_linux_gcc build as it doesn't have the +lse enabled.__atomic_fetch_add will generate a different instruction with SVE enabled.
Instead can we add +sve to the first line to prevent outer loop from optimizing out the trap?
I tested with 10.2 and n2 config below change works fine.
-" .cpu generic+lse\n"
+" .cpu generic+lse+sve\n"
Regards,
Pavan.
Quoted 48 lines
static
__rte_always_inlineuint64_totx2_atomic64_add_sync(int64_t incr, int64_t *ptr){drivers/common/octeontx2/otx2_io_arm64.h +1
-10-uint64_t result; - -/* Atomic add with ordering */ - asmvolatile ( -".cpu generic+lse\n" -"ldadda %x[i], %x[r], [%[b]]" - : [r]"=r" (result),"+m" (*ptr) - : [i]"r" (incr), [b]"r" (ptr) - :"memory" ); -return result; + return (uint64_t)__atomic_fetch_add(ptr, incr,
__ATOMIC_ACQUIRE);
}static
__rte_always_inlineuint64_totx2_lmt_submit(rte_iova_t io_address)
{drivers/common/octeontx2/otx2_io_arm64.h +1
-7-uint64_t result; - - asmvolatile ( -".cpu generic+lse\n" -"ldeor xzr,%x[rf],[%[rs]]" : - [rf]"=r" (result): [rs]"r" (io_address)); -return result; + return __atomic_fetch_xor((uint64_t *)io_address, 0,
__ATOMIC_RELAXED);
}static
__rte_always_inlineuint64_totx2_lmt_submit_release(rte_iova_t io_address)
{drivers/common/octeontx2/otx2_io_arm64.h +1
-7-uint64_t result; - - asmvolatile ( -".cpu generic+lse\n" -"ldeorl xzr,%x[rf],[%[rs]]" : - [rf]"=r" (result) : [rs]"r" (io_address)); -return result; + return __atomic_fetch_xor((uint64_t *)io_address, 0,
__ATOMIC_RELEASE);
}static
__rte_always_inlinevoid
--
2.25.1
Re: [dpdk-dev] [EXT] [PATCH v2 4/5] common/octeontx2: fix build with sve enabled
Quoted 62 lines
-----Original Message-----
From: Pavan Nikhilesh Bhagavatula <[email protected]>
Sent: Friday, January 8, 2021 6:29 PM
To: Ruifeng Wang <[email protected]>; [email protected]; Nithin Kumar Dabilpuram <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>; [email protected]
Subject: RE: [EXT] [PATCH v2 4/5] common/octeontx2: fix build with sve enabledHi Ruifeng,
Quoted 48 lines
Building with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:4002: Error: selected processor does not support `mov z3.b,#0'
{standard input}:4003: Error: selected processor does not support `whilelo p1.b,xzr,x7'
{standard input}:4005: Error: selected processor does not support `ld1b z0.b,p1/z,[x8]'
{standard input}:4006: Error: selected processor does not support `whilelo p4.s,wzr,w7'This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Fixed the issue by replacing inline assembly with equivalent atomic built-ins. Compiler will generate LSE instructions for cpu that has the extension.
Fixes 8a4f835971f5 ("common/octeontx2: add IO handling APIs")Signed-off-by Ruifeng Wang <[email protected]>---
drivers/common/octeontx2/otx2_io_arm64.h| 37 +++-------------------- -1 file changed, 4 insertions(+), 33 deletions(-)drivers/common/octeontx2/otx2_io_arm64.h +0
-0@@ -24,55 +24,26 @@static
__rte_always_inlineuint64_totx2_atomic64_add_nosync(int64_t incr, int64_t *ptr){drivers/common/octeontx2/otx2_io_arm64.h +0
-2-uint64_t result; -/* Atomic add with no ordering */drivers/common/octeontx2/otx2_io_arm64.h +0
-7- asmvolatile ( -".cpu generic+lse\n" -"ldadd %x[i], %x[r], [%[b]]" - : [r]"=r" (result),"+m" (*ptr) - : [i]"r" (incr), [b]"r" (ptr) - :"memory" ); -return result;
Quoted 8 lines
Quoted 4 lines
drivers/common/octeontx2/otx2_io_arm64.h +1
-0+ return (uint64_t)__atomic_fetch_add(ptr, incr,
__ATOMIC_RELAXED);
}Here LDADD acts as a way to interface to co-processors i.e. LDADD instruction opcode + specific io address are recognized by HW interceptor and dispatched to the specific coprocessor.
OK. Now I understand the background.
Quoted 8 lines
Leaving it to the compiler to use the correct instruction is a bad idea. This breaks the
arm64_armv8_linux_gccbuild as it doesn't have the +lse enabled.__atomic_fetch_addwill generate a different instruction with SVE enabled.Instead can we add +sve to the first line to prevent outer loop from optimizing out the trap?
Since the inline assembly needs to be preserved, we have to tune the enabled extensions. I will change in next version.
Thanks,
Ruifeng
Quoted 53 lines
I tested with 10.2 and n2 config below change works fine.
-" .cpu generic+lse\n"
+" .cpu generic+lse+sve\n"Regards,
Pavan.Quoted 45 lines
static
__rte_always_inlineuint64_totx2_atomic64_add_sync(int64_t incr, int64_t *ptr){drivers/common/octeontx2/otx2_io_arm64.h +1
-10-uint64_t result; - -/* Atomic add with ordering */ - asmvolatile ( -".cpu generic+lse\n" -"ldadda %x[i], %x[r], [%[b]]" - : [r]"=r" (result),"+m" (*ptr) - : [i]"r" (incr), [b]"r" (ptr) - :"memory" ); -return result; + return (uint64_t)__atomic_fetch_add(ptr, incr,
__ATOMIC_ACQUIRE);
}static
__rte_always_inlineuint64_totx2_lmt_submit(rte_iova_t io_address){drivers/common/octeontx2/otx2_io_arm64.h +1
-7-uint64_t result; - - asmvolatile ( -".cpu generic+lse\n" -"ldeor xzr,%x[rf],[%[rs]]" : - [rf]"=r" (result): [rs]"r" (io_address)); -return result; + return __atomic_fetch_xor((uint64_t *)io_address, 0,
__ATOMIC_RELAXED);
}static
__rte_always_inlineuint64_totx2_lmt_submit_release(rte_iova_t io_address){drivers/common/octeontx2/otx2_io_arm64.h +1
-7-uint64_t result; - - asmvolatile ( -".cpu generic+lse\n" -"ldeorl xzr,%x[rf],[%[rs]]" : - [rf]"=r" (result) : [rs]"r" (io_address)); -return result; + return __atomic_fetch_xor((uint64_t *)io_address, 0,
__ATOMIC_RELEASE);
}static
__rte_always_inlinevoid
--
2.25.1
PATCH v2 5/5 config: add Arm Neoverse N2
In reply to Ruifeng WangAdd Arm Neoverse N2 cpu support.
--- config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 config/arm/arm64_n2_linux_gcc
config/arm/arm64_n2_linux_gcc new file +17 -0
@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'
config/arm/meson.build +10 -1
@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [ + ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]] machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']],
@@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra]] + ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra], + ['0xd49', ['-march=armv8.5-a+crypto+sve'], flags_n2generic_extra]] machine_args_cavium = [ ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2
+ Juraj
Please note that this clashes with Juraj's patch for meson rework.
<snip>
Quoted 39 lines
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>--- config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644config/arm/arm64_n2_linux_gcc
(quoted diff) +0
-0b/config/arm/arm64_n2_linux_gcc new file mode 100644 index 000000000..78f6f3e2b
config/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build index renamed from config/arm/meson.build +0
-0
42b4e43c7..58e0ae643100644config/arm/meson.build +0
-0@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1],
config/arm/meson.build flags_n1generic_extra = [ · line 99
Quoted 10 lines
config/arm/meson.build +8
-0['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [ + ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]]
Do we need a flag RTE_ARM_FEATURE_SVE?
config/arm/meson.build machine_args_generic = [ · line 112
Quoted 12 lines
config/arm/meson.build +1
-1machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
flags_n1generic_extra]]config/arm/meson.build +1
-0+ ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
flags_n1generic_extra],config/arm/meson.build +1
-0+ ['0xd49', ['-march=armv8.5-a+crypto+sve'], flags_n2generic_extra]]
Should this be 'sve2'? There should be a flag to indicate SVE2.
Quoted 5 lines
machine_args_cavium= [
['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
--
2.25.1
Re: [dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2
Quoted 12 lines
-----Original Message-----
From: Honnappa Nagarahalli <[email protected]>
Sent: Saturday, January 9, 2021 7:58 AM
To: Ruifeng Wang <[email protected]>; [email protected]; Ruifeng Wang <[email protected]>; Jan Viktorin <[email protected]>; Bruce Richardson <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>
Subject: RE: [PATCH v2 5/5] config: add Arm Neoverse N2
Quoted 3 lines
+ Juraj
Please note that this clashes with Juraj's patch for meson rework.
Yes. I didn't base it on the build options rework series. I will rebase when that series got merged.
Quoted 45 lines
<snip>
Quoted 42 lines
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>--- config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644config/arm/arm64_n2_linux_gcc
(quoted diff) +0
-0b/config/arm/arm64_n2_linux_gcc new file mode 100644 index 000000000..78f6f3e2b
config/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build index renamed from config/arm/meson.build +0
-0
42b4e43c7..58e0ae643100644config/arm/meson.build +1
-0@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [
Quoted 8 lines
config/arm/meson.build flags_n1generic_extra = [ · line 99
Quoted 7 lines
config/arm/meson.build +7
-0+ ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]]Do we need a flag
RTE_ARM_FEATURE_SVE?
I don't think extra flag is needed. We can rely on __ARM_FEATURE_SVE from compiler. One scenario I can think of where RTE_ARM_FEATURE_SVE can be needed is, when we are writing inline assembly with sve instructions and using compiler that has no sve support. I'm not sure we will have sve inline assembly as C intrinsics are available.
Quoted 14 lines
config/arm/meson.build machine_args_generic = [ · line 112
Quoted 13 lines
config/arm/meson.build +1
-1machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
flags_n1generic_extra]]config/arm/meson.build +1
-0+ ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
flags_n1generic_extra],config/arm/meson.build +1
-0+ ['0xd49', ['-march=armv8.5-a+crypto+sve'], flags_n2generic_extra]]Should this be 'sve2'? There should be a flag to indicate SVE2.
Yes. N2 supports sve2 and sve2 is superset of sve. I will do the change in next version.
Quoted 6 lines
Quoted 6 lines
machine_args_cavium= [
['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
--
2.25.1
Re: [dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2
Quoted 73 lines · Ruifeng Wang
Quoted 13 lines
-----Original Message-----
From: Honnappa Nagarahalli <[email protected]>
Sent: Saturday, January 9, 2021 7:58 AM
To: Ruifeng Wang <[email protected]>; [email protected]; Ruifeng Wang <[email protected]>; Jan Viktorin <[email protected]>; Bruce Richardson <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>
Subject: RE: [PATCH v2 5/5] config: add Arm Neoverse N2Quoted 3 lines
+ Juraj
Please note that this clashes with Juraj's patch for meson rework.
Yes. I didn't base it on the build options rework series. I will rebase when that series got merged.
Quoted 45 lines
<snip>
Quoted 42 lines
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>--- config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644config/arm/arm64_n2_linux_gcc
(quoted diff) +0
-0b/config/arm/arm64_n2_linux_gcc new file mode 100644 index 000000000..78f6f3e2b
config/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build index renamed from config/arm/meson.build +0
-0
42b4e43c7..58e0ae643100644config/arm/meson.build +1
-0@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [Quoted 8 lines
config/arm/meson.build flags_n1generic_extra = [ · line 99
Quoted 7 lines
config/arm/meson.build +7
-0+ ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]]Do we need a flag
RTE_ARM_FEATURE_SVE?
Quoted 4 lines
I don't think extra flag is needed. We can rely on
__ARM_FEATURE_SVEfrom compiler. One scenario I can think of whereRTE_ARM_FEATURE_SVEcan be needed is, when we are writing inline assembly with sve instructions and using compiler that has no sve support. I'm not sure we will have sve inline assembly as C intrinsics are available.
It may be useful to introduce RTE_ARM_FEATURE_SVE to abstract any compiler difference in
future(GCC vs clang or another tool chain etc).
Quoted 24 lines
Quoted 13 lines
Quoted 9 lines
config/arm/meson.build +1
-1machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],Quoted 4 lines
flags_n1generic_extra]]
+ ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],flags_n1generic_extra],
+ ['0xd49', ['-march=armv8.5-a+crypto+sve'],flags_n2generic_extra]]Quoted 1 line
Should this be 'sve2'? There should be a flag to indicate SVE2.
Yes. N2 supports sve2 and sve2 is superset of sve. I will do the change in next version.
Quoted 6 lines
Quoted 6 lines
machine_args_cavium= [['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],--
2.25.1
Re: [dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2
Quoted 90 lines
-----Original Message-----
From: Jerin Jacob <[email protected]>
Sent: Monday, January 11, 2021 11:09 AM
To: Ruifeng Wang <[email protected]>
Cc: Honnappa Nagarahalli <[email protected]>; [email protected]; Jan Viktorin <[email protected]>; Bruce Richardson <[email protected]>; [email protected]; [email protected]; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2Quoted 6 lines · Ruifeng Wang
Quoted 6 lines
-----Original Message-----
From: Honnappa Nagarahalli <[email protected]>
Sent: Saturday, January 9, 2021 7:58 AM
To: Ruifeng Wang <[email protected]>; [email protected];Ruifeng
Quoted 1 line
Quoted 1 line
Wang <[email protected]>; Jan Viktorin
Quoted 66 lines
Quoted 9 lines
Bruce Richardson <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>
Subject: RE: [PATCH v2 5/5] config: add Arm Neoverse N2+ Juraj
Please note that this clashes with Juraj's patch for meson rework.
Yes. I didn't base it on the build options rework series. I will rebase when that series got merged.
Quoted 45 lines
<snip>
Quoted 42 lines
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>--- config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode100644 config/arm/arm64_n2_linux_gcc
(quoted diff) +0
-0b/config/arm/arm64_n2_linux_gcc new file mode 100644 index 000000000..78f6f3e2b
config/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build index renamed from config/arm/meson.build +0
-0
42b4e43c7..58e0ae643100644config/arm/meson.build +1
-0@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [Quoted 8 lines
config/arm/meson.build flags_n1generic_extra = [ · line 99
Quoted 7 lines
config/arm/meson.build +7
-0+ ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]]Do we need a flag
RTE_ARM_FEATURE_SVE?Quoted 1 line
I don't think extra flag is needed. We can rely on
__ARM_FEATURE_SVE
Quoted 8 lines
from compiler.
Quoted 2 lines
One scenario I can think of where
RTE_ARM_FEATURE_SVEcan be needed is, when we are writing inline assembly with sve instructions and usingcompiler that has no sve support.
Quoted 1 line
I'm not sure we will have sve inline assembly as C intrinsics are available.
It may be useful to introduce
RTE_ARM_FEATURE_SVEto abstract any compiler difference in future(GCC vs clang or another tool chain etc).
According to Arm C Language Extension (ACLE) for SVE, preprocessor macros like __ARM_FEATURE_SVE are defined to indicate available features. GCC and clang have the macros defined. We can have RTE_ARM_FEATURE_SVE for some other tool chain that don't stick to ACLE. I'll add in next version.
Quoted 28 lines
Quoted 28 lines
Quoted 17 lines
Quoted 11 lines
config/arm/meson.build +1
-1machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@ -100,7 +108,8 @@ machine_args_generic = [['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']],Quoted 6 lines
- ['
0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],flags_n1generic_extra]]
+ ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],flags_n1generic_extra],
+ ['0xd49', ['-march=armv8.5-a+crypto+sve'],
+flags_n2generic_extra]]Quoted 1 line
Should this be 'sve2'? There should be a flag to indicate SVE2.
Yes. N2 supports sve2 and sve2 is superset of sve. I will do the change in next version.
Quoted 6 lines
Quoted 6 lines
machine_args_cavium= [['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],--
2.25.1
Re: [dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2
<snip>
Quoted 70 lines
Quoted 70 lines
Quoted 62 lines
Quoted 4 lines
+ Juraj
Please note that this clashes with Juraj's patch for meson rework.
Yes. I didn't base it on the build options rework series. I will rebase when that series got merged.
Quoted 46 lines
<snip>
Quoted 43 lines
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>--- config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode100644 config/arm/arm64_n2_linux_gcc
(quoted diff) +0
-0b/config/arm/arm64_n2_linux_gcc new file mode 100644 index 000000000..78f6f3e2b
config/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build +0
-0index
42b4e43c7..58e0ae643100644config/arm/meson.build +1
-0@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [Quoted 8 lines
config/arm/meson.build flags_n1generic_extra = [ · line 99
Quoted 7 lines
config/arm/meson.build +7
-0+ ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]]Do we need a flag
RTE_ARM_FEATURE_SVE?Quoted 1 line
I don't think extra flag is needed. We can rely on
__ARM_FEATURE_SVEfrom compiler.
Quoted 3 lines
One scenario I can think of where
RTE_ARM_FEATURE_SVEcan be needed is, when we are writing inline assembly with sve instructions and usingcompiler that has no sve support.
Quoted 1 line
I'm not sure we will have sve inline assembly as C intrinsics are available.
Quoted 7 lines
Quoted 2 lines
It may be useful to introduce
RTE_ARM_FEATURE_SVEto abstract any compiler difference in future(GCC vs clang or another tool chain etc).According to Arm C Language Extension (ACLE) for SVE, preprocessor macros like
__ARM_FEATURE_SVEare defined to indicate available features. GCC and clang have the macros defined. We can haveRTE_ARM_FEATURE_SVEfor some other tool chain that don't stick to ACLE. I'll add in next version.
The flag __ARM_FEATURE_SVE is a requirement from ACLE. If it is not defined, it is a bug in the compiler. Since, GCC/Clang define this flag, I am thinking we are fine without defining our own. It avoids checking for this additional flag in the code. We can always add it when we come across a toolchain that does not define this flag (or fix the toolchain).
BTW, this problem exists for __ARM_FEATURE_ATOMICS, it is not defined by Clang. Hence, we have RTE_ARM_FEATURE_ATOMICS. But, it is getting fixed in Clang.
Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Quoted 18 lines
Quoted 12 lines
config/arm/meson.build +1
-1machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@ -100,7 +108,8 @@ machine_args_generic = [['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']],Quoted 6 lines
- ['
0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],flags_n1generic_extra]]
+ ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],flags_n1generic_extra],
+ ['0xd49', ['-march=armv8.5-a+crypto+sve'],
+flags_n2generic_extra]]Quoted 1 line
Should this be 'sve2'? There should be a flag to indicate SVE2.
Yes. N2 supports sve2 and sve2 is superset of sve. I will do the change in next version.
Quoted 6 lines
Quoted 6 lines
machine_args_cavium= [['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],--
2.25.1
v3 cover lpm lookup with sve support
In reply to Ruifeng WangAdded lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface.
Refer to [1] for more information about SVE.
Configuration was added for Neoverse N2 CPU which has SVE support.
Some bugs were fixed so compiling with sve enabled can pass.
---
v2:
Fixed tbl8 group index calculation. (Vladimir)
Added N2 config.
Fixed compiling when sve was enabled.
Ruifeng Wang (5):
lpm: add sve support for lookup on Arm platform
net/hns3: fix build with sve enabled
net/octeontx: fix build with sve enabled
common/octeontx2: fix build with sve enabled
config: add Arm Neoverse N2
config/arm/arm64_n2_linux_gcc | 17 +++++ config/arm/meson.build | 11 +++- drivers/common/octeontx2/otx2_io_arm64.h | 15 +++-- drivers/net/hns3/hns3_rxtx.c | 4 +- drivers/net/hns3/meson.build | 1 - drivers/net/octeontx/base/octeontx_io.h | 10 ++- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 ++++++++++++++++++++++++ 10 files changed, 139 insertions(+), 11 deletions(-) create mode 100644 config/arm/arm64_n2_linux_gcc create mode 100644 lib/librte_lpm/rte_lpm_sve.h
Signature · 1 line
2.25.1
PATCH v3 1/5 lpm: add sve support for lookup on Arm platform
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
---
v2:
Fixed tbl8 group index calculation. (Vladimir)
lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build | 2 +- lib/librte_lpm/rte_lpm.h | 4 ++ lib/librte_lpm/rte_lpm_sve.h | 83 +++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 lib/librte_lpm/rte_lpm_sve.h
lib/librte_eal/arm/include/rte_vect.h +3 -0
@@ -9,6 +9,9 @@#include "generic/rte_vect.h" #include "rte_debug.h" #include "arm_neon.h" +#ifdef __ARM_FEATURE_SVE +#include <arm_sve.h> +#endif #ifdef __cplusplusextern "C" {
lib/librte_lpm/meson.build +1 -1
@@ -5,6 +5,6 @@ sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers # without worrying about which architecture we actually need -headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h') +headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h', 'rte_lpm_sve.h') deps += ['hash'] deps += ['rcu']
lib/librte_lpm/rte_lpm.h +4 -0
@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else
lib/librte_lpm/rte_lpm_sve.h new file +83 -0
83 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoted 5 lines · Ruifeng Wang
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set.
Signed-off-by Ruifeng Wang <[email protected]>
Review please?
Signature · 1 line
David Marchand
Quoted 27 lines · Ruifeng Wang
lib/librte_lpm/rte_lpm.h +4
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else lib/librte_lpm/rte_lpm_sve.h new file +5
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_
lib/librte_lpm/rte_lpm_sve.h line 15
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static void
I was looking into use of the __rte_internal tag in the tree.
This helper is called from a inlined API used by applications, so out of the DPDK build.
It looks like the compiler is not complaining when compiling examples (I hacked my env to cross compile with gcc 10 + SVE enabled) but this seems incorrect to me.
Is there really a need for this helper?
It is only used below afaics.
Quoted 3 lines
lib/librte_lpm/rte_lpm_sve.h new file +3
-0+__rte_lpm_lookup_vec(const struct rte_lpm *lpm, const uint32_t *ips, + uint32_t *__rte_restrict next_hops, const uint32_t n) +{
[snip]
Quoted 4 lines
lib/librte_lpm/rte_lpm_sve.h new file +4
-0+} + +static inline void +rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4],
lib/librte_lpm/rte_lpm_sve.h line 77
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+ uint32_t defv) +{ +uint32_t i, ips[4 ]; + +vst1q_s32 ((int32_t *)ips, ip); +for (i =0 ; i <4 ; i++) + hop[i] = defv; + +__rte_lpm_lookup_vec (lpm, ips, hop,4 ); +}
--
David Marchand
<snip>
Quoted 44 lines
lib/librte_lpm/rte_lpm.h rte_lpm_lookupx4(const struct rte_lpm *lpm,
Quoted 5 lines · Ruifeng Wang
lib/librte_lpm/rte_lpm.h index renamed from lib/librte_lpm/rte_lpm.h +0
-0
1afe55cdc..28b57683b100644lib/librte_lpm/rte_lpm.h +0
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm,
xmm_tip,uint32_thop[4],Quoted 22 lines
lib/librte_lpm/rte_lpm.h +4
-0uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else (quoted diff) +0
-0
b/lib/librte_lpm/rte_lpm_sve.hnew file mode 100644 index 000000000..2e319373elib/librte_lpm/rte_lpm_sve.h new file +5
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_lib/librte_lpm/rte_lpm_sve.h line 15
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static voidI was looking into use of the
__rte_internaltag in the tree.
Quoted 8 lines
This helper is called from a inlined API used by applications, so out of the DPDK build.
It looks like the compiler is not complaining when compiling examples (I hacked my env to cross compile with gcc 10 + SVE enabled) but this seems incorrect to me.Is there really a need for this helper?
It is only used below afaics.
I do not think it is required.
At the same time the commit log when '__rte_internal' was introduced is confusing.
It says "Introduce the __rte_internal tag to mark internal ABI function which is used only by the drivers or other libraries". Why would an internal function have an ABI?
Quoted 26 lines
Quoted 5 lines
lib/librte_lpm/rte_lpm_sve.h new file +3
-0+__rte_lpm_lookup_vec(const struct rte_lpm *lpm, const uint32_t *ips, + uint32_t *__rte_restrict next_hops, const uint32_t n) +{[snip]
lib/librte_lpm/rte_lpm_sve.h
Quoted 13 lines
lib/librte_lpm/rte_lpm_sve.h new file +13
-0+} + +static inline void +rte_lpm_lookupx4 (const struct rte_lpm *lpm,xmm_t ip,uint32_t hop[4 ], +uint32_t defv) +{ +uint32_t i, ips[4 ]; + +vst1q_s32 ((int32_t *)ips, ip); +for (i =0 ; i <4 ; i++) + hop[i] = defv; + +__rte_lpm_lookup_vec (lpm, ips, hop,4 ); }--
David Marchand
Quoted 53 lines · Honnappa Nagarahalli
<snip>
Quoted 50 lines
lib/librte_lpm/rte_lpm.h rte_lpm_lookupx4(const struct rte_lpm *lpm,
Quoted 5 lines · Ruifeng Wang
lib/librte_lpm/rte_lpm.h index renamed from lib/librte_lpm/rte_lpm.h +0
-0
1afe55cdc..28b57683b100644lib/librte_lpm/rte_lpm.h +0
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm,
xmm_tip,uint32_thop[4],Quoted 22 lines
lib/librte_lpm/rte_lpm.h +4
-0uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else (quoted diff) +0
-0
b/lib/librte_lpm/rte_lpm_sve.hnew file mode 100644 index 000000000..2e319373elib/librte_lpm/rte_lpm_sve.h new file +5
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_lib/librte_lpm/rte_lpm_sve.h line 15
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static voidI was looking into use of the
__rte_internaltag in the tree.This helper is called from a inlined API used by applications, so out of the DPDK build.
It looks like the compiler is not complaining when compiling examples (I hacked my env to cross compile with gcc 10 + SVE enabled) but this seems incorrect to me.
Quoted 6 lines
Quoted 2 lines
Is there really a need for this helper?
It is only used below afaics.I do not think it is required.
At the same time the commit log when '
__rte_internal' was introduced is confusing.
It says "Introduce the__rte_internaltag to mark internal ABI function which is used only by the drivers or other libraries". Why would an internal function have an ABI?
It happens that drivers/libraries in DPDK offer some interface for other parts of the DPDK to use.
But we might want them to keep them hidden to final applications, because this is purely internal and/or we don't want to guarantee compatibility in later versions.
For such cases, a function can be marked __rte_internal.
This tag has two impacts:
- a marked symbol is versionned as INTERNAL when exported (so this does not apply to inlines),
- if an application tries to use a marked API, an error is triggered at build time to prevent use of such API,
Signature · 1 line
David Marchand
<snip>
Quoted 74 lines
Quoted 53 lines · Honnappa Nagarahalli
<snip>
Quoted 50 lines
lib/librte_lpm/rte_lpm.h rte_lpm_lookupx4(const struct rte_lpm *lpm,
Quoted 5 lines · Ruifeng Wang
lib/librte_lpm/rte_lpm.h +0
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm,
xmm_tip,uint32_thop[4],Quoted 22 lines
lib/librte_lpm/rte_lpm.h +4
-0uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else (quoted diff) +0
-0
b/lib/librte_lpm/rte_lpm_sve.hnew file mode 100644 index 000000000..2e319373elib/librte_lpm/rte_lpm_sve.h new file +5
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_lib/librte_lpm/rte_lpm_sve.h line 15
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static voidI was looking into use of the
__rte_internaltag in the tree.This helper is called from a inlined API used by applications, so out of the DPDK build.
It looks like the compiler is not complaining when compiling examples (I hacked my env to cross compile with gcc 10 + SVE enabled) but this seems incorrect to me.Quoted 5 lines
Quoted 2 lines
Is there really a need for this helper?
It is only used below afaics.I do not think it is required.
At the same time the commit log when '
__rte_internal' was introduced isconfusing.
Quoted 1 line
It says "Introduce the
__rte_internaltag to mark internal ABI function which isused only by the drivers or other libraries". Why would an internal function have an ABI?
It happens that
drivers/librariesin DPDK offer some interface for other parts of the DPDK to use.
But we might want them to keep them hidden to final applications, because this is purely internal and/or we don't want to guarantee compatibility in later versions.
For such cases, a function can be marked__rte_internal.
Quoted 5 lines
This tag has two impacts:
- a marked symbol is versionned as INTERNAL when exported (so this does not apply to inlines),
- if an application tries to use a marked API, an error is triggered at build time to prevent use of such API,
Thanks David, it makes sense now. The word 'internal ABI' in the commit log caused the confusion.
Is this required because all the header files (header files meant for the application and the DPDK internal header files) are in the same directory?
From the above definition, we do not need the internal tag for this function as it is very much internal to LPM library.
Quoted 4 lines
--
David Marchand
Quoted 55 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Wednesday, January 27, 2021 9:05 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; Jan Viktorin <[email protected]>; Bruce Richardson <[email protected]>; Vladimir Medvedkin <[email protected]>; dev <[email protected]>; Pavan Nikhilesh <[email protected]>; [email protected]; Honnappa Nagarahalli <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v3 1/5] lpm: add sve support for lookup on Arm platformlib/librte_lpm/rte_lpm.h rte_lpm_lookupx4(const struct rte_lpm *lpm,
Quoted 5 lines · Ruifeng Wang
lib/librte_lpm/rte_lpm.h index renamed from lib/librte_lpm/rte_lpm.h +0
-0
1afe55cdc..28b57683b100644lib/librte_lpm/rte_lpm.h +0
-0@@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm,
xmm_tip,uint32_thop[4],Quoted 22 lines
lib/librte_lpm/rte_lpm.h +4
-0uint32_t defv);#if defined(RTE_ARCH_ARM ) +#ifdef __ARM_FEATURE_SVE +#include "rte_lpm_sve.h" +#else #include "rte_lpm_neon.h" +#endif #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h" #else (quoted diff) +0
-0
b/lib/librte_lpm/rte_lpm_sve.hnew file mode 100644 index 000000000..2e319373elib/librte_lpm/rte_lpm_sve.h new file +5
-0@@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: BSD-3-Clause +* Copyright(c) 2020 Arm Limited +*/ + +#ifndef _RTE_LPM_SVE_H_lib/librte_lpm/rte_lpm_sve.h line 15
Quoted 10 lines
lib/librte_lpm/rte_lpm_sve.h new file +10
-0+#define _RTE_LPM_SVE_H_ + +#include <rte_vect.h> + +#ifdef __cplusplus +extern "C" { +#endif + +__rte_internal +static voidI was looking into use of the
__rte_internaltag in the tree.
Quoted 8 lines
This helper is called from a inlined API used by applications, so out of the DPDK build.
It looks like the compiler is not complaining when compiling examples (I hacked my env to cross compile with gcc 10 + SVE enabled) but this seems incorrect to me.Is there really a need for this helper?
It is only used below afaics.
My intention was to keep the helper generic. So it can be used not only in rte_lpm_lookupx4 as below, but also in other lookup functions like rte_lpm_lookup_bulk where number of IPs to be looked up is not a fixed value.
Will removing __rte_internal tag resolve the issue?
Quoted 26 lines
Quoted 5 lines
lib/librte_lpm/rte_lpm_sve.h new file +3
-0+__rte_lpm_lookup_vec(const struct rte_lpm *lpm, const uint32_t *ips, + uint32_t *__rte_restrict next_hops, const uint32_t n) +{[snip]
lib/librte_lpm/rte_lpm_sve.h
Quoted 13 lines
lib/librte_lpm/rte_lpm_sve.h new file +13
-0+} + +static inline void +rte_lpm_lookupx4 (const struct rte_lpm *lpm,xmm_t ip,uint32_t hop[4 ], +uint32_t defv) +{ +uint32_t i, ips[4 ]; + +vst1q_s32 ((int32_t *)ips, ip); +for (i =0 ; i <4 ; i++) + hop[i] = defv; + +__rte_lpm_lookup_vec (lpm, ips, hop,4 ); }--
David Marchand
PATCH v3 2/5 net/hns3: fix build with sve enabled
In reply to Ruifeng WangBuilding with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #define PG64_256BIT svwhilelt_b64(0, 4)
This is caused by unintentional cflags reset.
Fixed the issue by not touching cflags, and using flags defined by compiler.
---
v3:
Removed extra flag, use compiler flag instead.
drivers/net/hns3/hns3_rxtx.c | 4 ++-- drivers/net/hns3/meson.build | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/net/hns3/hns3_rxtx.c +2 -2
@@ -10,7 +10,7 @@#include <rte_io.h> #include <rte_net.h> #include <rte_malloc.h> -#if defined(RTE_ARCH_ARM64 ) && defined(CC_SVE_SUPPORT ) +#if defined(RTE_ARCH_ARM64 ) && defined(__ARM_FEATURE_SVE)#include <rte_cpuflags.h> #endif
@@ -2467,7 +2467,7 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,static bool hns3_check_sve_support (void ) { -#if defined(RTE_ARCH_ARM64 ) && defined(CC_SVE_SUPPORT ) +#if defined(RTE_ARCH_ARM64 ) && defined(__ARM_FEATURE_SVE)if (rte_cpu_get_flag_enabled (RTE_CPUFLAG_SVE ))return true;#endif
drivers/net/hns3/meson.build +0 -1
@@ -32,7 +32,6 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] sources += files('hns3_rxtx_vec_sve.c') endif endif
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3 2/5] net/hns3: fix build with sve enabled
<snip>
Quoted 6 lines
Building with SVE extension enabled stopped with error:
error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
18 | #definePG64_256BITsvwhilelt_b64(0, 4)
Quoted 7 lines
This is caused by unintentional cflags reset.
Fixed the issue by not touching cflags, and using flags defined by compiler.Fixes 952ebacce4f2 ("net/hns3: support SVE Rx")Signed-off-by Ruifeng Wang <[email protected]>
Quoted 44 lines
---
v3:
Removed extra flag, use compiler flag instead.drivers/net/hns3/hns3_rxtx.c | 4 ++-- drivers/net/hns3/meson.build | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)drivers/net/hns3/hns3_rxtx.c +2
-2@@ -10,7 +10,7 @@#include <rte_io.h> #include <rte_net.h> #include <rte_malloc.h> -#if defined(RTE_ARCH_ARM64 ) && defined(CC_SVE_SUPPORT ) +#if defined(RTE_ARCH_ARM64 ) && defined(__ARM_FEATURE_SVE)#include <rte_cpuflags.h> #endif @@ -2467,7 +2467,7 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, static bool hns3_check_sve_support(void) { -#if defined(RTE_ARCH_ARM64 ) && defined(CC_SVE_SUPPORT ) +#if defined(RTE_ARCH_ARM64 ) && defined(__ARM_FEATURE_SVE)if (rte_cpu_get_flag_enabled (RTE_CPUFLAG_SVE ))return true;#endif drivers/net/hns3/meson.build +0
-2@@ -32,7 +32,6 @@ deps += ['hash'] if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') sources += files('hns3_rxtx_vec.c') if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' - cflags = ['-DCC_SVE_SUPPORT'] sources += files('hns3_rxtx_vec_sve.c') endif endif --2.25.1
PATCH v3 3/5 net/octeontx: fix build with sve enabled
In reply to Ruifeng WangBuilding with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:91: Error: selected processor does not support addvl x4,x8,#-1' {standard input}:95: Error: selected processor does not support ptrue p1.d,all' {standard input}:135: Error: selected processor does not support whilelo p2.d,xzr,x5' {standard input}:137: Error: selected processor does not support decb x1'
This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Added SVE to the cpu model specified by inline assembly for SVE support. Not replacing the inline assembly with C atomics because the driver relies on specific LSE instruction to interface to co-processor [1].
[1] https://mails.dpdk.org/archives/dev/2021-January/196092.html
---
v3:
Keep inline assembly and add sve extension to fix issue. (Pavan)
drivers/net/octeontx/base/octeontx_io.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/net/octeontx/base/octeontx_io.h +8 -2
@@ -52,6 +52,11 @@ do { \#endif #if defined(RTE_ARCH_ARM64 ) +#if defined(__ARM_FEATURE_SVE) +#define __LSE_PREAMBLE " .cpu generic+lse+sve\n" +#else +#define __LSE_PREAMBLE " .cpu generic+lse\n" +#endif /** * Perform an atomic fetch-and-add operation. */
@@ -61,7 +66,7 @@ octeontx_reg_ldadd_u64(void *addr, int64_t off)uint64_t old_val; __asm__volatile ( -" .cpu generic+lse\n" + __LSE_PREAMBLE" ldadd %1, %0, [%2]\n" :"=r" (old_val) :"r" (off),"r" (addr) :"memory" );
@@ -98,12 +103,13 @@ octeontx_reg_lmtst(void *lmtline_va, void *ioreg_va, const uint64_t cmdbuf[],/* LDEOR initiates atomic transfer to I/O device */ __asm__volatile ( -" .cpu generic+lse\n" + __LSE_PREAMBLE" ldeor xzr, %0, [%1]\n" : "=r" (result) : "r" (ioreg_va) : "memory"); }while (!result); } +#undef __LSE_PREAMBLE#else static inline uint64_t
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3 3/5] net/octeontx: fix build with sve enabled
Quoted 17 lines · Ruifeng Wang
Building with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:91: Error: selected processor does not supportaddvl x4,x8,#-1' {standard input}:95: Error: selected processor does not supportptrue p1.d,all' {standard input}:135: Error: selected processor does not supportwhilelo p2.d,xzr,x5' {standard input}:137: Error: selected processor does not supportdecb x1'This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Added SVE to the cpu model specified by inline assembly for SVE support. Not replacing the inline assembly with C atomics because the driver relies on specific LSE instruction to interface to co-processor [1].
Quoted 7 lines
Fixes f0c7bb1bf778 ("net/octeontx/base: add octeontx IO operations")[1] https://mails.dpdk.org/archives/dev/2021-January/196092.html
Signed-off-by Ruifeng Wang <[email protected]>
Quoted 50 lines
---
v3:
Keep inline assembly and add sve extension to fix issue. (Pavan)drivers/net/octeontx/base/octeontx_io.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)drivers/net/octeontx/base/octeontx_io.h +8
-3@@ -52,6 +52,11 @@ do { \#endif #if defined(RTE_ARCH_ARM64 ) +#if defined(__ARM_FEATURE_SVE) +#define __LSE_PREAMBLE " .cpu generic+lse+sve\n" +#else +#define __LSE_PREAMBLE " .cpu generic+lse\n" +#endif /** * Perform an atomic fetch-and-add operation. */ @@ -61,7 +66,7 @@ octeontx_reg_ldadd_u64(void *addr, int64_t off)uint64_t old_val; __asm__volatile ( -" .cpu generic+lse\n" + __LSE_PREAMBLE" ldadd %1, %0, [%2]\n" :"=r" (old_val) :"r" (off),"r" (addr) :"memory" );@@ -98,12 +103,13 @@ octeontx_reg_lmtst(void *lmtline_va, void *ioreg_va, const uint64_t cmdbuf[],/* LDEOR initiates atomic transfer to I/O device */ __asm__volatile ( -" .cpu generic+lse\n" + __LSE_PREAMBLE" ldeor xzr, %0, [%1]\n" : "=r" (result) : "r" (ioreg_va) : "memory"); }while (!result); } +#undef __LSE_PREAMBLE#else static inline uint64_t --2.25.1
PATCH v3 4/5 common/octeontx2: fix build with sve enabled
In reply to Ruifeng WangBuilding with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:4002: Error: selected processor does not support mov z3.b,#0' {standard input}:4003: Error: selected processor does not support whilelo p1.b,xzr,x7' {standard input}:4005: Error: selected processor does not support ld1b z0.b,p1/z,[x8]' {standard input}:4006: Error: selected processor does not support whilelo p4.s,wzr,w7'
This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Added SVE to the cpu model specified by inline assembly for SVE support. Not replacing the inline assembly with C atomics because the driver relies on specific LSE instruction to interface to co-processor [1].
[1] https://mails.dpdk.org/archives/dev/2021-January/196092.html
---
v3:
Keep inline assembly and add sve extension to fix issue. (Pavan)
drivers/common/octeontx2/otx2_io_arm64.h | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/common/octeontx2/otx2_io_arm64.h +11 -4
@@ -21,6 +21,12 @@#define otx2_prefetch_store_keep (ptr) ({\ asm volatile("prfm pstl1keep, [%x0]\n" : : "r" (ptr)); }) +#if defined(__ARM_FEATURE_SVE) +#define __LSE_PREAMBLE " .cpu generic+lse+sve\n" +#else +#define __LSE_PREAMBLE " .cpu generic+lse\n" +#endif + static __rte_always_inline uint64_totx2_atomic64_add_nosync (int64_t incr,int64_t *ptr) {
@@ -28,7 +34,7 @@ otx2_atomic64_add_nosync(int64_t incr, int64_t *ptr)/* Atomic add with no ordering */ asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldadd %x[i], %x[r], [%[b]]" : [r]"=r" (result),"+m" (*ptr) : [i] "r" (incr), [b] "r" (ptr)
@@ -43,7 +49,7 @@ otx2_atomic64_add_sync(int64_t incr, int64_t *ptr)/* Atomic add with ordering */ asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldadda %x[i], %x[r], [%[b]]" : [r]"=r" (result),"+m" (*ptr) : [i] "r" (incr), [b] "r" (ptr)
@@ -57,7 +63,7 @@ otx2_lmt_submit(rte_iova_t io_address)uint64_t result; asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldeor xzr,%x[rf],[%[rs]]" : [rf]"=r" (result): [rs]"r" (io_address));return result;
@@ -69,7 +75,7 @@ otx2_lmt_submit_release(rte_iova_t io_address)uint64_t result; asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldeorl xzr,%x[rf],[%[rs]]" : [rf]"=r" (result) : [rs]"r" (io_address));return result;
@@ -104,4 +110,5 @@ otx2_lmt_mov_seg(void *out, const void *in, const uint16_t segdw) dst128[i] = src128[i]; } +#undef __LSE_PREAMBLE#endif /* _OTX2_IO_ARM64_H_ */
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3 4/5] common/octeontx2: fix build with sve enabled
Quoted 13 lines · Ruifeng Wang
Building with gcc 10.2 with SVE extension enabled got error:
{standard input}: Assembler messages:
{standard input}:4002: Error: selected processor does not supportmov z3.b,#0' {standard input}:4003: Error: selected processor does not supportwhilelo p1.b,xzr,x7' {standard input}:4005: Error: selected processor does not supportld1b z0.b,p1/z,[x8]' {standard input}:4006: Error: selected processor does not supportwhilelo p4.s,wzr,w7'This is because inline assembly code explicitly resets cpu model to not have SVE support. Thus SVE instructions generated by compiler auto vectorization got rejected by assembler.
Quoted 7 lines
Added SVE to the cpu model specified by inline assembly for SVE support. Not replacing the inline assembly with C atomics because the driver relies on specific LSE instruction to interface to co-processor [1].
Fixes 8a4f835971f5 ("common/octeontx2: add IO handling APIs")
Quoted 73 lines
[1] https://mails.dpdk.org/archives/dev/2021-January/196092.html
Signed-off-by Ruifeng Wang <[email protected]>---
v3:
Keep inline assembly and add sve extension to fix issue. (Pavan)drivers/common/octeontx2/otx2_io_arm64.h | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)drivers/common/octeontx2/otx2_io_arm64.h +11
-5@@ -21,6 +21,12 @@#define otx2_prefetch_store_keep (ptr) ({\ asm volatile("prfm pstl1keep, [%x0]\n" : : "r" (ptr)); }) +#if defined(__ARM_FEATURE_SVE) +#define __LSE_PREAMBLE " .cpu generic+lse+sve\n" +#else +#define __LSE_PREAMBLE " .cpu generic+lse\n" +#endif + static __rte_always_inline uint64_totx2_atomic64_add_nosync (int64_t incr,int64_t *ptr) {@@ -28,7 +34,7 @@ otx2_atomic64_add_nosync(int64_t incr, int64_t *ptr)/* Atomic add with no ordering */ asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldadd %x[i], %x[r], [%[b]]" : [r]"=r" (result),"+m" (*ptr) : [i] "r" (incr), [b] "r" (ptr)@@ -43,7 +49,7 @@ otx2_atomic64_add_sync(int64_t incr, int64_t *ptr)/* Atomic add with ordering */ asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldadda %x[i], %x[r], [%[b]]" : [r]"=r" (result),"+m" (*ptr) : [i] "r" (incr), [b] "r" (ptr)@@ -57,7 +63,7 @@ otx2_lmt_submit(rte_iova_t io_address)uint64_t result; asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldeor xzr,%x[rf],[%[rs]]" : [rf]"=r" (result): [rs]"r" (io_address));return result;@@ -69,7 +75,7 @@ otx2_lmt_submit_release(rte_iova_t io_address)uint64_t result; asmvolatile ( -".cpu generic+lse\n" + __LSE_PREAMBLE"ldeorl xzr,%x[rf],[%[rs]]" : [rf]"=r" (result) : [rs]"r" (io_address));return result;@@ -104,4 +110,5 @@ otx2_lmt_mov_seg(void *out, const void *in, const uint16_t segdw) dst128[i] = src128[i]; } +#undef __LSE_PREAMBLE#endif /* _OTX2_IO_ARM64_H_ */ --2.25.1
PATCH v3 5/5 config: add Arm Neoverse N2
In reply to Ruifeng WangAdd Arm Neoverse N2 cpu support.
---
v3:
Changed arch extension from sve to sve2 as N2 supports sve2. (Honnappa)
config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 config/arm/arm64_n2_linux_gcc
config/arm/arm64_n2_linux_gcc new file +17 -0
@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'
config/arm/meson.build +10 -1
@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [ + ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]] machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']],
@@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra]] + ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra], + ['0xd49', ['-march=armv8.5-a+crypto+sve2'], flags_n2generic_extra]] machine_args_cavium = [ ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3 5/5] config: add Arm Neoverse N2
Quoted 4 lines · Ruifeng Wang
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>
Quoted 64 lines
---
v3:
Changed arch extension from sve to sve2 as N2 supports sve2. (Honnappa)config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 config/arm/arm64_n2_linux_gccconfig/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build +10
-2@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [ + ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]] machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']],@@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra]] + ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra], + ['0xd49', ['-march=armv8.5-a+crypto+sve2'], flags_n2generic_extra]] machine_args_cavium = [ ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']], --2.25.1
Re: [dpdk-dev] [PATCH v3 5/5] config: add Arm Neoverse N2
In reply to Ruifeng Wang<snip>
Quoted 4 lines
Add Arm Neoverse N2 cpu support.
Signed-off-by Ruifeng Wang <[email protected]>
Looks good
Quoted 65 lines
---
v3:
Changed arch extension from sve to sve2 as N2 supports sve2. (Honnappa)config/arm/arm64_n2_linux_gcc | 17 +++++++++++++++++ config/arm/meson.build | 11 ++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644config/arm/arm64_n2_linux_gcc
(quoted diff) +0
-0b/config/arm/arm64_n2_linux_gcc new file mode 100644 index 000000000..78f6f3e2b
config/arm/arm64_n2_linux_gcc new file +17
-0@@ -0,0 +1,17 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementor_id = '0x41' +implementor_pn = '0xd49'config/arm/meson.build index renamed from config/arm/meson.build +0
-0
42b4e43c7..5fd1c40a0100644config/arm/meson.build +9
-1@@ -89,6 +89,14 @@ flags_n1generic_extra = [ ['RTE_MAX_NUMA_NODES', 1], ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], ['RTE_LIBRTE_VHOST_NUMA', false]] +flags_n2generic_extra = [ + ['RTE_MACHINE', '"neoverse-n2"'], + ['RTE_MAX_LCORE', 64], + ['RTE_CACHE_LINE_SIZE', 64], + ['RTE_ARM_FEATURE_ATOMICS', true], + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false], + ['RTE_LIBRTE_VHOST_NUMA', false]] machine_args_generic = [ ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@ -100,7 +108,8 @@ machine_args_generic = [ ['0xd09', ['-mcpu=cortex-a73']], ['0xd0a', ['-mcpu=cortex-a75']], ['0xd0b', ['-mcpu=cortex-a76']], - ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
flags_n1generic_extra]]config/arm/meson.build +1
-0+ ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
flags_n1generic_extra],config/arm/meson.build +1
-1+ ['0xd49', ['-march=armv8.5-a+crypto+sve2'], flags_n2generic_extra]] machine_args_cavium = [ ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']], --2.25.1
Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support
In reply to Ruifeng WangRuifeng, Honnappa,
Quoted 11 lines · Ruifeng Wang
Added lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface.
Refer to [1] for more information about SVE.Configuration was added for Neoverse N2 CPU which has SVE support.
Some bugs were fixed so compiling with sve enabled can pass.
Can you point at a toolchain that supports SVE without having to register to some commercial spamming system? :-)
The only aarch64-linux-gnu- toolchain I found on the ARM website is a 8.x gcc that does not seem to support SVE.
Signature · 1 line
David Marchand
Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support
Quoted 12 lines · David Marchand
Ruifeng, Honnappa,
Quoted 8 lines · Ruifeng Wang
Added lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface.
Refer to [1] for more information about SVE.Configuration was added for Neoverse N2 CPU which has SVE support.
Quoted 8 lines
Quoted 3 lines
Some bugs were fixed so compiling with sve enabled can pass.
Can you point at a toolchain that supports SVE without having to register to some commercial spamming system? :-)
The only aarch64-linux-gnu- toolchain I found on the ARM website is a 8.x gcc that does not seem to support SVE.
I tested this using
https://developer.arm.com/-/media/Files/downloads/gnu-a/10.2-2020.11/binrel/gcc-arm-10.2-2020.11-x86_64-aarch64-none-linux-gnu.tar.xz
But I had to modify the cross compile prefix in config/arm/arm64_n2_linux_gcc (adding a none_).
I am still interested in a toolchain that works out of the box.
Series applied, thanks.
Signature · 1 line
David Marchand
Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support
Quoted 34 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Thursday, January 14, 2021 11:40 PM
To: Ruifeng Wang <[email protected]>; Honnappa Nagarahalli <[email protected]>
Cc: dev <[email protected]>; Vladimir Medvedkin <[email protected]>; Pavan Nikhilesh <[email protected]>; [email protected]; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve supportQuoted 4 lines · David Marchand
Ruifeng, Honnappa,
On Tue, Jan 12, 2021 at 3:57 AM Ruifeng Wang <[email protected]>
Quoted 6 lines · wrote:
Quoted 6 lines
Added lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface.
Refer to [1] for more information about SVE.Quoted 6 lines
Quoted 6 lines
Configuration was added for Neoverse N2 CPU which has SVE support.
Some bugs were fixed so compiling with sve enabled can pass.
hpc/compile/
Quoted 2 lines
Quoted 1 line
arm-instruction-emulator/resources/tutorials/sve
Quoted 8 lines
Quoted 4 lines
Can you point at a toolchain that supports SVE without having to register to some commercial spamming system? :-) The only aarch64-linux-gnu- toolchain I found on the ARM website is a 8.x gcc that does not seem to support SVE.
I tested this using
https://developer.arm.com/-/media/Files/downloads/gnu-a/10.2-
2020.11/binrel/gcc-arm-10.2-2020.11-x86_64-aarch64-none-linux-gnu.tar.xz
Yes, gcc-10 has SVE support. Arm cross compilers available at:
https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads
Quoted 3 lines
But I had to modify the cross compile prefix in config/arm/arm64_n2_linux_gcc (adding a
none_).
I am still interested in a toolchain that works out of the box.
I think on Ubuntu, it will work out of the box after installing package gcc-10-aarch64-linux-gnu.
Quoted 2 lines
Series applied, thanks.
Thank you.
Quoted 4 lines
--
David Marchand