arm: xea: Regression fixes for i.MX28 based XEA board
cover arm: xea: Regression fixes for i.MX28 based XEA board
This patch set provides boot regression fix and some enhancements for i.MX28 based XEA board.
The most notably one is the disablement of CONFIG_SPL_OF_PLATDATA_PARENT which prevents from having the board bricked.
Lukasz Majewski (3):
xea: spl: Disable pull UP for GPIO0_2{35}
xea: config: Use CONFIG_PREBOOT from Kconfig
xea: config: Disable CONFIG_SPL_OF_PLATDATA_PARENT on XEA (imx28)
board/liebherr/xea/spl_xea.c | 2 +- configs/imx28_xea_defconfig | 3 +++ include/configs/xea.h | 1 - 3 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/3 xea: spl: Disable pull UP for GPIO0_2{35}
On the imx287 pin GPMI_WRN (GPIO0_25) no PullUP is available that can be enabled.
To get the same behavior for both boot select pins (i.e. GPIO0_2{35}) disable pull UPs on both.
---
board/liebherr/xea/spl_xea.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/liebherr/xea/spl_xea.c +1 -1
@@ -20,7 +20,7 @@#include <asm/arch/sys_proto.h> #define MUX_CONFIG_LCD (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_NOPULL) -#define MUX_CONFIG_BOOT (MXS_PAD_3V3 | MXS_PAD_PULLUP) +#define MUX_CONFIG_BOOT (MXS_PAD_3V3)#define MUX_CONFIG_TSC (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)#define MUX_CONFIG_SSP0 (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_PULLUP)#define MUX_CONFIG_SSP2 (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP)
Signature · 1 line
2.20.1
PATCH 1/3 xea: spl: Disable pull UP for GPIO0_2{35}
Quoted 7 lines · Lukasz Majewski
On the imx287 pin
GPMI_WRN(GPIO0_25) no PullUP is available that can be enabled.To get the same behavior for both boot select pins (i.e. GPIO0_2{35}) disable pull UPs on both.
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210108/fa6068f7/attachment.sig>
PATCH 2/3 xea: config: Use CONFIG_PREBOOT from Kconfig
In reply to Lukasz MajewskiThe usage of the preboot feature is now controlled via a separate Kconfig option - namely CONFIG_USE_PREBOOT.
It must be enabled for preboot code executing commands now defined in CONFIG_PREBOOT (also moved to the Kconfig).
After defining both CONFIG_USE_PREBOOT and CONFIG_PREBOOT in imx28_xea_defconfig the define of CONFIG_PREBOOT shall be removed from xea.h as it is redundant.
---
configs/imx28_xea_defconfig | 2 ++ include/configs/xea.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-)
configs/imx28_xea_defconfig +2 -0
@@ -25,6 +25,8 @@ CONFIG_FIT=y CONFIG_OF_BOARD_SETUP=y CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyAMA0,115200n8" +CONFIG_USE_PREBOOT=y +CONFIG_PREBOOT="run prebootcmd" CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL_BOARD_INIT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
include/configs/xea.h +0 -1
@@ -47,7 +47,6 @@#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR/* Extra Environment */ -#define CONFIG_PREBOOT "run prebootcmd"#define CONFIG_HOSTNAME "xea"#define CONFIG_EXTRA_ENV_SETTINGS \
Signature · 1 line
2.20.1
PATCH 2/3 xea: config: Use CONFIG_PREBOOT from Kconfig
Quoted 10 lines · Lukasz Majewski
The usage of the preboot feature is now controlled via a separate
Kconfigoption - namelyCONFIG_USE_PREBOOT.
It must be enabled for preboot code executing commands now defined inCONFIG_PREBOOT(also moved to theKconfig).After defining both
CONFIG_USE_PREBOOTandCONFIG_PREBOOTinimx28_xea_defconfigthe define ofCONFIG_PREBOOTshall be removed fromxea.has it is redundant.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210108/cad5b4c4/attachment.sig>
PATCH 2/3 xea: config: Use CONFIG_PREBOOT from Kconfig
In reply to Lukasz MajewskiQuoted 10 lines · Lukasz Majewski
The usage of the preboot feature is now controlled via a separate
Kconfigoption - namelyCONFIG_USE_PREBOOT.
It must be enabled for preboot code executing commands now defined inCONFIG_PREBOOT(also moved to theKconfig).After defining both
CONFIG_USE_PREBOOTandCONFIG_PREBOOTinimx28_xea_defconfigthe define ofCONFIG_PREBOOTshall be removed fromxea.has it is redundant.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210108/70f6a684/attachment.sig>
PATCH 3/3 xea: config: Disable CONFIG_SPL_OF_PLATDATA_PARENT on XEA (imx28)
In reply to Lukasz MajewskiOn the XEA board (imx28) one needs in the SPL support for GPIO, MMC and SPI. Two last ones are necessary for booting the device. The GPIO support allows deciding which medium will be used. For example the GPIO DTS node (gpio at 0 at imx28.dtsi) has pinctrl parent (pinctrl at 80018000) for which we don't need driver asigned for correct operation.
In the spl/dts/dt-platdata.c the gpio at 0 has index 4 and its parent - pinctrl at 80018000 has index 5.
In the bind_drivers_pass() function (at drivers/core/lists.c) call to device_bind_by_name() for fsl_imx23_pinctrl returns -2, which is expected.
With current setup - when the SPL_OF_PLATDATA_PARENT=y
The gpio at 0 node with index 4 is skipped as its parent with 5 is not yet bound. It cannot be as we don't need and provide the driver for it. As a result the gpio at 0 is never bound and we end up with bricked board in the SPL stage.
When CONFIG_SPL_OF_PLATDATA_PARENT is NOT set, all entries from spl/dts/dt-platdata.c are scanned in ascending index order, so gpio at 0 is properly initialized. For fsl_imx_pinctrl we simply check 10 times if the driver for is available (which is not) and exit.
As a result the GPIOs are initialized and can be used in early SPL stage. This commit fixes XEA regression introduced with e41651fffda7da55f6.
---
configs/imx28_xea_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/imx28_xea_defconfig +1 -0
@@ -65,6 +65,7 @@ CONFIG_OF_CONTROL=y CONFIG_SPL_OF_CONTROL=y CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent interrupts" CONFIG_SPL_OF_PLATDATA=y +# CONFIG_SPL_OF_PLATDATA_PARENT is not set CONFIG_ENV_OVERWRITE=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_USE_ENV_SPI_BUS=y
Signature · 1 line
2.20.1
PATCH 3/3 xea: config: Disable CONFIG_SPL_OF_PLATDATA_PARENT on XEA (imx28)
Hi Lukasz,
Quoted 27 lines · Lukasz Majewski
On the XEA board (imx28) one needs in the SPL support for GPIO, MMC and SPI. Two last ones are necessary for booting the device. The GPIO support allows deciding which medium will be used. For example the GPIO DTS node (gpio at 0 at
imx28.dtsi) has pinctrl parent (pinctrl at 80018000) for which we don't need driver asigned for correct operation.
In thespl/dts/dt-platdata.cthe gpio at 0 has index 4 and its parent - pinctrl at 80018000 has index 5.In the
bind_drivers_pass()function (atdrivers/core/lists.c) call todevice_bind_by_name()forfsl_imx23_pinctrlreturns -2, which is expected.With current setup - when the SPL_OF_PLATDATA_PARENT=y
The gpio at 0 node with index 4 is skipped as its parent with 5 is not yet bound. It cannot be as we don't need and provide the driver for it. As a result the gpio at 0 is never bound and we end up with bricked board in the SPL stage.When
CONFIG_SPL_OF_PLATDATA_PARENTis NOT set, all entries fromspl/dts/dt-platdata.care scanned in ascending index order, so gpio at 0 is properly initialized. Forfsl_imx_pinctrlwe simply check 10 times if the driver for is available (which is not) and exit.As a result the GPIOs are initialized and can be used in early SPL stage. This commit fixes XEA regression introduced with
e41651fffda7da55f6.
Quoted 6 lines
Signed-off-by Lukasz Majewski <[email protected]>---
configs/imx28_xea_defconfig | 1 + 1 file changed, 1 insertion(+)
Would it not be better to provide the parent driver?
With the new of-platdata I don't think this is going to work.
Anyway, to fix for this release:
Regards,
Simon
PATCH 3/3 xea: config: Disable CONFIG_SPL_OF_PLATDATA_PARENT on XEA (imx28)
In reply to Lukasz MajewskiQuoted 23 lines · Lukasz Majewski
On the XEA board (imx28) one needs in the SPL support for GPIO, MMC and SPI. Two last ones are necessary for booting the device. The GPIO support allows deciding which medium will be used. For example the GPIO DTS node (gpio at 0 at
imx28.dtsi) has pinctrl parent (pinctrl at 80018000) for which we don't need driver asigned for correct operation.
In thespl/dts/dt-platdata.cthe gpio at 0 has index 4 and its parent - pinctrl at 80018000 has index 5.In the
bind_drivers_pass()function (atdrivers/core/lists.c) call todevice_bind_by_name()forfsl_imx23_pinctrlreturns -2, which is expected.With current setup - when the SPL_OF_PLATDATA_PARENT=y
The gpio at 0 node with index 4 is skipped as its parent with 5 is not yet bound. It cannot be as we don't need and provide the driver for it. As a result the gpio at 0 is never bound and we end up with bricked board in the SPL stage.When
CONFIG_SPL_OF_PLATDATA_PARENTis NOT set, all entries fromspl/dts/dt-platdata.care scanned in ascending index order, so gpio at 0 is properly initialized. Forfsl_imx_pinctrlwe simply check 10 times if the driver for is available (which is not) and exit.
Quoted 5 lines
As a result the GPIOs are initialized and can be used in early SPL stage. This commit fixes XEA regression introduced with
e41651fffda7da55f6.Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210108/4cbfd48f/attachment.sig>