Skip to contentSkip to conversation

Add support for Boundary Nitrogen8M Mini SBC

PATCH Superseded Adrien Grassein 2 participants 10 messages Jan 18, 2021 – Jan 29, 2021

Subsystems (2)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover Add support for Boundary Nitrogen8M Mini SBC

Hello,

This patch set aims is to add the support of the Nitrogen8M Mini SBC from Boundary Devices.

Thanks,

Update in v2:
- Rewrite the dts (Remove the unused wlan and audio);
- Remove useless definition;
- Take in account review.

Update in v3:
- Take in account review.

Update in v4:
- Reorder definition in pmic

Update in v5:
- Take in account review.
- Remove useless i2c groups

Adrien Grassein (3):
dt-bindings: arm: imx: add imx8mm nitrogen support
arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support
arm64: defconfig: Enable PF8x00 as builtin

 .../devicetree/bindings/arm/fsl.yaml          |   1 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++
 arch/arm64/configs/defconfig                  |   1 +
 4 files changed, 398 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH v5 1/3 dt-bindings: arm: imx: add imx8mm nitrogen support

The Nitrogen8M Mini is an ARM based single board computer (SBC).

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 2ae66407e2aa..30e126c421f2 100644
@@ -674,6 +674,7 @@ properties:
         items:
           - enum:
               - beacon,imx8mm-beacon-kit  # i.MX8MM Beacon Development Kit
+              - boundary,imx8mm-nitrogen8mm  # i.MX8MM Nitrogen Board
               - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
               - fsl,imx8mm-evk            # i.MX8MM EVK Board
               - gw,imx8mm-gw71xx-0x       # i.MX8MM Gateworks Development Kit
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH v5 2/3 arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

In reply to Adrien Grassein

Tested with a basic Build Root configuration booting from sdcard.

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++
 2 files changed, 396 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 38559943c15d..398b5cb4f3e2 100644
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +395 -0

395 lines not on this page · raw message

Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

Hi Adrien,

thanks for the patch. I've made only a few comments inline.

Quoted 61 lines · Adrien Grassein

Tested with a basic Build Root configuration booting from sdcard.

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++
 2 files changed, 396 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 38559943c15d..398b5cb4f3e2 100644
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +33 -0
new file mode 100644
index 000000000000..755088387ea5
@@ -0,0 +1,395 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board.
+ * Adrien Grassein <[email protected]>
+ */
+/dts-v1/;
+#include "imx8mm.dtsi"
+
+/ {
+	model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
+	compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
+};
+
+&A53_0 {
+	cpu-supply = <&reg_sw3>;
+};
+
+&A53_1 {
+	cpu-supply = <&reg_sw3>;
+};
+
+&A53_2 {
+	cpu-supply = <&reg_sw3>;
+};
+
+&A53_3 {
+	cpu-supply = <&reg_sw3>;
+};
+
+&fec1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec1>;
+	phy-mode = "rgmii-id";

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 43

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+	phy-handle = <&ethphy0>;
+	fsl,magic-packet;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@4 {
+			compatible = "ethernet-phy-id004d.d072",

^
Do we really need to add the id here?

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 52

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+				"ethernet-phy-ieee802.3-c22";
+			reg = <4>;
+			interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>;
+		};
+	};
+};
+
+&i2c1 {
+	clock-frequency = <400000>;
			    ^
		Is the i2c errata fixed on the imx8?

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 53

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +1 -0
+	pinctrl-names = "default", "gpio";
				     ^
			no pinctrl for gpio.

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 62

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	pmic@8 {
+		compatible = "nxp,pf8121a";
+		reg = <0x8>;
+
+		regulators {
+		    reg_ldo1: ldo1 {
			^
		   alignment
Quoted 72 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +72 -0
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <5000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_ldo2: ldo2 {
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <5000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_ldo3: ldo3 {
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <5000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_ldo4: ldo4 {
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <5000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_buck1: buck1 {
+				regulator-min-microvolt = <400000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_buck2: buck2 {
+				regulator-min-microvolt = <400000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_sw3: buck3 {
+				regulator-min-microvolt = <400000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_buck4: buck4 {
+				regulator-min-microvolt = <400000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_buck5: buck5 {
+				regulator-min-microvolt = <400000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_buck6: buck6 {
+				regulator-min-microvolt = <400000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_buck7: buck7 {
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 144

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			reg_vsnvs: vsnvs {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};

Do we really need to have all regulators marked as always-on?

Quoted 16 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +16 -0
+		};
+	};
+};
+
+&i2c3 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default", "gpio";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "okay";
+
+	i2cmux@70 {
+		compatible = "nxp,pca9540";
+		reg = <0x70>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 170

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+		i2c3 {
+			reg = <0>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			rtc@68 {
+				compatible = "microcrystal,rv4162";
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_i2c3a_rv4162>;
+				reg = <0x68>;

reg should be the 2nd property, after the compatible.

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+				interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>;
+				wakeup-source;
+			};
+		};
+	};
+};
+
+/* console */
+&uart2 {
+	pinctrl-names = "default";

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+	pinctrl-0 = <&pinctrl_uart2>;
+	assigned-clocks = <&clk IMX8MM_CLK_UART2>;
+	assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
+	status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+	bus-width = <8>;
+	sdhci-caps-mask = <0x80000000 0x0>;
		^

This is a SD host controller property according the doc.

Quoted 20 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +20 -0
+	non-removable;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	status = "okay";
+};
+
+/* sdcard */
+&usdhc2 {
+	bus-width = <4>;
+	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+	vqmmc-supply = <&reg_ldo2>;
+	status = "okay";
+};
+

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 220

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;

It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those.

Regards,
Marco

Quoted 184 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +175 -0
+
+	pinctrl_fec1: fec1grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_ENET_MDC_ENET1_MDC			0x3
+			MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO		0x3
+			MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3		0x1f
+			MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2		0x1f
+			MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1		0x1f
+			MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0		0x1f
+			MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3		0x91
+			MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2		0x91
+			MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1		0x91
+			MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0		0x91
+			MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC		0x1f
+			MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC		0x91
+			MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL	0x91
+			MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL	0x1f
+			MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16		0x159
+		>;
+	};
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09
+			MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09
+		>;
+	};
+
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
+			MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3
+		>;
+	};
+
+	pinctrl_i2c3: i2c3grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
+			MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
+		>;
+	};
+
+	pinctrl_i2c3a_rv4162: i2c3a-rv4162grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0
+		>;
+	};
+
+	pinctrl_uart2: uart2grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
+			MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
+		>;
+	};
+
+	pinctrl_usdhc1: usdhc1grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK		0x190
+			MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD		0x1d0
+			MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0	0x1d0
+			MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1	0x1d0
+			MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2	0x1d0
+			MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3	0x1d0
+			MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4	0x1d0
+			MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5	0x1d0
+			MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6	0x1d0
+			MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7	0x1d0
+			MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10	0x141
+		>;
+	};
+
+	pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK		0x194
+			MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD		0x1d4
+			MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0	0x1d4
+			MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1	0x1d4
+			MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2	0x1d4
+			MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3	0x1d4
+			MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4	0x1d4
+			MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5	0x1d4
+			MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6	0x1d4
+			MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7	0x1d4
+		>;
+	};
+
+	pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK		0x196
+			MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD		0x1d6
+			MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0	0x1d6
+			MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1	0x1d6
+			MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2	0x1d6
+			MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3	0x1d6
+			MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4	0x1d6
+			MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5	0x1d6
+			MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6	0x1d6
+			MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7	0x1d6
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK		0x190
+			MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD		0x1d0
+			MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0	0x1d0
+			MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1	0x1d0
+			MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2	0x1d0
+			MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3	0x1d0
+			MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12	0x1c4
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK		0x194
+			MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD		0x1d4
+			MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0	0x1d4
+			MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1	0x1d4
+			MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2	0x1d4
+			MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3	0x1d4
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK		0x196
+			MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD		0x1d6
+			MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0	0x1d6
+			MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1	0x1d6
+			MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2	0x1d6
+			MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3	0x1d6
+		>;
+	};
+
+	pinctrl_usdhc3: usdhc3grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK		0x190
+			MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD		0x1d0
+			MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0		0x1d0
+			MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1		0x1d0
+			MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2		0x1d0
+			MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3		0x1d0
+			MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K	0x03
+		>;
+	};
+
+	pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK	0x194
+			MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD	0x1d4
+			MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0	0x1d4
+			MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1	0x1d4
+			MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2	0x1d4
+			MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3	0x1d4
+		>;
+	};
+
+	pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK	0x196
+			MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD	0x1d6
+			MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0	0x1d6
+			MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1	0x1d6
+			MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2	0x1d6
+			MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3	0x1d6
+		>;
+	};
+
+	pinctrl_wdog: wdoggrp {
+		fsl,pins = <
+			MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140
+		>;
+	};
+};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#4 lore raw

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

Hi Marco,

Thanks for your time.

Quoted 71 lines · Marco Felsch

Hi Adrien,

thanks for the patch. I've made only a few comments inline.

Quoted 65 lines · Adrien Grassein

Tested with a basic Build Root configuration booting from sdcard.

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++
 2 files changed, 396 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 38559943c15d..398b5cb4f3e2 100644
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +37 -0
new file mode 100644
index 000000000000..755088387ea5
@@ -0,0 +1,395 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board.
+ * Adrien Grassein <[email protected]>
+ */
+/dts-v1/;
+#include "imx8mm.dtsi"
+
+/ {
+     model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
+     compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
+};
+
+&A53_0 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&A53_1 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&A53_2 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&A53_3 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&fec1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_fec1>;
+     phy-mode = "rgmii-id";
+     phy-handle = <&ethphy0>;
+     fsl,magic-packet;
+     status = "okay";
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 43

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+     mdio {
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             ethphy0: ethernet-phy@4 {
+                     compatible = "ethernet-phy-id004d.d072",

^
Do we really need to add the id here?

Yes, I don't know why, but the chip it's not recognized via the mdio interface. I will do further tests but I think it's needed.

Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 52

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+                             "ethernet-phy-ieee802.3-c22";
+                     reg = <4>;
+                     interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>;
+             };
+     };
+};
+
+&i2c1 {
+     clock-frequency = <400000>;

^
Is the i2c errata fixed on the imx8?

I don't know. What is this errata?
Should I set a lower speed for the particular i2c?

Quoted 4 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 53

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +1 -0
+     pinctrl-names = "default", "gpio";

^
no pinctrl for gpio.

Yes, it's a bug, thanks

Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 62

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+     pinctrl-0 = <&pinctrl_i2c1>;
+     status = "okay";
+
+     pmic@8 {
+             compatible = "nxp,pf8121a";
+             reg = <0x8>;
+
+             regulators {
+                 reg_ldo1: ldo1 {
                        ^
                   alignment

OK

Quoted 76 lines
Quoted 76 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +76 -0
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo2: ldo2 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo3: ldo3 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo4: ldo4 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck1: buck1 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck2: buck2 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_sw3: buck3 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck4: buck4 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck5: buck5 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck6: buck6 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck7: buck7 {
+                             regulator-min-microvolt = <3300000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 144

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+                     reg_vsnvs: vsnvs {
+                             regulator-min-microvolt = <1800000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };

Do we really need to have all regulators marked as always-on?

I used the definition present on the example.
I will remove this (for the one I don't use).

Quoted 20 lines
Quoted 20 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +20 -0
+             };
+     };
+};
+
+&i2c3 {
+     clock-frequency = <100000>;
+     pinctrl-names = "default", "gpio";
+     pinctrl-0 = <&pinctrl_i2c3>;
+     status = "okay";
+
+     i2cmux@70 {
+             compatible = "nxp,pca9540";
+             reg = <0x70>;
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             i2c3 {
+                     reg = <0>;
+                     #address-cells = <1>;
+                     #size-cells = <0>;
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 170

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+
+                     rtc@68 {
+                             compatible = "microcrystal,rv4162";
+                             pinctrl-names = "default";
+                             pinctrl-0 = <&pinctrl_i2c3a_rv4162>;
+                             reg = <0x68>;

reg should be the 2nd property, after the compatible.

OK.

Quoted 21 lines
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+                             interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>;
+                             wakeup-source;
+                     };
+             };
+     };
+};
+
+/* console */
+&uart2 {
+     pinctrl-names = "default";

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+     pinctrl-0 = <&pinctrl_uart2>;
+     assigned-clocks = <&clk IMX8MM_CLK_UART2>;
+     assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
+     status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+     bus-width = <8>;
+     sdhci-caps-mask = <0x80000000 0x0>;
                ^
Quoted 2 lines

This is a SD host controller property according the doc.

Yes, I don't understand the point, sorry.
This property is read by the host driver, but should be present here (like in some other dts).

Quoted 25 lines
Quoted 25 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +25 -0
+     non-removable;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc1>;
+     pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+     status = "okay";
+};
+
+/* sdcard */
+&usdhc2 {
+     bus-width = <4>;
+     cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc2>;
+     pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+     vqmmc-supply = <&reg_ldo2>;
+     status = "okay";
+};
+
+&wdog1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_wdog>;
+     fsl,ext-reset-output;
+     status = "okay";
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 220

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +5 -0
+};
+
+&iomuxc {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_hog>;

It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those.

Once again (sorry), I don't understand the point.
I did this like any other imx8 board (imx8mq-nitrogem for example).

Quoted 189 lines

Regards,
Marco

Quoted 179 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +175 -1
+
+     pinctrl_fec1: fec1grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_ENET_MDC_ENET1_MDC                 0x3
+                     MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO               0x3
+                     MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3           0x1f
+                     MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2           0x1f
+                     MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1           0x1f
+                     MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0           0x1f
+                     MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3           0x91
+                     MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2           0x91
+                     MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1           0x91
+                     MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0           0x91
+                     MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC           0x1f
+                     MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC           0x91
+                     MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL     0x91
+                     MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL     0x1f
+                     MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16            0x159
+             >;
+     };
+
+     pinctrl_hog: hoggrp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09
+                     MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09
+             >;
+     };
+
+     pinctrl_i2c1: i2c1grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
+                     MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3
+             >;
+     };
+
+     pinctrl_i2c3: i2c3grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
+                     MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
+             >;
+     };
+
+     pinctrl_i2c3a_rv4162: i2c3a-rv4162grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0
+             >;
+     };
+
+     pinctrl_uart2: uart2grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
+                     MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
+             >;
+     };
+
+     pinctrl_usdhc1: usdhc1grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK         0x190
+                     MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD         0x1d0
+                     MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7     0x1d0
+                     MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10     0x141
+             >;
+     };
+
+     pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK         0x194
+                     MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD         0x1d4
+                     MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7     0x1d4
+             >;
+     };
+
+     pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK         0x196
+                     MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD         0x1d6
+                     MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7     0x1d6
+             >;
+     };
+
+     pinctrl_usdhc2: usdhc2grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x190
+                     MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d0
+                     MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d0
+                     MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d0
+                     MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d0
+                     MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d0
+                     MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12        0x1c4
+             >;
+     };
+
+     pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x194
+                     MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d4
+                     MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d4
+                     MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d4
+                     MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d4
+                     MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d4
+             >;
+     };
+
+     pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x196
+                     MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d6
+                     MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d6
+                     MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d6
+                     MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d6
+                     MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d6
+             >;
+     };
+
+     pinctrl_usdhc3: usdhc3grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK               0x190
+                     MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD               0x1d0
+                     MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0           0x1d0
+                     MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1           0x1d0
+                     MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2           0x1d0
+                     MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3           0x1d0
+                     MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K      0x03
+             >;
+     };
+
+     pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK       0x194
+                     MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD       0x1d4
+                     MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0   0x1d4
+                     MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1   0x1d4
+                     MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2   0x1d4
+                     MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3   0x1d4
+             >;
+     };
+
+     pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK       0x196
+                     MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD       0x1d6
+                     MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0   0x1d6
+                     MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1   0x1d6
+                     MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2   0x1d6
+                     MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3   0x1d6
+             >;
+     };
+
+     pinctrl_wdog: wdoggrp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140
+             >;
+     };
+};
--

2.25.1

Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--

Quoted 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Thanks,

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

Here are some additional answers:

Quoted 86 lines · Adrien Grassein

Hi Marco,

Thanks for your time.

Quoted 71 lines · Marco Felsch

Hi Adrien,

thanks for the patch. I've made only a few comments inline.

Quoted 65 lines · Adrien Grassein

Tested with a basic Build Root configuration booting from sdcard.

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++
 2 files changed, 396 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 38559943c15d..398b5cb4f3e2 100644
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +37 -0
new file mode 100644
index 000000000000..755088387ea5
@@ -0,0 +1,395 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board.
+ * Adrien Grassein <[email protected]>
+ */
+/dts-v1/;
+#include "imx8mm.dtsi"
+
+/ {
+     model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
+     compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
+};
+
+&A53_0 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&A53_1 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&A53_2 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&A53_3 {
+     cpu-supply = <&reg_sw3>;
+};
+
+&fec1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_fec1>;
+     phy-mode = "rgmii-id";
+     phy-handle = <&ethphy0>;
+     fsl,magic-packet;
+     status = "okay";
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 43

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+     mdio {
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             ethphy0: ethernet-phy@4 {
+                     compatible = "ethernet-phy-id004d.d072",

^
Do we really need to add the id here?

Quoted 3 lines

Yes, I don't know why, but the chip it's not recognized via the mdio interface. I will do further tests but I think it's needed.

Not needed anymore.

Quoted 121 lines
Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 52

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+                             "ethernet-phy-ieee802.3-c22";
+                     reg = <4>;
+                     interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>;
+             };
+     };
+};
+
+&i2c1 {
+     clock-frequency = <400000>;

^
Is the i2c errata fixed on the imx8?

I don't know. What is this errata?
Should I set a lower speed for the particular i2c?

Quoted 4 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 53

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +1 -0
+     pinctrl-names = "default", "gpio";

^
no pinctrl for gpio.

Yes, it's a bug, thanks

Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 62

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+     pinctrl-0 = <&pinctrl_i2c1>;
+     status = "okay";
+
+     pmic@8 {
+             compatible = "nxp,pf8121a";
+             reg = <0x8>;
+
+             regulators {
+                 reg_ldo1: ldo1 {
                        ^
                   alignment

OK

Quoted 76 lines
Quoted 76 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +76 -0
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo2: ldo2 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo3: ldo3 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo4: ldo4 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck1: buck1 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck2: buck2 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_sw3: buck3 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck4: buck4 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck5: buck5 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck6: buck6 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck7: buck7 {
+                             regulator-min-microvolt = <3300000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 144

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+                     reg_vsnvs: vsnvs {
+                             regulator-min-microvolt = <1800000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };

Do we really need to have all regulators marked as always-on?

Quoted 2 lines

I used the definition present on the example.
I will remove this (for the one I don't use).

Yes it's needed. In fact the only one not needed is the reg_vsnvs one. Disabling any of ldo or buck will disable all others.

Quoted 289 lines
Quoted 20 lines
Quoted 20 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +20 -0
+             };
+     };
+};
+
+&i2c3 {
+     clock-frequency = <100000>;
+     pinctrl-names = "default", "gpio";
+     pinctrl-0 = <&pinctrl_i2c3>;
+     status = "okay";
+
+     i2cmux@70 {
+             compatible = "nxp,pca9540";
+             reg = <0x70>;
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             i2c3 {
+                     reg = <0>;
+                     #address-cells = <1>;
+                     #size-cells = <0>;
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 170

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+
+                     rtc@68 {
+                             compatible = "microcrystal,rv4162";
+                             pinctrl-names = "default";
+                             pinctrl-0 = <&pinctrl_i2c3a_rv4162>;
+                             reg = <0x68>;

reg should be the 2nd property, after the compatible.

OK.

Quoted 21 lines
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+                             interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>;
+                             wakeup-source;
+                     };
+             };
+     };
+};
+
+/* console */
+&uart2 {
+     pinctrl-names = "default";

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+     pinctrl-0 = <&pinctrl_uart2>;
+     assigned-clocks = <&clk IMX8MM_CLK_UART2>;
+     assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
+     status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+     bus-width = <8>;
+     sdhci-caps-mask = <0x80000000 0x0>;
                ^
Quoted 2 lines

This is a SD host controller property according the doc.

Yes, I don't understand the point, sorry.
This property is read by the host driver, but should be present here (like in some other dts).

Quoted 25 lines
Quoted 25 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +25 -0
+     non-removable;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc1>;
+     pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+     status = "okay";
+};
+
+/* sdcard */
+&usdhc2 {
+     bus-width = <4>;
+     cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc2>;
+     pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+     vqmmc-supply = <&reg_ldo2>;
+     status = "okay";
+};
+
+&wdog1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_wdog>;
+     fsl,ext-reset-output;
+     status = "okay";
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 220

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +5 -0
+};
+
+&iomuxc {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_hog>;

It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those.

Once again (sorry), I don't understand the point.
I did this like any other imx8 board (imx8mq-nitrogem for example).

Quoted 189 lines

Regards,
Marco

Quoted 179 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +175 -1
+
+     pinctrl_fec1: fec1grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_ENET_MDC_ENET1_MDC                 0x3
+                     MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO               0x3
+                     MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3           0x1f
+                     MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2           0x1f
+                     MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1           0x1f
+                     MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0           0x1f
+                     MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3           0x91
+                     MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2           0x91
+                     MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1           0x91
+                     MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0           0x91
+                     MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC           0x1f
+                     MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC           0x91
+                     MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL     0x91
+                     MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL     0x1f
+                     MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16            0x159
+             >;
+     };
+
+     pinctrl_hog: hoggrp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09
+                     MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09
+             >;
+     };
+
+     pinctrl_i2c1: i2c1grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
+                     MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3
+             >;
+     };
+
+     pinctrl_i2c3: i2c3grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
+                     MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
+             >;
+     };
+
+     pinctrl_i2c3a_rv4162: i2c3a-rv4162grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0
+             >;
+     };
+
+     pinctrl_uart2: uart2grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
+                     MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
+             >;
+     };
+
+     pinctrl_usdhc1: usdhc1grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK         0x190
+                     MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD         0x1d0
+                     MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6     0x1d0
+                     MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7     0x1d0
+                     MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10     0x141
+             >;
+     };
+
+     pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK         0x194
+                     MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD         0x1d4
+                     MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6     0x1d4
+                     MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7     0x1d4
+             >;
+     };
+
+     pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK         0x196
+                     MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD         0x1d6
+                     MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6     0x1d6
+                     MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7     0x1d6
+             >;
+     };
+
+     pinctrl_usdhc2: usdhc2grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x190
+                     MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d0
+                     MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d0
+                     MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d0
+                     MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d0
+                     MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d0
+                     MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12        0x1c4
+             >;
+     };
+
+     pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x194
+                     MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d4
+                     MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d4
+                     MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d4
+                     MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d4
+                     MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d4
+             >;
+     };
+
+     pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x196
+                     MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d6
+                     MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d6
+                     MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d6
+                     MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d6
+                     MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d6
+             >;
+     };
+
+     pinctrl_usdhc3: usdhc3grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK               0x190
+                     MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD               0x1d0
+                     MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0           0x1d0
+                     MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1           0x1d0
+                     MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2           0x1d0
+                     MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3           0x1d0
+                     MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K      0x03
+             >;
+     };
+
+     pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK       0x194
+                     MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD       0x1d4
+                     MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0   0x1d4
+                     MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1   0x1d4
+                     MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2   0x1d4
+                     MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3   0x1d4
+             >;
+     };
+
+     pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK       0x196
+                     MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD       0x1d6
+                     MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0   0x1d6
+                     MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1   0x1d6
+                     MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2   0x1d6
+                     MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3   0x1d6
+             >;
+     };
+
+     pinctrl_wdog: wdoggrp {
+             fsl,pins = <
+                     MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140
+             >;
+     };
+};
--

2.25.1

Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--

Quoted 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Quoted 1 line

Thanks,

Thanks again.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

In reply to Adrien Grassein

Hi Adrien,

Quoted 7 lines · Adrien Grassein
Quoted 4 lines
Quoted 2 lines

+&i2c1 {
+ clock-frequency = <400000>;

^
Is the i2c errata fixed on the imx8?

I don't know. What is this errata?
Should I set a lower speed for the particular i2c?

The max. clock on iMX6 is 375kHz due to errate ERR007805
https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf

Quoted 106 lines
Quoted 4 lines
Quoted 2 lines

+ pinctrl-names = "default", "gpio";

^
no pinctrl for gpio.

Yes, it's a bug, thanks

Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 62

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+     pinctrl-0 = <&pinctrl_i2c1>;
+     status = "okay";
+
+     pmic@8 {
+             compatible = "nxp,pf8121a";
+             reg = <0x8>;
+
+             regulators {
+                 reg_ldo1: ldo1 {
                        ^
                   alignment

OK

Quoted 76 lines
Quoted 76 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +76 -0
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo2: ldo2 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo3: ldo3 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo4: ldo4 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck1: buck1 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck2: buck2 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_sw3: buck3 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck4: buck4 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck5: buck5 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck6: buck6 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck7: buck7 {
+                             regulator-min-microvolt = <3300000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 144

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+                     reg_vsnvs: vsnvs {
+                             regulator-min-microvolt = <1800000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };

Do we really need to have all regulators marked as always-on?

Quoted 2 lines

I used the definition present on the example.
I will remove this (for the one I don't use).

Can you test to remove all always-on except for those really needed e.g. the vddr-ref. Regulators are obtained on demand by the devices. This allows us to save power e.g. in suspend-to-ram case.

Quoted 54 lines
Quoted 20 lines
Quoted 20 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +20 -0
+             };
+     };
+};
+
+&i2c3 {
+     clock-frequency = <100000>;
+     pinctrl-names = "default", "gpio";
+     pinctrl-0 = <&pinctrl_i2c3>;
+     status = "okay";
+
+     i2cmux@70 {
+             compatible = "nxp,pca9540";
+             reg = <0x70>;
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             i2c3 {
+                     reg = <0>;
+                     #address-cells = <1>;
+                     #size-cells = <0>;
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 170

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+
+                     rtc@68 {
+                             compatible = "microcrystal,rv4162";
+                             pinctrl-names = "default";
+                             pinctrl-0 = <&pinctrl_i2c3a_rv4162>;
+                             reg = <0x68>;

reg should be the 2nd property, after the compatible.

OK.

Quoted 21 lines
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+                             interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>;
+                             wakeup-source;
+                     };
+             };
+     };
+};
+
+/* console */
+&uart2 {
+     pinctrl-names = "default";

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+     pinctrl-0 = <&pinctrl_uart2>;
+     assigned-clocks = <&clk IMX8MM_CLK_UART2>;
+     assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
+     status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+     bus-width = <8>;
+     sdhci-caps-mask = <0x80000000 0x0>;
                ^
Quoted 2 lines

This is a SD host controller property according the doc.

Quoted 3 lines

Yes, I don't understand the point, sorry.
This property is read by the host driver, but should be present here (like in some other dts).

I've never seen this property. I said "This is a SD host controller" because your comment says that this usdhc controller is used for eMMC which is not an SD controller.

Quoted 34 lines
Quoted 25 lines
Quoted 25 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +25 -0
+     non-removable;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc1>;
+     pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+     status = "okay";
+};
+
+/* sdcard */
+&usdhc2 {
+     bus-width = <4>;
+     cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc2>;
+     pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+     vqmmc-supply = <&reg_ldo2>;
+     status = "okay";
+};
+
+&wdog1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_wdog>;
+     fsl,ext-reset-output;
+     status = "okay";
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 220

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +5 -0
+};
+
+&iomuxc {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_hog>;

It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those.

Quoted 2 lines

Once again (sorry), I don't understand the point.
I did this like any other imx8 board (imx8mq-nitrogem for example).

Question is where are those pins used and for what purpose. It is common to specify the muxing within the device nodes like you did for the wdog1 device. This mechanism here is something like: "Oh I don't wanna setup the muxing on the correct places, so let's mux it here in glob". Your hog group isn't really large but it would be nice to avoid it since day one.

Regards,
Marco

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

Hi Marco,

Quoted 7 lines · Marco Felsch

Hi Adrien,

Quoted 2 lines · Adrien Grassein
Quoted 2 lines
Quoted 2 lines

+&i2c1 {
+ clock-frequency = <400000>;

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

^
Is the i2c errata fixed on the imx8?

I don't know. What is this errata?
Should I set a lower speed for the particular i2c?

The max. clock on iMX6 is 375kHz due to errate ERR007805
https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf

It's an imx8. So I guess that this errata will not affect my board.

Quoted 106 lines
Quoted 106 lines
Quoted 4 lines
Quoted 2 lines

+ pinctrl-names = "default", "gpio";

^
no pinctrl for gpio.

Yes, it's a bug, thanks

Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 62

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +9 -0
+     pinctrl-0 = <&pinctrl_i2c1>;
+     status = "okay";
+
+     pmic@8 {
+             compatible = "nxp,pf8121a";
+             reg = <0x8>;
+
+             regulators {
+                 reg_ldo1: ldo1 {
                        ^
                   alignment

OK

Quoted 85 lines
Quoted 72 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +72 -0
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo2: ldo2 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo3: ldo3 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_ldo4: ldo4 {
+                             regulator-min-microvolt = <1500000>;
+                             regulator-max-microvolt = <5000000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck1: buck1 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck2: buck2 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_sw3: buck3 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck4: buck4 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck5: buck5 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck6: buck6 {
+                             regulator-min-microvolt = <400000>;
+                             regulator-max-microvolt = <1800000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_buck7: buck7 {
+                             regulator-min-microvolt = <3300000>;
+                             regulator-max-microvolt = <3300000>;

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 144

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };
+
+                     reg_vsnvs: vsnvs {
+                             regulator-min-microvolt = <1800000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-boot-on;
+                             regulator-always-on;
+                     };

Do we really need to have all regulators marked as always-on?

Quoted 7 lines
Quoted 2 lines

I used the definition present on the example.
I will remove this (for the one I don't use).

Can you test to remove all always-on except for those really needed e.g. the vddr-ref. Regulators are obtained on demand by the devices. This allows us to save power e.g. in suspend-to-ram case.

Ok, thanks,

Quoted 54 lines
Quoted 54 lines
Quoted 20 lines
Quoted 20 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +20 -0
+             };
+     };
+};
+
+&i2c3 {
+     clock-frequency = <100000>;
+     pinctrl-names = "default", "gpio";
+     pinctrl-0 = <&pinctrl_i2c3>;
+     status = "okay";
+
+     i2cmux@70 {
+             compatible = "nxp,pca9540";
+             reg = <0x70>;
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             i2c3 {
+                     reg = <0>;
+                     #address-cells = <1>;
+                     #size-cells = <0>;
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 170

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +6 -0
+
+                     rtc@68 {
+                             compatible = "microcrystal,rv4162";
+                             pinctrl-names = "default";
+                             pinctrl-0 = <&pinctrl_i2c3a_rv4162>;
+                             reg = <0x68>;

reg should be the 2nd property, after the compatible.

OK.

Quoted 23 lines
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+                             interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>;
+                             wakeup-source;
+                     };
+             };
+     };
+};
+
+/* console */
+&uart2 {
+     pinctrl-names = "default";

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +10 -0
+     pinctrl-0 = <&pinctrl_uart2>;
+     assigned-clocks = <&clk IMX8MM_CLK_UART2>;
+     assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
+     status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+     bus-width = <8>;
+     sdhci-caps-mask = <0x80000000 0x0>;
                ^

This is a SD host controller property according the doc.

Quoted 8 lines
Quoted 3 lines

Yes, I don't understand the point, sorry.
This property is read by the host driver, but should be present here (like in some other dts).

I've never seen this property. I said "This is a SD host controller" because your comment says that this usdhc controller is used for eMMC which is not an SD controller.

The eMMC is connected to this controller. Without this, my eMMC is not recognized by the kernel.

Quoted 37 lines
Quoted 34 lines
Quoted 25 lines
Quoted 25 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +25 -0
+     non-removable;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc1>;
+     pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+     status = "okay";
+};
+
+/* sdcard */
+&usdhc2 {
+     bus-width = <4>;
+     cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc2>;
+     pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+     vqmmc-supply = <&reg_ldo2>;
+     status = "okay";
+};
+
+&wdog1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_wdog>;
+     fsl,ext-reset-output;
+     status = "okay";
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts line 220

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file +5 -0
+};
+
+&iomuxc {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_hog>;

It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those.

Quoted 2 lines

Once again (sorry), I don't understand the point.
I did this like any other imx8 board (imx8mq-nitrogem for example).

Quoted 7 lines

Question is where are those pins used and for what purpose. It is common to specify the muxing within the device nodes like you did for the wdog1 device. This mechanism here is something like: "Oh I don't wanna setup the muxing on the correct places, so let's mux it here in glob". Your hog group isn't really large but it would be nice to avoid it since day one.

Ok, no problem with this, but how can I do this?
Do you have an example?

Quoted 2 lines

Regards,
Marco

Moreover, yesterday I did another version of this patchset taking in account mot of your review exept:
- errata;
- SD Host property;
- hog group.

Thanks again,
Adrien

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#8 lore raw

PATCH v5 3/3 arm64: defconfig: Enable PF8x00 as builtin

In reply to Adrien Grassein

This driver is mandatory for the nitrogen8m mini board when booting from the sdcard slot.

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index 15fe99544c67..fe7f82ceba9d 100644
@@ -607,6 +607,7 @@ CONFIG_REGULATOR_MAX77620=y
 CONFIG_REGULATOR_MAX8973=y
 CONFIG_REGULATOR_MP8859=y
 CONFIG_REGULATOR_PCA9450=y
+CONFIG_REGULATOR_PF8X00=y
 CONFIG_REGULATOR_PFUZE100=y
 CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_QCOM_RPMH=y
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#9 lore raw
In reply to Adrien Grassein

Hello Shawn,

Could you please have a look at the new patch set made after your commentaries? Thank a lot for your time,

Thanks,

Quoted 35 lines · Adrien Grassein

Hello,

This patch set aims is to add the support of the Nitrogen8M Mini SBC from Boundary Devices.

Thanks,

Update in v2:
- Rewrite the dts (Remove the unused wlan and audio);
- Remove useless definition;
- Take in account review.

Update in v3:
- Take in account review.

Update in v4:
- Reorder definition in pmic

Update in v5:
- Take in account review.
- Remove useless i2c groups

Adrien Grassein (3):
dt-bindings: arm: imx: add imx8mm nitrogen support
arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support
arm64: defconfig: Enable PF8x00 as builtin

 .../devicetree/bindings/arm/fsl.yaml          |   1 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++
 arch/arm64/configs/defconfig                  |   1 +
 4 files changed, 398 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts
Quoted 3 lines

--
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel