Skip to contentSkip to conversation

firmware: tee_bnxt: Use UUID API for exporting the UUID

PATCH RESEND In review Andy Shevchenko 2 participants 6 messages Jan 21, 2021 – Jan 27, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 firmware: tee_bnxt: Use UUID API for exporting the UUID

There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.

This allows to hide the uuid_t internals.

---
 drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/broadcom/tee_bnxt_fw.c +1 -1
index ed10da5313e8..4cf0c2576037 100644
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
 		return -ENODEV;
 
 	/* Open session with Bnxt load Trusted App */
-	memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+	export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
 	sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
 	sess_arg.num_params = 0;
 
Signature · 1 line
2.29.2
#1 lore raw
Quoted 2 lines · Andy Shevchenko

There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.

Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? If not, why review is not done yes for more than half a year?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

+ Cc: Christoph. Maybe you can apply this one, please?

Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.

Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? If not, why review is not done yes for more than half a year?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 1 line · Andy Shevchenko

+ Cc: Christoph. Maybe you can apply this one, please?

I've not even seen the original patch.

#4 lore raw
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Andy Shevchenko

+ Cc: Christoph. Maybe you can apply this one, please?

I've not even seen the original patch.

It's easy to retrieve with b4 tool:
b4 am -s [email protected]

But for your convenience I may resend once more with you being Cc'ed.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 10 lines · Andy Shevchenko
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Andy Shevchenko

+ Cc: Christoph. Maybe you can apply this one, please?

I've not even seen the original patch.

It's easy to retrieve with b4 tool:
b4 am -s [email protected]

But for your convenience I may resend once more with you being Cc'ed.

Just sent a v2 which is basically the same :-)

Signature · 2 lines
With Best Regards,
Andy Shevchenko