firmware: tee_bnxt: Use UUID API for exporting the UUID
PATCH RESEND 1/1 firmware: tee_bnxt: Use UUID API for exporting the UUID
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
--- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/broadcom/tee_bnxt_fw.c +1 -1
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)return -ENODEV ;/* Open session with Bnxt load Trusted App */ -memcpy (sess_arg.uuid, bnxt_device->id.uuid.b,TEE_IOCTL_UUID_LEN ); +export_uuid (sess_arg.uuid, &bnxt_device->id.uuid); sess_arg.clnt_login =TEE_IOCTL_LOGIN_PUBLIC ; sess_arg.num_params =0 ;
Signature · 1 line
2.29.2
Quoted 2 lines · Andy Shevchenko
There is
export_uuid()function which exportsuuid_tto the u8 array. Use it instead of open coding variant.
Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? If not, why review is not done yes for more than half a year?
Signature · 2 lines
With Best Regards, Andy Shevchenko
+ Cc: Christoph. Maybe you can apply this one, please?
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
There is
export_uuid()function which exportsuuid_tto the u8 array. Use it instead of open coding variant.Folks, is this orphaned driver? Should we update
MAINTAINERSaccordingly? If not, why review is not done yes for more than half a year?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 1 line · Andy Shevchenko
+ Cc: Christoph. Maybe you can apply this one, please?
I've not even seen the original patch.
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Andy Shevchenko
+ Cc: Christoph. Maybe you can apply this one, please?
I've not even seen the original patch.
It's easy to retrieve with b4 tool:b4 am -s [email protected]
But for your convenience I may resend once more with you being Cc'ed.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Andy Shevchenko
+ Cc: Christoph. Maybe you can apply this one, please?
I've not even seen the original patch.
It's easy to retrieve with b4 tool:
b4 am -s [email protected]But for your convenience I may resend once more with you being Cc'ed.
Just sent a v2 which is basically the same :-)
Signature · 2 lines
With Best Regards, Andy Shevchenko