usb: typec: tcpci_maxim: remove redundant assignment
Subsystems (2)
PATCH v2 1/1 usb: typec: tcpci_maxim: remove redundant assignment
From: Junlin Yang <[email protected]>
PTR_ERR(chip->tcpci) has been used as a return value, it is not necessary to assign it to ret, so remove it. And add terminating '\n' to the formats where missed too.
Signed-off-by Junlin Yang <[email protected]>
---
v2: add terminating '\n' to the formats where missed too.
drivers/usb/typec/tcpm/tcpci_maxim.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/usb/typec/tcpm/tcpci_maxim.c +6 -7
@@ -158,7 +158,7 @@ static void process_rx(struct max_tcpci_chip *chip, u16 status)*/ ret =regmap_raw_read (chip->data.regmap,TCPC_RX_BYTE_CNT , rx_buf,2 );if (ret <0 ) { -dev_err (chip->dev,"TCPC_RX_BYTE_CNT read failed ret:%d" , ret); +dev_err (chip->dev,"TCPC_RX_BYTE_CNT read failed ret:%d\n" , ret);return ; }
@@ -167,13 +167,13 @@ static void process_rx(struct max_tcpci_chip *chip, u16 status)if (count ==0 || frame_type !=TCPC_RX_BUF_FRAME_TYPE_SOP ) {max_tcpci_write16 (chip,TCPC_ALERT ,TCPC_ALERT_RX_STATUS ); -dev_err (chip->dev,"%s" , count ==0 ?"error: count is 0" : +dev_err (chip->dev,"%s\n" , count ==0 ?"error: count is 0" :"error frame_type is not SOP" );return ; }if (count >sizeof (struct pd_message ) || count +1 >TCPC_RECEIVE_BUFFER_LEN ) { -dev_err (chip->dev,"Invalid TCPC_RX_BYTE_CNT %d" , count); +dev_err (chip->dev,"Invalid TCPC_RX_BYTE_CNT %d\n" , count);return ; }
@@ -184,7 +184,7 @@ static void process_rx(struct max_tcpci_chip *chip, u16 status) count +=1 ; ret =regmap_raw_read (chip->data.regmap,TCPC_RX_BYTE_CNT , rx_buf, count);if (ret <0 ) { -dev_err (chip->dev,"Error: TCPC_RX_BYTE_CNT read failed: %d" , ret); +dev_err (chip->dev,"Error: TCPC_RX_BYTE_CNT read failed: %d\n" , ret);return ; }
@@ -317,7 +317,7 @@ static irqreturn_t _max_tcpci_irq(struct max_tcpci_chip *chip, u16 status)return ret;if (reg_status &TCPC_SINK_FAST_ROLE_SWAP ) { -dev_info (chip->dev,"FRS Signal" ); +dev_info (chip->dev,"FRS Signal\n" );tcpm_sink_frs (chip->port); } }
@@ -460,8 +460,7 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_idmax_tcpci_init_regs (chip); chip->tcpci =tcpci_register_port (chip->dev, &chip->data);if (IS_ERR (chip->tcpci)) { -dev_err (&client->dev,"TCPCI port registration failed" ); - ret =PTR_ERR (chip->tcpci); +dev_err (&client->dev,"TCPCI port registration failed\n" );return PTR_ERR (chip->tcpci); } chip->port =tcpci_get_tcpm_port (chip->tcpci);
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 9 lines · angkery
From: Junlin Yang <[email protected]>
PTR_ERR(chip->tcpci)has been used as a return value, it is not necessary to assign it to ret, so remove it. And add terminating '\n' to the formats where missed too.Signed-off-by Junlin Yang <[email protected]>---
v2: add terminating '\n' to the formats where missed too.
Don't mix different things in the same patch, this should be a patch series of 2 patches.
thanks,
greg k-h