usb: typec: tcpci_maxim: remove redundant assignment
Subsystems (2)
PATCH v3 1/2 usb: typec: tcpci_maxim: remove redundant assignment
From: Junlin Yang <[email protected]>
PTR_ERR(chip->tcpci) has been used as a return value, it is not necessary to assign it to ret, so remove it.
Signed-off-by Junlin Yang <[email protected]>
---
v3:remove the newline modification.
drivers/usb/typec/tcpm/tcpci_maxim.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/typec/tcpm/tcpci_maxim.c +0 -1
@@ -461,7 +461,6 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id chip->tcpci =tcpci_register_port (chip->dev, &chip->data);if (IS_ERR (chip->tcpci)) {dev_err (&client->dev,"TCPCI port registration failed" ); - ret =PTR_ERR (chip->tcpci);return PTR_ERR (chip->tcpci); } chip->port =tcpci_get_tcpm_port (chip->tcpci);
Signature · 1 line
1.9.1
Quoted 6 lines · angkery
From: Junlin Yang <[email protected]>
PTR_ERR(chip->tcpci)has been used as a return value, it is not necessary to assign it to ret, so remove it.Signed-off-by Junlin Yang <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 21 lines
---
v3:remove the newline modification.drivers/usb/typec/tcpm/tcpci_maxim.c | 1 - 1 file changed, 1 deletion(-)drivers/usb/typec/tcpm/tcpci_maxim.c +0
-1@@ -461,7 +461,6 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id chip->tcpci =tcpci_register_port (chip->dev, &chip->data);if (IS_ERR (chip->tcpci)) {dev_err (&client->dev,"TCPCI port registration failed" ); - ret =PTR_ERR (chip->tcpci);return PTR_ERR (chip->tcpci); } chip->port =tcpci_get_tcpm_port (chip->tcpci);Signature · 1 line
1.9.1
Quoted 6 lines · angkery
From: Junlin Yang <[email protected]>
PTR_ERR(chip->tcpci)has been used as a return value, it is not necessary to assign it to ret, so remove it.Signed-off-by Junlin Yang <[email protected]>
Reviewed-by Heikki Krogerus <[email protected]>
Quoted 20 lines
---
v3:remove the newline modification.drivers/usb/typec/tcpm/tcpci_maxim.c | 1 - 1 file changed, 1 deletion(-)drivers/usb/typec/tcpm/tcpci_maxim.c +0
-1@@ -461,7 +461,6 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id chip->tcpci =tcpci_register_port (chip->dev, &chip->data);if (IS_ERR (chip->tcpci)) {dev_err (&client->dev,"TCPCI port registration failed" ); - ret =PTR_ERR (chip->tcpci);return PTR_ERR (chip->tcpci); } chip->port =tcpci_get_tcpm_port (chip->tcpci);Signature · 1 line
1.9.1
thanks,
Signature · 1 line
heikki