meson: Try to clarify TCG / TCI options for new users
v4 cover meson: Try to clarify TCG / TCI options for new users
Since v3:
- Rebased
- Include fix for 23a77b2d18b ("build-system: clean up TCG/TCI configury")
- Use get_option() (Claudio)
- Use warning message suggested by Daniel
- Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo)
Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available.
Note, before Meson, warnings were summarized at the end of ./configure. Now they are displayed earlier, and likely missed IMHO. No clue how to improve that :/
Philippe Mathieu-Daudé (3):
configure: Improve TCI feature description
meson: Explicit TCG backend used
meson: Warn when TCI is selected but TCG backend is available
Richard Henderson (1):
configure: Fix --enable-tcg-interpreter
configure | 7 ++++--- meson.build | 15 +++++++++++++-- 2 files changed, 17 insertions(+), 5 deletions(-)
Signature · 1 line
2.26.2
PATCH v4 1/4 configure: Fix --enable-tcg-interpreter
From: Richard Henderson <[email protected]>
The configure option was backward, and we failed to pass the value on to meson.
Message-Id: <[email protected]>
--- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
configure +3 -2
@@ -1119,9 +1119,9 @@ for opt do ;; --enable-whpx) whpx="enabled" ;; - --disable-tcg-interpreter) tcg_interpreter="true" + --disable-tcg-interpreter) tcg_interpreter="false" ;; - --enable-tcg-interpreter) tcg_interpreter="false" + --enable-tcg-interpreter) tcg_interpreter="true" ;; --disable-cap-ng) cap_ng="disabled" ;;
@@ -6361,6 +6361,7 @@ NINJA=$ninja $meson setup \ -Dmalloc=$malloc -Dmalloc_trim=$malloc_trim -Dsparse=$sparse \ -Dkvm=$kvm -Dhax=$hax -Dwhpx=$whpx -Dhvf=$hvf \ -Dxen=$xen -Dxen_pci_passthrough=$xen_pci_passthrough -Dtcg=$tcg \ + -Dtcg_interpreter=$tcg_interpreter \ -Dcocoa=$cocoa -Dgtk=$gtk -Dmpath=$mpath -Dsdl=$sdl -Dsdl_image=$sdl_image \ -Dvnc=$vnc -Dvnc_sasl=$vnc_sasl -Dvnc_jpeg=$vnc_jpeg -Dvnc_png=$vnc_png \ -Dgettext=$gettext -Dxkbcommon=$xkbcommon -Du2f=$u2f -Dvirtiofsd=$virtiofsd \
Signature · 1 line
2.26.2
Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter
Quoted 32 lines · Philippe Mathieu-Daudé
From: Richard Henderson <[email protected]>
The configure option was backward, and we failed to pass the value on to meson.
Fixes 23a77b2d18b ("build-system: clean up TCG/TCI configury")Signed-off-by Richard Henderson <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Message-Id: <[email protected]>
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)configure +2
-2@@ -1119,9 +1119,9 @@ for opt do ;; --enable-whpx) whpx="enabled" ;; - --disable-tcg-interpreter) tcg_interpreter="true" + --disable-tcg-interpreter) tcg_interpreter="false" ;; - --enable-tcg-interpreter) tcg_interpreter="false" + --enable-tcg-interpreter) tcg_interpreter="true" ;; --disable-cap-ng) cap_ng="disabled" ;;
configure NINJA=$ninja $meson setup \ · line 6367
Quoted 7 lines
configure +1
-0@@ -6361,6 +6361,7 @@ NINJA=$ninja $meson setup \ -Dmalloc=$malloc -Dmalloc_trim=$malloc_trim -Dsparse=$sparse \ -Dkvm=$kvm -Dhax=$hax -Dwhpx=$whpx -Dhvf=$hvf \ -Dxen=$xen -Dxen_pci_passthrough=$xen_pci_passthrough -Dtcg=$tcg \ + -Dtcg_interpreter=$tcg_interpreter \ -Dcocoa=$cocoa -Dgtk=$gtk -Dmpath=$mpath -Dsdl=$sdl -Dsdl_image=$sdl_image \ -Dvnc=$vnc -Dvnc_sasl=$vnc_sasl -Dvnc_jpeg=$vnc_jpeg -Dvnc_png=$vnc_png \ -Dgettext=$gettext -Dxkbcommon=$xkbcommon -Du2f=$u2f -Dvirtiofsd=$virtiofsd \
Too bad, sorry.
There were two things to do when rebasing before the "automatic command line parsing" patch, and I messed up both of them.
Paolo
Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter
In reply to Philippe Mathieu-DaudéQuoted 5 lines · Philippe Mathieu-Daudé
From: Richard Henderson <[email protected]>
The configure option was backward, and we failed to pass the value on to meson.
Quoted 8 lines
Fixes 23a77b2d18b ("build-system: clean up TCG/TCI configury")Signed-off-by Richard Henderson <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Message-Id: <[email protected]>
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter
In reply to Philippe Mathieu-DaudéAm 25.01.21 um 15:45 schrieb Philippe Mathieu-Daudé:
Quoted 5 lines
From: Richard Henderson <[email protected]>
The configure option was backward, and we failed to pass the value on to meson.
Quoted 8 lines
Fixes 23a77b2d18b ("build-system: clean up TCG/TCI configury")Signed-off-by Richard Henderson <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Message-Id: <[email protected]>
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks,
Stefan
PATCH v4 2/4 configure: Improve TCI feature description
In reply to Philippe Mathieu-DaudéUsers might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly.
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
@@ -1748,7 +1748,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace-<pid> --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI) + --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu]
Signature · 1 line
2.26.2
Re: [PATCH v4 2/4] configure: Improve TCI feature description
Quoted 9 lines · Philippe Mathieu-Daudé
Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly.
Suggested-by Thomas Huth <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
PATCH v4 3/4 meson: Explicit TCG backend used
In reply to Philippe Mathieu-Daudé--- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
meson.build +6 -2
@@ -224,7 +224,7 @@ if not get_option('tcg').disabled() if cpu not in supported_cpus if get_option('tcg_interpreter') - warning('Unsupported CPU @0@, will use TCG with TCI (experimental)'.format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (experimental and slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif
@@ -2447,8 +2447,12 @@ endif summary_info += {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') + if get_option('tcg_interpreter') + summary_info += {'TCG backend': 'TCI (TCG with bytecode interpreter, experimental and slow)'} + else + summary_info += {'TCG backend': 'native (@0@)'.format(cpu)} + endif summary_info += {'TCG debug enabled': config_host.has_key('CONFIG_DEBUG_TCG')} - summary_info += {'TCG interpreter': tcg_arch == 'tci'} endif summary_info += {'target list': ' '.join(target_dirs)} if have_system
Signature · 1 line
2.26.2
Re: [PATCH v4 3/4] meson: Explicit TCG backend used
Quoted 6 lines · Philippe Mathieu-Daudé
Reviewed-by Thomas Huth <[email protected]>Reviewed-by Stefan Weil <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
PATCH v4 4/4 meson: Warn when TCI is selected but TCG backend is available
In reply to Philippe Mathieu-DaudéSome new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG.
Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration.
--- meson.build | 7 +++++++ 1 file changed, 7 insertions(+)
meson.build +7 -0
@@ -228,6 +228,13 @@ else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif + elif get_option('tcg_interpreter') + warning('Use of the TCG interpretor is not recommended on this host') + warning('architecture. There is a native TCG execution backend available') + warning('which provides substantially better performance and reliability.') + warning('It is strongly recommended to remove the --enable-tcg-interpreter') + warning('configuration option on this architecture to use the native') + warning('backend.') endif if get_option('tcg_interpreter') tcg_arch = 'tci'
Signature · 1 line
2.26.2
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 6 lines · Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG.
Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration.
Quoted 7 lines
Reviewed-by Stefan Weil <[email protected]>Reviewed-by Thomas Huth <[email protected]>Suggested-by Daniel Berrangé <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- meson.build | 7 +++++++ 1 file changed, 7 insertions(+)
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
In reply to Philippe Mathieu-DaudéQuoted 8 lines · Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG.
Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration.
Reviewed-by Stefan Weil <[email protected]>Reviewed-by Thomas Huth <[email protected]>
Nitpick, the text printed is completely rewritten from what they reviewed, so I would probably have dropped their R-b for that scenario.
Quoted 27 lines
Suggested-by Daniel Berrangé <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- meson.build | 7 +++++++ 1 file changed, 7 insertions(+)meson.build +7
-0@@ -228,6 +228,13 @@ else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif + elif get_option('tcg_interpreter') + warning('Use of the TCG interpretor is not recommended on this host') + warning('architecture. There is a native TCG execution backend available') + warning('which provides substantially better performance and reliability.') + warning('It is strongly recommended to remove the --enable-tcg-interpreter') + warning('configuration option on this architecture to use the native') + warning('backend.') endif if get_option('tcg_interpreter') tcg_arch = 'tci'Signature · 1 line
2.26.2
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 7 lines · Daniel P. Berrangé
Quoted 6 lines · Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG.
Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration.
Quoted 6 lines
Quoted 2 lines
Reviewed-by Stefan Weil <[email protected]>Reviewed-by Thomas Huth <[email protected]>Nitpick, the text printed is completely rewritten from what they reviewed, so I would probably have dropped their R-b for that scenario.
I thought about it, and assumed their review tag was for the logical change of adding a warning, not particularly the warning content.
I agree this it would have been better to ask them to review again. Next time I will reset the tags.
Quoted 31 lines
Quoted 27 lines
Suggested-by Daniel Berrangé <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- meson.build | 7 +++++++ 1 file changed, 7 insertions(+)meson.build +7
-0@@ -228,6 +228,13 @@ else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif + elif get_option('tcg_interpreter') + warning('Use of the TCG interpretor is not recommended on this host') + warning('architecture. There is a native TCG execution backend available') + warning('which provides substantially better performance and reliability.') + warning('It is strongly recommended to remove the --enable-tcg-interpreter') + warning('configuration option on this architecture to use the native') + warning('backend.') endif if get_option('tcg_interpreter') tcg_arch = 'tci'Signature · 1 line
2.26.2Regards,
Daniel
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 25.01.21 um 18:05 schrieb Philippe Mathieu-Daudé:
Quoted 10 lines · Daniel P. Berrangé
Quoted 9 lines · Philippe Mathieu-Daudé
Quoted 8 lines
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG.
Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration.
Reviewed-by Stefan Weil <[email protected]>Reviewed-by Thomas Huth <[email protected]>
Quoted 8 lines
Quoted 3 lines
Nitpick, the text printed is completely rewritten from what they reviewed, so I would probably have dropped their R-b for that scenario.
I thought about it, and assumed their review tag was for the logical change of adding a warning, not particularly the warning content.
I agree this it would have been better to ask them to review again. Next time I will reset the tags.
You are right, I would not have signed that new text and either used the original text (which was sufficient in my opinion) or used a different one:
Use of the TCG interpretor is not recommended on this host architecture for most users because there is a native TCG execution backend available which provides substantially better performance.
I have no evidence that TCI is less reliable than TCG, so I would not write that.
And there are people who have good reasons to use TCI. So why should I recommend them to stop that?
Stefan
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Suggested-by Daniel Berrangé <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- meson.build | 7 +++++++ 1 file changed, 7 insertions(+)meson.build +7
-0@@ -228,6 +228,13 @@ else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif + elif get_option('tcg_interpreter') + warning('Use of the TCG interpretor is not recommended on this host') + warning('architecture. There is a native TCG execution backend available') + warning('which provides substantially better performance and reliability.') + warning('It is strongly recommended to remove the --enable-tcg-interpreter') + warning('configuration option on this architecture to use the native') + warning('backend.')
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 1 line · Stefan Weil
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
r~
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 25.01.21 um 20:02 schrieb Richard Henderson:
Quoted 3 lines · Stefan Weil
Quoted 1 line
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
Where does it fail? Maybe an expected timeout problem which can be solved by increasing the timeouts for TCI?
I have just run a local test of make check-tcg with native TCG and with TCI and did not see a difference. But I noticed that in both cases many tests show "skipped".
Stefan
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 8 lines · Stefan Weil
Am 25.01.21 um 20:02 schrieb Richard Henderson:
Quoted 4 lines · Stefan Weil
Quoted 2 lines
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
Quoted 6 lines
Where does it fail? Maybe an expected timeout problem which can be solved by increasing the timeouts for TCI?
I have just run a local test of
make check-tcgwith native TCG and with TCI and did not see a difference. But I noticed that in both cases many tests show "skipped".
You need to enable docker or podman for your development, so that you get all of the cross-compilers.
Then:
TEST fcvt on arm
TODO ../qemu/tcg/tci.c:614: tcg_qemu_tb_exec() ../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
TEST float_convs on m68k
TODO ../qemu/tcg/tci.c:614: tcg_qemu_tb_exec() ../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
which is of course one of the TODO assertions. It's positively criminal those still exist in the code.
r~
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 25.01.21 um 23:35 schrieb Richard Henderson:
Quoted 22 lines · Stefan Weil
Quoted 11 lines
Am 25.01.21 um 20:02 schrieb Richard Henderson:
Quoted 4 lines · Stefan Weil
Quoted 2 lines
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
Where does it fail? Maybe an expected timeout problem which can be solved by increasing the timeouts for TCI?
I have just run a local test of
make check-tcgwith native TCG and with TCI and did not see a difference. But I noticed that in both cases many tests show "skipped".You need to enable docker or podman for your development, so that you get all of the cross-compilers.
Then:
TEST fcvt on arm
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Quoted 7 lines
TEST
float_convson m68k
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumpedwhich is of course one of the TODO assertions. It's positively criminal those still exist in the code.
I installed podman and repeated make check-tcg. The log file still shows 87 lines with "SKIPPED". There is also a gdb core dump, several warnings, but nothing related to TCI. Both tests cited above seem to work without a problem.
The complete log file is available from https://qemu.weilnetz.de/test/check-tcg.txt.
Daniel, regarding your comment: TCI has 100 % test coverage for the productive code lines. All code lines which were never tested raise an assertion, so can easily be identified (and fixed as soon as there is a test case which triggers such an assertion). The known deficits are speed, missing TCG opcodes, unimplemented TCG opcodes because of missing test cases and missing support for some host architectures.
Stefan
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 28 lines · Stefan Weil
Am 25.01.21 um 23:35 schrieb Richard Henderson:
Quoted 27 lines · Stefan Weil
Quoted 11 lines
Am 25.01.21 um 20:02 schrieb Richard Henderson:
Quoted 4 lines · Stefan Weil
Quoted 2 lines
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
Where does it fail? Maybe an expected timeout problem which can be solved by increasing the timeouts for TCI?
I have just run a local test of
make check-tcgwith native TCG and with TCI and did not see a difference. But I noticed that in both cases many tests show "skipped".You need to enable docker or podman for your development, so that you get all of the cross-compilers.
Then:
TEST fcvt on arm
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumpedTEST
float_convson m68k
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Quoted 8 lines
Quoted 2 lines
which is of course one of the TODO assertions. It's positively criminal those still exist in the code.
I installed podman and repeated
make check-tcg. The log file still shows 87 lines with "SKIPPED". There is also a gdb core dump, several warnings, but nothing related to TCI. Both tests cited above seem to work without a problem.
I'm going to go out on a limb and guess you have commit:
23a77b2d18 (build-system: clean up TCG/TCI configury)
which temporarily has the effect of disabling TCI. See
Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter From: Paolo Bonzini <[email protected]> Message-ID: <[email protected]> Date: Mon, 25 Jan 2021 17:36:42 +0100
with that fix fixed I see the same failures as Richard:
./qemu-arm ./tests/tcg/arm-linux-user/fcvt > /dev/null
TODO ../../tcg/tci.c:614: tcg_qemu_tb_exec()
../../tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
fish: “./qemu-arm ./tests/tcg/arm-linu…” terminated by signal SIGSEGV (Address boundary error)
which does raise the question before today when was the last time anyone attempted to run check-tcg on this?
Quoted 5 lines
The complete log file is available from
https://qemu.weilnetz.de/test/check-tcg.txt.Daniel, regarding your comment: TCI has 100 % test coverage for the productive code lines.
By what tests? The fact you don't hit asserts in your day to day testing doesn't mean there are features missing that are easily tripped up or that TCI got it right.
Quoted 5 lines
All code lines which were never tested raise an
assertion, so can easily be identified (and fixed as soon as there is a test case which triggers such an assertion). The known deficits are speed, missing TCG opcodes, unimplemented TCG opcodes because of missing test cases and missing support for some host architectures.
Passing check-tcg would be a minimum for me.
Signature · 1 line
Alex Bennée
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 26.01.21 um 18:24 schrieb Alex Bennée:
Quoted 13 lines
I'm going to go out on a limb and guess you have commit:
23a77b2d18(build-system: clean up TCG/TCI configury)which temporarily has the effect of disabling TCI. See
Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter From: Paolo Bonzini <[email protected]> Message-ID: <[email protected]> Date: Mon, 25 Jan 2021 17:36:42 +0100with that fix fixed I see the same failures as Richard:
Quoted 8 lines
./qemu-arm ./tests/tcg/arm-linux-user/fcvt >
/dev/null
TODO../../tcg/tci.c:614:tcg_qemu_tb_exec()
../../tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
fish: “./qemu-arm ./tests/tcg/arm-linu…” terminated by signal SIGSEGV (Address boundary error)which does raise the question before today when was the last time anyone attempted to run check-tcg on this?
Yes, I tested with latest git master and did not notice that --enable-tcg-interpreter was broken.
Paolo's patch fixed that.I could reproduce the fatal assertions which were all caused by the same missing TCG opcode implementation.
I have sent a trivial patch which adds that implementation and fixes all segmentation faults.
Quoted 5 lines
Quoted 2 lines
Daniel, regarding your comment: TCI has 100 % test coverage for the productive code lines.
By what tests? The fact you don't hit asserts in your day to day testing doesn't mean there are features missing that are easily tripped up or that TCI got it right.
I was not talking about the TODO assertions. When I wrote TCI, I only enabled and included code which was triggered by my testing - that's why I said the productive code lines have 100 % test coverage. TODO assertions are not productive code, but debug code which were made to detect new test cases. They were successful, too, because they were triggered by some tests in make check-tcg.
Quoted 5 lines
Quoted 5 lines
All code lines which were never tested raise an
assertion, so can easily be identified (and fixed as soon as there is a test case which triggers such an assertion). The known deficits are speed, missing TCG opcodes, unimplemented TCG opcodes because of missing test cases and missing support for some host architectures.
As soon as I was aware of the new test cases, adding the missing TCG opcode implementation was not difficult.
Quoted 1 line
Passing check-tcg would be a minimum for me.
It should pass now unless you get timeouts for some tests. Please tell me if more TODO assertions are triggered by new tests.
Stefan
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 5 lines · Stefan Weil
Yes, I tested with latest git master and did not notice that --enable-tcg-interpreter was broken.
Paolo's patch fixed that.I could reproduce the fatal assertions which were all caused by the same missing TCG opcode implementation.
My patch _broke_ that. Richard fixed it.
Paolo
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 26.01.21 um 21:07 schrieb Paolo Bonzini:
Quoted 10 lines · Stefan Weil
Quoted 5 lines
Yes, I tested with latest git master and did not notice that --enable-tcg-interpreter was broken.
Paolo's patch fixed that.I could reproduce the fatal assertions which were all caused by the same missing TCG opcode implementation.
My patch _broke_ that. Richard fixed it.
Paolo
Sorry for the confusion in my e-mail. Yes, you are right.
Stefan
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
In reply to Stefan WeilQuoted 6 lines · Stefan Weil
I was not talking about the TODO assertions. When I wrote TCI, I only enabled and included code which was triggered by my testing - that's why I said the productive code lines have 100 % test coverage. TODO assertions are not productive code, but debug code which were made to detect new test cases. They were successful, too, because they were triggered by some tests in
make check-tcg.
The TODO assertions are all bugs.
Any *real* dead code detection should have been done in tcg/tci/tcg-target.c.inc. What's interpreted in tcg/tci.c should be exactly what is produced on the other side, and you are producing more than you are consuming.
Quoted 2 lines
It should pass now unless you get timeouts for some tests. Please tell me if more TODO assertions are triggered by new tests.
case INDEX_op_ld8s_i32:
TODO();
break;Can be triggered by
target/arm/translate-a64.c:1061:
tcg_gen_ld8s_i64(tcg_dest, cpu_env, vect_off);
target/arm/translate-a64.c:1090:
tcg_gen_ld8s_i32(tcg_dest, cpu_env, vect_off);
target/arm/translate.c:1210:
tcg_gen_ld8s_i32(dest, cpu_env, off);target/s390x/translate_vx.c.inc:81:
tcg_gen_ld8s_i64(dst, cpu_env, offs);
target/s390x/translate_vx.c.inc:111:
tcg_gen_ld8s_i32(dst, cpu_env, offs);
case INDEX_op_ld16s_i32:
TODO();
break;Can be triggered by
target/arm/translate-a64.c:1064:
tcg_gen_ld16s_i64(tcg_dest, cpu_env, vect_off);
target/arm/translate-a64.c:1093:
tcg_gen_ld16s_i32(tcg_dest, cpu_env, vect_off);
target/arm/translate.c:1216:
tcg_gen_ld16s_i32(dest, cpu_env, off);
target/s390x/translate_vx.c.inc:84:
tcg_gen_ld16s_i64(dst, cpu_env, offs);
target/s390x/translate_vx.c.inc:114:
tcg_gen_ld16s_i32(dst, cpu_env, offs);All of which are target vector instructions.
I'm sure it would be trivial to whip up test cases for them, but I don't see that as my job.
Please maintain this code properly or give it up.
r~
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 26.01.21 um 23:39 schrieb Richard Henderson:
Quoted 7 lines · Stefan Weil
Quoted 6 lines
I was not talking about the TODO assertions. When I wrote TCI, I only enabled and included code which was triggered by my testing - that's why I said the productive code lines have 100 % test coverage. TODO assertions are not productive code, but debug code which were made to detect new test cases. They were successful, too, because they were triggered by some tests in
make check-tcg.
Quoted 6 lines
The TODO assertions are all bugs.
Any *real* dead code detection should have been done in tcg/tci/tcg-target.c.inc. What's interpreted in
tcg/tci.cshould be exactly what is produced on the other side, and you are producing more than you are consuming.
Unless the TCG opcodes in tcg/tci/tcg-target.c.inc are used in real-live scenarios, they are dead code, too.
Writing a test case which produces them directly (not for some real architecture) is not a real-live scenario.
And the remaining TODO assertions are a good indicator that the current tests are incomplete for native TCG because they obviously don't cover all TCG opcodes.
Stefan
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 2 lines · Stefan Weil
And the remaining TODO assertions are a good indicator that the current tests are incomplete for native TCG because they obviously don't cover all TCG opcodes.
If the symbol appears in target/, then the opcode can be produced. I've just shown you how for 2 of them, via 2 different target architectures.
r~
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
In reply to Stefan WeilQuoted 11 lines · Stefan Weil
Am 26.01.21 um 23:39 schrieb Richard Henderson:
Quoted 9 lines · Stefan Weil
Quoted 6 lines
I was not talking about the TODO assertions. When I wrote TCI, I only enabled and included code which was triggered by my testing - that's why I said the productive code lines have 100 % test coverage. TODO assertions are not productive code, but debug code which were made to detect new test cases. They were successful, too, because they were triggered by some tests in
make check-tcg.The TODO assertions are all bugs.
Quoted 8 lines
Quoted 4 lines
Any *real* dead code detection should have been done in tcg/tci/tcg-target.c.inc. What's interpreted in
tcg/tci.cshould be exactly what is produced on the other side, and you are producing more than you are consuming.Unless the TCG opcodes in tcg/tci/tcg-target.c.inc are used in real-live scenarios, they are dead code, too.
For example - debian-buster (arm64) running ffmpeg:
alex.bennee@8cd150a4b35d:~/lsrc/qemu.git/builds/all.tci$ ./qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm TODO ../../tcg/tci.c:882: tcg_qemu_tb_exec() ../../tcg/tci.c:882: tcg fatal error qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped)
Quoted 6 lines
Writing a test case which produces them directly (not for some real architecture) is not a real-live scenario.
And the remaining TODO assertions are a good indicator that the current tests are incomplete for native TCG because they obviously don't cover all TCG opcodes.
That's because check-tcg isn't a comprehensive test suite and expecting it to be misses the point of it. It was added to make it easy to add new test cases and remove some of the burden off maintainers having their own zoo of test binaries. It has slowly grown as directed test cases were written while bug hunting and sometimes when new features where added. It will never be a comprehensive exercising of the CPU emulation although some architectures have more coverage than others. For example MIPs has a bunch of ISA level tests as part of check-tcg but most of the ARM ISA validation is done externally using the RISU random instruction testing tool.
Besides you've just argued writing a test case that targets missing functionality in TCI would somehow be cheating as it's not a "real-live" scenario.
I don't mind either way - the fact that TCI is useful to people is cool and more power to them. But lets not pretend it is a fully functional and maintained backend because it has obviously got some major holes. If it ends up being a drag on efforts to maintain and improve the TCG then we have to question why we are keeping it in. Being able to run emulation on esoteric hardware without a real backend is a party trick at best. The other use-cases that have been mentioned could be solved with investing some effort in the rest of the TCG code.
Signature · 1 line
Alex Bennée
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 27.01.21 um 20:52 schrieb Alex Bennée:
Quoted 7 lines
For example - debian-buster (arm64) running ffmpeg:
alex.bennee@8cd150a4b35d:~/lsrc/qemu.git/builds/all.tci$ ./qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm TODO ../../tcg/tci.c:882: tcg_qemu_tb_exec() ../../tcg/tci.c:882: tcg fatal error qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped)
Thanks. All I tried to say is that I prefer to replace those TODO statements by working code as soon as there was a case which triggers them. Most of those TODO statements are very easy to implement, so anyone can add them when he/she detects a missing one. If I get information about a scenario which triggers a missing TODO, I'll fix that of course. I just don't want to add that missing code blindly.
Using make check-tcg helped finding and fixing one of them, future improved CI checks can find more, and so can examples like the one above. The error message tci.c:882 is INDEX_op_ld8s_i64 (https://github.com/qemu/qemu/blob/master/tcg/tci.c#L882). The missing code is nearly identical to the existing code for INDEX_op_ld8u_i64, but with *(int8_t *) instead of *(uint8_t *), so maybe you can try that and confirm whether it fixes the reported problem. Otherwise I'll try to reproduce it with any mkv file.
I recently tried running tesseract with qemu-x86_64 because I had expected that it might trigger some unimplemented TCG opcodes. Instead it showed a general problem for native TCG: qemu-x86_64 allocates too much memory for tesseract and gets killed by the Linux kernel OOM handler.
Regards,
Stefan
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 11 lines · Stefan Weil
Am 27.01.21 um 20:52 schrieb Alex Bennée:
Quoted 7 lines
For example - debian-buster (arm64) running ffmpeg:
alex.bennee@8cd150a4b35d:~/lsrc/qemu.git/builds/all.tci$ ./qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm TODO ../../tcg/tci.c:882: tcg_qemu_tb_exec() ../../tcg/tci.c:882: tcg fatal error qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped)
Quoted 6 lines
Thanks. All I tried to say is that I prefer to replace those TODO statements by working code as soon as there was a case which triggers them. Most of those TODO statements are very easy to implement, so anyone can add them when he/she detects a missing one. If I get information about a scenario which triggers a missing TODO, I'll fix that of course. I just don't want to add that missing code blindly.
Your just going to end up playing wack-a-mole:
TODO ../../tcg/tci.c:620: tcg_qemu_tb_exec()me=00:00:00.00 bitrate=N/A speed= 0x
../../tcg/tci.c:620: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped)
Quoted 8 lines
Using
make check-tcghelped finding and fixing one of them, future improved CI checks can find more, and so can examples like the one above. The error message tci.c:882 isINDEX_op_ld8s_i64
(https://github.com/qemu/qemu/blob/master/tcg/tci.c#L882). The missing code is nearly identical to the existing code forINDEX_op_ld8u_i64, but with *(int8_t *) instead of *(uint8_t *), so maybe you can try that and confirm whether it fixes the reported problem. Otherwise I'll try to reproduce it with any mkv file.
ffmpeg is a good application for working out the SIMD code because it features quite a lot of optimised code for each architecture.
Quoted 2 lines
I recently tried running tesseract with qemu-x86_64 because I had expected that it might trigger some unimplemented TCG opcodes.
qemu-x86-64 is a poor choice as a relatively under maintained front-end doesn't emulate a particularly new CPU or take advantage of the new TCG features. ARM64 is pretty good because the default cpu for linux-user is CPU max which a) enables all ISA features we have and b) exposes them fairly easily to guest detection routines which probe feature registers.
Quoted 4 lines
Instead
it showed a general problem for native TCG: qemu-x86_64 allocates too much memory for tesseract and gets killed by the Linux kernel OOM handler.
Do you have a command line? That sounds like something that should be fixed.
Quoted 4 lines
Regards,
Stefan
Signature · 1 line
Alex Bennée
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Am 27.01.21 um 22:47 schrieb Alex Bennée:
Quoted 6 lines
Your just going to end up playing wack-a-mole:
TODO
../../tcg/tci.c:620: tcg_qemu_tb_exec()me=00:00:00.00 bitrate=N/A speed= 0x
../../tcg/tci.c:620: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped)
That's INDEX_op_ld16s_i32. Only five levels left in the play as soon as that is implemented, too.
Thanks,
Stefan
qemu user mode fails to run programs with large VM / built with address sanitizer (was: Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available)
In reply to Alex BennéeAm 27.01.21 um 22:47 schrieb Alex Bennée:
Quoted 9 lines
Quoted 2 lines · Stefan Weil
I recently tried running tesseract with qemu-x86_64 because I had expected that it might trigger some unimplemented TCG opcodes.
qemu-x86-64 is a poor choice as a relatively under maintained front-end doesn't emulate a particularly new CPU or take advantage of the new TCG features. ARM64 is pretty good because the default cpu for linux-user is CPU max which a) enables all ISA features we have and b) exposes them fairly easily to guest detection routines which probe feature registers.
Quoted 6 lines
Quoted 4 lines
Instead
it showed a general problem for native TCG: qemu-x86_64 allocates too much memory for tesseract and gets killed by the Linux kernel OOM handler.Do you have a command line? That sounds like something that should be fixed.
The problem occurred with a locally built tesseract, but I now found that it is more general.
Any program which was compiled with address sanitizer uses huge virtual memory (TB) right at the start. QEMU user mode tries to allocate that memory until it is killed by the Linux kernel OOM handler.
A simple hello program compiled with "gcc -fsanitize=address hello.c" is sufficient to show the problem. Just run it with "qemu-x86_64 a.out".
I did not test but expect the same problem for other architectures, too, unless their VM is more limited.
Regards,
Stefan
Re: qemu user mode fails to run programs with large VM / built with address sanitizer (was: Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available)
Quoted 6 lines · Stefan Weil
The problem occurred with a locally built tesseract, but I now found that it is more general.
Any program which was compiled with address sanitizer uses huge virtual memory (TB) right at the start. QEMU user mode tries to allocate that memory until it is killed by the Linux kernel OOM handler.
Yes, we have an open bug for that. It is not a trivial problem.
https://bugs.launchpad.net/qemu/+bug/1898011
r~
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
In reply to Alex BennéeQuoted 72 lines · Alex Bennée
Quoted 28 lines · Stefan Weil
Am 25.01.21 um 23:35 schrieb Richard Henderson:
Quoted 27 lines · Stefan Weil
Quoted 11 lines
Am 25.01.21 um 20:02 schrieb Richard Henderson:
Quoted 4 lines · Stefan Weil
Quoted 2 lines
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
Where does it fail? Maybe an expected timeout problem which can be solved by increasing the timeouts for TCI?
I have just run a local test of
make check-tcgwith native TCG and with TCI and did not see a difference. But I noticed that in both cases many tests show "skipped".You need to enable docker or podman for your development, so that you get all of the cross-compilers.
Then:
TEST fcvt on arm
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumpedTEST
float_convson m68k
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumpedQuoted 8 lines
Quoted 2 lines
which is of course one of the TODO assertions. It's positively criminal those still exist in the code.
I installed podman and repeated
make check-tcg. The log file still shows 87 lines with "SKIPPED". There is also a gdb core dump, several warnings, but nothing related to TCI. Both tests cited above seem to work without a problem.I'm going to go out on a limb and guess you have commit:
23a77b2d18(build-system: clean up TCG/TCI configury)which temporarily has the effect of disabling TCI. See
Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter From: Paolo Bonzini <[email protected]> Message-ID: <[email protected]> Date: Mon, 25 Jan 2021 17:36:42 +0100with that fix fixed I see the same failures as Richard:
./qemu-arm ./tests/tcg/arm-linux-user/fcvt >
/dev/null
TODO../../tcg/tci.c:614:tcg_qemu_tb_exec()
../../tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
fish: “./qemu-arm ./tests/tcg/arm-linu…” terminated by signal SIGSEGV (Address boundary error)which does raise the question before today when was the last time anyone attempted to run check-tcg on this?
Quoted 5 lines
The complete log file is available from
https://qemu.weilnetz.de/test/check-tcg.txt.Daniel, regarding your comment: TCI has 100 % test coverage for the productive code lines.
By what tests? The fact you don't hit asserts in your day to day testing doesn't mean there are features missing that are easily tripped up or that TCI got it right.
Quoted 7 lines
Quoted 5 lines
All code lines which were never tested raise an
assertion, so can easily be identified (and fixed as soon as there is a test case which triggers such an assertion). The known deficits are speed, missing TCG opcodes, unimplemented TCG opcodes because of missing test cases and missing support for some host architectures.Passing check-tcg would be a minimum for me.
Passing check-tcg *in gitlab CI* would be the minimum to consider it on a par with TCG.
The lack of automated GitLab CI for TCI is a reason my proposed wording described TCI as less reliable than native TCG. We can't claim it has equivalent reliability unless we have equiv automated testing of TCI.
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Quoted 79 lines · Daniel P. Berrangé
Quoted 78 lines · Alex Bennée
Quoted 28 lines · Stefan Weil
Am 25.01.21 um 23:35 schrieb Richard Henderson:
Quoted 27 lines · Stefan Weil
Quoted 11 lines
Am 25.01.21 um 20:02 schrieb Richard Henderson:
Quoted 4 lines · Stefan Weil
Quoted 2 lines
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
Where does it fail? Maybe an expected timeout problem which can be solved by increasing the timeouts for TCI?
I have just run a local test of
make check-tcgwith native TCG and with TCI and did not see a difference. But I noticed that in both cases many tests show "skipped".You need to enable docker or podman for your development, so that you get all of the cross-compilers.
Then:
TEST fcvt on arm
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumpedTEST
float_convson m68k
TODO../qemu/tcg/tci.c:614:tcg_qemu_tb_exec()../qemu/tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumpedQuoted 8 lines
Quoted 2 lines
which is of course one of the TODO assertions. It's positively criminal those still exist in the code.
I installed podman and repeated
make check-tcg. The log file still shows 87 lines with "SKIPPED". There is also a gdb core dump, several warnings, but nothing related to TCI. Both tests cited above seem to work without a problem.I'm going to go out on a limb and guess you have commit:
23a77b2d18(build-system: clean up TCG/TCI configury)which temporarily has the effect of disabling TCI. See
Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter From: Paolo Bonzini <[email protected]> Message-ID: <[email protected]> Date: Mon, 25 Jan 2021 17:36:42 +0100with that fix fixed I see the same failures as Richard:
./qemu-arm ./tests/tcg/arm-linux-user/fcvt >
/dev/null
TODO../../tcg/tci.c:614:tcg_qemu_tb_exec()
../../tcg/tci.c:614: tcg fatal error
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
fish: “./qemu-arm ./tests/tcg/arm-linu…” terminated by signal SIGSEGV (Address boundary error)which does raise the question before today when was the last time anyone attempted to run check-tcg on this?
Quoted 5 lines
The complete log file is available from
https://qemu.weilnetz.de/test/check-tcg.txt.Daniel, regarding your comment: TCI has 100 % test coverage for the productive code lines.
By what tests? The fact you don't hit asserts in your day to day testing doesn't mean there are features missing that are easily tripped up or that TCI got it right.
Quoted 5 lines
All code lines which were never tested raise an
assertion, so can easily be identified (and fixed as soon as there is a test case which triggers such an assertion). The known deficits are speed, missing TCG opcodes, unimplemented TCG opcodes because of missing test cases and missing support for some host architectures.
Quoted 8 lines
Quoted 1 line
Passing check-tcg would be a minimum for me.
Passing check-tcg *in gitlab CI* would be the minimum to consider it on a par with TCG.
The lack of automated GitLab CI for TCI is a reason my proposed wording described TCI as less reliable than native TCG. We can't claim it has equivalent reliability unless we have equiv automated testing of TCI.
I should point out that check-tcg is hardly a comprehensive test suite. Most of our instruction testing for example tends to be done with RISU. Any program that attempts to use vector instructions is likely to come a cropper with TCI. I guess we don't even attempt to run check-acceptance due to speed issues but it would be interesting to see how far it gets.
Quoted 3 lines
Regards,
Daniel
Signature · 1 line
Alex Bennée
Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
In reply to Richard HendersonQuoted 4 lines · Richard Henderson
Quoted 1 line · Stefan Weil
I have no evidence that TCI is less reliable than TCG, so I would not write that.
It can't pass make check-tcg.
It also doesn't have anyhere near the same level of automated or manual testing than TCG does, so I don't think we can claim it is at the same quality level.
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Paolo Bonzini
AppliedQuoted 20 lines · Philippe Mathieu-Daudé
Since v3:
- Rebased
- Include fix for23a77b2d18b("build-system: clean up TCG/TCI configury")
- Useget_option()(Claudio)
- Use warning message suggested by Daniel
- Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo)Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available.
Note, before Meson, warnings were summarized at the end of ./configure. Now they are displayed earlier, and likely missed IMHO. No clue how to improve that :/
Philippe Mathieu-Daudé (3):
configure: Improve TCI feature description
meson: Explicit TCG backend used
meson: Warn when TCI is selected but TCG backend is available
Quoted 7 lines
Richard Henderson (1):
configure: Fix --enable-tcg-interpreterconfigure | 7 ++++--- meson.build | 15 +++++++++++++-- 2 files changed, 17 insertions(+), 5 deletions(-)
Queued, thanks. In pattch 2 I made the corresponding changes at meson_options.txt too.
Paolo