Skip to content

meson: Try to clarify TCG / TCI options for new users

Philippe Mathieu-Daudé qemu-devel 4 versions – Applied

Status from this message: Queued, thanks. In pattch 2 I made the corresponding changes at meson_options.txt too.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 30 repliesApplied
  2. v34 patches 4 repliesSuperseded
  3. v24 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches5 repliesSuperseded

Changes in v4 from the cover letter

- Rebased
- Include fix for 23a77b2d18b ("build-system: clean up TCG/TCI configury")
- Use get_option() (Claudio)
- Use warning message suggested by Daniel
- Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4configure: Fix --enable-tcg-interpreterconfigure+3 -23 replies
2/4configure: Improve TCI feature descriptionconfigure+1 -11 reply
3/4meson: Explicit TCG backend usedmeson.build+6 -21 reply
4/4meson: Warn when TCI is selected but TCG backend is availablemeson.build+7 -024 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéThomas HuthStefan WeilDaniel P. Berrangé
1/4R-b T-b R-b
2/4R-b
3/4R-b R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users

Since v3:
- Rebased
- Include fix for 23a77b2d18b ("build-system: clean up TCG/TCI configury")
- Use get_option() (Claudio)
- Use warning message suggested by Daniel
- Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo)

Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available.

Note, before Meson, warnings were summarized at the end of ./configure. Now they are displayed earlier, and likely missed IMHO. No clue how to improve that :/

Philippe Mathieu-Daudé (3):
configure: Improve TCI feature description
meson: Explicit TCG backend used
meson: Warn when TCI is selected but TCG backend is available

Richard Henderson (1):
configure: Fix --enable-tcg-interpreter

 configure   |  7 ++++---
 meson.build | 15 +++++++++++++--
 2 files changed, 17 insertions(+), 5 deletions(-)
Signature · 1 line
2.26.2