Skip to contentSkip to conversation

tests/kms_vrr: Update condition checks for flipline test

PATCH Superseded Bhanuprakash Modem 3 participants 4 messages Jan 25, 2021

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 tests/kms_vrr: Update condition checks for flipline test

This patch includes below updates
* For Flipline test: if refresh_rate <= Vrr_min then
- Expected returned refresh rate would be vrr_max
- At least 35% of the flips should be in threshold
* Update "igt_display_commit_atomic" with "igt_display_commit2"
* Calculate the target timestamp based on the delta between event timestamps & whatever the time left to reach the expected rate.
* Add few debug prints

V2:
* Rebase
V3:
* Compute the target timestamp based on the delta (Ville)

Cc Ville Syrjälä <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
---
 tests/kms_vrr.c | 72 +++++++++++++++++++++----------------------------
 1 file changed, 31 insertions(+), 41 deletions(-)
tests/kms_vrr.c +31 -41
index beb06854f..8c9dd1bc0 100644
@@ -170,7 +170,7 @@ static void set_vrr_on_pipe(data_t *data, enum pipe pipe, bool enabled)
 {
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED,
 				enabled);
-	igt_display_commit_atomic(&data->display, 0, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Prepare the display for testing on the given pipe. */
@@ -208,8 +208,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 	 */
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, 0);
 
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Waits for the vblank interval. Returns the vblank timestamp in ns. */
@@ -260,17 +259,16 @@ static uint32_t
 flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 uint64_t rate_ns, uint64_t duration_ns)
 {
-	uint64_t start_ns, last_event_ns;
+	uint64_t start_ns, last_event_ns, target_ns;
 	uint32_t total_flip = 0, total_pass = 0;
 	bool front = false;
 	vtest_ns_t vtest_ns = get_test_rate_ns(data, output);
 
 	/* Align with the vblank region to speed up convergence. */
-	last_event_ns = wait_for_vblank(data, pipe);
-	start_ns = get_time_ns();
+	start_ns = last_event_ns = target_ns = wait_for_vblank(data, pipe);
 
 	for (;;) {
-		uint64_t now_ns, event_ns, wait_ns, target_ns;
+		uint64_t event_ns, wait_ns;
 		int64_t diff_ns;
 
 		front = !front;
@@ -291,14 +289,10 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 * difference between 144Hz and 143Hz which should give this
 		 * enough accuracy for most use cases.
 		 */
-		if (rate_ns <= vtest_ns.min && rate_ns >= vtest_ns.max)
+		if ((rate_ns < vtest_ns.min) && (rate_ns >= vtest_ns.max))
 			diff_ns = rate_ns;
-		else if (rate_ns > vtest_ns.min)
-			diff_ns = vtest_ns.min;
-		else if (rate_ns < vtest_ns.max)
-			diff_ns = vtest_ns.max;
 		else
-			diff_ns = rate_ns;
+			diff_ns = vtest_ns.max;
 		diff_ns -= event_ns - last_event_ns;
 
 		if (llabs(diff_ns) < 50000ll)
@@ -307,24 +301,24 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		last_event_ns = event_ns;
 		total_flip += 1;
 
-		now_ns = get_time_ns();
-		if (now_ns - start_ns > duration_ns)
+		if (event_ns - start_ns > duration_ns)
 			break;
 
 		/*
 		 * Burn CPU until next timestamp, sleeping isn't accurate enough.
-		 * It's worth noting that the target timestamp is based on absolute
-		 * timestamp rather than a delta to avoid accumulation errors.
+		 * The target timestamp is based on the delta b/w event timestamps
+		 * and whatever the time left to reach the expected refresh rate.
 		 */
-		diff_ns = now_ns - start_ns;
+		diff_ns = event_ns - target_ns;
 		wait_ns = ((diff_ns + rate_ns - 1) / rate_ns) * rate_ns;
-		target_ns = start_ns + wait_ns - 10;
+		wait_ns -= diff_ns;
+		target_ns = event_ns + wait_ns;
 
-		while (get_time_ns() < target_ns);
+		while (get_time_ns() < target_ns - 10);
 	}
 
-	igt_info("Completed %u flips, %u were in threshold for %"PRIu64"ns.\n",
-		 total_flip, total_pass, rate_ns);
+	igt_info("Completed %u flips, %u were in threshold for (%llu Hz) %"PRIu64"ns.\n",
+		 total_flip, total_pass, (NSECS_PER_SEC/rate_ns), rate_ns);
 
 	return total_flip ? ((total_pass * 100) / total_flip) : 0;
 }
@@ -338,8 +332,8 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	range_t range = get_vrr_range(data, output);
 	uint64_t rate = vtest_ns.mid;
 
-	igt_info("VRR Test execution on %s, PIPE_%s\n",
-		 output->name, kmstest_pipe_name(pipe));
+	igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
+		 output->name, kmstest_pipe_name(pipe), range.min, range.max);
 
 	prepare_test(data, output, pipe);
 
@@ -370,46 +364,42 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	 * decision boundary.
 	 *
 	 * Example: if range is 40 - 60Hz and
-	 * if refresh_rate > 60Hz:
+	 * if refresh_rate > 60Hz or <= 40Hz:
 	 *      Flip should happen at the flipline boundary & returned refresh rate
 	 *      would be 60Hz.
 	 * if refresh_rate is 50Hz:
 	 *      Flip will happen right away so returned refresh rate is 50Hz.
-	 * if refresh_rate < 40Hz:
-	 *      Flip should happen at the vmax so the returned refresh rate
-	 *      would be 40Hz.
 	 */
 	if (flags & TEST_FLIPLINE) {
-		rate = rate_from_refresh(range.min - 5);
+		rate = rate_from_refresh(range.max + 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.max + 5), rate, result);
 
-		rate = rate_from_refresh(range.max + 5);
+		rate = rate_from_refresh(range.min - 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
-		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+		igt_assert_f(result > 35,
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.min - 5), rate, result);
 	}
 
 	rate = vtest_ns.mid;
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result > 75,
-		     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	set_vrr_on_pipe(data, pipe, 0);
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result < 10,
-		     "Refresh rate %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	/* Clean-up */
 	igt_plane_set_fb(data->primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	igt_remove_fb(data->drm_fd, &data->fb1);
 	igt_remove_fb(data->drm_fd, &data->fb0);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: Update condition checks for flipline test (rev3)

== Series Details ==

== Series Details ==

Series: tests/kms_vrr: Update condition checks for flipline test (rev3)
URL : https://patchwork.freedesktop.org/series/84932/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9679 -> IGTPW_5428
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/index.html

Known issues
------------

Here are the changes found in IGTPW_5428 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-tgl-u2: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-u2/igt@amdgpu/[email protected]

* igt@debugfs_test@read_all_entries:
- fi-tgl-y: NOTRUN -> [DMESG-WARN][2] ([i915#402]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-y/igt@debugfs_test@read_all_entries.html

* igt@gem_huc_copy@huc-copy:
- fi-tgl-u2: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-u2/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-tgl-y: NOTRUN -> [DMESG-FAIL][4] ([i915#2373])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-y/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@gt_pm:
- fi-tgl-y: NOTRUN -> [DMESG-FAIL][5] ([i915#1759])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-y/igt@i915_selftest@live@gt_pm.html

* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-u2: NOTRUN -> [SKIP][6] ([fdo#109284] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#2203] / [i915#2868])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- fi-tgl-y: NOTRUN -> [SKIP][9] ([fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-y/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-u2: NOTRUN -> [SKIP][10] ([fdo#109285])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-u2/igt@[email protected]
- fi-tgl-y: NOTRUN -> [SKIP][11] ([fdo#109285])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [DMESG-WARN][12] ([i915#2203]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/fi-icl-u2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/fi-icl-u2/igt@[email protected]

[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (36 -> 33)
------------------------------

Additional (2): fi-tgl-y fi-tgl-u2
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-ctg-p8600 fi-dg1-1

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5971 -> IGTPW_5428

CI-20190529: 20190529
CI_DRM_9679: f2467849acce5e1e824c5ca5e1a12ce69eb695a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5428: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/index.html
IGT_5971: abef2b7d6ff30f3b948b3e5d39653debb73083f3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_vrr: Update condition checks for flipline test (rev3)

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: tests/kms_vrr: Update condition checks for flipline test (rev3)
URL : https://patchwork.freedesktop.org/series/84932/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9679_full -> IGTPW_5428_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5428_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@gem_create@create-massive}:
- shard-hsw: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw1/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5428_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][2] -> [SKIP][3] ([i915#658])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@[email protected]

* igt@gem_ctx_persistence@close-replace-race:
- shard-glk: [PASS][4] -> [TIMEOUT][5] ([i915#2918])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-glk2/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk1/igt@[email protected]

* igt@gem_ctx_persistence@engines-cleanup:
- shard-hsw: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw2/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-snb7/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-tglb2/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb6/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][10] -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-apl6/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-glk5/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb4/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb1/igt@gem_exec_fair@[email protected]
- shard-glk: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][18] ([i915#2842]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-apl8/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl1/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@no-blt:
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#109283])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109283])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-tglb: NOTRUN -> [FAIL][25] ([i915#2389]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@gem_exec_reloc@[email protected]
- shard-glk: NOTRUN -> [FAIL][26] ([i915#2389])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk9/igt@gem_exec_reloc@[email protected]
- shard-snb: NOTRUN -> [FAIL][27] ([i915#2389]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-snb2/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_reloc@basic-many-active@vcs0:
- shard-kbl: NOTRUN -> [FAIL][28] ([i915#2389]) +4 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl4/igt@gem_exec_reloc@[email protected]
- shard-hsw: NOTRUN -> [FAIL][29] ([i915#2389]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw7/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][30] ([i915#2389]) +5 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb4/igt@gem_exec_reloc@[email protected]

* igt@gem_render_copy@yf-tiled-to-vebox-x-tiled:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb4/igt@[email protected]

* igt@gem_userptr_blits@readonly-mmap-unsync@wb:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#1704]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb6/igt@gem_userptr_blits@[email protected]
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#1704]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb5/igt@gem_userptr_blits@[email protected]

* igt@gen9_exec_parse@bb-start-cmd:
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#112306])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#112306])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#1937])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl1/igt@i915_pm_lpsp@[email protected]
- shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#1937])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl1/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#1937])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk2/igt@i915_pm_lpsp@[email protected]

* igt@kms_big_joiner@basic:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#2705])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#2705])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2705])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb4/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#2705])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk9/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2705])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl4/igt@[email protected]

* igt@kms_color@pipe-b-ctm-0-75:
- shard-tglb: NOTRUN -> [FAIL][44] ([i915#1149] / [i915#315])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][45] ([i915#1149] / [i915#315])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb6/igt@[email protected]

* igt@kms_color@pipe-c-legacy-gamma-reset:
- shard-kbl: NOTRUN -> [FAIL][46] ([i915#2964])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl1/igt@[email protected]
- shard-apl: [PASS][47] -> [FAIL][48] ([i915#2964])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-apl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl7/igt@[email protected]
- shard-glk: [PASS][49] -> [FAIL][50] ([i915#2964])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-glk7/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk3/igt@[email protected]
- shard-hsw: [PASS][51] -> [FAIL][52] ([i915#2964])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-hsw4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw4/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +10 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk9/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109284] / [fdo#111827]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb4/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-gamma:
- shard-hsw: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +9 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw1/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-snb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278] / [fdo#109279]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
- shard-apl: [PASS][62] -> [FAIL][63] ([i915#54])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-apl2/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109279]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb3/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109274] / [fdo#109278]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109278]) +7 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb5/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#533]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-dpms:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109274]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][71] -> [FAIL][72] ([i915#2598])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-tglb6/igt@kms_flip@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb5/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#2672])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109280]) +13 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#111825]) +19 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271]) +37 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271]) +91 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl2/igt@[email protected]

* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#1187])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#1187])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@[email protected]

* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109289])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109289])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb5/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
- shard-snb: [PASS][82] -> [SKIP][83] ([fdo#109271])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-snb5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-snb4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][84] ([fdo#108145] / [i915#265])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk5/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl6/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl8/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#658]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk1/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2920]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb1/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109441])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@kms_psr@psr2_cursor_render.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][93] -> [SKIP][94] ([fdo#109441]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html

* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271]) +48 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-apl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#2530]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb5/igt@[email protected]

* igt@nouveau_crc@pipe-b-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#2530]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@[email protected]

* igt@sysfs_heartbeat_interval@precise@rcs0:
- shard-snb: NOTRUN -> [SKIP][98] ([fdo#109271]) +69 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-snb7/igt@sysfs_heartbeat_interval@[email protected]

* igt@sysfs_heartbeat_interval@precise@vcs0:
- shard-hsw: NOTRUN -> [SKIP][99] ([fdo#109271]) +141 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw2/igt@sysfs_heartbeat_interval@[email protected]

* igt@tools_test@sysfs_l3_parity:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109307])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb7/igt@tools_test@sysfs_l3_parity.html
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#109307])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb2/igt@tools_test@sysfs_l3_parity.html

#### Possible fixes ####

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [FAIL][102] ([i915#2842]) -> [PASS][103] +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl3/igt@gem_exec_fair@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglb: [FAIL][104] ([i915#2842]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-tglb2/igt@gem_exec_fair@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][106] ([i915#2842]) -> [PASS][107] +5 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-glk7/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-kbl: [DMESG-WARN][108] ([i915#1610] / [i915#2803]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl2/igt@gem_exec_schedule@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl1/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [DMESG-WARN][110] ([i915#118] / [i915#95]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-glk7/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-glk1/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][112] ([i915#2190]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-tglb6/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [WARN][114] ([i915#1519]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-hsw4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-hsw4/igt@[email protected]

* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][116] ([i915#2597]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-tglb3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-tglb7/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@perf_pmu@rc6-suspend:
- shard-kbl: [INCOMPLETE][120] ([i915#155]) -> [PASS][121] +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl7/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][122] ([i915#2684]) -> [WARN][123] ([i915#2681] / [i915#2684])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb2/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb8/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][124] ([i915#2681] / [i915#2684]) -> [WARN][125] ([i915#1804] / [i915#2684])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb8/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb3/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][126] ([i915#658]) -> [SKIP][127] ([i915#2920])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb6/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][128] ([i915#2920]) -> [SKIP][129] ([i915#658]) +2 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-iclb2/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-iclb4/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133]) ([i915#2295] / [i915#2426]) -> ([FAIL][134], [FAIL][135], [FAIL][136]) ([i915#2295])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl7/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9679/shard-kbl2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl2/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/shard-kbl7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1187]: https://gitlab.freedesktop.org/drm/intel/issues/1187
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1704]: https://gitlab.freedesktop.org/drm/intel/issues/1704
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitl

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5428/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw
In reply to Bhanuprakash Modem
Quoted 98 lines · Bhanuprakash Modem

This patch includes below updates
* For Flipline test: if refresh_rate <= Vrr_min then
- Expected returned refresh rate would be vrr_max
- At least 35% of the flips should be in threshold
* Update "igt_display_commit_atomic" with "igt_display_commit2"
* Calculate the target timestamp based on the delta between event timestamps & whatever the time left to reach the expected rate.
* Add few debug prints

V2:
* Rebase
V3:
* Compute the target timestamp based on the delta (Ville)

Cc Ville Syrjälä <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
---
 tests/kms_vrr.c | 72 +++++++++++++++++++++----------------------------
 1 file changed, 31 insertions(+), 41 deletions(-)
tests/kms_vrr.c +10 -17
index beb06854f..8c9dd1bc0 100644
@@ -170,7 +170,7 @@ static void set_vrr_on_pipe(data_t *data, enum pipe pipe, bool enabled)
 {
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED,
 				enabled);
-	igt_display_commit_atomic(&data->display, 0, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Prepare the display for testing on the given pipe. */
@@ -208,8 +208,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 	 */
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, 0);
 
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Waits for the vblank interval. Returns the vblank timestamp in ns. */
@@ -260,17 +259,16 @@ static uint32_t
 flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 uint64_t rate_ns, uint64_t duration_ns)
 {
-	uint64_t start_ns, last_event_ns;
+	uint64_t start_ns, last_event_ns, target_ns;
 	uint32_t total_flip = 0, total_pass = 0;
 	bool front = false;
 	vtest_ns_t vtest_ns = get_test_rate_ns(data, output);
 
 	/* Align with the vblank region to speed up convergence. */
-	last_event_ns = wait_for_vblank(data, pipe);
-	start_ns = get_time_ns();
+	start_ns = last_event_ns = target_ns = wait_for_vblank(data, pipe);
 
 	for (;;) {
-		uint64_t now_ns, event_ns, wait_ns, target_ns;
+		uint64_t event_ns, wait_ns;
 		int64_t diff_ns;
 
 		front = !front;
@@ -291,14 +289,10 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 * difference between 144Hz and 143Hz which should give this
 		 * enough accuracy for most use cases.
 		 */
-		if (rate_ns <= vtest_ns.min && rate_ns >= vtest_ns.max)
+		if ((rate_ns < vtest_ns.min) && (rate_ns >= vtest_ns.max))
 			diff_ns = rate_ns;
-		else if (rate_ns > vtest_ns.min)
-			diff_ns = vtest_ns.min;
-		else if (rate_ns < vtest_ns.max)
-			diff_ns = vtest_ns.max;
 		else
-			diff_ns = rate_ns;
+			diff_ns = vtest_ns.max;
 		diff_ns -= event_ns - last_event_ns;
 
 		if (llabs(diff_ns) < 50000ll)
@@ -307,24 +301,24 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		last_event_ns = event_ns;
 		total_flip += 1;
 
-		now_ns = get_time_ns();
-		if (now_ns - start_ns > duration_ns)
+		if (event_ns - start_ns > duration_ns)
 			break;
 
 		/*
 		 * Burn CPU until next timestamp, sleeping isn't accurate enough.
-		 * It's worth noting that the target timestamp is based on absolute
-		 * timestamp rather than a delta to avoid accumulation errors.
+		 * The target timestamp is based on the delta b/w event timestamps
+		 * and whatever the time left to reach the expected refresh rate.

tests/kms_vrr.c flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe, · line 317

Quoted 10 lines
tests/kms_vrr.c +4 -3
 		 */
-		diff_ns = now_ns - start_ns;
+		diff_ns = event_ns - target_ns;
 		wait_ns = ((diff_ns + rate_ns - 1) / rate_ns) * rate_ns;
-		target_ns = start_ns + wait_ns - 10;
+		wait_ns -= diff_ns;
+		target_ns = event_ns + wait_ns;
 
-		while (get_time_ns() < target_ns);
+		while (get_time_ns() < target_ns - 10);

I will have Ville confirm that this logic suggested by him looks good.

Manasi

Quoted 23 lines
tests/kms_vrr.c +4 -4
 	}
 
-	igt_info("Completed %u flips, %u were in threshold for %"PRIu64"ns.\n",
-		 total_flip, total_pass, rate_ns);
+	igt_info("Completed %u flips, %u were in threshold for (%llu Hz) %"PRIu64"ns.\n",
+		 total_flip, total_pass, (NSECS_PER_SEC/rate_ns), rate_ns);
 
 	return total_flip ? ((total_pass * 100) / total_flip) : 0;
 }
@@ -338,8 +332,8 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	range_t range = get_vrr_range(data, output);
 	uint64_t rate = vtest_ns.mid;
 
-	igt_info("VRR Test execution on %s, PIPE_%s\n",
-		 output->name, kmstest_pipe_name(pipe));
+	igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
+		 output->name, kmstest_pipe_name(pipe), range.min, range.max);
 
 	prepare_test(data, output, pipe);
 
@@ -370,46 +364,42 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	 * decision boundary.
 	 *

tests/kms_vrr.c test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags) · line 380

Quoted 10 lines
tests/kms_vrr.c +1 -4
 	 * Example: if range is 40 - 60Hz and
-	 * if refresh_rate > 60Hz:
+	 * if refresh_rate > 60Hz or <= 40Hz:
 	 *      Flip should happen at the flipline boundary & returned refresh rate
 	 *      would be 60Hz.
 	 * if refresh_rate is 50Hz:
 	 *      Flip will happen right away so returned refresh rate is 50Hz.
-	 * if refresh_rate < 40Hz:
-	 *      Flip should happen at the vmax so the returned refresh rate
-	 *      would be 40Hz.

Why was this comment removed, flips should happen at Vmax and the returned refresh rate for <=40Hz should be 40Hz.
And if we are not seeing this then the "why" should be justified in terms of HW behaviour or monitor limitation or with appropriate explanation.

Quoted 50 lines
tests/kms_vrr.c +12 -13
 	 */
 	if (flags & TEST_FLIPLINE) {
-		rate = rate_from_refresh(range.min - 5);
+		rate = rate_from_refresh(range.max + 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.max + 5), rate, result);
 
-		rate = rate_from_refresh(range.max + 5);
+		rate = rate_from_refresh(range.min - 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
-		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+		igt_assert_f(result > 35,
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.min - 5), rate, result);
 	}
 
 	rate = vtest_ns.mid;
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result > 75,
-		     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	set_vrr_on_pipe(data, pipe, 0);
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result < 10,
-		     "Refresh rate %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	/* Clean-up */
 	igt_plane_set_fb(data->primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	igt_remove_fb(data->drm_fd, &data->fb1);
 	igt_remove_fb(data->drm_fd, &data->fb0);
Signature · 1 line
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev