package/uboot-tools: drop redundant parentheses
PATCH 1/1 package/uboot-tools: drop redundant parentheses
Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.
Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
--- package/uboot-tools/uboot-tools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/uboot-tools/uboot-tools.mk +1 -1
@@ -160,7 +160,7 @@ endif #BR_BUILDING define HOST_UBOOT_TOOLS_GENERATE_BOOT_SCRIPT $(@D)/tools/mkimage -C none -A $(MKIMAGE_ARCH) -T script \ -d $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE)) \ - $(@D)/tools/boot.scr) + $(@D)/tools/boot.scr endef define HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT $(INSTALL) -m 0755 -D $(@D)/tools/boot.scr $(BINARIES_DIR)/boot.scr
Signature · 1 line
2.29.2
PATCH 1/1 package/uboot-tools: drop redundant parentheses
Baruch,
Quoted 9 lines · Baruch Siach
Commit
d8db91fc6fa("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
Opps, I'll have to check with Kalpesh as we must have only tested the env binary portion for v2 of the previous series. Thx for sending the patch.
PATCH 1/1 package/uboot-tools: drop redundant parentheses
Quoted 5 lines · On Thu, 28 Jan 2021 07:25:25 -0600 Matthew Weber via buildroot…
Opps, I'll have to check with Kalpesh as we must have only tested the env binary portion for v2 of the previous series. Thx for sending the patch.
Reviewed-by Matt Weber <[email protected]>
We need unit tests for this stuff! :-)
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/uboot-tools: drop redundant parentheses
In reply to Baruch SiachQuoted 9 lines · Baruch Siach
Commit
d8db91fc6fa("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
Quoted 7 lines
Cc Matt Weber <[email protected]>Cc Kalpesh Panchal <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/uboot-tools/uboot-tools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I was about to send exactly the same patch :)
Yann E. MORIN
AppliedPATCH 1/1 package/uboot-tools: drop redundant parentheses
In reply to Baruch SiachBaruch, All,
On 2021-01-28 14:33 +0200, Baruch Siach spake thusly:
Quoted 11 lines
Commit
d8db91fc6fa("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/Cc Matt Weber <[email protected]>Cc Kalpesh Panchal <[email protected]>Signed-off-by Baruch Siach <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 24 lines
--- package/uboot-tools/uboot-tools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/uboot-tools/uboot-tools.mk +1
-1@@ -160,7 +160,7 @@ endif #BR_BUILDING define HOST_UBOOT_TOOLS_GENERATE_BOOT_SCRIPT $(@D)/tools/mkimage -C none -A $(MKIMAGE_ARCH) -T script \ -d $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE)) \ - $(@D)/tools/boot.scr) + $(@D)/tools/boot.scr endef define HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT $(INSTALL) -m 0755 -D $(@D)/tools/boot.scr $(BINARIES_DIR)/boot.scrSignature · 6 lines
2.29.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/uboot-tools: drop redundant parentheses
In reply to Baruch SiachQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
Commit
d8db91fc6fa("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/Cc Matt Weber <[email protected]>Cc Kalpesh Panchal <[email protected]>Signed-off-by Baruch Siach <[email protected]>
Committed to 2020.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard