Skip to contentSkip to conversation

package/uboot-tools: drop redundant parentheses

PATCH New Baruch Siach 6 participants 6 messages Jan 28, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/uboot-tools: drop redundant parentheses

Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.

Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/

Cc Matt Weber <[email protected]>
Cc Kalpesh Panchal <[email protected]>
---
 package/uboot-tools/uboot-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/uboot-tools/uboot-tools.mk +1 -1
index f2bd627e927e..a0cdcafd4e7e 100644
@@ -160,7 +160,7 @@ endif #BR_BUILDING
 define HOST_UBOOT_TOOLS_GENERATE_BOOT_SCRIPT
 	$(@D)/tools/mkimage -C none -A $(MKIMAGE_ARCH) -T script \
 		-d $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE)) \
-		$(@D)/tools/boot.scr)
+		$(@D)/tools/boot.scr
 endef
 define HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT
 	$(INSTALL) -m 0755 -D $(@D)/tools/boot.scr $(BINARIES_DIR)/boot.scr
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/uboot-tools: drop redundant parentheses

Baruch,

Quoted 9 lines · Baruch Siach

Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.

Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/

Opps, I'll have to check with Kalpesh as we must have only tested the env binary portion for v2 of the previous series. Thx for sending the patch.

#2 lore raw

PATCH 1/1 package/uboot-tools: drop redundant parentheses

Quoted 5 lines · On Thu, 28 Jan 2021 07:25:25 -0600 Matthew Weber via buildroot…

Opps, I'll have to check with Kalpesh as we must have only tested the env binary portion for v2 of the previous series. Thx for sending the patch.

We need unit tests for this stuff! :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/uboot-tools: drop redundant parentheses

In reply to Baruch Siach
Quoted 9 lines · Baruch Siach

Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.

Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/

Quoted 7 lines
Cc Matt Weber <[email protected]>
Cc Kalpesh Panchal <[email protected]>
---
 package/uboot-tools/uboot-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I was about to send exactly the same patch :)

#4 lore raw

PATCH 1/1 package/uboot-tools: drop redundant parentheses

In reply to Baruch Siach

Baruch, All,

On 2021-01-28 14:33 +0200, Baruch Siach spake thusly:

Quoted 11 lines

Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.

Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/

Cc Matt Weber <[email protected]>
Cc Kalpesh Panchal <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/uboot-tools/uboot-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/uboot-tools/uboot-tools.mk +1 -1
index f2bd627e927e..a0cdcafd4e7e 100644
@@ -160,7 +160,7 @@ endif #BR_BUILDING
 define HOST_UBOOT_TOOLS_GENERATE_BOOT_SCRIPT
 	$(@D)/tools/mkimage -C none -A $(MKIMAGE_ARCH) -T script \
 		-d $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE)) \
-		$(@D)/tools/boot.scr)
+		$(@D)/tools/boot.scr
 endef
 define HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT
 	$(INSTALL) -m 0755 -D $(@D)/tools/boot.scr $(BINARIES_DIR)/boot.scr
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/1 package/uboot-tools: drop redundant parentheses

In reply to Baruch Siach
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script error") introduced closing parentheses that is not matched and not needed.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/

Cc Matt Weber <[email protected]>
Cc Kalpesh Panchal <[email protected]>

Committed to 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard