Skip to contentSkip to conversation

dt-bindings: display: Add "disable-hpd" binding

PATCH In review Mykyta Poturai 3 participants 3 messages Jan 31, 2021 – Feb 9, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 dt-bindings: display: Add "disable-hpd" binding

Add the "disable-hpd" binding, used to disable hotplug detected functionality in the driver. When it's enabled the driver assumes that the connector is always connected and disables the hotplug detect related IRQ.

---
 .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt       | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +1 -0
index 3f6072651182..b2b899f46b86 100644
@@ -39,6 +39,7 @@ Optional properties:
 
 - power-domains: Shall reference the power domain that contains the DWC HDMI,
   if any.
+- disable-hpd: Disables the hotplug detect feature
 
 
 Example:
Signature · 1 line
2.30.0
#1 lore raw

Hi,

Quoted 4 lines · Mykyta Poturai

Add the "disable-hpd" binding, used to disable hotplug detected functionality in the driver. When it's enabled the driver assumes that the connector is always connected and disables the hotplug detect related IRQ.

DT describes the hardware, not the software behaviour.

So if the HPD is broken, then add a "snps,broken-hpd" instead, or if you want to force output, use the DRM mode forcing, which is handled by the dw-hdmi code:
https://wiki.archlinux.org/index.php/kernel_mode_setting#Forcing_modes

Neil

Quoted 12 lines
---
 .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt       | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +0 -0
index 3f6072651182..b2b899f46b86 100644

Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt Optional properties: · line 45

Quoted 7 lines
Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +1 -0
@@ -39,6 +39,7 @@ Optional properties:
 
 - power-domains: Shall reference the power domain that contains the DWC HDMI,
   if any.
+- disable-hpd: Disables the hotplug detect feature
 
 
 Example:

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
In reply to Mykyta Poturai

Hi Mykyta,

Thank you for the patch.

Quoted 15 lines · Mykyta Poturai

Add the "disable-hpd" binding, used to disable hotplug detected functionality in the driver. When it's enabled the driver assumes that the connector is always connected and disables the hotplug detect related IRQ.

---
 .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt       | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +0 -0
index 3f6072651182..b2b899f46b86 100644

Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt Optional properties: · line 42

Quoted 4 lines
Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +1 -0
@@ -39,6 +39,7 @@ Optional properties:
 
 - power-domains: Shall reference the power domain that contains the DWC HDMI,
   if any.
+- disable-hpd: Disables the hotplug detect feature

A similar property has been added to the ti,sn65dsi86 bindings in commit 1dbc979172af ("dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd"). A property with the same name exists in panel-common.yaml. Could we standardize on that name ?

The description should also explain the hardware architecture, not the driver behaviour. This is what the ti,sn65dsi86 binding documents:

no-hpd:
type: boolean
description:
Set if the HPD line on the bridge isn't hooked up to anything or is otherwise unusable.

You could use the same description, assuming this is the use case you want to support. Could you perhaps describe your problem in a bit more details ? Do you have a system with an HDMI panel that is always connected, with the HPD signal of the dw-hdmi not connected ?

Quoted 1 line
Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +0 -0
 Example:
Signature · 7 lines
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel