Skip to contentSkip to conversation

usb: typec: Return void in typec_partner_set_pd_revision

PATCH In review Kyle Tso 4 participants 6 messages Feb 2, 2021

Subsystems (2)
lore
Share & tools
lore

Kyle Tso

author
#0 lore raw

PATCH 1/1 usb: typec: Return void in typec_partner_set_pd_revision

typec_partner_set_pd_revision doesn't need any return value.

Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
---
 drivers/usb/typec/class.c | 10 ++--------
 include/linux/usb/typec.h |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)
drivers/usb/typec/class.c +2 -8
index b6ceab3dc16b..a7d1bc83c2d4 100644
@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
  *
  * This routine is used to report that the PD revision of the port partner has
  * become available.
- *
- * Returns 0 on success or negative error number on failure.
  */
-int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
+void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
 {
-	int ret;
-
 	if (partner->pd_revision == pd_revision)
-		return 0;
+		return;
 
 	partner->pd_revision = pd_revision;
 	sysfs_notify(&partner->dev.kobj, NULL, "usb_power_delivery_revision");
@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision
 			     "supports_usb_power_delivery");
 	}
 	kobject_uevent(&partner->dev.kobj, KOBJ_CHANGE);
-
-	return 0;
 }
 EXPORT_SYMBOL_GPL(typec_partner_set_pd_revision);
 
include/linux/usb/typec.h +1 -1
index 4946eca742d5..a94df82ab62f 100644
@@ -126,7 +126,7 @@ struct typec_altmode_desc {
 	enum typec_port_data	roles;
 };
 
-int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
+void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
 int typec_partner_set_num_altmodes(struct typec_partner *partner, int num_altmodes);
 struct typec_altmode
 *typec_partner_register_altmode(struct typec_partner *partner,
Signature · 1 line
2.30.0.365.g02bc693789-goog
#1 lore raw

Hi Kyle,

Quoted 4 lines · Kyle Tso

typec_partner_set_pd_revision doesn't need any return value.

Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")

Review tags for <[email protected]>
Thanks for the quick fix!

Thanks,
Benson

Quoted 52 lines
---
 drivers/usb/typec/class.c | 10 ++--------
 include/linux/usb/typec.h |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)
drivers/usb/typec/class.c +2 -8
index b6ceab3dc16b..a7d1bc83c2d4 100644
@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
  *
  * This routine is used to report that the PD revision of the port partner has
  * become available.
- *
- * Returns 0 on success or negative error number on failure.
  */
-int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
+void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
 {
-	int ret;
-
 	if (partner->pd_revision == pd_revision)
-		return 0;
+		return;
 
 	partner->pd_revision = pd_revision;
 	sysfs_notify(&partner->dev.kobj, NULL, "usb_power_delivery_revision");
@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision
 			     "supports_usb_power_delivery");
 	}
 	kobject_uevent(&partner->dev.kobj, KOBJ_CHANGE);
-
-	return 0;
 }
 EXPORT_SYMBOL_GPL(typec_partner_set_pd_revision);
 
include/linux/usb/typec.h +1 -1
index 4946eca742d5..a94df82ab62f 100644
@@ -126,7 +126,7 @@ struct typec_altmode_desc {
 	enum typec_port_data	roles;
 };
 
-int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
+void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
 int typec_partner_set_num_altmodes(struct typec_partner *partner, int num_altmodes);
 struct typec_altmode
 *typec_partner_register_altmode(struct typec_partner *partner,
Signature · 1 line
2.30.0.365.g02bc693789-goog
Signature · 7 lines
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]
maintainer
#2 lore raw
Quoted 9 lines · Benson Leung

Hi Kyle,

Quoted 4 lines · Kyle Tso

typec_partner_set_pd_revision doesn't need any return value.

Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")

Review tags for <[email protected]>

What does that mean?

Please respond with a line that I can use...

thanks,

greg k-h

Reviewed-by
#3 lore raw
Quoted 6 lines · Greg KH
Quoted 5 lines · Benson Leung

Hi Kyle,

Quoted 2 lines · Kyle Tso

typec_partner_set_pd_revision doesn't need any return value.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")

Review tags for <[email protected]>

What does that mean?

Please respond with a line that I can use...

Sorry.

Benson

Quoted 3 lines

thanks,

greg k-h

Signature · 7 lines
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]
maintainer Reviewed-by on v1 1/1
#4 lore raw
In reply to Kyle Tso
Quoted 4 lines · Kyle Tso

typec_partner_set_pd_revision doesn't need any return value.

Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")

Good catch.

Quoted 51 lines
---
 drivers/usb/typec/class.c | 10 ++--------
 include/linux/usb/typec.h |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)
drivers/usb/typec/class.c +2 -8
index b6ceab3dc16b..a7d1bc83c2d4 100644
@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
  *
  * This routine is used to report that the PD revision of the port partner has
  * become available.
- *
- * Returns 0 on success or negative error number on failure.
  */
-int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
+void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
 {
-	int ret;
-
 	if (partner->pd_revision == pd_revision)
-		return 0;
+		return;
 
 	partner->pd_revision = pd_revision;
 	sysfs_notify(&partner->dev.kobj, NULL, "usb_power_delivery_revision");
@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision
 			     "supports_usb_power_delivery");
 	}
 	kobject_uevent(&partner->dev.kobj, KOBJ_CHANGE);
-
-	return 0;
 }
 EXPORT_SYMBOL_GPL(typec_partner_set_pd_revision);
 
include/linux/usb/typec.h +1 -1
index 4946eca742d5..a94df82ab62f 100644
@@ -126,7 +126,7 @@ struct typec_altmode_desc {
 	enum typec_port_data	roles;
 };
 
-int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
+void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
 int typec_partner_set_num_altmodes(struct typec_partner *partner, int num_altmodes);
 struct typec_altmode
 *typec_partner_register_altmode(struct typec_partner *partner,
Signature · 1 line
2.30.0.365.g02bc693789-goog

thanks,

Signature · 1 line
heikki