usb: typec: Return void in typec_partner_set_pd_revision
Subsystems (2)
PATCH 1/1 usb: typec: Return void in typec_partner_set_pd_revision
typec_partner_set_pd_revision doesn't need any return value.
--- drivers/usb/typec/class.c | 10 ++-------- include/linux/usb/typec.h | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-)
drivers/usb/typec/class.c +2 -8
@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);* * This routine is used to report that the PD revision of the port partner has * become available. -* -* Returns 0 on success or negative error number on failure. */ -int typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision) +void typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision) { -int ret; -if (partner->pd_revision == pd_revision) -return 0 ; +return ; partner->pd_revision = pd_revision;sysfs_notify (&partner->dev.kobj,NULL ,"usb_power_delivery_revision" );
@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision "supports_usb_power_delivery"); }kobject_uevent (&partner->dev.kobj,KOBJ_CHANGE ); - -return 0 ; }EXPORT_SYMBOL_GPL (typec_partner_set_pd_revision);
include/linux/usb/typec.h +1 -1
@@ -126,7 +126,7 @@ struct typec_altmode_desc {enum typec_port_data roles; }; -int typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision); +void typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision);int typec_partner_set_num_altmodes (struct typec_partner *partner,int num_altmodes);struct typec_altmode *typec_partner_register_altmode(struct typec_partner *partner,
Signature · 1 line
2.30.0.365.g02bc693789-goog
Hi Kyle,
Quoted 4 lines · Kyle Tso
typec_partner_set_pd_revisiondoesn't need any return value.Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")Signed-off-by Kyle Tso <[email protected]>
Review tags for <[email protected]>
Thanks for the quick fix!
Thanks,
Benson
Quoted 52 lines
--- drivers/usb/typec/class.c | 10 ++-------- include/linux/usb/typec.h | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-)drivers/usb/typec/class.c +2
-8@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);* * This routine is used to report that the PD revision of the port partner has * become available. -* -* Returns 0 on success or negative error number on failure. */ -int typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision) +void typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision) { -int ret; -if (partner->pd_revision == pd_revision) -return 0 ; +return ; partner->pd_revision = pd_revision;sysfs_notify (&partner->dev.kobj,NULL ,"usb_power_delivery_revision" );@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision "supports_usb_power_delivery"); }kobject_uevent (&partner->dev.kobj,KOBJ_CHANGE ); - -return 0 ; }EXPORT_SYMBOL_GPL (typec_partner_set_pd_revision);include/linux/usb/typec.h +1
-1@@ -126,7 +126,7 @@ struct typec_altmode_desc {enum typec_port_data roles; }; -int typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision); +void typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision);int typec_partner_set_num_altmodes (struct typec_partner *partner,int num_altmodes);struct typec_altmode *typec_partner_register_altmode(struct typec_partner *partner,Signature · 1 line
2.30.0.365.g02bc693789-goog
Signature · 7 lines
Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]
Greg KH
maintainerQuoted 9 lines · Benson Leung
Hi Kyle,
Quoted 4 lines · Kyle Tso
typec_partner_set_pd_revisiondoesn't need any return value.Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")Signed-off-by Kyle Tso <[email protected]>Review tags for <[email protected]>
What does that mean?
Please respond with a line that I can use...
thanks,
greg k-h
Benson Leung
Reviewed-byQuoted 6 lines · Greg KH
Quoted 5 lines · Benson Leung
Hi Kyle,
Quoted 2 lines · Kyle Tso
typec_partner_set_pd_revisiondoesn't need any return value.
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")Signed-off-by Kyle Tso <[email protected]>Review tags for <[email protected]>
What does that mean?
Please respond with a line that I can use...
Sorry.
Benson
Quoted 3 lines
thanks,
greg k-h
Signature · 7 lines
Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]
Quoted 4 lines · Kyle Tso
typec_partner_set_pd_revisiondoesn't need any return value.Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")Signed-off-by Kyle Tso <[email protected]>
Good catch.
Quoted 51 lines
--- drivers/usb/typec/class.c | 10 ++-------- include/linux/usb/typec.h | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-)drivers/usb/typec/class.c +2
-8@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);* * This routine is used to report that the PD revision of the port partner has * become available. -* -* Returns 0 on success or negative error number on failure. */ -int typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision) +void typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision) { -int ret; -if (partner->pd_revision == pd_revision) -return 0 ; +return ; partner->pd_revision = pd_revision;sysfs_notify (&partner->dev.kobj,NULL ,"usb_power_delivery_revision" );@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision "supports_usb_power_delivery"); }kobject_uevent (&partner->dev.kobj,KOBJ_CHANGE ); - -return 0 ; }EXPORT_SYMBOL_GPL (typec_partner_set_pd_revision);include/linux/usb/typec.h +1
-1@@ -126,7 +126,7 @@ struct typec_altmode_desc {enum typec_port_data roles; }; -int typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision); +void typec_partner_set_pd_revision (struct typec_partner *partner,u16 pd_revision);int typec_partner_set_num_altmodes (struct typec_partner *partner,int num_altmodes);struct typec_altmode *typec_partner_register_altmode(struct typec_partner *partner,Signature · 1 line
2.30.0.365.g02bc693789-goog
thanks,
Signature · 1 line
heikki
Greg KH
maintainerQuoted 4 lines · Kyle Tso
typec_partner_set_pd_revisiondoesn't need any return value.Fixes 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")Signed-off-by Kyle Tso <[email protected]>
Thanks, now queued up.
greg k-h