KVM: x86: remove incorrect comment on active_mmu_pages
PATCH 1/1 KVM: x86: remove incorrect comment on active_mmu_pages
The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a list. This patch removes the incorrect comment on active_mmu_pages.
--- arch/x86/include/asm/kvm_host.h | 3 --- 1 file changed, 3 deletions(-)
arch/x86/include/asm/kvm_host.h +0 -3
@@ -937,9 +937,6 @@ struct kvm_arch {unsigned int indirect_shadow_pages;u8 mmu_valid_gen;struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES ]; -/* -* Hash table of struct kvm_mmu_page. -*/ struct list_head active_mmu_pages;struct list_head zapped_obsolete_pages;struct list_head lpage_disallowed_mmu_pages;
Signature · 1 line
2.17.1
Quoted 2 lines · Dongli Zhang
The '
mmu_page_hash' is used as hash table while 'active_mmu_pages' is a list. This patch removes the incorrect comment onactive_mmu_pages.
Maybe change the last sentence to "Remove the misplaced comment, it's mostly stating the obvious anyways." It's more misplaced than flat out incorrect, e.g. the alternative would be to hoist the comment above mmu_page_hash. I like removing it though, IMO mmu_page_hash is the most obvious name out of the various structures that track shadow pages.
With that tweak:
Quoted 22 lines
Signed-off-by Dongli Zhang <[email protected]>--- arch/x86/include/asm/kvm_host.h | 3 --- 1 file changed, 3 deletions(-)arch/x86/include/asm/kvm_host.h +0
-3@@ -937,9 +937,6 @@ struct kvm_arch {unsigned int indirect_shadow_pages;u8 mmu_valid_gen;struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES ]; -/* -* Hash table of struct kvm_mmu_page. -*/ struct list_head active_mmu_pages;struct list_head zapped_obsolete_pages;struct list_head lpage_disallowed_mmu_pages;Signature · 1 line
2.17.1
Quoted 9 lines · Sean Christopherson
Quoted 2 lines · Dongli Zhang
The '
mmu_page_hash' is used as hash table while 'active_mmu_pages' is a list. This patch removes the incorrect comment onactive_mmu_pages.Maybe change the last sentence to "Remove the misplaced comment, it's mostly stating the obvious anyways." It's more misplaced than flat out incorrect, e.g. the alternative would be to hoist the comment above
mmu_page_hash. I like removing it though, IMOmmu_page_hashis the most obvious name out of the various structures that track shadow pages.
Thank you very much!
I will change the last sentence and send v2 with your Reviewed-by.
Dongli Zhang
Quoted 28 lines
With that tweak:
Reviewed-by Sean Christopherson <[email protected]>Quoted 22 lines
Signed-off-by Dongli Zhang <[email protected]>--- arch/x86/include/asm/kvm_host.h | 3 --- 1 file changed, 3 deletions(-)arch/x86/include/asm/kvm_host.h +0
-3@@ -937,9 +937,6 @@ struct kvm_arch {unsigned int indirect_shadow_pages;u8 mmu_valid_gen;struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES ]; -/* -* Hash table of struct kvm_mmu_page. -*/ struct list_head active_mmu_pages;struct list_head zapped_obsolete_pages;struct list_head lpage_disallowed_mmu_pages;Signature · 1 line
2.17.1