staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan
PATCH v2 1/1 staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan
Function _rtl92e_wx_set_scan calls memcpy without checking the length. A user could control that length and trigger a buffer overflow. Fix by checking the length is within the maximum allowed size.
Changes in v2:
Changed to use min_t as per useful suggestions
Signed-off-by Lee Gibson <[email protected]>
--- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +4 -3
@@ -406,9 +406,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,struct iw_scan_req *req = (struct iw_scan_req *)b;if (req->essid_len) { - ieee->current_network.ssid_len = req->essid_len; -memcpy (ieee->current_network.ssid, req->essid, - req->essid_len); +int len =min_t (int, req->essid_len,IW_ESSID_MAX_SIZE ); + + ieee->current_network.ssid_len = len; +memcpy (ieee->current_network.ssid, req->essid, len); } }
Signature · 1 line
2.25.1
Quoted 6 lines · Lee Gibson
Function
_rtl92e_wx_set_scancalls memcpy without checking the length. A user could control that length and trigger a buffer overflow. Fix by checking the length is within the maximum allowed size.Changes in v2:
Changed to usemin_tas per useful suggestions
This kind of information is supposed to go below the --- cut off line
Quoted 3 lines
Signed-off-by Lee Gibson <[email protected]>---
^^^
here.
regards,
dan carpenter