Skip to contentSkip to conversation

staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan

PATCH Superseded Lee Gibson 2 participants 2 messages Feb 26, 2021 Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Lee Gibson

author
#0 lore raw

PATCH v2 1/1 staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan

Function _rtl92e_wx_set_scan calls memcpy without checking the length. A user could control that length and trigger a buffer overflow. Fix by checking the length is within the maximum allowed size.

Changes in v2:
Changed to use min_t as per useful suggestions

---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +4 -3
index 16bcee13f64b..407effde5e71 100644
@@ -406,9 +406,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
 		struct iw_scan_req *req = (struct iw_scan_req *)b;
 
 		if (req->essid_len) {
-			ieee->current_network.ssid_len = req->essid_len;
-			memcpy(ieee->current_network.ssid, req->essid,
-			       req->essid_len);
+			int len = min_t(int, req->essid_len, IW_ESSID_MAX_SIZE);
+
+			ieee->current_network.ssid_len = len;
+			memcpy(ieee->current_network.ssid, req->essid, len);
 		}
 	}
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Lee Gibson

Function _rtl92e_wx_set_scan calls memcpy without checking the length. A user could control that length and trigger a buffer overflow. Fix by checking the length is within the maximum allowed size.

Changes in v2:
Changed to use min_t as per useful suggestions

This kind of information is supposed to go below the --- cut off line

Quoted 3 lines

---

^^^

here.

regards,
dan carpenter