drivers: firmware: efi: fix Kconfig dependency on CRYPTO
Subsystems (2)
PATCH 1/1 drivers: firmware: efi: fix Kconfig dependency on CRYPTO
When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256 without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256 depending on CRYPTO.
--- drivers/firmware/efi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/firmware/efi/Kconfig +1 -0
@@ -248,6 +248,7 @@ endmenu config EFI_EMBEDDED_FIRMWARE bool depends on EFI + select CRYPTO select CRYPTO_LIB_SHA256 config UEFI_CPER
Signature · 1 line
2.27.0
Ard Biesheuvel
maintainerQuoted 9 lines · Julian Braha
When
EFI_EMBEDDED_FIRMWAREis enabled, and CRYPTO is not enabled,Kbuildgives the following warning:WARNING: unmet direct dependencies detected for
CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
-EFI_EMBEDDED_FIRMWARE[=y] && EFI [=y]
Quoted 5 lines
This is because
EFI_EMBEDDED_FIRMWAREselectsCRYPTO_LIB_SHA256without selecting or depending on CRYPTO, despiteCRYPTO_LIB_SHA256depending on CRYPTO.Signed-off-by Julian Braha <[email protected]>
Could you try the below instead? CRYPTO_LIB_SHA256 should not depend on CRYPTO in the first place, we should fix that if we can
crypto/Kconfig +2 -1
@@ -1936,9 +1936,10 @@ config CRYPTO_STATS config CRYPTO_HASH_INFO bool -source "lib/crypto/Kconfig" source "drivers/crypto/Kconfig" source "crypto/asymmetric_keys/Kconfig" source "certs/Kconfig" endif # if CRYPTO + +source "lib/crypto/Kconfig"
Quoted 19 lines
--- drivers/firmware/efi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/firmware/efi/Kconfig +1
-1@@ -248,6 +248,7 @@ endmenu config EFI_EMBEDDED_FIRMWARE bool depends on EFI + select CRYPTO select CRYPTO_LIB_SHA256 config UEFI_CPER --2.27.0
Quoted 52 lines · EST you
Quoted 9 lines · Julian Braha
When
EFI_EMBEDDED_FIRMWAREis enabled, and CRYPTO is not enabled,Kbuildgives the following warning:WARNING: unmet direct dependencies detected for
CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
-EFI_EMBEDDED_FIRMWARE[=y] && EFI [=y]Quoted 5 lines
This is because
EFI_EMBEDDED_FIRMWAREselectsCRYPTO_LIB_SHA256without selecting or depending on CRYPTO, despiteCRYPTO_LIB_SHA256depending on CRYPTO.Signed-off-by Julian Braha <[email protected]>Could you try the below instead?
CRYPTO_LIB_SHA256should not depend on CRYPTO in the first place, we should fix that if we cancrypto/Kconfig +2
-1@@ -1936,9 +1936,10 @@ config CRYPTO_STATS config CRYPTO_HASH_INFO bool -source "lib/crypto/Kconfig" source "drivers/crypto/Kconfig" source "crypto/asymmetric_keys/Kconfig" source "certs/Kconfig" endif # if CRYPTO + +source "lib/crypto/Kconfig"Quoted 17 lines
--- drivers/firmware/efi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/firmware/efi/Kconfig +1
-0@@ -248,6 +248,7 @@ endmenu config EFI_EMBEDDED_FIRMWARE bool depends on EFI + select CRYPTO select CRYPTO_LIB_SHA256
Quoted 5 lines
Quoted 4 lines
drivers/firmware/efi/Kconfig +0
-1config UEFI_CPER --2.27.0
Hi Ard, this solution works fine, and doesn't seem to introduce any new issues with unmet dependencies.
- Julian Braha