Skip to contentSkip to conversation

drivers: firmware: efi: fix Kconfig dependency on CRYPTO

PATCH In review Julian Braha 2 participants 3 messages Feb 27, 2021 – Feb 28, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: firmware: efi: fix Kconfig dependency on CRYPTO

When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]

This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256 without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256 depending on CRYPTO.

---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/efi/Kconfig +1 -0
index 2c3dac5ecb36..f914da9845ac 100644
@@ -248,6 +248,7 @@ endmenu
 config EFI_EMBEDDED_FIRMWARE
 	bool
 	depends on EFI
+	select CRYPTO
 	select CRYPTO_LIB_SHA256
 
 config UEFI_CPER
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 9 lines · Julian Braha

When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]

Quoted 5 lines

This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256 without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256 depending on CRYPTO.

Could you try the below instead? CRYPTO_LIB_SHA256 should not depend on CRYPTO in the first place, we should fix that if we can

crypto/Kconfig +2 -1
index a367fcfeb5d4..77e6bc6df0ee 100644
@@ -1936,9 +1936,10 @@ config CRYPTO_STATS
 config CRYPTO_HASH_INFO
        bool
 
-source "lib/crypto/Kconfig"
 source "drivers/crypto/Kconfig"
 source "crypto/asymmetric_keys/Kconfig"
 source "certs/Kconfig"
 
 endif  # if CRYPTO
+
+source "lib/crypto/Kconfig"
Quoted 19 lines
---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/efi/Kconfig +1 -1
index 2c3dac5ecb36..f914da9845ac 100644
@@ -248,6 +248,7 @@ endmenu
 config EFI_EMBEDDED_FIRMWARE
        bool
        depends on EFI
+       select CRYPTO
        select CRYPTO_LIB_SHA256
 
 config UEFI_CPER
--

2.27.0

#2 lore raw
Quoted 52 lines · EST you
Quoted 9 lines · Julian Braha

When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]

Quoted 5 lines

This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256 without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256 depending on CRYPTO.

Could you try the below instead? CRYPTO_LIB_SHA256 should not depend on CRYPTO in the first place, we should fix that if we can

crypto/Kconfig +2 -1
index a367fcfeb5d4..77e6bc6df0ee 100644
@@ -1936,9 +1936,10 @@ config CRYPTO_STATS
 config CRYPTO_HASH_INFO
        bool
 
-source "lib/crypto/Kconfig"
 source "drivers/crypto/Kconfig"
 source "crypto/asymmetric_keys/Kconfig"
 source "certs/Kconfig"
 
 endif  # if CRYPTO
+
+source "lib/crypto/Kconfig"
Quoted 17 lines

---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/efi/Kconfig +1 -0
index 2c3dac5ecb36..f914da9845ac 100644
@@ -248,6 +248,7 @@ endmenu
 config EFI_EMBEDDED_FIRMWARE
        bool
        depends on EFI
+       select CRYPTO
        select CRYPTO_LIB_SHA256
 
Quoted 5 lines
Quoted 4 lines
drivers/firmware/efi/Kconfig +0 -1
 config UEFI_CPER
--

2.27.0

Hi Ard, this solution works fine, and doesn't seem to introduce any new issues with unmet dependencies.

- Julian Braha