Skip to contentSkip to conversation

Enable stmpe811 touch screen on stm32f429-disco board

PATCH In review [email protected] 4 participants 12 messages Jun 9, 2020 – May 7, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v4 cover Enable stmpe811 touch screen on stm32f429-disco board

From: dillon min <[email protected]>

This patchset is intend to enable stmpe811 touch screen on stm32f429-disco board with three dts and one i2c driver changes.

has been validated by ts_print tool

Changes log:
V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

V3: just add change log in [PATCH V3 3/4] below ---

V2: remove id, blocks, irq-trigger from stmpe811 dts

V1:
ARM: dts: stm32: add I2C3 support on STM32F429 SoC
ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4
ARM: dts: stm32: enable stmpe811 on stm32429-disco board
i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

dillon min (4):
ARM: dts: stm32: add I2C3 support on STM32F429 SoC
ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4
ARM: dts: stm32: enable stmpe811 on stm32429-disco board
i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

 arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 12 +++++++++
 arch/arm/boot/dts/stm32f429-disco.dts  | 47 ++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/stm32f429.dtsi       | 12 +++++++++
 drivers/i2c/busses/i2c-stm32f4.c       | 12 ++++++---
 4 files changed, 80 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH v4 1/4 ARM: dts: stm32: add I2C3 support on STM32F429 SoC

From: dillon min <[email protected]>

This patch adds I2C3 instances of the STM32F429 SoC

---
 arch/arm/boot/dts/stm32f429.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/stm32f429.dtsi +12 -0
index d7770699feb5..257b8431dece 100644
@@ -402,6 +402,18 @@
 			status = "disabled";
 		};
 
+		i2c3: i2c@40005c00 {
+			compatible = "st,stm32f4-i2c";
+			reg = <0x40005c00 0x400>;
+			interrupts = <72>,
+				     <73>;
+			resets = <&rcc STM32F4_APB1_RESET(I2C3)>;
+			clocks = <&rcc 0 STM32F4_APB1_CLOCK(I2C3)>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		dac: dac@40007400 {
 			compatible = "st,stm32f4-dac-core";
 			reg = <0x40007400 0x400>;
Signature · 1 line
2.7.4
#2 lore raw

PATCH v4 2/4 ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4

In reply to [email protected]

From: dillon min <[email protected]>

This patch adds the pin configuration for I2C3 controller on stm32f4.

---
 arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/stm32f4-pinctrl.dtsi +12 -0
index 392fa143ce07..051f33627e15 100644
@@ -316,6 +316,18 @@
 				};
 			};
 
+			i2c3_pins: i2c3-0 {
+				pins {
+					pinmux = <STM32_PINMUX('C', 9, AF4)>,
+						/* I2C3_SDA */
+						 <STM32_PINMUX('A', 8, AF4)>;
+						/* I2C3_SCL */
+					bias-disable;
+					drive-open-drain;
+					slew-rate = <3>;
+				};
+			};
+
 			dcmi_pins: dcmi-0 {
 				pins {
 					pinmux = <STM32_PINMUX('A', 4, AF13)>, /* DCMI_HSYNC */
Signature · 1 line
2.7.4
#3 lore raw

PATCH v4 3/4 ARM: dts: stm32: enable stmpe811 on stm32429-disco board

In reply to [email protected]

From: dillon min <[email protected]>

Enable the stmpe811 touch screen on stm32429-disco board.

---
 arch/arm/boot/dts/stm32f429-disco.dts | 47 +++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
arch/arm/boot/dts/stm32f429-disco.dts +47 -0
index 30c0f6717871..fad1ec10efb6 100644
@@ -49,6 +49,8 @@
 #include "stm32f429.dtsi"
 #include "stm32f429-pinctrl.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "STMicroelectronics STM32F429i-DISCO board";
@@ -127,3 +129,48 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&i2c3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c3_pins>;
+	clock-frequency = <100000>;
+	status = "okay";
+
+	stmpe811@41 {
+		compatible = "st,stmpe811";
+		reg = <0x41>;
+		interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-parent = <&gpioa>;
+		/* 3.25 MHz ADC clock speed */
+		st,adc-freq = <1>;
+		/* 12-bit ADC */
+		st,mod-12b = <1>;
+		/* internal ADC reference */
+		st,ref-sel = <0>;
+		/* ADC converstion time: 80 clocks */
+		st,sample-time = <4>;
+
+		stmpe_touchscreen {
+			compatible = "st,stmpe-ts";
+			/* 8 sample average control */
+			st,ave-ctrl = <3>;
+			/* 7 length fractional part in z */
+			st,fraction-z = <7>;
+			/*
+			 * 50 mA typical 80 mA max touchscreen drivers
+			 * current limit value
+			 */
+			st,i-drive = <1>;
+			/* 1 ms panel driver settling time */
+			st,settling = <3>;
+			/* 5 ms touch detect interrupt delay */
+			st,touch-det-delay = <5>;
+		};
+
+		stmpe_adc {
+			compatible = "st,stmpe-adc";
+			/* forbid to use ADC channels 3-0 (touch) */
+			st,norequest-mask = <0x0F>;
+		};
+	};
+};
Signature · 1 line
2.7.4
#4 lore raw

PATCH v4 4/4 i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

In reply to [email protected]

From: dillon min <[email protected]>

as stm32f429's internal flash is 2Mbytes and compiled kernel image bigger than 2Mbytes, so we have to load kernel image to sdram on stm32f429-disco board which has 8Mbytes sdram space.

based on above context, as you knows kernel running on external sdram is more slower than internal flash. besides, we need read 4 bytes to get touch screen xyz(x, y, pressure) coordinate data in stmpe811 interrupt.

so, in stm32f4_i2c_handle_rx_done, as i2c read slower than running in xip mode, have to adjust 'STOP/START bit set position' from last two bytes to last one bytes. else, will get i2c timeout in reading touch screen coordinate.

to not take side effect, introduce IIC_LAST_BYTE_POS to support xip kernel or has mmu platform.

---

V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

 drivers/i2c/busses/i2c-stm32f4.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-stm32f4.c +9 -3
index d6a69dfcac3f..97cf42ae7fa0 100644
@@ -93,6 +93,12 @@
 #define STM32F4_I2C_MAX_FREQ		46U
 #define HZ_TO_MHZ			1000000
 
+#if !defined(CONFIG_MMU) && !defined(CONFIG_XIP_KERNEL)
+#define IIC_LAST_BYTE_POS 1
+#else
+#define IIC_LAST_BYTE_POS 2
+#endif
+
 /**
  * struct stm32f4_i2c_msg - client specific data
  * @addr: 8-bit slave addr, including r/w bit
@@ -439,7 +445,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 	int i;
 
 	switch (msg->count) {
-	case 2:
+	case IIC_LAST_BYTE_POS:
 		/*
 		 * In order to correctly send the Stop or Repeated Start
 		 * condition on the I2C bus, the STOP/START bit has to be set
@@ -454,7 +460,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 		else
 			stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
 
-		for (i = 2; i > 0; i--)
+		for (i = IIC_LAST_BYTE_POS; i > 0; i--)
 			stm32f4_i2c_read_msg(i2c_dev);
 
 		reg = i2c_dev->base + STM32F4_I2C_CR2;
@@ -463,7 +469,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 
 		complete(&i2c_dev->complete);
 		break;
-	case 3:
+	case (IIC_LAST_BYTE_POS+1):
 		/*
 		 * In order to correctly generate the NACK pulse after the last
 		 * received data byte, we have to enable NACK before reading N-2
Signature · 1 line
2.7.4
author
#5 lore raw

Re: [PATCH v4 4/4] i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Hi All,

Just a gentle ping.

Regards.

Quoted 75 lines · On Tue, Jun 9, 2020 at 9:27 PM <[email protected]> wrote:

From: dillon min <[email protected]>

as stm32f429's internal flash is 2Mbytes and compiled kernel image bigger than 2Mbytes, so we have to load kernel image to sdram on stm32f429-disco board which has 8Mbytes sdram space.

based on above context, as you knows kernel running on external sdram is more slower than internal flash. besides, we need read 4 bytes to get touch screen xyz(x, y, pressure) coordinate data in stmpe811 interrupt.

so, in stm32f4_i2c_handle_rx_done, as i2c read slower than running in xip mode, have to adjust 'STOP/START bit set position' from last two bytes to last one bytes. else, will get i2c timeout in reading touch screen coordinate.

to not take side effect, introduce IIC_LAST_BYTE_POS to support xip kernel or has mmu platform.

---

V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

 drivers/i2c/busses/i2c-stm32f4.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-stm32f4.c +9 -4
index d6a69dfcac3f..97cf42ae7fa0 100644
@@ -93,6 +93,12 @@
 #define STM32F4_I2C_MAX_FREQ           46U
 #define HZ_TO_MHZ                      1000000
 
+#if !defined(CONFIG_MMU) && !defined(CONFIG_XIP_KERNEL)
+#define IIC_LAST_BYTE_POS 1
+#else
+#define IIC_LAST_BYTE_POS 2
+#endif
+
 /**
  * struct stm32f4_i2c_msg - client specific data
  * @addr: 8-bit slave addr, including r/w bit
@@ -439,7 +445,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
        int i;
 
        switch (msg->count) {
-       case 2:
+       case IIC_LAST_BYTE_POS:
                /*
                 * In order to correctly send the Stop or Repeated Start
                 * condition on the I2C bus, the STOP/START bit has to be set
@@ -454,7 +460,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
                else
                        stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
 
-               for (i = 2; i > 0; i--)
+               for (i = IIC_LAST_BYTE_POS; i > 0; i--)
                        stm32f4_i2c_read_msg(i2c_dev);
 
                reg = i2c_dev->base + STM32F4_I2C_CR2;
@@ -463,7 +469,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 
                complete(&i2c_dev->complete);
                break;
-       case 3:
+       case (IIC_LAST_BYTE_POS+1):
                /*
                 * In order to correctly generate the NACK pulse after the last
                 * received data byte, we have to enable NACK before reading N-2
--

2.7.4

#6 lore raw

Re: [PATCH v4 4/4] i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Quoted 3 lines · dillon min

Hi All,

Just a gentle ping.

Pierre-Yves?

Quoted 79 lines

Regards.

Quoted 75 lines · On Tue, Jun 9, 2020 at 9:27 PM <[email protected]> wrote:

From: dillon min <[email protected]>

as stm32f429's internal flash is 2Mbytes and compiled kernel image bigger than 2Mbytes, so we have to load kernel image to sdram on stm32f429-disco board which has 8Mbytes sdram space.

based on above context, as you knows kernel running on external sdram is more slower than internal flash. besides, we need read 4 bytes to get touch screen xyz(x, y, pressure) coordinate data in stmpe811 interrupt.

so, in stm32f4_i2c_handle_rx_done, as i2c read slower than running in xip mode, have to adjust 'STOP/START bit set position' from last two bytes to last one bytes. else, will get i2c timeout in reading touch screen coordinate.

to not take side effect, introduce IIC_LAST_BYTE_POS to support xip kernel or has mmu platform.

---

V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

 drivers/i2c/busses/i2c-stm32f4.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-stm32f4.c +9 -4
index d6a69dfcac3f..97cf42ae7fa0 100644
@@ -93,6 +93,12 @@
 #define STM32F4_I2C_MAX_FREQ           46U
 #define HZ_TO_MHZ                      1000000
 
+#if !defined(CONFIG_MMU) && !defined(CONFIG_XIP_KERNEL)
+#define IIC_LAST_BYTE_POS 1
+#else
+#define IIC_LAST_BYTE_POS 2
+#endif
+
 /**
  * struct stm32f4_i2c_msg - client specific data
  * @addr: 8-bit slave addr, including r/w bit
@@ -439,7 +445,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
        int i;
 
        switch (msg->count) {
-       case 2:
+       case IIC_LAST_BYTE_POS:
                /*
                 * In order to correctly send the Stop or Repeated Start
                 * condition on the I2C bus, the STOP/START bit has to be set
@@ -454,7 +460,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
                else
                        stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
 
-               for (i = 2; i > 0; i--)
+               for (i = IIC_LAST_BYTE_POS; i > 0; i--)
                        stm32f4_i2c_read_msg(i2c_dev);
 
                reg = i2c_dev->base + STM32F4_I2C_CR2;
@@ -463,7 +469,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 
                complete(&i2c_dev->complete);
                break;
-       case 3:
+       case (IIC_LAST_BYTE_POS+1):
                /*
                 * In order to correctly generate the NACK pulse after the last
                 * received data byte, we have to enable NACK before reading N-2
--

2.7.4

author
#7 lore raw

Re: [PATCH v4 4/4] i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Hi Pierre-Yves, Alain

Could you help to take a look?
i really appreciate it.

Thanks,

Best Regards
Dillon

Quoted 87 lines · Wolfram Sang
Quoted 3 lines · dillon min

Hi All,

Just a gentle ping.

Pierre-Yves?

Quoted 79 lines

Regards.

Quoted 75 lines · On Tue, Jun 9, 2020 at 9:27 PM <[email protected]> wrote:

From: dillon min <[email protected]>

as stm32f429's internal flash is 2Mbytes and compiled kernel image bigger than 2Mbytes, so we have to load kernel image to sdram on stm32f429-disco board which has 8Mbytes sdram space.

based on above context, as you knows kernel running on external sdram is more slower than internal flash. besides, we need read 4 bytes to get touch screen xyz(x, y, pressure) coordinate data in stmpe811 interrupt.

so, in stm32f4_i2c_handle_rx_done, as i2c read slower than running in xip mode, have to adjust 'STOP/START bit set position' from last two bytes to last one bytes. else, will get i2c timeout in reading touch screen coordinate.

to not take side effect, introduce IIC_LAST_BYTE_POS to support xip kernel or has mmu platform.

---

V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

 drivers/i2c/busses/i2c-stm32f4.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-stm32f4.c +9 -4
index d6a69dfcac3f..97cf42ae7fa0 100644
@@ -93,6 +93,12 @@
 #define STM32F4_I2C_MAX_FREQ           46U
 #define HZ_TO_MHZ                      1000000
 
+#if !defined(CONFIG_MMU) && !defined(CONFIG_XIP_KERNEL)
+#define IIC_LAST_BYTE_POS 1
+#else
+#define IIC_LAST_BYTE_POS 2
+#endif
+
 /**
  * struct stm32f4_i2c_msg - client specific data
  * @addr: 8-bit slave addr, including r/w bit
@@ -439,7 +445,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
        int i;
 
        switch (msg->count) {
-       case 2:
+       case IIC_LAST_BYTE_POS:
                /*
                 * In order to correctly send the Stop or Repeated Start
                 * condition on the I2C bus, the STOP/START bit has to be set
@@ -454,7 +460,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
                else
                        stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
 
-               for (i = 2; i > 0; i--)
+               for (i = IIC_LAST_BYTE_POS; i > 0; i--)
                        stm32f4_i2c_read_msg(i2c_dev);
 
                reg = i2c_dev->base + STM32F4_I2C_CR2;
@@ -463,7 +469,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 
                complete(&i2c_dev->complete);
                break;
-       case 3:
+       case (IIC_LAST_BYTE_POS+1):
                /*
                 * In order to correctly generate the NACK pulse after the last
                 * received data byte, we have to enable NACK before reading N-2
--

2.7.4

#8 lore raw

Re: [Linux-stm32] [PATCH v4 4/4] i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Hi Dillon

In order to test this patch, it's tricky to make a recent kernel running on stm32f429-disco as this board embeds only 8MB of SDRAM and 2MB of flash.

Can you indicates us which kernel version you are using and also the kernel config please ?

Thanks

Patrice

Quoted 103 lines · dillon min

Hi Pierre-Yves, Alain

Could you help to take a look?
i really appreciate it.

Thanks,

Best Regards
Dillon

Quoted 77 lines · Wolfram Sang
Quoted 3 lines · dillon min

Hi All,

Just a gentle ping.

Pierre-Yves?

Quoted 69 lines

Regards.

Quoted 65 lines · On Tue, Jun 9, 2020 at 9:27 PM <[email protected]> wrote:

From: dillon min <[email protected]>

as stm32f429's internal flash is 2Mbytes and compiled kernel image bigger than 2Mbytes, so we have to load kernel image to sdram on stm32f429-disco board which has 8Mbytes sdram space.

based on above context, as you knows kernel running on external sdram is more slower than internal flash. besides, we need read 4 bytes to get touch screen xyz(x, y, pressure) coordinate data in stmpe811 interrupt.

so, in stm32f4_i2c_handle_rx_done, as i2c read slower than running in xip mode, have to adjust 'STOP/START bit set position' from last two bytes to last one bytes. else, will get i2c timeout in reading touch screen coordinate.

to not take side effect, introduce IIC_LAST_BYTE_POS to support xip kernel or has mmu platform.

---

V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

 drivers/i2c/busses/i2c-stm32f4.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-stm32f4.c +8 -2
index d6a69dfcac3f..97cf42ae7fa0 100644
@@ -93,6 +93,12 @@
 #define STM32F4_I2C_MAX_FREQ           46U
 #define HZ_TO_MHZ                      1000000
 
+#if !defined(CONFIG_MMU) && !defined(CONFIG_XIP_KERNEL)
+#define IIC_LAST_BYTE_POS 1
+#else
+#define IIC_LAST_BYTE_POS 2
+#endif
+
 /**
  * struct stm32f4_i2c_msg - client specific data
  * @addr: 8-bit slave addr, including r/w bit
@@ -439,7 +445,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
        int i;
 
        switch (msg->count) {
-       case 2:
+       case IIC_LAST_BYTE_POS:
                /*
                 * In order to correctly send the Stop or Repeated Start
                 * condition on the I2C bus, the STOP/START bit has to be set
@@ -454,7 +460,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
                else
                        stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
 
-               for (i = 2; i > 0; i--)
+               for (i = IIC_LAST_BYTE_POS; i > 0; i--)
                        stm32f4_i2c_read_msg(i2c_dev);
 
                reg = i2c_dev->base + STM32F4_I2C_CR2;
@@ -463,7 +469,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/i2c/busses/i2c-stm32f4.c +1 -2
                complete(&i2c_dev->complete);
                break;
-       case 3:
+       case (IIC_LAST_BYTE_POS+1):
                /*
                 * In order to correctly generate the NACK pulse after the last
                 * received data byte, we have to enable NACK before reading N-2
--

2.7.4

_______________________________________________
Linux-stm32 mailing list
[email protected]
https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32

author
#9 lore raw

Re: [Linux-stm32] [PATCH v4 4/4] i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Hi Patrice

Thanks for the reply.

Quoted 7 lines · Patrice CHOTARD

Hi Dillon

In order to test this patch, it's tricky to make a recent kernel running on stm32f429-disco as this board embeds only 8MB of SDRAM and 2MB of flash.

Can you indicates us which kernel version you are using and also the kernel config please ?

Since this patch was submitted in last year, might it be 5.0? not for sure Anyway, I will resubmit it in the recent kernel version with the kernel config and a detailed test step for you.

Thanks for your time.

Quoted 109 lines

Thanks

Patrice

Quoted 103 lines · dillon min

Hi Pierre-Yves, Alain

Could you help to take a look?
i really appreciate it.

Thanks,

Best Regards
Dillon

Quoted 77 lines · Wolfram Sang
Quoted 3 lines · dillon min

Hi All,

Just a gentle ping.

Pierre-Yves?

Quoted 69 lines

Regards.

Quoted 65 lines · On Tue, Jun 9, 2020 at 9:27 PM <[email protected]> wrote:

From: dillon min <[email protected]>

as stm32f429's internal flash is 2Mbytes and compiled kernel image bigger than 2Mbytes, so we have to load kernel image to sdram on stm32f429-disco board which has 8Mbytes sdram space.

based on above context, as you knows kernel running on external sdram is more slower than internal flash. besides, we need read 4 bytes to get touch screen xyz(x, y, pressure) coordinate data in stmpe811 interrupt.

so, in stm32f4_i2c_handle_rx_done, as i2c read slower than running in xip mode, have to adjust 'STOP/START bit set position' from last two bytes to last one bytes. else, will get i2c timeout in reading touch screen coordinate.

to not take side effect, introduce IIC_LAST_BYTE_POS to support xip kernel or has mmu platform.

---

V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

 drivers/i2c/busses/i2c-stm32f4.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-stm32f4.c +8 -2
index d6a69dfcac3f..97cf42ae7fa0 100644
@@ -93,6 +93,12 @@
 #define STM32F4_I2C_MAX_FREQ           46U
 #define HZ_TO_MHZ                      1000000
 
+#if !defined(CONFIG_MMU) && !defined(CONFIG_XIP_KERNEL)
+#define IIC_LAST_BYTE_POS 1
+#else
+#define IIC_LAST_BYTE_POS 2
+#endif
+
 /**
  * struct stm32f4_i2c_msg - client specific data
  * @addr: 8-bit slave addr, including r/w bit
@@ -439,7 +445,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
        int i;
 
        switch (msg->count) {
-       case 2:
+       case IIC_LAST_BYTE_POS:
                /*
                 * In order to correctly send the Stop or Repeated Start
                 * condition on the I2C bus, the STOP/START bit has to be set
@@ -454,7 +460,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
                else
                        stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
 
-               for (i = 2; i > 0; i--)
+               for (i = IIC_LAST_BYTE_POS; i > 0; i--)
                        stm32f4_i2c_read_msg(i2c_dev);
 
                reg = i2c_dev->base + STM32F4_I2C_CR2;
@@ -463,7 +469,7 @@ static void stm32f4_i2c_handle_rx_done(struct stm32f4_i2c_dev *i2c_dev)
 
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/i2c/busses/i2c-stm32f4.c +1 -2
                complete(&i2c_dev->complete);
                break;
-       case 3:
+       case (IIC_LAST_BYTE_POS+1):
                /*
                 * In order to correctly generate the NACK pulse after the last
                 * received data byte, we have to enable NACK before reading N-2
--

2.7.4

_______________________________________________
Linux-stm32 mailing list
[email protected]
https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32

---
Best regards
Dillon,

#10 lore raw
In reply to [email protected]

Hi Dillon

Quoted 26 lines · On 6/9/20 3:26 PM, [email protected] wrote:

From: dillon min <[email protected]>

This patchset is intend to enable stmpe811 touch screen on stm32f429-disco board with three dts and one i2c driver changes.

has been validated by ts_print tool

Changes log:
V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

V3: just add change log in [PATCH V3 3/4] below ---

V2: remove id, blocks, irq-trigger from stmpe811 dts

V1:
ARM: dts: stm32: add I2C3 support on STM32F429 SoC
ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4
ARM: dts: stm32: enable stmpe811 on stm32429-disco board
i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

dillon min (4):
ARM: dts: stm32: add I2C3 support on STM32F429 SoC
ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4
ARM: dts: stm32: enable stmpe811 on stm32429-disco board
i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Quoted 6 lines
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 12 +++++++++
  arch/arm/boot/dts/stm32f429-disco.dts  | 47 ++++++++++++++++++++++++++++++++++
  arch/arm/boot/dts/stm32f429.dtsi       | 12 +++++++++
  drivers/i2c/busses/i2c-stm32f4.c       | 12 ++++++---
  4 files changed, 80 insertions(+), 3 deletions(-)

DT patches applied on stm32-next. I changed node ordering in patch 3.

Thanks
Alex

author
#11 lore raw
Quoted 30 lines · Alexandre Torgue

Hi Dillon

Quoted 26 lines · On 6/9/20 3:26 PM, [email protected] wrote:

From: dillon min <[email protected]>

This patchset is intend to enable stmpe811 touch screen on stm32f429-disco board with three dts and one i2c driver changes.

has been validated by ts_print tool

Changes log:
V4: indroduce 'IIC_LAST_BYTE_POS' to compatible with xipkernel boot

V3: just add change log in [PATCH V3 3/4] below ---

V2: remove id, blocks, irq-trigger from stmpe811 dts

V1:
ARM: dts: stm32: add I2C3 support on STM32F429 SoC
ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4
ARM: dts: stm32: enable stmpe811 on stm32429-disco board
i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

dillon min (4):
ARM: dts: stm32: add I2C3 support on STM32F429 SoC
ARM: dts: stm32: Add pin map for I2C3 controller on stm32f4
ARM: dts: stm32: enable stmpe811 on stm32429-disco board
i2c: stm32f4: Fix stmpe811 get xyz data timeout issue

Quoted 8 lines
Quoted 6 lines
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 12 +++++++++
  arch/arm/boot/dts/stm32f429-disco.dts  | 47 ++++++++++++++++++++++++++++++++++
  arch/arm/boot/dts/stm32f429.dtsi       | 12 +++++++++
  drivers/i2c/busses/i2c-stm32f4.c       | 12 ++++++---
  4 files changed, 80 insertions(+), 3 deletions(-)

DT patches applied on stm32-next. I changed node ordering in patch 3.

Okay, thanks.

Regards,
Dillon,

Quoted 3 lines

Thanks
Alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel