Rid W=1 warnings from ATA
cover Rid W=1 warnings from ATA
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings.
This is set 2 out of 2 sets required.
Lee Jones (15):
ata: pata_pdc202xx_old: Fix some incorrectly named functions
ata: pata_sil680: Add some missing function parameter docs
ata: pata_sis: Remove superfluous param description and supply another
ata: pata_triflex: Repair some misnamed functions and fix some param
descriptions
ata: pata_it821x: Fix possible doc-rotted function names
ata: pata_via: Fix a kernel-doc formatting issue
ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header
ata: pata_sl82c105: Fix potential doc-rot
ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'
ata: pata_legacy: Repair a couple kernel-doc problems
ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param
ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()'
ata: libata-acpi: Fix function name and provide description for
'prev_gtf'
ata: pata_acpi: Fix some incorrect function param descriptions
drivers/ata/ata_generic.c | 2 +- drivers/ata/libata-acpi.c | 3 ++- drivers/ata/pata_acpi.c | 6 +++--- drivers/ata/pata_cs5530.c | 2 +- drivers/ata/pata_it821x.c | 4 ++-- drivers/ata/pata_legacy.c | 8 ++++---- drivers/ata/pata_opti.c | 2 +- drivers/ata/pata_pdc202xx_old.c | 4 ++-- drivers/ata/pata_piccolo.c | 2 +- drivers/ata/pata_sil680.c | 2 ++ drivers/ata/pata_sis.c | 2 +- drivers/ata/pata_sl82c105.c | 2 +- drivers/ata/pata_triflex.c | 7 +++---- drivers/ata/pata_via.c | 2 +- drivers/ata/sata_mv.c | 2 +- 15 files changed, 26 insertions(+), 24 deletions(-)
Signature · 1 line
2.27.0
PATCH 1/15 ata: pata_pdc202xx_old: Fix some incorrectly named functions
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_pdc202xx_old.c:127: warning: expecting prototype for pdc202xx_configure_dmamode(). Prototype was for pdc202xx_set_dmamode() instead drivers/ata/pata_pdc202xx_old.c:228: warning: expecting prototype for pdc2026x_bmdma_end(). Prototype was for pdc2026x_bmdma_stop() instead
--- drivers/ata/pata_pdc202xx_old.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/pata_pdc202xx_old.c +2 -2
@@ -115,7 +115,7 @@ static void pdc202xx_set_piomode(struct ata_port *ap, struct ata_device *adev) }/** -* pdc202xx_configure_dmamode - set DMA mode in chip +* pdc202xx_set_dmamode - set DMA mode in chip * @ap: ATA interface * @adev: ATA device *
@@ -214,7 +214,7 @@ static void pdc2026x_bmdma_start(struct ata_queued_cmd *qc) }/** -* pdc2026x_bmdma_end - DMA engine stop +* pdc2026x_bmdma_stop - DMA engine stop * @qc: ATA command * * After a DMA completes we need to put the clock back to 33MHz for
Signature · 1 line
2.27.0
PATCH 2/15 ata: pata_sil680: Add some missing function parameter docs
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_sil680.c:68: warning: Function parameter or member 'adev' not described in 'sil680_seldev' drivers/ata/pata_sil680.c:254: warning: Function parameter or member 'try_mmio' not described in 'sil680_init_chip'
--- drivers/ata/pata_sil680.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/ata/pata_sil680.c +2 -0
@@ -57,6 +57,7 @@ static unsigned long sil680_selreg(struct ata_port *ap, int r)/** * sil680_seldev - return register base * @ap: ATA interface +* @adev: ATA device * @r: config offset * * Turn a config register offset into the right address in PCI space
@@ -244,6 +245,7 @@ static struct ata_port_operations sil680_port_ops = {/** * sil680_init_chip - chip setup * @pdev: PCI device +* @try_mmio: Indicates to caller whether MMIO should be attempted * * Perform all the chip setup which must be done both when the device * is powered up on boot and when we resume in case we resumed from RAM.
Signature · 1 line
2.27.0
PATCH 3/15 ata: pata_sis: Remove superfluous param description and supply another
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_sis.c:124: warning: Excess function parameter 'deadline' description in 'sis_133_cable_detect' drivers/ata/pata_sis.c:529: warning: Function parameter or member 'mask' not described in 'sis_133_mode_filter'
--- drivers/ata/pata_sis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_sis.c +1 -1
@@ -114,7 +114,6 @@ static int sis_port_base(struct ata_device *adev)/** * sis_133_cable_detect - check for 40/80 pin * @ap: Port -* @deadline: deadline jiffies for the operation * * Perform cable detection for the later UDMA133 capable * SiS chipset.
@@ -521,6 +520,7 @@ static void sis_133_set_dmamode (struct ata_port *ap, struct ata_device *adev)/** * sis_133_mode_filter - mode selection filter * @adev: ATA device +* @mask: received mask to manipulate and pass back * * Block UDMA6 on devices that do not support it. */
Signature · 1 line
2.27.0
PATCH 4/15 ata: pata_triflex: Repair some misnamed functions and fix some param descriptions
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_triflex.c:143: warning: expecting prototype for triflex_dma_start(). Prototype was for triflex_bmdma_start() instead drivers/ata/pata_triflex.c:159: warning: Function parameter or member 'qc' not described in 'triflex_bmdma_stop' drivers/ata/pata_triflex.c:159: warning: expecting prototype for triflex_dma_stop(). Prototype was for triflex_bmdma_stop() instead
--- drivers/ata/pata_triflex.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/ata/pata_triflex.c +3 -4
@@ -129,7 +129,7 @@ static void triflex_set_piomode(struct ata_port *ap, struct ata_device *adev) }/** -* triflex_dma_start - DMA start callback +* triflex_bmdma_start - DMA start callback * @qc: Command in progress * * Usually drivers set the DMA timing at the point the set_dmamode call
@@ -146,9 +146,8 @@ static void triflex_bmdma_start(struct ata_queued_cmd *qc) }/** -* triflex_dma_stop - DMA stop callback -* @ap: ATA interface -* @adev: ATA device +* triflex_bmdma_stop - DMA stop callback +* @qc: ATA command * * We loaded new timings in dma_start, as a result we need to restore * the PIO timings in dma_stop so that the next command issue gets the
Signature · 1 line
2.27.0
PATCH 5/15 ata: pata_it821x: Fix possible doc-rotted function names
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_it821x.c:346: warning: expecting prototype for it821x_passthru_dma_start(). Prototype was for it821x_passthru_bmdma_start() instead drivers/ata/pata_it821x.c:369: warning: expecting prototype for it821x_passthru_dma_stop(). Prototype was for it821x_passthru_bmdma_stop() instead
--- drivers/ata/pata_it821x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/pata_it821x.c +2 -2
@@ -334,7 +334,7 @@ static void it821x_passthru_set_dmamode(struct ata_port *ap, struct ata_device * }/** -* it821x_passthru_dma_start - DMA start callback +* it821x_passthru_bmdma_start - DMA start callback * @qc: Command in progress * * Usually drivers set the DMA timing at the point the set_dmamode call
@@ -357,7 +357,7 @@ static void it821x_passthru_bmdma_start(struct ata_queued_cmd *qc) }/** -* it821x_passthru_dma_stop - DMA stop callback +* it821x_passthru_bmdma_stop - DMA stop callback * @qc: ATA command * * We loaded new timings in dma_start, as a result we need to restore
Signature · 1 line
2.27.0
PATCH 6/15 ata: pata_via: Fix a kernel-doc formatting issue
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_via.c:675: warning: Function parameter or member 'pdev' not described in 'via_reinit_one'
--- drivers/ata/pata_via.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_via.c +1 -1
@@ -663,7 +663,7 @@ static int via_init_one(struct pci_dev *pdev, const struct pci_device_id *id)#ifdef CONFIG_PM_SLEEP /** * via_reinit_one - reinit after resume -* @pdev; PCI device +* @pdev: PCI device * * Called when the VIA PATA device is resumed. We must then * reconfigure the fifo and other setup we may have altered. In
Signature · 1 line
2.27.0
PATCH 7/15 ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_piccolo.c:87: warning: expecting prototype for ata_tosh_init(). Prototype was for ata_tosh_init_one() instead
--- drivers/ata/pata_piccolo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_piccolo.c +1 -1
@@ -74,7 +74,7 @@ static struct ata_port_operations tosh_port_ops = { };/** -* ata_tosh_init - attach generic IDE +* ata_tosh_init_one - attach generic IDE * @dev: PCI device found * @id: match entry *
Signature · 1 line
2.27.0
PATCH 8/15 ata: pata_sl82c105: Fix potential doc-rot
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_sl82c105.c:191: warning: expecting prototype for sl82c105_bmdma_end(). Prototype was for sl82c105_bmdma_stop() instead
--- drivers/ata/pata_sl82c105.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_sl82c105.c +1 -1
@@ -173,7 +173,7 @@ static void sl82c105_bmdma_start(struct ata_queued_cmd *qc) }/** -* sl82c105_bmdma_end - DMA engine stop +* sl82c105_bmdma_stop - DMA engine stop * @qc: ATA command * * Reset the DMA engine each use as recommended by the errata
Signature · 1 line
2.27.0
PATCH 9/15 ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_opti.c:82: warning: Function parameter or member 'val' not described in 'opti_write_reg' drivers/ata/pata_opti.c:82: warning: Excess function parameter 'value' description in 'opti_write_reg'
--- drivers/ata/pata_opti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_opti.c +1 -1
@@ -69,7 +69,7 @@ static int opti_pre_reset(struct ata_link *link, unsigned long deadline)/** * opti_write_reg - control register setup * @ap: ATA port -* @value: value +* @val: value * @reg: control register number * * The Opti uses magic 'trapdoor' register accesses to do configuration
Signature · 1 line
2.27.0
PATCH 10/15 ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/ata_generic.c:164: warning: expecting prototype for ata_generic_init(). Prototype was for ata_generic_init_one() instead
--- drivers/ata/ata_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/ata_generic.c +1 -1
@@ -151,7 +151,7 @@ static int is_intel_ider(struct pci_dev *dev) }/** -* ata_generic_init - attach generic IDE +* ata_generic_init_one - attach generic IDE * @dev: PCI device found * @id: match entry *
Signature · 1 line
2.27.0
PATCH 11/15 ata: pata_legacy: Repair a couple kernel-doc problems
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_legacy.c:606: warning: expecting prototype for opt82c465mv_qc_issue(). Prototype was for opti82c46x_qc_issue() instead drivers/ata/pata_legacy.c:933: warning: Function parameter or member 'probe' not described in 'legacy_init_one' drivers/ata/pata_legacy.c:933: warning: Excess function parameter 'pl' description in 'legacy_init_one' drivers/ata/pata_legacy.c:1024: warning: Function parameter or member 'primary' not described in 'legacy_check_special_cases' drivers/ata/pata_legacy.c:1024: warning: Function parameter or member 'secondary' not described in 'legacy_check_special_cases' drivers/ata/pata_legacy.c:1024: warning: Excess function parameter 'master' description in 'legacy_check_special_cases' drivers/ata/pata_legacy.c:1024: warning: Excess function parameter 'master' description in 'legacy_check_special_cases'
--- drivers/ata/pata_legacy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/ata/pata_legacy.c +4 -4
@@ -588,7 +588,7 @@ static void opti82c46x_set_piomode(struct ata_port *ap, struct ata_device *adev) }/** -* opt82c465mv_qc_issue - command issue +* opti82c46x_qc_issue - command issue * @qc: command pending * * Called when the libata layer is about to issue a command. We wrap
@@ -923,7 +923,7 @@ static __init int probe_chip_type(struct legacy_probe *probe)/** * legacy_init_one - attach a legacy interface -* @pl: probe record +* @probe: probe record * * Register an ISA bus IDE interface. Such interfaces are PIO and we * assume do not support IRQ sharing.
@@ -1009,8 +1009,8 @@ static __init int legacy_init_one(struct legacy_probe *probe)/** * legacy_check_special_cases - ATA special cases * @p: PCI device to check -* @master: set this if we find an ATA master -* @master: set this if we find an ATA secondary +* @primary: set this if we find an ATA master +* @secondary: set this if we find an ATA secondary * * A small number of vendors implemented early PCI ATA interfaces * on bridge logic without the ATA interface being PCI visible.
Signature · 1 line
2.27.0
PATCH 12/15 ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_cs5530.c:283: warning: Function parameter or member 'pdev' not described in 'cs5530_init_one' drivers/ata/pata_cs5530.c:283: warning: Excess function parameter 'dev' description in 'cs5530_init_one'
--- drivers/ata/pata_cs5530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_cs5530.c +1 -1
@@ -271,7 +271,7 @@ static int cs5530_init_chip(void)/** * cs5530_init_one - Initialise a CS5530 -* @dev: PCI device +* @pdev: PCI device * @id: Entry in match table * * Install a driver for the newly found CS5530 companion chip. Most of
Signature · 1 line
2.27.0
PATCH 13/15 ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/sata_mv.c:1929: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead
--- drivers/ata/sata_mv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_mv.c +1 -1
@@ -1917,7 +1917,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc) }/** -* mv_bmdma_stop - Stop BMDMA transfer +* mv_bmdma_stop_ap - Stop BMDMA transfer * @ap: port to stop * * Clears the ATA_DMA_START flag in the bmdma control register
Signature · 1 line
2.27.0
PATCH 14/15 ata: libata-acpi: Fix function name and provide description for 'prev_gtf'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/libata-acpi.c:493: warning: expecting prototype for ata_acpi_gtm_xfermode(). Prototype was for ata_acpi_gtm_xfermask() instead drivers/ata/libata-acpi.c:648: warning: Function parameter or member 'prev_gtf' not described in 'ata_acpi_run_tf'
--- drivers/ata/libata-acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/libata-acpi.c +2 -1
@@ -476,7 +476,7 @@ static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf) }/** -* ata_acpi_gtm_xfermode - determine xfermode from GTM parameter +* ata_acpi_gtm_xfermask - determine xfermode from GTM parameter * @dev: target device * @gtm: GTM parameter to use *
@@ -624,6 +624,7 @@ static int ata_acpi_filter_tf(struct ata_device *dev,* ata_acpi_run_tf - send taskfile registers to host controller * @dev: target ATA device * @gtf: raw ATA taskfile register set (0x1f1 - 0x1f7) +* @prev_gtf: previous command * * Outputs ATA taskfile to standard ATA host controller. * Writes the control, feature, nsect, lbal, lbam, and lbah registers.
Signature · 1 line
2.27.0
PATCH 15/15 ata: pata_acpi: Fix some incorrect function param descriptions
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/ata/pata_acpi.c:38: warning: Function parameter or member 'link' not described in 'pacpi_pre_reset' drivers/ata/pata_acpi.c:38: warning: Excess function parameter 'ap' description in 'pacpi_pre_reset' drivers/ata/pata_acpi.c:74: warning: Function parameter or member 'ap' not described in 'pacpi_discover_modes' drivers/ata/pata_acpi.c:74: warning: Excess function parameter 'mask' description in 'pacpi_discover_modes' drivers/ata/pata_acpi.c:239: warning: Function parameter or member 'id' not described in 'pacpi_init_one' drivers/ata/pata_acpi.c:239: warning: Excess function parameter 'ent' description in 'pacpi_init_one'
--- drivers/ata/pata_acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ata/pata_acpi.c +3 -3
@@ -28,7 +28,7 @@ struct pata_acpi {/** * pacpi_pre_reset - check for 40/80 pin -* @ap: Port +* @link: ATA link * @deadline: deadline jiffies for the operation * * Perform the PATA port setup we need.
@@ -63,8 +63,8 @@ static int pacpi_cable_detect(struct ata_port *ap)/** * pacpi_discover_modes - filter non ACPI modes +* @ap: ATA port * @adev: ATA device -* @mask: proposed modes * * Try the modes available and see which ones the ACPI method will * set up sensibly. From this we get a mask of ACPI modes we can use
@@ -224,7 +224,7 @@ static struct ata_port_operations pacpi_ops = {/** * pacpi_init_one - Register ACPI ATA PCI device with kernel services * @pdev: PCI device to register -* @ent: Entry in pacpi_pci_tbl matching with @pdev +* @id: PCI device ID * * Called from kernel PCI layer. *
Signature · 1 line
2.27.0
Quoted 22 lines · Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings.
This is set 2 out of 2 sets required.
Lee Jones (15):
ata:pata_pdc202xx_old: Fix some incorrectly named functions
ata:pata_sil680: Add some missing function parameter docs
ata:pata_sis: Remove superfluous param description and supply another
ata:pata_triflex: Repair some misnamed functions and fix some param
descriptions
ata:pata_it821x: Fix possible doc-rotted function names
ata:pata_via: Fix a kernel-doc formatting issue
ata:pata_piccolo: 'ata_tosh_init()' is misnamed in its header
ata:pata_sl82c105: Fix potential doc-rot
ata:pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
ata:ata_generic: Fix misspelling of 'ata_generic_init_one()'
ata:pata_legacy: Repair a couple kernel-doc problems
ata:pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param
ata:sata_mv: Fix misnaming of 'mv_bmdma_stop()'
ata: libata-acpi: Fix function name and provide description for
Quoted 2 lines
'prev_gtf'ata:
pata_acpi: Fix some incorrect function param descriptions
Would you like me to resubmit these?
Quoted 33 lines
drivers/ata/ata_generic.c | 2 +- drivers/ata/libata-acpi.c | 3 ++- drivers/ata/pata_acpi.c | 6 +++--- drivers/ata/pata_cs5530.c | 2 +- drivers/ata/pata_it821x.c | 4 ++-- drivers/ata/pata_legacy.c | 8 ++++---- drivers/ata/pata_opti.c | 2 +- drivers/ata/pata_pdc202xx_old.c | 4 ++-- drivers/ata/pata_piccolo.c | 2 +- drivers/ata/pata_sil680.c | 2 ++ drivers/ata/pata_sis.c | 2 +- drivers/ata/pata_sl82c105.c | 2 +- drivers/ata/pata_triflex.c | 7 +++---- drivers/ata/pata_via.c | 2 +- drivers/ata/sata_mv.c | 2 +- 15 files changed, 26 insertions(+), 24 deletions(-)Cc Alan Cox <[email protected]>Cc ALWAYS copy <[email protected]>Cc Andre Hedrick <[email protected]>Cc Colten Edwards <[email protected]>Cc Hat Inc <[email protected]>Cc Jan Harkes <[email protected]>Cc Jaromir Koutek <[email protected]>Cc Jens Axboe <[email protected]>Cc "L.C. Chang" <[email protected]>Cc Lionel Bouton <[email protected]>Cc Mark Lord <[email protected]>Cc Red Hat <[email protected]>Cc Samuel Thibault <[email protected]>Cc Torben Mathiasen <[email protected]>Cc Vojtech Pavlik <[email protected]>
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Jens Axboe
AppliedQuoted 5 lines · Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings.
This is set 2 out of 2 sets required.
Applied, thanks.
Signature · 1 line
Jens Axboe