staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h
PATCH v2 1/1 staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h
Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.
--- drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/hal/Hal8723BReg.h +8 -8
@@ -110,7 +110,7 @@#define REG_RSVD3_8723B 0x0168#define REG_C2HEVT_MSG_NORMAL_8723B 0x01A0#define REG_C2HEVT_CMD_SEQ_88XX 0x01A1 -#define REG_C2hEVT_CMD_CONTENT_88XX 0x01A2 +#define REG_C2HEVT_CMD_CONTENT_88XX 0x01A2#define REG_C2HEVT_CMD_LEN_88XX 0x01AE#define REG_C2HEVT_CLEAR_8723B 0x01AF#define REG_MCUTST_1_8723B 0x01C0
@@ -424,13 +424,13 @@#define IMR_RXFOVW_8723B BIT8/* Receive FIFO Overflow */ /* 2 ACMHWCTRL 0x05C0 */ -#define AcmHw_HwEn_8723B BIT(0) -#define AcmHw_VoqEn_8723B BIT(1) -#define AcmHw_ViqEn_8723B BIT(2) -#define AcmHw_BeqEn_8723B BIT(3) -#define AcmHw_VoqStatus_8723B BIT(5) -#define AcmHw_ViqStatus_8723B BIT(6) -#define AcmHw_BeqStatus_8723B BIT(7) +#define ACMHW_HWEN_8723B BIT(0) +#define ACMHW_VOQEN_8723B BIT(1) +#define ACMHW_VIQEN_8723B BIT(2) +#define ACMHW_BEQEN_8723B BIT(3) +#define ACMHW_VOQSTATUS_8723B BIT(5) +#define ACMHW_VIQSTATUS_8723B BIT(6) +#define ACMHW_BEQSTATUS_8723B BIT(7)/* 8195 (RCR) Receive Configuration Register (Offset 0x608, 32 bits) */ #define RCR_TCPOFLD_EN BIT25/* Enable TCP checksum offload */
Signature · 1 line
2.30.2
Greg KH
maintainerQuoted 7 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
If this is "v2", you need to put below the --- line what changed from v1.
Please fix up and send a v3.
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 3 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)If this is "v2", you need to put below the --- line what changed from v1.
It is a v2 only because you made me notice that I forgot to cc linux-staging and linux-kernel.
So I sent it again, but probably I shouldn't have changed the version number because nothing else had changed.
Quoted 2 lines
Please fix up and send a v3.
No problem at all. I can explain in the patch v3 what I wrote above. May you please confirm that a patch v3 is the correct solution even when nothing changes in the code?
Thanks for your help,
Fabio
Quoted 3 lines
thanks,
greg k-h
Quoted 19 lines · FMDF
Quoted 5 lines · Greg KH
Quoted 3 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.Quoted 7 lines
Quoted 4 lines
Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)If this is "v2", you need to put below the --- line what changed from v1.
It is a v2 only because you made me notice that I forgot to cc linux-staging and linux-kernel.
So I sent it again, but probably I shouldn't have changed the version number because nothing else had changed.
Quoted 6 lines
Quoted 2 lines
Please fix up and send a v3.
No problem at all. I can explain in the patch v3 what I wrote above. May you please confirm that a patch v3 is the correct solution even when nothing changes in the code?
When Greg acknowledges your patch, everyone who is concerned with the patch should see it. So he needs to pick up the right version of the patch that has everyone in CC. He can use the version number to choose the most recent one.
The version numbers don't appear anywhere once the code is committed. So it's not a problem to move up to the next version for any reason. On the other hand, if you skip a version, it can be a problem, because someone may wonder if they missed some useful information.
julia
Quoted 14 lines
Thanks for your help,
Fabio
Quoted 3 lines
thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAPj211u9MHgtjeZGUPsLxU3HkbJ8cr2EUL0v9HA7LE9-b1uUoA%40mail.gmail.com.
Quoted 36 lines · Julia Lawall
Quoted 19 lines · FMDF
Quoted 5 lines · Greg KH
Quoted 3 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.Quoted 7 lines
Quoted 4 lines
Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)If this is "v2", you need to put below the --- line what changed from v1.
It is a v2 only because you made me notice that I forgot to cc linux-staging and linux-kernel.
So I sent it again, but probably I shouldn't have changed the version number because nothing else had changed.Quoted 6 lines
Quoted 2 lines
Please fix up and send a v3.
No problem at all. I can explain in the patch v3 what I wrote above. May you please confirm that a patch v3 is the correct solution even when nothing changes in the code?
When Greg acknowledges your patch, everyone who is concerned with the patch should see it. So he needs to pick up the right version of the patch that has everyone in CC. He can use the version number to choose the most recent one.
Quoted 7 lines
The version numbers don't appear anywhere once the code is committed. So it's not a problem to move up to the next version for any reason. On the other hand, if you skip a version, it can be a problem, because someone may wonder if they missed some useful information.
julia
Thanks for your clear explanation of these details of the workflow,
Fabio
Quoted 14 lines
Quoted 14 lines
Thanks for your help,
Fabio
Quoted 3 lines
thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAPj211u9MHgtjeZGUPsLxU3HkbJ8cr2EUL0v9HA7LE9-b1uUoA%40mail.gmail.com.