staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h
PATCH v3 1/1 staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h
Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.
---
Patch v3 changes nothing with respect to v2 and v1. It exists only to cc some recipients that were missing in the header of the previous email.
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/hal/Hal8723BReg.h +8 -8
@@ -110,7 +110,7 @@#define REG_RSVD3_8723B 0x0168#define REG_C2HEVT_MSG_NORMAL_8723B 0x01A0#define REG_C2HEVT_CMD_SEQ_88XX 0x01A1 -#define REG_C2hEVT_CMD_CONTENT_88XX 0x01A2 +#define REG_C2HEVT_CMD_CONTENT_88XX 0x01A2#define REG_C2HEVT_CMD_LEN_88XX 0x01AE#define REG_C2HEVT_CLEAR_8723B 0x01AF#define REG_MCUTST_1_8723B 0x01C0
@@ -424,13 +424,13 @@#define IMR_RXFOVW_8723B BIT8/* Receive FIFO Overflow */ /* 2 ACMHWCTRL 0x05C0 */ -#define AcmHw_HwEn_8723B BIT(0) -#define AcmHw_VoqEn_8723B BIT(1) -#define AcmHw_ViqEn_8723B BIT(2) -#define AcmHw_BeqEn_8723B BIT(3) -#define AcmHw_VoqStatus_8723B BIT(5) -#define AcmHw_ViqStatus_8723B BIT(6) -#define AcmHw_BeqStatus_8723B BIT(7) +#define ACMHW_HWEN_8723B BIT(0) +#define ACMHW_VOQEN_8723B BIT(1) +#define ACMHW_VIQEN_8723B BIT(2) +#define ACMHW_BEQEN_8723B BIT(3) +#define ACMHW_VOQSTATUS_8723B BIT(5) +#define ACMHW_VIQSTATUS_8723B BIT(6) +#define ACMHW_BEQSTATUS_8723B BIT(7)/* 8195 (RCR) Receive Configuration Register (Offset 0x608, 32 bits) */ #define RCR_TCPOFLD_EN BIT25/* Enable TCP checksum offload */
Signature · 1 line
2.30.2
Greg KH
maintainerQuoted 10 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.Signed-off-by Fabio M. De Francesco <[email protected]>---
Patch v3 changes nothing with respect to v2 and v1. It exists only to cc some recipients that were missing in the header of the previous email.
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
This patch does not apply to my tree right now. Can you refresh and rebase your copy of my branch and rebase it and resend?
thanks,
greg k-h
Quoted 7 lines · CEST Greg KH
Quoted 6 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.Signed-off-by Fabio M. De Francesco <[email protected]>---
Quoted 8 lines
Quoted 4 lines
Patch v3 changes nothing with respect to v2 and v1. It exists only to cc some recipients that were missing in the header of the previous email.
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)This patch does not apply to my tree right now. Can you refresh and rebase your copy of my branch and rebase it and resend?
Sure. I'm about to submit that patch again in a few minutes.
Thanks,
Fabio
Quoted 5 lines
thanks,
greg k-h
Quoted 11 lines · Fabio M. De Francesco
Quoted 9 lines · CEST Greg KH
Quoted 8 lines · Fabio M. De Francesco
Remove camelcase in some symbols defined in
Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver.Signed-off-by Fabio M. De Francesco <[email protected]>---
Patch v3 changes nothing with respect to v2 and v1. It exists only to cc some recipients that were missing in the header of the previous email.
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)This patch does not apply to my tree right now. Can you refresh and rebase your copy of my branch and rebase it and resend?
Sure. I'm about to submit that patch again in a few minutes.
Also while you're at it, don't forget to put the information under -- about what has changed since the first version of it. Otherwise it becomes hard for the reviewers to track the progress of each version.
Ideally it should go like below:
Changes since v2:
Changes since v1:
Quoted 16 lines
Thanks,
Fabio
Quoted 5 lines
thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/3526833.TqPzfDAv2q%40localhost.localdomain.
Signature · 1 line
Vaishali