i2c: img-scb: fix PM reference leak in img_i2c_xfer()
PATCH 1/1 i2c: img-scb: fix PM reference leak in img_i2c_xfer()
pm_runtime_get_sync() will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get() to keep usage counter balanced.
Signed-off-by Pu Lehui <[email protected]>
--- drivers/i2c/busses/i2c-img-scb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-img-scb.c +2 -2
@@ -1057,7 +1057,7 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, atomic = true; } - ret =pm_runtime_get_sync (adap->dev.parent); + ret =pm_runtime_resume_and_get (adap->dev.parent);if (ret <0 )return ret;
@@ -1158,7 +1158,7 @@ static int img_i2c_init(struct img_i2c *i2c)u32 rev;int ret; - ret =pm_runtime_get_sync (i2c->adap.dev.parent); + ret =pm_runtime_resume_and_get (i2c->adap.dev.parent);if (ret <0 )return ret;
Signature · 1 line
2.17.1
Quoted 6 lines · Pu Lehui
pm_runtime_get_sync()will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it withpm_runtime_resume_and_get()to keep usage counter balanced.Signed-off-by Pu Lehui <[email protected]>
Thanks, yet I applied this series now:
http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*