Skip to contentSkip to conversation

i2c: img-scb: fix PM reference leak in img_i2c_xfer()

PATCH In review Pu Lehui 2 participants 2 messages Apr 8, 2021 – Apr 14, 2021 I2C subsystem host drivers

lore
Share & tools
lore

Pu Lehui

author
#0 lore raw

PATCH 1/1 i2c: img-scb: fix PM reference leak in img_i2c_xfer()

pm_runtime_get_sync() will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get() to keep usage counter balanced.

---
 drivers/i2c/busses/i2c-img-scb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-img-scb.c +2 -2
index 98a89301ed2a..8e987945ed45 100644
@@ -1057,7 +1057,7 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
 			atomic = true;
 	}
 
-	ret = pm_runtime_get_sync(adap->dev.parent);
+	ret = pm_runtime_resume_and_get(adap->dev.parent);
 	if (ret < 0)
 		return ret;
 
@@ -1158,7 +1158,7 @@ static int img_i2c_init(struct img_i2c *i2c)
 	u32 rev;
 	int ret;
 
-	ret = pm_runtime_get_sync(i2c->adap.dev.parent);
+	ret = pm_runtime_resume_and_get(i2c->adap.dev.parent);
 	if (ret < 0)
 		return ret;
 
Signature · 1 line
2.17.1