Skip to contentSkip to conversation

Add libseccomp

PATCH In review Armin Kuster 3 participants 20 messages Apr 24, 2021 – Apr 26, 2021 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

cover Add libseccomp

This ports over the libseccomp pkg from meta-security.

Use DISTRO_FEATURE check to enable recipe Add PACKAGECONFIG tweaking for a few core pkgs if DISTRO_FEATURE (seccomp) is set for a few core pkgs.

Skipped updating "file" as I don't recall the issues file enabled with seccomp had on pseudo

Added pkg grp for adding libseccomp to base pkg grp
Add "seccomp" to DEFUALT_FEATURES as its on the same level as xattr.

I relealize some changes may be controversial and don't need to be taken.

enjoy.

Armin Kuster (6):
libseccomp: move recipe from meta-security to core
qemu: Enable seccomp if FEATURE is set
gnutls: Enable seccomp if FEATURE is set
systemd: Enable seccomp if FEATURE is set packagegroups/packagegroup-base: add seccomp grp default-distrovars.inc: Add seccomp to DISTRO_FEATURES_DEFAULT

 .../distro/include/default-distrovars.inc     |  2 +-
 .../packagegroups/packagegroup-base.bb        |  6 +++
 meta/recipes-core/systemd/systemd_247.6.bb    |  3 +-
 meta/recipes-devtools/qemu/qemu_5.2.0.bb      |  1 +
 meta/recipes-support/gnutls/gnutls_3.7.1.bb   |  2 +-
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 7 files changed, 63 insertions(+), 4 deletions(-)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/6 libseccomp: move recipe from meta-security to core

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -0

49 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 52 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +16 -0
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb line 26

Quoted 10 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +10 -0
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""

do we need apps to use some static libs ? if so which library is it, Or is it all internal?

Quoted 29 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +23 -1
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#3 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 56 lines · Khem Raj
Quoted 55 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +20 -0
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
Quoted 8 lines

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb line 26

Quoted 6 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +6 -0
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""

do we need apps to use some static libs ? if so which library is it, Or is it all internal?

The commit that added that:

commit 2153c59b429293120095a2bd4562f4f7553c1ae7
Author: Stefan Agner <[email protected]>
Date:   Sun Sep 1 21:48:13 2019 +0200

    libseccomp: build static library always

    Always build static library. This is required e.g. for runc from meta-virtualization in its default configuration.

Meta-virt is one of the reasons I am this patch set.

-armin

Quoted 30 lines
Quoted 30 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +23 -1
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#4 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 81 lines · On Sat, Apr 24, 2021 at 9:55 AM akuster808 <[email protected]> wrote:
Quoted 1 line · Khem Raj

On Sat, Apr 24, 2021 at 8:56 AM Armin Kuster <[email protected]>

Quoted 19 lines · wrote:
Quoted 19 lines

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta/recipes-support/libseccomp/files/run-ptest

Quoted 10 lines

Review

Quoted 10 lines

new file mode 100644
index 00000000000..54b4a63cd2c

meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
(quoted diff) +0 -0

b/meta/recipes-support/libseccomp/libseccomp_2.5.1.bb

Quoted 7 lines

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb line 2

Quoted 7 lines

new file mode 100644
index 00000000000..667d5da8242

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +2 -0
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use,

platform independent,interface to the Linux Kernel's syscall filtering
mechanism: seccomp."

Quoted 3 lines

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb

Quoted 3 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +3 -0
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM =

"file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"

Quoted 6 lines

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb

Quoted 6 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +6 -0
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5

\

Quoted 9 lines
Quoted 9 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +9 -0
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
Quoted 8 lines

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb line 26

Quoted 6 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +6 -0
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""

do we need apps to use some static libs ? if so which library is it, Or is it all internal?

The commit that added that:

commit 2153c59b429293120095a2bd4562f4f7553c1ae7

Author: Stefan Agner <[email protected]>
Date:   Sun Sep 1 21:48:13 2019 +0200
Quoted 7 lines

libseccomp: build static library always

Always build static library. This is required e.g. for runc from meta-virtualization in its default configuration.

Meta-virt is one of the reasons I am this patch set.

Ok since it can silently link to any app perhaps turning this into a packageconfig could be a good improvement

Quoted 35 lines

-armin

Quoted 14 lines
Quoted 14 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +13 -0
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
Quoted 8 lines

meta/recipes-support/libseccomp/libseccomp_2.5.1.bb

Quoted 8 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +8 -0
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*

${libdir}/${PN}/tools/.debug"

Quoted 8 lines
Quoted 8 lines
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +2 -1
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#5 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

In reply to Armin Kuster

riscv32 is not happy

ERROR: Nothing PROVIDES 'libseccomp' (but /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-core/systemd/systemd_247.6.bb, /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-support/gnutls/gnutls_3.7.1.bb DEPENDS on or otherwise requires it)
libseccomp was skipped: incompatible with host riscv32-yoe-linux (not
in COMPATIBLE_HOST)

see
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemuriscv32/1123/consoleFull

Quoted 91 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -1
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#6 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

musl/x86 apt fails

https://errors.yoctoproject.org/Errors/Details/577480/

Quoted 105 lines · Khem Raj

riscv32 is not happy

ERROR: Nothing PROVIDES 'libseccomp' (but /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-core/systemd/systemd_247.6.bb, /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-support/gnutls/gnutls_3.7.1.bb DEPENDS on or otherwise requires it)
libseccomp was skipped: incompatible with host riscv32-yoe-linux (not
in COMPATIBLE_HOST)

see
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemuriscv32/1123/consoleFull

Quoted 91 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -1
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#7 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 1 line · Khem Raj

musl/x86 apt fails

Right. RP told me yesterday. I have been looking into it.

I say your patch. thanks.

-armin

Quoted 107 lines

https://errors.yoctoproject.org/Errors/Details/577480/

Quoted 103 lines · Khem Raj

riscv32 is not happy

ERROR: Nothing PROVIDES 'libseccomp' (but /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-core/systemd/systemd_247.6.bb, /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-support/gnutls/gnutls_3.7.1.bb DEPENDS on or otherwise requires it)
libseccomp was skipped: incompatible with host riscv32-yoe-linux (not
in COMPATIBLE_HOST)

see
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemuriscv32/1123/consoleFull

Quoted 90 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -1
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#8 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

In reply to Khem Raj
Quoted 1 line · Khem Raj

riscv32 is not happy

that is not supported by libseccomp per their supported arch list. I came across that yesterday.

Quoted 7 lines

ERROR: Nothing PROVIDES 'libseccomp' (but /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-core/systemd/systemd_247.6.bb, /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-support/gnutls/gnutls_3.7.1.bb DEPENDS on or otherwise requires it)
libseccomp was skipped: incompatible with host riscv32-yoe-linux (not
in COMPATIBLE_HOST)

I suspect we need to exclude the arch for now. I didn't notice any patch to add that yet.

-armin

Quoted 95 lines

see
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemuriscv32/1123/consoleFull

Quoted 90 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -1
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#9 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 8 lines · On Sun, Apr 25, 2021 at 11:26 AM akuster808 <[email protected]> wrote:
Quoted 1 line · Khem Raj

riscv32 is not happy

that is not supported by libseccomp per their supported arch list. I came across that yesterday.

I think the problem is when we enable it by default in DISTRO_FEATURES perhaps we should add an explicit

DISTRO_FEATURES_remove_riscv32 = "seccomp"

in default-distrovars.inc

Quoted 108 lines
Quoted 7 lines

ERROR: Nothing PROVIDES 'libseccomp' (but /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-core/systemd/systemd_247.6.bb, /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-support/gnutls/gnutls_3.7.1.bb DEPENDS on or otherwise requires it)
libseccomp was skipped: incompatible with host riscv32-yoe-linux (not
in COMPATIBLE_HOST)

I suspect we need to exclude the arch for now. I didn't notice any patch to add that yet.

-armin

Quoted 95 lines

see
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemuriscv32/1123/consoleFull

Quoted 90 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -1
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#10 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 5 lines · Khem Raj
Quoted 4 lines · On Sun, Apr 25, 2021 at 11:26 AM akuster808 <[email protected]> wrote:
Quoted 1 line · Khem Raj

riscv32 is not happy

Quoted 8 lines
Quoted 2 lines

that is not supported by libseccomp per their supported arch list. I came across that yesterday.

I think the problem is when we enable it by default in DISTRO_FEATURES perhaps we should add an explicit

DISTRO_FEATURES_remove_riscv32 = "seccomp"

in default-distrovars.inc

sounds good. libseccomp hit master this morning.

-armin

Quoted 106 lines
Quoted 106 lines
Quoted 7 lines

ERROR: Nothing PROVIDES 'libseccomp' (but /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-core/systemd/systemd_247.6.bb, /home/jenkins/oe/world/yoe/sources/openembedded-core/meta/recipes-support/gnutls/gnutls_3.7.1.bb DEPENDS on or otherwise requires it)
libseccomp was skipped: incompatible with host riscv32-yoe-linux (not
in COMPATIBLE_HOST)

I suspect we need to exclude the arch for now. I didn't notice any patch to add that yet.

-armin

Quoted 94 lines

see
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemuriscv32/1123/consoleFull

Quoted 90 lines · Armin Kuster

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -1
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"
--

2.25.1

#11 lore raw

PATCH 2/6 qemu: Enable seccomp if FEATURE is set

In reply to Armin Kuster
---
 meta/recipes-devtools/qemu/qemu_5.2.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/qemu/qemu_5.2.0.bb +1 -0
index 7afa66e3960..f265204b105 100644
@@ -22,6 +22,7 @@ PACKAGECONFIG ??= " \
     fdt sdl kvm \
     ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'virglrenderer glx', '', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'seccomp', d)} \
 "
 PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'virglrenderer glx', '', d)} \
Signature · 1 line
2.25.1
#12 lore raw

PATCH 3/6 gnutls: Enable seccomp if FEATURE is set

In reply to Armin Kuster
---
 meta/recipes-support/gnutls/gnutls_3.7.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/gnutls/gnutls_3.7.1.bb +1 -1
index 51d472c8285..3e1958c9695 100644
@@ -27,7 +27,7 @@ SRC_URI[sha256sum] = "3777d7963eca5e06eb315686163b7b3f5045e2baac5e54e038ace9835e
 
 inherit autotools texinfo pkgconfig gettext lib_package gtk-doc
 
-PACKAGECONFIG ??= "libidn"
+PACKAGECONFIG ??= "libidn  ${@bb.utils.filter('DISTRO_FEATURES', 'seccomp', d)}"
 
 # You must also have CONFIG_SECCOMP enabled in the kernel for
 # seccomp to work.
Signature · 1 line
2.25.1
#13 lore raw

PATCH 4/6 systemd: Enable seccomp if FEATURE is set

In reply to Armin Kuster
---
 meta/recipes-core/systemd/systemd_247.6.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-core/systemd/systemd_247.6.bb +1 -2
index 32afa159ec3..ce6ac7ebaa0 100644
@@ -65,7 +65,7 @@ PAM_PLUGINS = " \
 "
 
 PACKAGECONFIG ??= " \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit seccomp', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
     backlight \
@@ -177,7 +177,6 @@ PACKAGECONFIG[quotacheck] = "-Dquotacheck=true,-Dquotacheck=false"
 PACKAGECONFIG[randomseed] = "-Drandomseed=true,-Drandomseed=false"
 PACKAGECONFIG[resolved] = "-Dresolve=true,-Dresolve=false"
 PACKAGECONFIG[rfkill] = "-Drfkill=true,-Drfkill=false"
-# libseccomp is found in meta-security
 PACKAGECONFIG[seccomp] = "-Dseccomp=true,-Dseccomp=false,libseccomp"
 PACKAGECONFIG[selinux] = "-Dselinux=true,-Dselinux=false,libselinux,initscripts-sushell"
 PACKAGECONFIG[smack] = "-Dsmack=true,-Dsmack=false"
Signature · 1 line
2.25.1
#14 lore raw

Re: [OE-core] [PATCH 4/6] systemd: Enable seccomp if FEATURE is set

Hi,

Patch itself is ok, but I'll just comment that I've seen some boot time regressions coming from systemd seccomp support. On NXP iMX8 and dunfell, systemd needed a few 100 ms more time in early boot if seccomp was enabled. I could not figure out where this was lost though. Could be just kernel or BSP SW configuration problem that we had. Ideas what could be causing this would be nice to hear...

Cheers,

-Mikko

#15 lore raw

PATCH 5/6 packagegroups/packagegroup-base: add seccomp grp

In reply to Armin Kuster

This allows for inclusion of the package when
the FEATURE is set

---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 6 ++++++
 1 file changed, 6 insertions(+)
meta/recipes-core/packagegroups/packagegroup-base.bb +6 -0
index 6d4d7e6f7e7..3482ea43133 100644
@@ -38,6 +38,7 @@ PACKAGES = ' \
             ${@bb.utils.contains("DISTRO_FEATURES", "ppp", "packagegroup-base-ppp", "", d)} \
             ${@bb.utils.contains("DISTRO_FEATURES", "smbfs", "packagegroup-base-smbfs", "", d)} \
             ${@bb.utils.contains("DISTRO_FEATURES", "zeroconf", "packagegroup-base-zeroconf", "", d)} \
+            ${@bb.utils.contains("DISTRO_FEATURES", "seccomp", "packagegroup-base-seccomp", "", d)} \
             \
             '
 
@@ -76,6 +77,7 @@ RDEPENDS_packagegroup-base = "\
     ${@bb.utils.contains('DISTRO_FEATURES', 'ipsec', 'packagegroup-base-ipsec', '',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'ppp', 'packagegroup-base-ppp', '',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', 'packagegroup-base-zeroconf', '',d)} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "seccomp", "packagegroup-base-seccomp", "", d)} \
     "
 
 
@@ -343,3 +345,7 @@ RDEPENDS_packagegroup-base-serial = "\
 SUMMARY_packagegroup-base-phone = "Cellular telephony (voice) support"
 RDEPENDS_packagegroup-base-phone = "\
     ofono"
+
+SUMMARY_packagegroup-base-seccomp = "Seccomp support"
+RDEPENDS_packagegroup-base-seccomp = "\
+    libseccomp"
Signature · 1 line
2.25.1
#16 lore raw

Re: [OE-core] [PATCH 5/6] packagegroups/packagegroup-base: add seccomp grp

Quoted 4 lines · Armin Kuster

This allows for inclusion of the package when
the FEATURE is set

isn't liibseccomp a library which would be automatically included if a package needs it ?
in that case we may avoid this packagegrooup

Quoted 39 lines
---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 6 ++++++
 1 file changed, 6 insertions(+)
meta/recipes-core/packagegroups/packagegroup-base.bb +6 -1
index 6d4d7e6f7e7..3482ea43133 100644
@@ -38,6 +38,7 @@ PACKAGES = ' \
             ${@bb.utils.contains("DISTRO_FEATURES", "ppp", "packagegroup-base-ppp", "", d)} \
             ${@bb.utils.contains("DISTRO_FEATURES", "smbfs", "packagegroup-base-smbfs", "", d)} \
             ${@bb.utils.contains("DISTRO_FEATURES", "zeroconf", "packagegroup-base-zeroconf", "", d)} \
+            ${@bb.utils.contains("DISTRO_FEATURES", "seccomp", "packagegroup-base-seccomp", "", d)} \
             \
             '
 
@@ -76,6 +77,7 @@ RDEPENDS_packagegroup-base = "\
     ${@bb.utils.contains('DISTRO_FEATURES', 'ipsec', 'packagegroup-base-ipsec', '',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'ppp', 'packagegroup-base-ppp', '',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', 'packagegroup-base-zeroconf', '',d)} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "seccomp", "packagegroup-base-seccomp", "", d)} \
     "
 
 
@@ -343,3 +345,7 @@ RDEPENDS_packagegroup-base-serial = "\
 SUMMARY_packagegroup-base-phone = "Cellular telephony (voice) support"
 RDEPENDS_packagegroup-base-phone = "\
     ofono"
+
+SUMMARY_packagegroup-base-seccomp = "Seccomp support"
+RDEPENDS_packagegroup-base-seccomp = "\
+    libseccomp"
--

2.25.1

#17 lore raw

Re: [OE-core] [PATCH 5/6] packagegroups/packagegroup-base: add seccomp grp

Quoted 7 lines · Khem Raj
Quoted 3 lines · Armin Kuster

This allows for inclusion of the package when
the FEATURE is set

isn't liibseccomp a library which would be automatically included if a package needs it ?
in that case we may avoid this packagegrooup

Err, you are right..

thanks,
Armin

Quoted 39 lines
Quoted 39 lines
---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 6 ++++++
 1 file changed, 6 insertions(+)
meta/recipes-core/packagegroups/packagegroup-base.bb +6 -1
index 6d4d7e6f7e7..3482ea43133 100644
@@ -38,6 +38,7 @@ PACKAGES = ' \
             ${@bb.utils.contains("DISTRO_FEATURES", "ppp", "packagegroup-base-ppp", "", d)} \
             ${@bb.utils.contains("DISTRO_FEATURES", "smbfs", "packagegroup-base-smbfs", "", d)} \
             ${@bb.utils.contains("DISTRO_FEATURES", "zeroconf", "packagegroup-base-zeroconf", "", d)} \
+            ${@bb.utils.contains("DISTRO_FEATURES", "seccomp", "packagegroup-base-seccomp", "", d)} \
             \
             '
 
@@ -76,6 +77,7 @@ RDEPENDS_packagegroup-base = "\
     ${@bb.utils.contains('DISTRO_FEATURES', 'ipsec', 'packagegroup-base-ipsec', '',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'ppp', 'packagegroup-base-ppp', '',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', 'packagegroup-base-zeroconf', '',d)} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "seccomp", "packagegroup-base-seccomp", "", d)} \
     "
 
 
@@ -343,3 +345,7 @@ RDEPENDS_packagegroup-base-serial = "\
 SUMMARY_packagegroup-base-phone = "Cellular telephony (voice) support"
 RDEPENDS_packagegroup-base-phone = "\
     ofono"
+
+SUMMARY_packagegroup-base-seccomp = "Seccomp support"
+RDEPENDS_packagegroup-base-seccomp = "\
+    libseccomp"
--

2.25.1

#18 lore raw

PATCH 6/6 default-distrovars.inc: Add seccomp to DISTRO_FEATURES_DEFAULT

In reply to Armin Kuster

Since xattr is included, seccomp should be too

---
 meta/conf/distro/include/default-distrovars.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/distro/include/default-distrovars.inc +1 -1
index 9fcc10f83a7..45f4633c354 100644
@@ -10,7 +10,7 @@ LOCALE_UTF8_ONLY ?= "0"
 LOCALE_UTF8_IS_DEFAULT ?= "1"
 LOCALE_UTF8_IS_DEFAULT_class-nativesdk = "0"
 
-DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat"
+DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp"
 DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT}"
 IMAGE_FEATURES ?= ""
 
Signature · 1 line
2.25.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#20 lore raw

Re: [OE-core] [PATCH 1/6] libseccomp: move recipe from meta-security to core

Quoted 7 lines · Armin Kuster via lists.openembedded.org

ptest results:
Regression Test Summary
tests run: 1404
tests skipped: 369
tests passed: 1402
tests failed: 2
tests errored: 154

Ptest  on x86 musl with the patches in master-next many thanks to Richard and Khem for their fixes.

Regression Test Summary
 tests run: 8150
 tests skipped: 114
 tests passed: 8148
 tests failed: 2
 tests errored: 0

Many of the skipped are do to missing valgrind or wrong arch.

-armin

Quoted 80 lines

Add feature_check so that the other recipes who can take advantage of this funtionality can enable it.

---
 .../libseccomp/files/run-ptest                |  4 ++
 .../libseccomp/libseccomp_2.5.1.bb            | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-support/libseccomp/files/run-ptest
 create mode 100644 meta/recipes-support/libseccomp/libseccomp_2.5.1.bb
meta/recipes-support/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 00000000000..54b4a63cd2c
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta/recipes-support/libseccomp/libseccomp_2.5.1.bb new file +49 -0
new file mode 100644
index 00000000000..667d5da8242
@@ -0,0 +1,49 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+DEPENDS += "gperf-native"
+
+SRCREV = "4bf70431a339a2886ab8c82e9a45378f30c6e6c7"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.5 \
+           file://run-ptest \
+           "
+
+COMPATIBLE_HOST_riscv32 = "null"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "seccomp"
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python3"
+
+DISABLE_STATIC = ""
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "coreutils bash"