misc/pvpanic: add missing MODULE_DEVICE_TABLE
Subsystems (2)
PATCH 1/1 misc/pvpanic: add missing MODULE_DEVICE_TABLE
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
Reported-by Hulk Robot <[email protected]>
Signed-off-by Qiheng Lin <[email protected]>
--- drivers/misc/pvpanic/pvpanic-pci.c | 1 + 1 file changed, 1 insertion(+)
drivers/misc/pvpanic/pvpanic-pci.c +1 -0
@@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = { { PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)}, {} }; +MODULE_DEVICE_TABLE (pci, pvpanic_pci_id_tbl);static ssize_t capability_show (struct device *dev,struct device_attribute *attr,char *buf)
Greg Kroah-Hartman
maintainerQuoted 16 lines · Qiheng Lin
This patch adds missing
MODULE_DEVICE_TABLEdefinition which generates correct modalias for automatic loading of this driver when it is built as an external module.Reported-by Hulk Robot <[email protected]>Signed-off-by Qiheng Lin <[email protected]>--- drivers/misc/pvpanic/pvpanic-pci.c | 1 + 1 file changed, 1 insertion(+)drivers/misc/pvpanic/pvpanic-pci.c +0
-0
drivers/misc/pvpanic/pvpanic-pci.c static const struct pci_device_id pvpanic_pci_id_tbl[] = { · line 32
Quoted 7 lines
drivers/misc/pvpanic/pvpanic-pci.c +1
-0@@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = { { PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)}, {} }; +MODULE_DEVICE_TABLE (pci, pvpanic_pci_id_tbl);static ssize_t capability_show (struct device *dev,struct device_attribute *attr,char *buf)
As I have said before, unless you have a user that reports a real problem with these types of modules not automatically loading, I am not going to take these patches, and you should probably stop generating them.
thanks,
greg k-h