Skip to contentSkip to conversation

misc/pvpanic: add missing MODULE_DEVICE_TABLE

PATCH In review Qiheng Lin 2 participants 2 messages May 14, 2021

Subsystems (2)
lore
Share & tools
lore

Qiheng Lin

author
#0 lore raw

PATCH 1/1 misc/pvpanic: add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.

---
 drivers/misc/pvpanic/pvpanic-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/pvpanic/pvpanic-pci.c +1 -0
index 9ecc4e8559d5..ccd7e32d3f55 100644
@@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[]  = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
 	{}
 };
+MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
 
 static ssize_t capability_show(struct device *dev,
 			       struct device_attribute *attr, char *buf)
#1 lore raw
Quoted 16 lines · Qiheng Lin

This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.

---
 drivers/misc/pvpanic/pvpanic-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/pvpanic/pvpanic-pci.c +0 -0
index 9ecc4e8559d5..ccd7e32d3f55 100644

drivers/misc/pvpanic/pvpanic-pci.c static const struct pci_device_id pvpanic_pci_id_tbl[] = { · line 32

Quoted 7 lines
drivers/misc/pvpanic/pvpanic-pci.c +1 -0
@@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[]  = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
 	{}
 };
+MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
 
 static ssize_t capability_show(struct device *dev,
 			       struct device_attribute *attr, char *buf)

As I have said before, unless you have a user that reports a real problem with these types of modules not automatically loading, I am not going to take these patches, and you should probably stop generating them.

thanks,

greg k-h