toolchain: remove binutils bug 21464
PATCH v2 1/1 toolchain: remove binutils bug 21464
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobuf
---V1->V2:
* squashed 4 different patches into one
--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)
package/libgeos/Config.in +1 -3
@@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS bool "libgeos" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 help GEOS (Geometry Engine - Open Source) is a C++ port of the
@@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS https://trac.osgeo.org/geos -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597" +comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
package/postgis/Config.in +1 -3
@@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj depends on BR2_TOOLCHAIN_HAS_THREADS # proj depends on BR2_USE_WCHAR # libgeos, proj - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos select BR2_PACKAGE_LIBGEOS select BR2_PACKAGE_PROJ
@@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS https://postgis.net/ -comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597" +comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597" depends on !BR2_microblazeel && !BR2_microblazebe # ICE depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
package/protobuf/Config.in +0 -1
@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS default y if BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" depends on BR2_USE_MMU # fork() - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 config BR2_PACKAGE_PROTOBUF bool "protobuf"
toolchain/Config.in +0 -6
@@ -71,12 +71,6 @@ source "package/gdb/Config.in.host" comment "Toolchain Generic Options" -# https://sourceware.org/bugzilla/show_bug.cgi?id=21464 -# Affect toolchains built with binutils 2.31.1, still not fixed. -config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 - bool - default y if BR2_or1k - # https://sourceware.org/bugzilla/show_bug.cgi?id=27100 # Affect toolchains built with binutils 2.33.1 (fixed in binutils 2.36) config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
Signature · 1 line
2.25.1
PATCH v2 1/1 toolchain: remove binutils bug 21464
Quoted 11 lines · Giulio Benetti
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobufSigned-off-by Giulio Benetti <[email protected]>---
V1->V2:
* squashed 4 different patches into one
Quoted 6 lines
--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)
Thomas Petazzoni
AppliedQuoted 11 lines · On Fri, 21 May 2021 16:09:42 +0200 Giulio Benetti…
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobufSigned-off-by Giulio Benetti <[email protected]>---
V1->V2:
* squashed 4 different patches into one
Quoted 6 lines
--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 11 lines · On Fri, 21 May 2021 16:09:42 +0200 Giulio Benetti…
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobufSigned-off-by Giulio Benetti <[email protected]>---
V1->V2:
* squashed 4 different patches into one
Quoted 6 lines
--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)
In fact, no I reverted this patch. It depends on other patches to be applied first. This is an illustration of why you should *never* ever resend just a single patch out of a larger series. Even if only one patch is changed, please resend the entire series.
Could you update your "Fix binutils bug 21464 and remove it" series and resend it?
Thanks,
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 24 lines
Il giorno 26 lug 2021, alle ore 23:57, Thomas Petazzoni <[email protected]> ha scritto:
On Fri, 21 May 2021 16:09:42 +0200
Quoted 12 lines · Giulio Benetti
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobufSigned-off-by Giulio Benetti <[email protected]>---
V1->V2:
* squashed 4 different patches into one
---Quoted 5 lines
package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)
Quoted 4 lines
In fact, no I reverted this patch. It depends on other patches to be applied first. This is an illustration of why you should *never* ever resend just a single patch out of a larger series. Even if only one patch is changed, please resend the entire series.
Oh, I see the reason, sorry.
Quoted 3 lines
Could you update your "Fix binutils bug 21464 and remove it" series and resend it?
Sure I will.
Best regards
Giulio Benetti
Quoted 8 lines
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
v2 cover Fix binutils bug 21464 and remove it
In reply to Thomas PetazzoniThis patchset fixes binutils bug 21464 and fixes libgeos and protobuf packages build failure by introducing the gcc option flag -mcmodel. This is done by adding upstreamed binutils and gcc patches.
Note:
this way buildroot toolchains can be considered bug binutils 21464 free and the only other OpenRisc toolchain supported is the external Bootlin one. So this patchset has to be considered valid once Bootlin updates its OpenRisc by adding binutils and gcc patches that are added with patches in this patchset.
V1->V2:
* squashed patches [6..9/9] into one resulting into "toolchain: remove binutils bug 21464" where binutils bug gets removed all around buildroot. Note that this patch has been sent as v2 alone but it shouldn't have been since was part of this patchset and before it the other 2 patches which add -mcmodel=large to libgeos and protobuf must be applied.
Giulio Benetti (3):
package/libgeos: fix build failure due to missing -mcmodel=large package/protobuf: fix build failure due to missing -mcmodel=large
toolchain: remove binutils bug 21464
package/libgeos/Config.in | 4 +--- package/libgeos/libgeos.mk | 4 ++++ package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - package/protobuf/protobuf.mk | 4 ++++ toolchain/Config.in | 6 ------ 6 files changed, 10 insertions(+), 13 deletions(-)
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v2 1/3 package/libgeos: fix build failure due to missing -mcmodel=large
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/libgeos/libgeos.mk +4 -0
@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=large +endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)" $(eval $(cmake-package))
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
Quoted 14 lines · Giulio Benetti
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0
package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 10 lines
package/libgeos/libgeos.mk +4
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=large +endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)" $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
In reply to Giulio BenettiQuoted 13 lines · Giulio Benetti
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0
package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 27
Quoted 5 lines
package/libgeos/libgeos.mk +2
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=large
According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
sure that this works?
Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
some reason. Romain, you apparently didn't carry any of our patches when you added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message doesn't say anything. Do you remember anything about the patches? The patch was added to master on May 21 and you only submitted the GCC bump on June 12, but perhaps you already had it lying around for a while?
Giulio, maybe you can port the patch to 11.1.0?
Regards,
Arnout
package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 6 lines
package/libgeos/libgeos.mk +2
-0+endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)" $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
Hi Arnout,
Quoted 25 lines · Arnout Vandecappelle
Quoted 13 lines · Giulio Benetti
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 27
Quoted 5 lines
package/libgeos/libgeos.mk +2
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=largeAccording to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
sure that this works?
Quoted 8 lines
Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
some reason. Romain, you apparently didn't carry any of our patches when you added GCC 11 in2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message doesn't say anything. Do you remember anything about the patches? The patch was added to master on May 21 and you only submitted the GCC bump on June 12, but perhaps you already had it lying around for a while?Giulio, maybe you can port the patch to 11.1.0?
You've read into my mind :-), I've sent it yesterday:
https://patchwork.ozlabs.org/project/buildroot/list/?series=258108
and that is valid for both libgeos and profobuf.
Best regards!
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 7 lines
Regards,
ArnoutQuoted 4 lines
package/libgeos/libgeos.mk +2
-0+endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
Quoted 7 lines
package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 2 lines
package/libgeos/libgeos.mk +0
-0$(eval $(cmake-package))_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
In reply to Arnout VandecappelleQuoted 25 lines · Arnout Vandecappelle
Quoted 13 lines · Giulio Benetti
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 27
Quoted 5 lines
package/libgeos/libgeos.mk +2
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=largeAccording to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
sure that this works?
Quoted 8 lines
Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
some reason. Romain, you apparently didn't carry any of our patches when you added GCC 11 in2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message doesn't say anything. Do you remember anything about the patches? The patch was added to master on May 21 and you only submitted the GCC bump on June 12, but perhaps you already had it lying around for a while?Giulio, maybe you can port the patch to 11.1.0?
... and now I see you already did that in [1]. Thanks!
Regards,
Arnout
[1]
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Quoted 10 lines
Regards,
Arnoutpackage/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 6 lines
package/libgeos/libgeos.mk +2
-0+endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)" $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
In reply to Arnout VandecappelleHello Arnout,
Le 17/08/2021 à 22:34, Arnout Vandecappelle a écrit :
Quoted 25 lines · Giulio Benetti
Quoted 13 lines
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 27
Quoted 5 lines
package/libgeos/libgeos.mk +2
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=largeAccording to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
sure that this works?
Quoted 6 lines
Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
some reason. Romain, you apparently didn't carry any of our patches when you added GCC 11 in2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message doesn't say anything. Do you remember anything about the patches? The patch was added to master on May 21 and you only submitted the GCC bump on June 12, but perhaps you already had it lying around for a while?
Indeed, I missed this patch.
Quoted 2 lines
Giulio, maybe you can port the patch to 11.1.0?
Yes please.
Best regards,
Romain
Quoted 10 lines
Regards,
Arnoutpackage/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 6 lines
package/libgeos/libgeos.mk +2
-0+endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)" $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
Hi Romain,
Quoted 35 lines · Romain Naour
Hello Arnout,
Le 17/08/2021 à 22:34, Arnout Vandecappelle a écrit :
Quoted 25 lines · Giulio Benetti
Quoted 13 lines
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 27
Quoted 5 lines
package/libgeos/libgeos.mk +2
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=largeAccording to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
sure that this works?Quoted 6 lines
Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
some reason. Romain, you apparently didn't carry any of our patches when you added GCC 11 in2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message doesn't say anything. Do you remember anything about the patches? The patch was added to master on May 21 and you only submitted the GCC bump on June 12, but perhaps you already had it lying around for a while?
Quoted 6 lines
Indeed, I missed this patch.
Quoted 2 lines
Giulio, maybe you can port the patch to 11.1.0?
Yes please.
Already sent and applied here :-):
https://git.buildroot.net/buildroot/commit/?id=137225cef423ccbebc31d0c562bf3f37192739ac
I'm going to add myself to toolchain as maintainer too, so I keep up to date on toolchain movement and also I've added a bunch of binutils/gcc bugs. So it's time for it :-)
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 12 lines
Best regards,
RomainQuoted 8 lines
Regards,
ArnoutQuoted 4 lines
package/libgeos/libgeos.mk +2
-0+endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
Quoted 8 lines
Quoted 2 lines
package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 2 lines
package/libgeos/libgeos.mk +0
-0$(eval $(cmake-package))_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Arnout Vandecappelle
AppliedRe: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
In reply to Giulio BenettiQuoted 4 lines · Giulio Benetti
When building libgeos for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>
Applied to master, thanks.
I've added a comment to the commit message to explain that this option is from
a Buildroot patch.
I've also applied the second patch with the same comment.
Regards,
Arnout
Quoted 10 lines
--- package/libgeos/libgeos.mk | 4 ++++ 1 file changed, 4 insertions(+)package/libgeos/libgeos.mk +0
-0
package/libgeos/libgeos.mk ifeq ($(BR2_arm)$(BR2_armeb),y) · line 32
Quoted 10 lines
package/libgeos/libgeos.mk +4
-0@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y) LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON endif +ifeq ($(BR2_or1k),y) +LIBGEOS_CXXFLAGS += -mcmodel=large +endif + LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)" $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v2 2/3 package/protobuf: fix build failure due to missing -mcmodel=large
In reply to Giulio BenettiWhen building protobuf for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
--- package/protobuf/protobuf.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/protobuf/protobuf.mk +4 -0
@@ -24,6 +24,10 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) PROTOBUF_CXXFLAGS += -O0 endif +ifeq ($(BR2_or1k),y) +PROTOBUF_CXXFLAGS += -mcmodel=large +endif + PROTOBUF_CONF_ENV = CXXFLAGS="$(PROTOBUF_CXXFLAGS)" ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 2/3] package/protobuf: fix build failure due to missing -mcmodel=large
Quoted 14 lines · Giulio Benetti
When building protobuf for or1k -mcmodel=large is needed to link, so let's add that gcc option in case we're building for or1k.
Signed-off-by Giulio Benetti <[email protected]>--- package/protobuf/protobuf.mk | 4 ++++ 1 file changed, 4 insertions(+)package/protobuf/protobuf.mk +0
-0
package/protobuf/protobuf.mk ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) · line 33
Quoted 10 lines
package/protobuf/protobuf.mk +4
-0@@ -24,6 +24,10 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) PROTOBUF_CXXFLAGS += -O0 endif +ifeq ($(BR2_or1k),y) +PROTOBUF_CXXFLAGS += -mcmodel=large +endif + PROTOBUF_CONF_ENV = CXXFLAGS="$(PROTOBUF_CXXFLAGS)" ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v2 3/3 toolchain: remove binutils bug 21464
In reply to Giulio BenettiThis bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobuf
--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)
package/libgeos/Config.in +1 -3
@@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS bool "libgeos" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 help GEOS (Geometry Engine - Open Source) is a C++ port of the
@@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS https://trac.osgeo.org/geos -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597" +comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
package/postgis/Config.in +1 -3
@@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj depends on BR2_TOOLCHAIN_HAS_THREADS # proj depends on BR2_USE_WCHAR # libgeos, proj - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos select BR2_PACKAGE_LIBGEOS select BR2_PACKAGE_PROJ
@@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS https://postgis.net/ -comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597" +comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597" depends on !BR2_microblazeel && !BR2_microblazebe # ICE depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
package/protobuf/Config.in +0 -1
@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS default y if BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" depends on BR2_USE_MMU # fork() - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 config BR2_PACKAGE_PROTOBUF bool "protobuf"
toolchain/Config.in +0 -6
@@ -71,12 +71,6 @@ source "package/gdb/Config.in.host" comment "Toolchain Generic Options" -# https://sourceware.org/bugzilla/show_bug.cgi?id=21464 -# Affect toolchains built with binutils 2.31.1, still not fixed. -config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 - bool - default y if BR2_or1k - # https://sourceware.org/bugzilla/show_bug.cgi?id=27597 # Affect toolchains built with binutils 2.36.1, still not fixed. config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 6 lines · Giulio Benetti
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobuf
It's not clear to me if all the external toolchains that we use also have this
patch already. Basically that boils down to the stable and bleeding edge bootlin toolchains.
Well, I'm pretty sure they're not yet updated, since they're still 2020.08-1...
Regards,
Arnout
Quoted 74 lines
Signed-off-by Giulio Benetti <[email protected]>Reviewed-by Maxim Kochetkov <[email protected]>--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)package/libgeos/Config.in +1
-3@@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS bool "libgeos" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 help GEOS (Geometry Engine - Open Source) is a C++ port of the@@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS https://trac.osgeo.org/geos -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597" +comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597package/postgis/Config.in +1
-3@@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj depends on BR2_TOOLCHAIN_HAS_THREADS # proj depends on BR2_USE_WCHAR # libgeos, proj - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos select BR2_PACKAGE_LIBGEOS select BR2_PACKAGE_PROJ@@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS https://postgis.net/ -comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597" +comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597" depends on !BR2_microblazeel && !BR2_microblazebe # ICE depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597package/protobuf/Config.in +0
-1@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS default y if BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" depends on BR2_USE_MMU # fork() - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 config BR2_PACKAGE_PROTOBUF bool "protobuf"toolchain/Config.in +0
-0@@ -71,12 +71,6 @@ source "package/gdb/Config.in.host" comment "Toolchain Generic Options"
toolchain/Config.in source "package/gdb/Config.in.host" · line 76
Quoted 10 lines
toolchain/Config.in +0
-6-# https://sourceware.org/bugzilla/show_bug.cgi?id=21464 -# Affect toolchains built with binutils 2.31.1, still not fixed. -config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 - bool - default y if BR2_or1k - # https://sourceware.org/bugzilla/show_bug.cgi?id=27597 # Affect toolchains built with binutils 2.36.1, still not fixed. config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Hi Arnout,
Quoted 10 lines · Arnout Vandecappelle
Quoted 6 lines · Giulio Benetti
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobuf
Quoted 5 lines
It's not clear to me if all the external toolchains that we use also have this
patch already. Basically that boils down to the stable and bleeding edge bootlin toolchains.Well, I'm pretty sure they're not yet updated, since they're still 2020.08-1...
For this patch we have to wait until all or1k patches have been applied to Bootlin toolchain and they got rebuilt and bumped. Then we can apply it since Buildroot will become OpenRisc bug free. But this depends on external OpenRisc toolchains that only Bootlin provide
Kind regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 78 lines
Regards,
ArnoutQuoted 74 lines
Signed-off-by Giulio Benetti <[email protected]>Reviewed-by Maxim Kochetkov <[email protected]>--- package/libgeos/Config.in | 4 +--- package/postgis/Config.in | 4 +--- package/protobuf/Config.in | 1 - toolchain/Config.in | 6 ------ 4 files changed, 2 insertions(+), 13 deletions(-)package/libgeos/Config.in +1
-3@@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS bool "libgeos" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 help GEOS (Geometry Engine - Open Source) is a C++ port of the@@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS https://trac.osgeo.org/geos -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597" +comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597package/postgis/Config.in +1
-3@@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj depends on BR2_TOOLCHAIN_HAS_THREADS # proj depends on BR2_USE_WCHAR # libgeos, proj - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos select BR2_PACKAGE_LIBGEOS select BR2_PACKAGE_PROJ@@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS https://postgis.net/ -comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597" +comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597" depends on !BR2_microblazeel && !BR2_microblazebe # ICE depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ - BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \ BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597package/protobuf/Config.in +0
-1@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS default y if BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" depends on BR2_USE_MMU # fork() - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 config BR2_PACKAGE_PROTOBUF bool "protobuf"toolchain/Config.in +0
-0@@ -71,12 +71,6 @@ source "package/gdb/Config.in.host" comment "Toolchain Generic Options"
Quoted 10 lines
toolchain/Config.in source "package/gdb/Config.in.host" · line 76
Quoted 10 lines
toolchain/Config.in +0
-6-# https://sourceware.org/bugzilla/show_bug.cgi?id=21464 -# Affect toolchains built with binutils 2.31.1, still not fixed. -config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 - bool - default y if BR2_or1k - # https://sourceware.org/bugzilla/show_bug.cgi?id=27597 # Affect toolchains built with binutils 2.36.1, still not fixed. config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Hi Arnout, Thomas, All,
Quoted 17 lines · Giulio Benetti
Hi Arnout,
Quoted 14 lines · Arnout Vandecappelle
Quoted 6 lines · Giulio Benetti
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobufIt's not clear to me if all the external toolchains that we use also have this
patch already. Basically that boils down to the stable and bleeding edge bootlin toolchains.
Quoted 6 lines
Quoted 1 line
Well, I'm pretty sure they're not yet updated, since they're still 2020.08-1...
For this patch we have to wait until all or1k patches have been applied to Bootlin toolchain and they got rebuilt and bumped.
Then we can apply it since Buildroot will become OpenRisc bug free. But this depends on external OpenRisc toolchains that only Bootlin provide
Unfortunately libgeos is still affected by this bug and postgis too because it's its dependency. The reason is that libgeos has been bumped and I've never given a build after that.
Only protobuf has been fixed after rebuilding all Bootlin toolchains.
So I will report upstream that is usually very responsive and ask to fix this binutils again, hopefully once for all.
So please drop this patch. I'll send a patch for protobuf package only.
Best regards
Signature · 6 lines
Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 1/1 package/protobuf: drop dependency on binutils bug 21464
This package build failure has been fixed by using -mcmodel=large that is now available in external toolchains as well as buildroot toolchains. So we can drop its dependency on binutils 21464.
--- package/protobuf/Config.in | 1 - 1 file changed, 1 deletion(-)
package/protobuf/Config.in +0 -1
@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS default y if BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" depends on BR2_USE_MMU # fork() - depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 config BR2_PACKAGE_PROTOBUF bool "protobuf"
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni
AppliedRe: [Buildroot] [PATCH] package/protobuf: drop dependency on binutils bug 21464
Quoted 8 lines · On Thu, 30 Dec 2021 21:12:30 +0100 Giulio Benetti…
This package build failure has been fixed by using -mcmodel=large that is now available in external toolchains as well as buildroot toolchains. So we can drop its dependency on binutils 21464.
Signed-off-by Giulio Benetti <[email protected]>--- package/protobuf/Config.in | 1 - 1 file changed, 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 27 lines · Giulio Benetti
Hi Arnout, Thomas, All,
Quoted 17 lines · Giulio Benetti
Hi Arnout,
Quoted 14 lines · Arnout Vandecappelle
Quoted 6 lines · Giulio Benetti
This bug has been fixed upstream and backported to buildroot binutils package. So let's remove it from toolchain/Config.in and from packages that are affected by it:
- libgeos
- postgis
- protobufIt's not clear to me if all the external toolchains that we use also have this
patch already. Basically that boils down to the stable and bleeding edge bootlin toolchains.Quoted 6 lines
Quoted 1 line
Well, I'm pretty sure they're not yet updated, since they're still 2020.08-1...
For this patch we have to wait until all or1k patches have been applied to Bootlin toolchain and they got rebuilt and bumped.
Then we can apply it since Buildroot will become OpenRisc bug free. But this depends on external OpenRisc toolchains that only Bootlin provide
Quoted 7 lines
Unfortunately libgeos is still affected by this bug and postgis too because it's its dependency. The reason is that libgeos has been bumped and I've never given a build after that.
Only protobuf has been fixed after rebuilding all Bootlin toolchains. So I will report upstream that is usually very responsive and ask to fix this binutils again, hopefully once for all.
I've updated the bug on the gcc side that works together with binutils on the fix:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99783
Best regards
Signature · 6 lines
Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot