dt-bindings: connector: Replace BIT macro with generic bit ops
Subsystems (2)
PATCH 1/1 dt-bindings: connector: Replace BIT macro with generic bit ops
BIT macro is not supported in dt-bindings. Replace it with generic bit operations.
Fixes 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties")
Signed-off-by Kyle Tso <[email protected]>
--- include/dt-bindings/usb/pd.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
include/dt-bindings/usb/pd.h +10 -10
@@ -163,10 +163,10 @@#define UFP_VDO_VER1_2 2/* Device Capability */ -#define DEV_USB2_CAPABLE BIT(0) -#define DEV_USB2_BILLBOARD BIT(1) -#define DEV_USB3_CAPABLE BIT(2) -#define DEV_USB4_CAPABLE BIT(3) +#define DEV_USB2_CAPABLE (1 << 0) +#define DEV_USB2_BILLBOARD (1 << 1) +#define DEV_USB3_CAPABLE (1 << 2) +#define DEV_USB4_CAPABLE (1 << 3)/* Connector Type */ #define UFP_RECEPTACLE 2
@@ -191,9 +191,9 @@/* Alternate Modes */ #define UFP_ALTMODE_NOT_SUPP 0 -#define UFP_ALTMODE_TBT3 BIT(0) -#define UFP_ALTMODE_RECFG BIT(1) -#define UFP_ALTMODE_NO_RECFG BIT(2) +#define UFP_ALTMODE_TBT3 (1 << 0) +#define UFP_ALTMODE_RECFG (1 << 1) +#define UFP_ALTMODE_NO_RECFG (1 << 2)/* USB Highest Speed */ #define UFP_USB2_ONLY 0
@@ -217,9 +217,9 @@* <4:0> :: Port number */ #define DFP_VDO_VER1_1 1 -#define HOST_USB2_CAPABLE BIT(0) -#define HOST_USB3_CAPABLE BIT(1) -#define HOST_USB4_CAPABLE BIT(2) +#define HOST_USB2_CAPABLE (1 << 0) +#define HOST_USB3_CAPABLE (1 << 1) +#define HOST_USB4_CAPABLE (1 << 2)#define DFP_RECEPTACLE 2#define DFP_CAPTIVE 3
Signature · 1 line
2.31.1.818.g46aad6cb9e-goog
Greg KH
maintainerQuoted 2 lines · Kyle Tso
BIT macro is not supported in dt-bindings. Replace it with generic bit operations.
Why isn't the BIT macro supported there? How are we going to "remember" that I should not take patches that use this #define in that location?
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 2 lines · Kyle Tso
BIT macro is not supported in dt-bindings. Replace it with generic bit operations.
Why isn't the BIT macro supported there? How are we going to "remember" that I should not take patches that use this #define in that location?
I rephrased the commit message in v2
thanks,
Kyle
Quoted 4 lines
thanks,
greg k-h