Add the support of SVDM Version 2.0 VDOs
v3 cover Add the support of SVDM Version 2.0 VDOs
Add a patch on top of the v2 patches. They are not related but I put them together to avoid the conflict. No change in v2 patches.
usb: typec: tcpm: Fix misuses of AMS invocation
- This patch is to fix the misuse of tcpm_ams_start in tcpm_pd_svdm.
=== v2 cover letter
Got the Ack by Heikki so I re-examined the patches and found a *stupid* bug in the patch "usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0" that I separate the "for loop" into two parts, which is not only necessary but also redundant.
Changes since v1:
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- no code change
- add Acked-by tag
dt-bindings: connector: Add PD rev 2.0 VDO definition
- no code change
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- merge the assignment to array element 1 into the for loop. No semantic code logic change.
- add Acked-by tag
=== v1 cover letter
The patches are primarily for the responses to the Discover Identity command. This part was changed a lot from PD rev2.0 to PD rev3.0 (now it's rev3.1 :D). e.g. DFP can respond to Discover Identity command with ACK in PD rev3.x and the Product Type VDOs are quite different. Given that tcpm.c moved on to PD rev3.x and PD rev2.0 is still supported, some changes need to be made to support both PD rev3.x and rev2.0.
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- This patch is to unblock the responder ACK to Discover Identity if the port is DFP and the SVDM version is 2.0
dt-bindings: connector: Add PD rev 2.0 VDO definition
- similar changes to Commit 2a1673f0f1de ("usb: pd: Reland VDO definitions of PD2.0")
https://lore.kernel.org/linux-usb/[email protected]/
- add a new property sink-vdos-v1 to store the PD rev2.0 VDOs
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- populate the legacy VDOs from fwnode
- send these data if the port partner is SVDM Version 1.0
===
Kyle Tso (4):
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
dt-bindings: connector: Add PD rev 2.0 VDO definition
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
usb: typec: tcpm: Fix misuses of AMS invocation
.../bindings/connector/usb-connector.yaml | 15 ++++ drivers/usb/typec/tcpm/tcpm.c | 63 +++++++++++------ include/dt-bindings/usb/pd.h | 69 ++++++++++++++++++- 3 files changed, 123 insertions(+), 24 deletions(-)
Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog
PATCH v3 1/4 usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
In USB PD Spec Rev 3.1 Ver 1.0, section "6.12.5 Applicability of Structured VDM Commands", DFP is allowed and recommended to respond to Discovery Identity with ACK. And in section "6.4.4.2.5.1 Commands other than Attention", NAK should be returned only when receiving Messages with invalid fields, Messages in wrong situation, or unrecognize Messages.
Still keep the original design for SVDM Version 1.0 for backward compatibilities.
---
changes since v2:
- no change
drivers/usb/typec/tcpm/tcpm.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +10 -4
@@ -1575,19 +1575,25 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev,if (PD_VDO_VID (p[0 ]) !=USB_SID_PD )break ; -if (PD_VDO_SVDM_VER (p[0 ]) < svdm_version) +if (PD_VDO_SVDM_VER (p[0 ]) < svdm_version) {typec_partner_set_svdm_version (port->partner,PD_VDO_SVDM_VER (p[0 ])); + svdm_version =PD_VDO_SVDM_VER (p[0 ]); + }tcpm_ams_start (port,DISCOVER_IDENTITY ); -/* 6.4.4.3.1: Only respond as UFP (device) */ -if (port->data_role ==TYPEC_DEVICE && +/* +* PD2.0 Spec 6.10.3: respond with NAK as DFP (data host) +* PD3.1 Spec 6.4.4.2.5.1: respond with NAK if "invalid field" or +* "wrong configuation" or "Unrecognized" +*/ +if ((port->data_role ==TYPEC_DEVICE || svdm_version >=SVDM_VER_2_0 ) && port->nr_snk_vdo) {/* * Product Type DFP and Connector Type are not defined in SVDM * version 1.0 and shall be set to zero. */ -if (typec_get_negotiated_svdm_version (typec) <SVDM_VER_2_0 ) +if (svdm_version <SVDM_VER_2_0 ) response[1 ] = port->snk_vdo[0 ] & ~IDH_DFP_MASK & ~IDH_CONN_MASK ;else
Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog
PATCH v3 2/4 dt-bindings: connector: Add PD rev 2.0 VDO definition
In reply to Kyle TsoAdd the VDO definition for USB PD rev 2.0 in the bindings and define a new property snk-vdos-v1 containing legacy VDOs as the responses to the port partner which only supports PD rev 2.0.
---
changes since v2:
- no change
.../bindings/connector/usb-connector.yaml | 15 ++++ include/dt-bindings/usb/pd.h | 69 ++++++++++++++++++- 2 files changed, 81 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/connector/usb-connector.yaml +15 -0
@@ -149,6 +149,17 @@ properties: maxItems: 6 $ref: /schemas/types.yaml#/definitions/uint32-array + sink-vdos-v1: + description: An array of u32 with each entry, a Vendor Defined Message Object (VDO), + providing additional information corresponding to the product, the detailed bit + definitions and the order of each VDO can be found in + "USB Power Delivery Specification Revision 2.0, Version 1.3" chapter 6.4.4.3.1 Discover + Identity. User can specify the VDO array via VDO_IDH/_CERT/_PRODUCT/_CABLE/_AMA defined in + dt-bindings/usb/pd.h. + minItems: 3 + maxItems: 6 + $ref: /schemas/types.yaml#/definitions/uint32-array + op-sink-microwatt: description: Sink required operating power in microwatt, if source can't offer the power, Capability Mismatch is set. Required for power sink and
@@ -207,6 +218,10 @@ properties: SNK_READY for non-pd link. type: boolean +dependencies: + sink-vdos-v1: [ 'sink-vdos' ] + sink-vdos: [ 'sink-vdos-v1' ] + required: - compatible
include/dt-bindings/usb/pd.h +66 -3
111 lines not on this page · raw message
Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog
Re: [PATCH v3 2/4] dt-bindings: connector: Add PD rev 2.0 VDO definition
Quoted 4 lines · Kyle Tso
Add the VDO definition for USB PD rev 2.0 in the bindings and define a new property snk-vdos-v1 containing legacy VDOs as the responses to the port partner which only supports PD rev 2.0.
Quoted 9 lines
Signed-off-by Kyle Tso <[email protected]>---
changes since v2:
- no change.../bindings/connector/usb-connector.yaml | 15 ++++ include/dt-bindings/usb/pd.h | 69 ++++++++++++++++++- 2 files changed, 81 insertions(+), 3 deletions(-)
PATCH v3 3/4 usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
In reply to Kyle TsoThe ID Header VDO and Product VDOs defined in USB PD Spec rev 2.0 and rev 3.1 are quite different. Add an additional array snk_vdo_v1 and send it as the response to the port partner if it only supports SVDM version 1.0.
---
changes since v2:
- no change
drivers/usb/typec/tcpm/tcpm.c | 40 ++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 12 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +28 -12
@@ -401,6 +401,8 @@ struct tcpm_port {unsigned int nr_src_pdo;u32 snk_pdo[PDO_MAX_OBJECTS ];unsigned int nr_snk_pdo; +u32 snk_vdo_v1[VDO_MAX_OBJECTS ]; +unsigned int nr_snk_vdo_v1;u32 snk_vdo[VDO_MAX_OBJECTS ];unsigned int nr_snk_vdo;
@@ -1589,18 +1591,16 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev,*/ if ((port->data_role ==TYPEC_DEVICE || svdm_version >=SVDM_VER_2_0 ) && port->nr_snk_vdo) { -/* -* Product Type DFP and Connector Type are not defined in SVDM -* version 1.0 and shall be set to zero. -*/ -if (svdm_version <SVDM_VER_2_0 ) - response[1 ] = port->snk_vdo[0 ] & ~IDH_DFP_MASK - & ~IDH_CONN_MASK ; -else - response[1 ] = port->snk_vdo[0 ]; -for (i =1 ; i < port->nr_snk_vdo; i++) - response[i +1 ] = port->snk_vdo[i]; - rlen = port->nr_snk_vdo +1 ; +if (svdm_version <SVDM_VER_2_0 ) { +for (i =0 ; i < port->nr_snk_vdo_v1; i++) + response[i +1 ] = port->snk_vdo_v1[i]; + rlen = port->nr_snk_vdo_v1 +1 ; + + }else { +for (i =0 ; i < port->nr_snk_vdo; i++) + response[i +1 ] = port->snk_vdo[i]; + rlen = port->nr_snk_vdo +1 ; + } }break ;case CMD_DISCOVER_SVID :
@@ -5969,6 +5969,22 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return ret; } +/* If sink-vdos is found, sink-vdos-v1 is expected for backward compatibility. */ +if (port->nr_snk_vdo) { + ret =fwnode_property_count_u32 (fwnode,"sink-vdos-v1" ); +if (ret <0 ) +return ret; +else if (ret ==0 ) +return -ENODATA ; + + port->nr_snk_vdo_v1 =min (ret,VDO_MAX_OBJECTS ); + ret =fwnode_property_read_u32_array (fwnode,"sink-vdos-v1" , + port->snk_vdo_v1, + port->nr_snk_vdo_v1); +if (ret <0 ) +return ret; + } +return 0 ; }
Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog
PATCH v3 4/4 usb: typec: tcpm: Fix misuses of AMS invocation
In reply to Kyle Tsotcpm_ams_start is used to initiate an AMS as well as checking Collision Avoidance conditions but not for flagging passive AMS (initiated by the port partner). Fix the misuses of tcpm_ams_start in tcpm_pd_svdm.
ATTENTION doesn't need responses so the AMS flag is not needed here.
--- drivers/usb/typec/tcpm/tcpm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +5 -6
@@ -1583,7 +1583,7 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev, svdm_version =PD_VDO_SVDM_VER (p[0 ]); } -tcpm_ams_start (port,DISCOVER_IDENTITY ); + port->ams =DISCOVER_IDENTITY ;/* * PD2.0 Spec 6.10.3: respond with NAK as DFP (data host) * PD3.1 Spec 6.4.4.2.5.1: respond with NAK if "invalid field" or
@@ -1604,19 +1604,18 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev, }break ;case CMD_DISCOVER_SVID : -tcpm_ams_start (port,DISCOVER_SVIDS ); + port->ams =DISCOVER_SVIDS ;break ;case CMD_DISCOVER_MODES : -tcpm_ams_start (port,DISCOVER_MODES ); + port->ams =DISCOVER_MODES ;break ;case CMD_ENTER_MODE : -tcpm_ams_start (port,DFP_TO_UFP_ENTER_MODE ); + port->ams =DFP_TO_UFP_ENTER_MODE ;break ;case CMD_EXIT_MODE : -tcpm_ams_start (port,DFP_TO_UFP_EXIT_MODE ); + port->ams =DFP_TO_UFP_EXIT_MODE ;break ;case CMD_ATTENTION : -tcpm_ams_start (port,ATTENTION );/* Attention command does not have response */ *adev_action =ADEV_ATTENTION ;return 0 ;
Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog
Re: [PATCH v3 4/4] usb: typec: tcpm: Fix misuses of AMS invocation
Quoted 8 lines · Kyle Tso
tcpm_ams_startis used to initiate an AMS as well as checking Collision Avoidance conditions but not for flagging passive AMS (initiated by the port partner). Fix the misuses oftcpm_ams_startintcpm_pd_svdm.ATTENTION doesn't need responses so the AMS flag is not needed here.
Fixes 0bc3ee92880d ("usb: typec: tcpm: Properly interrupt VDM AMS")Signed-off-by Kyle Tso <[email protected]>
Quoted 43 lines
--- drivers/usb/typec/tcpm/tcpm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)drivers/usb/typec/tcpm/tcpm.c +5
-6@@ -1583,7 +1583,7 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev, svdm_version =PD_VDO_SVDM_VER (p[0 ]); } -tcpm_ams_start (port,DISCOVER_IDENTITY ); + port->ams =DISCOVER_IDENTITY ;/* * PD2.0 Spec 6.10.3: respond with NAK as DFP (data host) * PD3.1 Spec 6.4.4.2.5.1: respond with NAK if "invalid field" or @@ -1604,19 +1604,18 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev, }break ;case CMD_DISCOVER_SVID : -tcpm_ams_start (port,DISCOVER_SVIDS ); + port->ams =DISCOVER_SVIDS ;break ;case CMD_DISCOVER_MODES : -tcpm_ams_start (port,DISCOVER_MODES ); + port->ams =DISCOVER_MODES ;break ;case CMD_ENTER_MODE : -tcpm_ams_start (port,DFP_TO_UFP_ENTER_MODE ); + port->ams =DFP_TO_UFP_ENTER_MODE ;break ;case CMD_EXIT_MODE : -tcpm_ams_start (port,DFP_TO_UFP_EXIT_MODE ); + port->ams =DFP_TO_UFP_EXIT_MODE ;break ;case CMD_ATTENTION : -tcpm_ams_start (port,ATTENTION );/* Attention command does not have response */ *adev_action =ADEV_ATTENTION ;return 0 ;Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog
Signature · 1 line
heikki