Skip to content

Add the support of SVDM Version 2.0 VDOs

Kyle Tso linux-devicetree linux-usb lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v23 patches 0 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Changes since v1 from the cover letter

usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- no code change
- add Acked-by tag

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFPdrivers/usb/typec/tcpm/tcpm.c+10 -40 replies
2/4dt-bindings: connector: Add PD rev 2.0 VDO definitionDocumentation/devicetree/bindings/connector/usb-connector.yaml include/dt-bindings/usb/pd.h+81 -31 reply
3/4usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0drivers/usb/typec/tcpm/tcpm.c+28 -120 replies
4/4usb: typec: tcpm: Fix misuses of AMS invocationdrivers/usb/typec/tcpm/tcpm.c+5 -61 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchHeikki KrogerusRob Herring
1/4A-b
2/4R-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Add the support of SVDM Version 2.0 VDOs

Add a patch on top of the v2 patches. They are not related but I put them together to avoid the conflict. No change in v2 patches.

usb: typec: tcpm: Fix misuses of AMS invocation
- This patch is to fix the misuse of tcpm_ams_start in tcpm_pd_svdm.

=== v2 cover letter

Got the Ack by Heikki so I re-examined the patches and found a *stupid* bug in the patch "usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0" that I separate the "for loop" into two parts, which is not only necessary but also redundant.

Changes since v1:
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- no code change
- add Acked-by tag

dt-bindings: connector: Add PD rev 2.0 VDO definition
- no code change

usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- merge the assignment to array element 1 into the for loop. No semantic code logic change.
- add Acked-by tag

=== v1 cover letter

The patches are primarily for the responses to the Discover Identity command. This part was changed a lot from PD rev2.0 to PD rev3.0 (now it's rev3.1 :D). e.g. DFP can respond to Discover Identity command with ACK in PD rev3.x and the Product Type VDOs are quite different. Given that tcpm.c moved on to PD rev3.x and PD rev2.0 is still supported, some changes need to be made to support both PD rev3.x and rev2.0.

usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- This patch is to unblock the responder ACK to Discover Identity if the port is DFP and the SVDM version is 2.0

dt-bindings: connector: Add PD rev 2.0 VDO definition
- similar changes to Commit 2a1673f0f1de ("usb: pd: Reland VDO definitions of PD2.0")
https://lore.kernel.org/linux-usb/[email protected]/
- add a new property sink-vdos-v1 to store the PD rev2.0 VDOs

usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- populate the legacy VDOs from fwnode
- send these data if the port partner is SVDM Version 1.0

===

Kyle Tso (4):
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
dt-bindings: connector: Add PD rev 2.0 VDO definition
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
usb: typec: tcpm: Fix misuses of AMS invocation

 .../bindings/connector/usb-connector.yaml     | 15 ++++
 drivers/usb/typec/tcpm/tcpm.c                 | 63 +++++++++++------
 include/dt-bindings/usb/pd.h                  | 69 ++++++++++++++++++-
 3 files changed, 123 insertions(+), 24 deletions(-)
Signature · 1 line
2.32.0.rc0.204.g9fa02ecfa5-goog