Skip to contentSkip to conversation

vdpa: fix error code in vp_vdpa_probe()

PATCH In review Dan Carpenter 3 participants 3 messages Jun 5, 2021 – Jun 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vdpa: fix error code in vp_vdpa_probe()

Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it returns success.

Fixes 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
---
 drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
 1 file changed, 1 insertion(+)
drivers/vdpa/virtio_pci/vp_vdpa.c +1 -0
index c76ebb531212..e5d92db728d3 100644
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 			vp_modern_map_vq_notify(mdev, i,
 						&vp_vdpa->vring[i].notify_pa);
 		if (!vp_vdpa->vring[i].notify) {
+			ret = -ENOMEM;
 			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
 			goto err;
 		}
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Dan Carpenter

Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it returns success.

Fixes 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
---
  drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
  1 file changed, 1 insertion(+)

Thanks

Quoted 13 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1 -0
index c76ebb531212..e5d92db728d3 100644
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
  			vp_modern_map_vq_notify(mdev, i,
  						&vp_vdpa->vring[i].notify_pa);
  		if (!vp_vdpa->vring[i].notify) {
+			ret = -ENOMEM;
  			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
  			goto err;
  		}
Reviewed-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 24 lines · Dan Carpenter

Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it returns success.

Fixes 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")

---
drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +

1 file changed, 1 insertion(+)
drivers/vdpa/virtio_pci/vp_vdpa.c +1 -0
index c76ebb531212..e5d92db728d3 100644
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 			vp_modern_map_vq_notify(mdev, i,
 						&vp_vdpa->vring[i].notify_pa);
 		if (!vp_vdpa->vring[i].notify) {
+			ret = -ENOMEM;
 			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
 			goto err;
 		}
Signature · 1 line
2.30.2