vdpa: fix error code in vp_vdpa_probe()
Subsystems (2)
PATCH 1/1 vdpa: fix error code in vp_vdpa_probe()
Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it returns success.
Fixes 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + 1 file changed, 1 insertion(+)
drivers/vdpa/virtio_pci/vp_vdpa.c +1 -0
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)vp_modern_map_vq_notify (mdev, i, &vp_vdpa->vring[i].notify_pa);if (!vp_vdpa->vring[i].notify) { + ret = -ENOMEM ;dev_warn (&pdev->dev,"Fail to map vq notify %d\n" , i); goto err; }
Signature · 1 line
2.30.2
Quoted 8 lines · Dan Carpenter
Return
-ENOMEMifvp_modern_map_vq_notify()fails. Currently it returns success.Fixes 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")Signed-off-by Dan Carpenter <[email protected]>--- drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + 1 file changed, 1 insertion(+)
Acked-by Jason Wang <[email protected]>
Thanks
Quoted 13 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)vp_modern_map_vq_notify (mdev, i, &vp_vdpa->vring[i].notify_pa);if (!vp_vdpa->vring[i].notify) { + ret = -ENOMEM ;dev_warn (&pdev->dev,"Fail to map vq notify %d\n" , i); goto err; }
Quoted 24 lines · Dan Carpenter
Return
-ENOMEMifvp_modern_map_vq_notify()fails. Currently it returns success.Fixes 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")Signed-off-by Dan Carpenter <[email protected]>---
drivers/vdpa/virtio_pci/vp_vdpa.c| 1 +1 file changed, 1 insertion(+)drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)vp_modern_map_vq_notify (mdev, i, &vp_vdpa->vring[i].notify_pa);if (!vp_vdpa->vring[i].notify) { + ret = -ENOMEM ;dev_warn (&pdev->dev,"Fail to map vq notify %d\n" , i); goto err; }Signature · 1 line
2.30.2
Reviewed-by Stefano Garzarella <[email protected]>