Skip to contentSkip to conversation

libjpeg-turbo: fix do_compile error on armv5

PATCH Superseded Changqing Li 4 participants 7 messages Jun 9, 2021 – Jun 11, 2021

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libjpeg-turbo: fix do_compile error on armv5

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +2 -0
index 7f91cc02ac..da21971113 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
 # Work around missing non-floating point ABI support in MIPS
 EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"
+
 # Provide a workaround if Altivec unit is not present in PPC
 EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
 EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
Signature · 1 line
2.17.1
#1 lore raw

Btw, I'm hoping upstream will fix this for all arm
https://github.com/libjpeg-turbo/libjpeg-turbo/issues/523

Quoted 33 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +2 -1
index 7f91cc02ac..da21971113 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
 # Work around missing non-floating point ABI support in MIPS
 EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"
+
 # Provide a workaround if Altivec unit is not present in PPC
 EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
 EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1

#2 lore raw
In reply to Changqing Li
Quoted 8 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

Drop this comment. Neon may be missing from other ISA levels too (i.e. this fix is not specific to armv5).

Quoted 10 lines
---
 meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..da21971113 100644

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 4 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
 # Work around missing non-floating point ABI support in MIPS
 EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"

Shouldn't this be checking for neon in TUNE_FEATURES rather than TUNE_CCARGS_MFPU? It should also probably be conditional on the _arm over-ride since neon will be missing from TUNE_CCARGS_MFPU/TUNE_FEATURES for other architectures. Since big endian ARM doesn't use the _arm over-ride you will also need a duplicate line with the same logic with the _armeb override too. See the lines below which do the equivalent for _powerpc / _powerpc64 as a reference.

Quoted 9 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -1
 # Provide a workaround if Altivec unit is not present in PPC
 EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
 EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1

#3 lore raw
Quoted 27 lines · Andre McCurdy
Quoted 8 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

Drop this comment. Neon may be missing from other ISA levels too (i.e. this fix is not specific to armv5).

Quoted 13 lines
---
 meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..da21971113 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
 # Work around missing non-floating point ABI support in MIPS
 EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
Quoted 23 lines

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 1 line
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"

Shouldn't this be checking for neon in TUNE_FEATURES rather than TUNE_CCARGS_MFPU? It should also probably be conditional on the _arm over-ride since neon will be missing from TUNE_CCARGS_MFPU/TUNE_FEATURES for other architectures. Since big endian ARM doesn't use the _arm over-ride you will also need a duplicate line with the same logic with the _armeb override too. See the lines below which do the equivalent for _powerpc / _powerpc64 as a reference.

Quoted 9 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -1
 # Provide a workaround if Altivec unit is not present in PPC
 EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
 EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1

Just to confirm it fails on armv4 as well.

CheckSymbolExists.c:8:19: error: 'vld1_s16_x3' undeclared (first use in this function)
CheckSymbolExists.c:8:19: error: 'vld1_u16_x2' undeclared (first use in this function)
CheckSymbolExists.c:8:19: error: 'vld1q_u8_x4' undeclared (first use in this function)

...
#include <arm_neon.h>
...
3 | #error "float ABI = softfp"

A.A.

#4 lore raw
In reply to Andre McCurdy
Quoted 5 lines · Andre McCurdy

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 2 lines · Changqing Li

From: Changqing Li <[email protected]>

Quoted 7 lines
Quoted 5 lines

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

Drop this comment. Neon may be missing from other ISA levels too (i.e. this fix is not specific to armv5).

Get it. Thanks.

Quoted 14 lines
Quoted 14 lines
---
  meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
  1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..da21971113 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
  # Work around missing non-floating point ABI support in MIPS
  EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
Quoted 3 lines

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 1 line
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"

Shouldn't this be checking for neon in TUNE_FEATURES rather than TUNE_CCARGS_MFPU?

Refer feature-arm-vfp.inc:

TUNE_CCARGS_MFLOAT = "${@ bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', 'hard', 'softfp', d) if (d.getVar('TUNE_CCARGS_MFPU') != '') else '' }"

TUNE_CCARGS   .= "${@ ' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '')     else ''}"

There are condition that neon is not in TUNE_FEATURES, but vfp is in it. so TUNE_CCARGS may append -mfloat-abi=softfp,  then

simd module here can be compiled  sucessfully.

Quoted 7 lines

It should also probably be conditional on the _arm over-ride since neon will be missing from TUNE_CCARGS_MFPU/TUNE_FEATURES for other architectures.Since big endian ARM doesn't use the _arm over-ride you will also need a duplicate line with the same logic with the _armeb override too. See the lines below which do the equivalent for _powerpc / _powerpc64 as a reference.

ok. thanks.

Quoted 10 lines
Quoted 10 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -1
  # Provide a workaround if Altivec unit is not present in PPC
  EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
  EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1

#5 lore raw
Quoted 37 lines · Changqing Li
Quoted 5 lines · Andre McCurdy

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 2 lines · Changqing Li

From: Changqing Li <[email protected]>

Quoted 7 lines
Quoted 5 lines

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

Drop this comment. Neon may be missing from other ISA levels too (i.e. this fix is not specific to armv5).

Get it. Thanks.

Quoted 14 lines
Quoted 14 lines
---
  meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
  1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..da21971113 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
  # Work around missing non-floating point ABI support in MIPS
  EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
Quoted 3 lines

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 1 line
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"

Shouldn't this be checking for neon in TUNE_FEATURES rather than TUNE_CCARGS_MFPU?

Refer feature-arm-vfp.inc:

TUNE_CCARGS_MFLOAT = "${@ bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', 'hard', 'softfp', d) if (d.getVar('TUNE_CCARGS_MFPU') != '') else '' }"

Quoted 8 lines

TUNE_CCARGS .= "${@ ' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if
(d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"

There are condition that neon is not in TUNE_FEATURES, but vfp is in it. so TUNE_CCARGS may append -mfloat-abi=softfp, then

simd module here can be compiled sucessfully.

The SIMD code can only be used on targets which support neon. There may be other cases where the code can be compiled but if it can never be used at run time it's not very useful.

Quoted 19 lines
Quoted 7 lines

It should also probably be conditional on the _arm over-ride since neon will be missing from TUNE_CCARGS_MFPU/TUNE_FEATURES for other architectures.Since big endian ARM doesn't use the _arm over-ride you will also need a duplicate line with the same logic with the _armeb override too. See the lines below which do the equivalent for _powerpc / _powerpc64 as a reference.

ok. thanks.

Quoted 10 lines
Quoted 10 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -1
  # Provide a workaround if Altivec unit is not present in PPC
  EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
  EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1

#6 lore raw
Quoted 43 lines · Andre McCurdy

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 40 lines · Changqing Li
Quoted 5 lines · Andre McCurdy

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 2 lines · Changqing Li

From: Changqing Li <[email protected]>

Quoted 7 lines
Quoted 5 lines

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

Drop this comment. Neon may be missing from other ISA levels too (i.e. this fix is not specific to armv5).

Get it. Thanks.

Quoted 13 lines
Quoted 13 lines
---
   meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
   1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..da21971113 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
   # Work around missing non-floating point ABI support in MIPS
   EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
Quoted 3 lines

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 1 line
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
+EXTRA_OECMAKE_append_class-target = " ${@ ('') if (d.getVar('TUNE_CCARGS_MFPU') != '') else '-DWITH_SIMD=False'}"

Shouldn't this be checking for neon in TUNE_FEATURES rather than TUNE_CCARGS_MFPU?

Refer feature-arm-vfp.inc:

TUNE_CCARGS_MFLOAT = "${@ bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', 'hard', 'softfp', d) if (d.getVar('TUNE_CCARGS_MFPU') != '') else '' }"

TUNE_CCARGS .= "${@ ' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if
(d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"

Quoted 7 lines
Quoted 4 lines

There are condition that neon is not in TUNE_FEATURES, but vfp is in it. so TUNE_CCARGS may append -mfloat-abi=softfp, then

simd module here can be compiled sucessfully.

The SIMD code can only be used on targets which support neon. There may be other cases where the code can be compiled but if it can never be used at run time it's not very useful.

OK, thanks. I will send V3 patch.

Quoted 19 lines
Quoted 19 lines
Quoted 8 lines

It should also probably be conditional on the _arm over-ride since neon will be missing from TUNE_CCARGS_MFPU/TUNE_FEATURES for other architectures.Since big endian ARM doesn't use the _arm over-ride you will also need a duplicate line with the same logic with the _armeb override too. See the lines below which do the equivalent for _powerpc / _powerpc64 as a reference.

ok. thanks.

Quoted 9 lines
Quoted 9 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -1
   # Provide a workaround if Altivec unit is not present in PPC
   EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
   EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1