Skip to contentSkip to conversation

libjpeg-turbo: fix do_compile error on armv5

PATCH Superseded Changqing Li 2 participants 3 messages Jun 9, 2021

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libjpeg-turbo: fix do_compile error on armv5

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +2 -0
index 7f91cc02ac..9b1798b232 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
 # Work around missing non-floating point ABI support in MIPS
 EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
+EXTRA_OECMAKE_append_class-target_armv5 = " -DWITH_SIMD=False"
+
 # Provide a workaround if Altivec unit is not present in PPC
 EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
 EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 19 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..9b1798b232 100644

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 4 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
 # Work around missing non-floating point ABI support in MIPS
 EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
+EXTRA_OECMAKE_append_class-target_armv5 = " -DWITH_SIMD=False"

I think it should check for neon in machine features if its not available then disable it on arm.

Quoted 10 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -1
+
 # Provide a workaround if Altivec unit is not present in PPC
 EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
 EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1

#2 lore raw
Quoted 24 lines · Khem Raj

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 21 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard" 31 | #error "NEON intrinsics not available with the soft-float ABI. Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Neon is not supported by armv5, disable the simd extension build.

---
  meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb | 2 ++
  1 file changed, 2 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +0 -0
index 7f91cc02ac..9b1798b232 100644
@@ -40,6 +40,8 @@ EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3
  # Work around missing non-floating point ABI support in MIPS
  EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf", "-DWITH_SIMD=False", "", d)}"
 
Quoted 3 lines

meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb EXTRA_OECMAKE_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx3 · line 43

Quoted 1 line
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -0
+EXTRA_OECMAKE_append_class-target_armv5 = " -DWITH_SIMD=False"

I think it should check for neon in machine features if its not available then disable it on arm.

Thanks. I will send a V2.

Quoted 11 lines
Quoted 11 lines
meta/recipes-graphics/jpeg/libjpeg-turbo_2.1.0.bb +1 -1
+
  # Provide a workaround if Altivec unit is not present in PPC
  EXTRA_OECMAKE_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
  EXTRA_OECMAKE_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "-DWITH_SIMD=False", d)}"
--

2.17.1