phy: rockchip: add Innosilicon-based CSI DPHY
Subsystems (3)
Heiko Stuebner
maintainerv2 cover phy: rockchip: add Innosilicon-based CSI DPHY
Newer Rockchip SoCs use a different DPHY for camera operation based on an IP block from Innosilicon.
This adds a driver for it for px30/rk3326/rk3368/rk1808.
changes in v2:
- add Robs review to the binding
- adjust to Vinod's review comments from v1
including shift -> bitfield, helpers and
also making checkpatch --strict happy
Heiko Stuebner (2):
dt-bindings: phy: add yaml binding for rockchip-inno-csi-dphy phy/rockchip: add Innosilicon-based CSI dphy
.../bindings/phy/rockchip-inno-csi-dphy.yaml | 79 +++ drivers/phy/rockchip/Kconfig | 9 + drivers/phy/rockchip/Makefile | 1 + .../phy/rockchip/phy-rockchip-inno-csidphy.c | 459 ++++++++++++++++++ 4 files changed, 548 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-csidphy.c
Signature · 1 line
2.29.2
Heiko Stuebner
maintainerPATCH v2 1/2 dt-bindings: phy: add yaml binding for rockchip-inno-csi-dphy
From: Heiko Stuebner <[email protected]>
Some Rockchip SoCs like the rk3368, rk3326, px30 use a CSI dphy based on an Innosilicon IP. Add a binding for them.
--- .../bindings/phy/rockchip-inno-csi-dphy.yaml | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml new file +79 -0
@@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings + +maintainers: + - Heiko Stuebner <[email protected]> + +description: | + The Rockchip SoC has a MIPI CSI D-PHY based on an Innosilicon IP wich + connects to the ISP1 (Image Signal Processing unit v1.0) for CSI cameras. + +properties: + compatible: + enum: + - rockchip,px30-csi-dphy + - rockchip,rk1808-csi-dphy + - rockchip,rk3326-csi-dphy + - rockchip,rk3368-csi-dphy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: pclk + + '#phy-cells': + const: 0 + + power-domains: + description: Video in/out power domain. + maxItems: 1 + + resets: + items: + - description: exclusive PHY reset line + + reset-names: + items: + - const: apb + + rockchip,grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Some additional phy settings are access through GRF regs. + +required: + - compatible + - reg + - clocks + - clock-names + - '#phy-cells' + - power-domains + - resets + - reset-names + - rockchip,grf + +additionalProperties: false + +examples: + - | + + csi_dphy: phy@ff2f0000 { + compatible = "rockchip,px30-csi-dphy"; + reg = <0xff2f0000 0x4000>; + clocks = <&cru 1>; + clock-names = "pclk"; + #phy-cells = <0>; + power-domains = <&power 1>; + resets = <&cru 1>; + reset-names = "apb"; + rockchip,grf = <&grf>; + };
Signature · 1 line
2.29.2
Heiko Stuebner
maintainerPATCH v2 2/2 phy/rockchip: add Innosilicon-based CSI dphy
In reply to Heiko StuebnerFrom: Heiko Stuebner <[email protected]>
The CSI dphy found for example on the rk3326/px30 and rk3368 is based on an IP design from Innosilicon. Add a driver for it.
--- drivers/phy/rockchip/Kconfig | 9 + drivers/phy/rockchip/Makefile | 1 + .../phy/rockchip/phy-rockchip-inno-csidphy.c | 459 ++++++++++++++++++ 3 files changed, 469 insertions(+) create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-csidphy.c
drivers/phy/rockchip/Kconfig +9 -0
@@ -48,6 +48,15 @@ config PHY_ROCKCHIP_INNO_USB2 help Support for Rockchip USB2.0 PHY with Innosilicon IP block. +config PHY_ROCKCHIP_INNO_CSIDPHY + tristate "Rockchip Innosilicon MIPI CSI PHY driver" + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF + select GENERIC_PHY + select GENERIC_PHY_MIPI_DPHY + help + Enable this to support the Rockchip MIPI CSI PHY with + Innosilicon IP block. + config PHY_ROCKCHIP_INNO_DSIDPHY tristate "Rockchip Innosilicon MIPI/LVDS/TTL PHY driver" depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
drivers/phy/rockchip/Makefile +1 -0
@@ -2,6 +2,7 @@ obj-$(CONFIG_PHY_ROCKCHIP_DP) += phy-rockchip-dp.o obj-$(CONFIG_PHY_ROCKCHIP_DPHY_RX0) += phy-rockchip-dphy-rx0.o obj-$(CONFIG_PHY_ROCKCHIP_EMMC) += phy-rockchip-emmc.o +obj-$(CONFIG_PHY_ROCKCHIP_INNO_CSIDPHY) += phy-rockchip-inno-csidphy.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY) += phy-rockchip-inno-dsidphy.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_HDMI) += phy-rockchip-inno-hdmi.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_USB2) += phy-rockchip-inno-usb2.o
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +459 -0
459 lines not on this page · raw message
Signature · 1 line
2.29.2
Quoted 4 lines · Heiko Stuebner
Newer Rockchip SoCs use a different DPHY for camera operation based on an IP block from Innosilicon.
This adds a driver for it for px30/rk3326/rk3368/rk1808.
Applied, thanks
Signature · 1 line
~Vinod