Skip to contentSkip to conversation

net/i40e: fix set rss hash function invalid

PATCH Superseded Steve Yang 3 participants 7 messages Jun 11, 2021 – Jun 21, 2021 Network drivers

lore
Share & tools
lore

Steve Yang

author
#0 lore raw

PATCH 1/1 net/i40e: fix set rss hash function invalid

i40e can support following rss hash function types: default (toeplitz), symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default (toeplitz).

Delete the hash function limitation when parsing pattern action.

---
 drivers/net/i40e/i40e_hash.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/net/i40e/i40e_hash.c +0 -5
index b1cb24f437..bd734722d9 100644
@@ -1107,11 +1107,6 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev,
 
 	if (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-					  RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ supported when pattern specified");
 
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
Signature · 1 line
2.27.0
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Friday, June 11, 2021 9:35 AM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v1] net/i40e: fix set rss hash function invalid

Quoted 5 lines

i40e can support following rss hash function types: default (toeplitz), symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default (toeplitz).

Delete the hash function limitation when parsing pattern action.

Missed fix line.

Quoted 22 lines
---
 drivers/net/i40e/i40e_hash.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/net/i40e/i40e_hash.c +0 -5
index b1cb24f437..bd734722d9 100644
@@ -1107,11 +1107,6 @@ i40e_hash_parse_pattern_act(const struct
 rte_eth_dev *dev,
 
 	if (rss_act->func ==
 RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-
 RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ
Quoted 1 line

supported when pattern specified");

Do we any other error info if rss_act->func != default or rss_act->func != simple_xor?

Quoted 5 lines
drivers/net/i40e/i40e_hash.c +0 -1
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
--

2.27.0

author
#2 lore raw

PATCH v2 1/1 net/i40e: fix set rss hash function invalid

In reply to Steve Yang

i40e can support following rss hash function types: default/toeplitz, symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default.

Add simple_xor and toeplitz hash functions support when parsing pattern action.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

---
v2:
- add the fix line.
- support simple_xor and toeplitz hash functions explicitly.

 drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
drivers/net/i40e/i40e_hash.c +14 -6
index b1cb24f437..0cef21c88f 100644
@@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev,
 					  NULL,
 					  "RSS Queues not supported when pattern specified");
 
-	if (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
+	switch (rss_act->func) {
+	case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-					  RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ supported when pattern specified");
+		break;
+	case RTE_ETH_HASH_FUNCTION_DEFAULT:
+	case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
+	case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
+		break;
+	default:
+		return rte_flow_error_set(error, EINVAL,
+				RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+				NULL,
+				"RSS hash function not supported "
+				"when pattern specified");
+	}
 
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
Signature · 1 line
2.27.0
#3 lore raw
Quoted 10 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Friday, June 11, 2021 2:55 PM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v2] net/i40e: fix set rss hash function invalid

Quoted 8 lines

i40e can support following rss hash function types: default/toeplitz, symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default.

Add simple_xor and toeplitz hash functions support when parsing pattern action.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

Why didn't CC stable?

Quoted 49 lines

---
v2:
- add the fix line.
- support simple_xor and toeplitz hash functions explicitly.

 drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
drivers/net/i40e/i40e_hash.c +2 -6
index b1cb24f437..0cef21c88f 100644
@@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct
 rte_eth_dev *dev,
 					  NULL,
 					  "RSS Queues not supported when
 pattern specified");
 
-	if (rss_act->func ==
 RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
+	switch (rss_act->func) {
+	case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-
 RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ

supported when pattern specified");

drivers/net/i40e/i40e_hash.c +12 -1
+		break;
+	case RTE_ETH_HASH_FUNCTION_DEFAULT:
+	case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
+	case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
+		break;
+	default:
+		return rte_flow_error_set(error, EINVAL,
+				RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+				NULL,
+				"RSS hash function not supported "
+				"when pattern specified");
+	}
 
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
--

2.27.0

author
#4 lore raw

PATCH v3 1/1 net/i40e: fix set rss hash function invalid

In reply to Steve Yang

i40e can support following rss hash function types: default/toeplitz, symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default.

Add simple_xor and toeplitz hash functions support when parsing pattern action.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

---
v3:
- add Cc stable line.
v2:
- add the fix line.
- support simple_xor and toeplitz hash functions explicitly.

 drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
drivers/net/i40e/i40e_hash.c +14 -6
index b1cb24f437..0cef21c88f 100644
@@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev,
 					  NULL,
 					  "RSS Queues not supported when pattern specified");
 
-	if (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
+	switch (rss_act->func) {
+	case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-					  RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ supported when pattern specified");
+		break;
+	case RTE_ETH_HASH_FUNCTION_DEFAULT:
+	case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
+	case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
+		break;
+	default:
+		return rte_flow_error_set(error, EINVAL,
+				RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+				NULL,
+				"RSS hash function not supported "
+				"when pattern specified");
+	}
 
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
Signature · 1 line
2.27.0
Acked-by on v3 1/1
#5 lore raw
Quoted 69 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Steve Yang
Sent: Monday, June 21, 2021 4:04 PM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid

i40e can support following rss hash function types: default/toeplitz, symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default.

Add simple_xor and toeplitz hash functions support when parsing pattern action.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

---
v3:
- add Cc stable line.
v2:
- add the fix line.
- support simple_xor and toeplitz hash functions explicitly.

 drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
drivers/net/i40e/i40e_hash.c +2 -6
index b1cb24f437..0cef21c88f 100644
@@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct
 rte_eth_dev *dev,
 					  NULL,
 					  "RSS Queues not supported when
 pattern specified");
 
-	if (rss_act->func ==
 RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
+	switch (rss_act->func) {
+	case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-
 RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ

supported when pattern specified");

drivers/net/i40e/i40e_hash.c +12 -1
+		break;
+	case RTE_ETH_HASH_FUNCTION_DEFAULT:
+	case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
+	case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
+		break;
+	default:
+		return rte_flow_error_set(error, EINVAL,
+				RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+				NULL,
+				"RSS hash function not supported "
+				"when pattern specified");
+	}
 
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
--
Quoted 1 line

2.27.0

Applied
#6 lore raw
Quoted 76 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Xing, Beilei
Sent: Monday, June 21, 2021 4:19 PM
To: Yang, SteveX <[email protected]>; [email protected]
Cc: Yang, SteveX <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid

Quoted 35 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Steve Yang
Sent: Monday, June 21, 2021 4:04 PM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid

i40e can support following rss hash function types: default/toeplitz, symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default.

Add simple_xor and toeplitz hash functions support when parsing pattern action.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

---
v3:
- add Cc stable line.
v2:
- add the fix line.
- support simple_xor and toeplitz hash functions explicitly.

 drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
(quoted diff) +0 -0

b/drivers/net/i40e/i40e_hash.c index b1cb24f437..0cef21c88f 100644

drivers/net/i40e/i40e_hash.c i40e_hash_parse_pattern_act(const struct · line 1107

Quoted 3 lines
drivers/net/i40e/i40e_hash.c +0 -0
@@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct
 rte_eth_dev *dev,
 					  NULL,
 					  "RSS Queues not supported when pattern

specified");

Quoted 26 lines
drivers/net/i40e/i40e_hash.c +14 -6
-	if (rss_act->func ==
 RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
+	switch (rss_act->func) {
+	case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
 		rss_conf->symmetric_enable = true;
-	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
-		return rte_flow_error_set(error, -EINVAL,
-
 RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-					  NULL,
-					  "Only symmetric TOEPLITZ
 supported when pattern specified");
+		break;
+	case RTE_ETH_HASH_FUNCTION_DEFAULT:
+	case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
+	case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
+		break;
+	default:
+		return rte_flow_error_set(error, EINVAL,
+				RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+				NULL,
+				"RSS hash function not supported "
+				"when pattern specified");
+	}
Quoted 6 lines
Quoted 4 lines
drivers/net/i40e/i40e_hash.c +0 -1
 	if (!i40e_hash_validate_rss_types(rss_act->types))
 		return rte_flow_error_set(error, EINVAL,
--

2.27.0

Applied to dpdk-next-net-intel.

Thanks
Qi