pvrdma: Fix the ring init error flow (CVE-2021-3608)
PATCH 1/1 pvrdma: Fix the ring init error flow (CVE-2021-3608)
Do not unmap uninitialized dma addresses.
Fixes CVE-2021-3608
Reviewed-by VictorV (Kunlun Lab) <[email protected]>
Tested-by VictorV (Kunlun Lab) <[email protected]>
Signed-off-by Marcel Apfelbaum <[email protected]>
--- hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rdma/vmw/pvrdma_dev_ring.c +1 -1
@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,qatomic_set(&ring->ring_state->cons_head, 0); */ ring->npages = npages; - ring->pages =g_malloc (npages *sizeof (void *)); + ring->pages =g_malloc0 (npages *sizeof (void *));for (i =0 ; i < npages; i++) {if (!tbl[i]) {
Signature · 1 line
2.31.1
Quoted 15 lines · Marcel Apfelbaum
Do not unmap uninitialized dma addresses.
Fixes CVE-2021-3608Reviewed-by VictorV (Kunlun Lab) <[email protected]>Tested-by VictorV (Kunlun Lab) <[email protected]>Signed-off-by Marcel Apfelbaum <[email protected]>--- hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/rdma/vmw/pvrdma_dev_ring.c +0
-0
hw/rdma/vmw/pvrdma_dev_ring.c int pvrdma_ring_init(PvrdmaRing *ring, const char *name, · line 47
Quoted 8 lines
hw/rdma/vmw/pvrdma_dev_ring.c +1
-1@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name,PCIDevice *dev, qatomic_set(&ring->ring_state->cons_head, 0); */ ring->npages = npages; - ring->pages =g_malloc (npages *sizeof (void *)); + ring->pages =g_malloc0 (npages *sizeof (void *));
Reviewed-by Yuval Shaia <[email protected]>
Tested-by Yuval Shaia <[email protected]>
Quoted 6 lines
for (i = 0; i < npages; i++) { if (!tbl[i]) {--
2.31.1
Quoted 9 lines · Marcel Apfelbaum
Do not unmap uninitialized dma addresses.
Fixes CVE-2021-3608Reviewed-by VictorV (Kunlun Lab) <[email protected]>Tested-by VictorV (Kunlun Lab) <[email protected]>Signed-off-by Marcel Apfelbaum <[email protected]>--- hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Philippe Mathieu-Daudé <[email protected]>