Skip to contentSkip to conversation

pvrdma: Fix the ring init error flow (CVE-2021-3608)

PATCH In review Marcel Apfelbaum 3 participants 3 messages Jun 30, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pvrdma: Fix the ring init error flow (CVE-2021-3608)

Do not unmap uninitialized dma addresses.

---
 hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rdma/vmw/pvrdma_dev_ring.c +1 -1
index 074ac59b84..42130667a7 100644
@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,
     qatomic_set(&ring->ring_state->cons_head, 0);
     */
     ring->npages = npages;
-    ring->pages = g_malloc(npages * sizeof(void *));
+    ring->pages = g_malloc0(npages * sizeof(void *));
 
     for (i = 0; i < npages; i++) {
         if (!tbl[i]) {
Signature · 1 line
2.31.1
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 15 lines · Marcel Apfelbaum

Do not unmap uninitialized dma addresses.

---
 hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rdma/vmw/pvrdma_dev_ring.c +0 -0
index 074ac59b84..42130667a7 100644

hw/rdma/vmw/pvrdma_dev_ring.c int pvrdma_ring_init(PvrdmaRing *ring, const char *name, · line 47

Quoted 8 lines
hw/rdma/vmw/pvrdma_dev_ring.c +1 -1
@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name,
 PCIDevice *dev,
     qatomic_set(&ring->ring_state->cons_head, 0);
     */
     ring->npages = npages;
-    ring->pages = g_malloc(npages * sizeof(void *));
+    ring->pages = g_malloc0(npages * sizeof(void *));
 
 
Quoted 6 lines
     for (i = 0; i < npages; i++) {
         if (!tbl[i]) {

--
2.31.1

Reviewed-by on v1 1/1
#2 lore raw
In reply to Marcel Apfelbaum
Quoted 9 lines · Marcel Apfelbaum

Do not unmap uninitialized dma addresses.

---
 hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)