Skip to contentSkip to conversation

riscv: dts: microchip: Use 'local-mac-address' for emac1

PATCH Superseded Bin Meng 4 participants 11 messages Jul 2, 2021 – Aug 4, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/2 riscv: dts: microchip: Use 'local-mac-address' for emac1

From: Bin Meng <[email protected]>

Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.

---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1 -1
index 0659068b62f7..a9c558366d61 100644
@@ -317,7 +317,7 @@ emac1: ethernet@20112000 {
 			reg = <0x0 0x20112000 0x0 0x2000>;
 			interrupt-parent = <&plic>;
 			interrupts = <70 71 72 73>;
-			mac-address = [00 00 00 00 00 00];
+			local-mac-address = [00 00 00 00 00 00];
 			clocks = <&clkcfg 5>, <&clkcfg 2>;
 			status = "disabled";
 			clock-names = "pclk", "hclk";
Signature · 7 lines
2.25.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
author
#1 lore raw

PATCH 2/2 riscv: dts: microchip: Add ethernet0 to the aliases node

From: Bin Meng <[email protected]>

U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node.

Note on the Icicle Kit board, currently only emac1 is enabled so it becomes the 'ethernet0'.

---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
index a9c558366d61..16cc6573107b 100644
@@ -9,6 +9,10 @@ / {
 	model = "Microchip MPFS Icicle Kit";
 	compatible = "microchip,mpfs-icicle-kit";
 
+	aliases {
+		ethernet0 = &emac1;
+	};
+
 	chosen {
 	};
 
Signature · 7 lines
2.25.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

Quoted 21 lines · Bin Meng

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

From: Bin Meng <[email protected]>

U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node.

Note on the Icicle Kit board, currently only emac1 is enabled so it becomes the 'ethernet0'.

---

  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 4 ++++
  1 file changed, 4 insertions(+)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -0
index a9c558366d61..16cc6573107b 100644

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 9 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
@@ -9,6 +9,10 @@ / {
         model = "Microchip MPFS Icicle Kit";
         compatible = "microchip,mpfs-icicle-kit";
 
+       aliases {
+               ethernet0 = &emac1;
+       };
+
         chosen {
         };

Sure.

Quoted 8 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -1
--

2.25.1

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#3 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

In reply to Bin Meng

Hi Bing,

Quoted 9 lines · Bin Meng

From: Bin Meng <[email protected]>

U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node.

Note on the Icicle Kit board, currently only emac1 is enabled so it becomes the 'ethernet0'.

Thanks for your patch!

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 12 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
@@ -9,6 +9,10 @@ / {
        model = "Microchip MPFS Icicle Kit";
        compatible = "microchip,mpfs-icicle-kit";
 
+       aliases {
+               ethernet0 = &emac1;
+       };
+
        chosen {
        };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) instead.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author
#4 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

Hi Geert,

Quoted 9 lines · Geert Uytterhoeven

Hi Bing,

Quoted 5 lines · Bin Meng

From: Bin Meng <[email protected]>

U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node.

Quoted 6 lines
Quoted 4 lines

Note on the Icicle Kit board, currently only emac1 is enabled so it becomes the 'ethernet0'.

Thanks for your patch!

Thanks for the review!

Quoted 7 lines
Quoted 7 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -0
@@ -9,6 +9,10 @@ / {
        model = "Microchip MPFS Icicle Kit";
        compatible = "microchip,mpfs-icicle-kit";
 
Quoted 9 lines

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 6 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
+       aliases {
+               ethernet0 = &emac1;
+       };
+
        chosen {
        };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) instead.

I was wondering the same thing before doing this, but when I checked all other DTS in arch/riscv/boot I found the aliases node is put in the SoC dtsi file instead of the board on so I think that's the convention.

Regards,
Bin

#5 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

Hi Bin,

Quoted 18 lines · Bin Meng
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Bin Meng
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -0
@@ -9,6 +9,10 @@ / {
        model = "Microchip MPFS Icicle Kit";
        compatible = "microchip,mpfs-icicle-kit";
 
Quoted 9 lines

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 6 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
+       aliases {
+               ethernet0 = &emac1;
+       };
+
        chosen {
        };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) instead.

Quoted 4 lines

I was wondering the same thing before doing this, but when I checked all other DTS in arch/riscv/boot I found the aliases node is put in the SoC dtsi file instead of the board on so I think that's the convention.

The numbering of the aliases is supposed to match the labels on the board, hence it is board-specific, not SoC-specific.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
maintainer
#6 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

Quoted 26 lines · On Fri, 16 Jul 2021 04:34:02 PDT (-0700), [email protected] wrote:

Hi Bin,

Quoted 18 lines · Bin Meng
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Bin Meng
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -0
@@ -9,6 +9,10 @@ / {
        model = "Microchip MPFS Icicle Kit";
        compatible = "microchip,mpfs-icicle-kit";
 
Quoted 9 lines

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 6 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
+       aliases {
+               ethernet0 = &emac1;
+       };
+
        chosen {
        };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) instead.

Quoted 4 lines

I was wondering the same thing before doing this, but when I checked all other DTS in arch/riscv/boot I found the aliases node is put in the SoC dtsi file instead of the board on so I think that's the convention.

Quoted 6 lines

The numbering of the aliases is supposed to match the labels on the board, hence it is board-specific, not SoC-specific.

Gr{oetje,eeting}s,

Geert

I don't see a v2 of this.

author
#7 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

Quoted 28 lines · Palmer Dabbelt
Quoted 26 lines · On Fri, 16 Jul 2021 04:34:02 PDT (-0700), [email protected] wrote:

Hi Bin,

Quoted 22 lines · Bin Meng
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Bin Meng
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -0
@@ -9,6 +9,10 @@ / {
        model = "Microchip MPFS Icicle Kit";
        compatible = "microchip,mpfs-icicle-kit";
 
Quoted 9 lines

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 6 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
+       aliases {
+               ethernet0 = &emac1;
+       };
+
        chosen {
        };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) instead.

I was wondering the same thing before doing this, but when I checked all other DTS in arch/riscv/boot I found the aliases node is put in the SoC dtsi file instead of the board on so I think that's the convention.

Quoted 8 lines
Quoted 6 lines

The numbering of the aliases is supposed to match the labels on the board, hence it is board-specific, not SoC-specific.

Gr{oetje,eeting}s,

Geert

I don't see a v2 of this.

Will send v2 soon.

Regards,
Bin

maintainer
#8 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

Quoted 32 lines · On Tue, 03 Aug 2021 20:55:56 PDT (-0700), [email protected] wrote:
Quoted 31 lines · Palmer Dabbelt
Quoted 29 lines · On Fri, 16 Jul 2021 04:34:02 PDT (-0700), [email protected] wrote:

Hi Bin,

Quoted 18 lines · Bin Meng
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Bin Meng
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -0
@@ -9,6 +9,10 @@ / {
        model = "Microchip MPFS Icicle Kit";
        compatible = "microchip,mpfs-icicle-kit";
 
Quoted 9 lines

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi / { · line 17

Quoted 6 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +4 -0
+       aliases {
+               ethernet0 = &emac1;
+       };
+
        chosen {
        };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) instead.

Quoted 4 lines

I was wondering the same thing before doing this, but when I checked all other DTS in arch/riscv/boot I found the aliases node is put in the SoC dtsi file instead of the board on so I think that's the convention.

The numbering of the aliases is supposed to match the labels on the board, hence it is board-specific, not SoC-specific.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Gr{oetje,eeting}s,

Geert

I don't see a v2 of this.

Will send v2 soon.

Thanks. I'm assuming you're going to send both patches.

author
#9 lore raw
In reply to Bin Meng
Quoted 9 lines · Bin Meng

From: Bin Meng <[email protected]>

Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.

Quoted 6 lines

---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ping?

maintainer Reviewed-by
#10 lore raw
Quoted 11 lines · Bin Meng

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 8 lines · Bin Meng

From: Bin Meng<[email protected]>

Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.

Quoted 7 lines
Quoted 6 lines

---

  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Ping?

Yeah, thats fine.

Quoted 4 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv