block/rbd: fix type of task->complete
PATCH 1/1 block/rbd: fix type of task->complete
task->complete is a bool not an integer.
--- block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/rbd.c +1 -1
@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)static void qemu_rbd_finish_bh (void *opaque) {RBDTask *task = opaque; - task->complete =1 ; + task->complete = true;aio_co_wake (task->co); }
Signature · 1 line
2.17.1
PATCH 1/1 MAINTAINERS: update block/rbd.c maintainer
adding myself as a designated reviewer.
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -3058,6 +3058,7 @@ F: block/vmdk.c RBD M: Ilya Dryomov <[email protected]> +R: Peter Lieven <[email protected]> L: [email protected] S: Supported F: block/rbd.c
Signature · 1 line
2.17.1
Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer
Quoted 21 lines · Peter Lieven
adding myself as a designated reviewer.
Signed-off-by Peter Lieven <[email protected]>--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +1
-1@@ -3058,6 +3058,7 @@ F: block/vmdk.c RBD M: Ilya Dryomov <[email protected]> +R: Peter Lieven <[email protected]> L: [email protected] S: Supported F: block/rbd.c --
Quoted 3 lines
2.17.1
Nit: I would change the title to "MAINTAINERS: add block/rbd.c reviewer" or something like that.
Thanks again for volunteering!
Ilya
Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer
Am 08.07.2021 um 12:44 hat Ilya Dryomov geschrieben:
Quoted 15 lines · Peter Lieven
Quoted 14 lines
adding myself as a designated reviewer.
Signed-off-by Peter Lieven <[email protected]>--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +0
-0@@ -3058,6 +3058,7 @@ F: block/vmdk.c
Quoted 9 lines
MAINTAINERS F: block/vmdk.c · line 3064
Quoted 6 lines
MAINTAINERS +1
-0RBD M: Ilya Dryomov <[email protected]> +R: Peter Lieven <[email protected]> L: [email protected] S: Supported F: block/rbd.cNit: I would change the title to "
MAINTAINERS: addblock/rbd.creviewer" or something like that.
Yes, this is better. I've changed it in my queue.
Kevin
Quoted 13 lines · Peter Lieven
task->completeis a bool not an integer.Signed-off-by Peter Lieven <[email protected]>--- block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)block/rbd.c +0
-0
block/rbd.c static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size) · line 1072
Quoted 8 lines
block/rbd.c +1
-1@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)static void qemu_rbd_finish_bh (void *opaque) {RBDTask *task = opaque; - task->complete =1 ; + task->complete = true;aio_co_wake (task->co); }
Hi Peter,
What tree/QEMU git sha does this apply to? I am having trouble finding definitions for RBDTask and qemu_rbd_finish_bh; and the patch won't apply to my few-minutes-old clone of upstream.
Connor
Am 07.07.2021 um 23:51 hat Connor Kuehl geschrieben:
Quoted 25 lines · Peter Lieven
Quoted 13 lines
task->completeis a bool not an integer.Signed-off-by Peter Lieven <[email protected]>--- block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)block/rbd.c +0
-0block/rbd.c static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size) · line 1072
Quoted 8 lines
block/rbd.c +1
-1@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)static void qemu_rbd_finish_bh (void *opaque) {RBDTask *task = opaque; - task->complete =1 ; + task->complete = true;aio_co_wake (task->co); }Hi Peter,
Quoted 3 lines
What tree/QEMU git sha does this apply to? I am having trouble finding definitions for RBDTask and
qemu_rbd_finish_bh; and the patch won't apply to my few-minutes-old clone of upstream.
It is on top of:
[PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support
Message-Id: <[email protected]>
Also, thanks, applied to the block branch.
Kevin
Quoted 22 lines · Peter Lieven
task->completeis a bool not an integer.Signed-off-by Peter Lieven <[email protected]>--- block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)block/rbd.c +1
-2@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)static void qemu_rbd_finish_bh (void *opaque) {RBDTask *task = opaque; - task->complete =1 ; + task->complete = true;aio_co_wake (task->co); } --
Quoted 3 lines
2.17.1
Thanks,
Ilya